Skip to content

Add inverse SNR and TrigFlow components - #2200

Draft
CharlelieLrt wants to merge 2 commits into
NVIDIA:mainfrom
CharlelieLrt:diffusion-trigflow
Draft

CharlelieLrt wants to merge 2 commits into
NVIDIA:mainfrom
CharlelieLrt:diffusion-trigflow

Conversation

@CharlelieLrt

@CharlelieLrt CharlelieLrt commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Description

This PR adds TrigFlowNoiseScheduler and TrigFlowPreconditioner to
physicsnemo.diffusion. Users can pair them with the same sigma_data value to train
a backbone that predicts normalized velocity while exposing clean-data
predictions through the usual diffusion model interface.

Built-in linear Gaussian schedules also gain snr_inv(q), which converts the
amplitude ratio q = alpha / sigma back to diffusion time.
Custom schedules can supply their own inverse. This gives the private FastGen
adapters a way to translate noise levels between schedules without relying on
inference grids.

Checklist

  • This PR follows the contribution guidelines.
  • The documentation describes the API and its role in the stack.
  • This PR remains a draft.

Dependencies

If FastGen maintainers decline FastGen #44, we would close PhysicsNeMo #2205.
The preceding PhysicsNeMo stack would remain available.

Review process

This draft replaces PhysicsNeMo #2095 and comes from the personal fork. This migration preserves the implementation. The first commit also includes the requested documentation clarifications.

Review the isolated commit diff for this layer. Each branch adds one commit to its prerequisite branch. All replacement PRs target upstream main, so later PRs include prerequisite commits awaiting merge in their Files changed tab. After prerequisites merge, update the remaining branches to remove them from those diffs.

Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS review map

Current for commit 93133b1e9659. An approval covers every file listed for that owner; one owner is sufficient for shared files.

⏳ @CharlelieLrt — 31 file(s)
  • docs/api/diffusion/introduction.rst
  • docs/api/diffusion/models.rst
  • docs/api/diffusion/noise_schedulers.rst
  • docs/api/diffusion/preconditioners.rst
  • physicsnemo/diffusion/init.py
  • physicsnemo/diffusion/base.py
  • physicsnemo/diffusion/metrics/losses.py
  • physicsnemo/diffusion/noise_schedulers/init.py
  • physicsnemo/diffusion/noise_schedulers/edm.py
  • physicsnemo/diffusion/noise_schedulers/iddpm.py
  • physicsnemo/diffusion/noise_schedulers/linear_gaussian.py
  • physicsnemo/diffusion/noise_schedulers/rectified_flow.py
  • physicsnemo/diffusion/noise_schedulers/trigflow.py
  • physicsnemo/diffusion/noise_schedulers/ve.py
  • physicsnemo/diffusion/noise_schedulers/vp.py
  • physicsnemo/diffusion/preconditioners/init.py
  • physicsnemo/diffusion/preconditioners/preconditioners.py
  • physicsnemo/diffusion/utils/model_wrappers.py
  • test/diffusion/data/trigflow_precond_conv.mdlus
  • test/diffusion/data/trigflow_precond_conv_coefficients.pth
  • test/diffusion/data/trigflow_precond_conv_forward.pth
  • test/diffusion/data/trigflow_precond_conv_sigma.pth
  • test/diffusion/data/trigflow_precond_linear.mdlus
  • test/diffusion/data/trigflow_precond_linear_coefficients.pth
  • test/diffusion/data/trigflow_precond_linear_forward.pth
  • test/diffusion/data/trigflow_precond_linear_sigma.pth
  • test/diffusion/helpers.py
  • test/diffusion/test_model_io.py
  • test/diffusion/test_noise_schedulers.py
  • test/diffusion/test_preconditioners.py
  • test/diffusion/test_trigflow.py
⏳ @megnvidia — 4 file(s)
  • docs/api/diffusion/introduction.rst
  • docs/api/diffusion/models.rst
  • docs/api/diffusion/noise_schedulers.rst
  • docs/api/diffusion/preconditioners.rst

No CODEOWNER

  • .importlinter
  • CHANGELOG.md

Comment /codeowners-info to refresh.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 - In Progress Currently a work in progress 5 - DO NOT MERGE Hold off on merging; see PR for details 5 - Merge After Dependencies Depends on another PR: do not merge out of order

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant