Repository navigation
Adopt proposed FastGen loss hooks conditionally - #2205
Draft
CharlelieLrt wants to merge 7 commits into
Draft
CharlelieLrt wants to merge 7 commits into
CharlelieLrt wants to merge 7 commits into
Conversation
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
Contributor
CODEOWNERS review mapCurrent for commit ⏳ @CharlelieLrt — 59 file(s)
⏳ @coreyjadams — 1 file(s)
⏳ @ktangsali — 2 file(s)
⏳ @megnvidia — 6 file(s)
No CODEOWNER
Comment |
This was referenced Oct 29, 2026
This was referenced Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adopts the shared loss hooks proposed in FastGen #44 and removes the
corresponding private compatibility code from PhysicsNeMo. It does not change
the public
DistillationLossAPI, model roles, masks, or checkpoint state.This is a conditional follow-up, not a prerequisite for the initial integration.
The earlier PhysicsNeMo PRs work without the proposed hooks. The dependency pin
combines FastGen #43 and #44 on the user fork so development can proceed in
parallel. Before merging this PR, we would replace that pin with an accepted
upstream revision. If FastGen maintainers decline the hooks, we would close
this PR and keep the earlier implementation.
Checklist
Dependencies
Depends on
Earlier prerequisites
Depends on this PR
If FastGen maintainers decline FastGen #44, we would close PhysicsNeMo #2205.
The preceding PhysicsNeMo stack would remain available.
Review process
This draft replaces PhysicsNeMo #2100 and comes from the personal fork. This migration preserves the implementation. The first commit also includes the requested documentation clarifications.
Review the isolated commit diff for this layer. Each branch adds one commit to its prerequisite branch. All replacement PRs target upstream
main, so later PRs include prerequisite commits awaiting merge in their Files changed tab. After prerequisites merge, update the remaining branches to remove them from those diffs.