Repository navigation
Add optional extra diffusion times and outputs - #2199
Draft
CharlelieLrt wants to merge 1 commit into
Draft
CharlelieLrt wants to merge 1 commit into
CharlelieLrt wants to merge 1 commit into
Conversation
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
Contributor
CODEOWNERS review mapCurrent for commit ⏳ @CharlelieLrt — 9 file(s)
⏳ @megnvidia — 2 file(s)
No CODEOWNER
Comment |
This was referenced Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
DiffusionExtraTimesandDiffusionExtraOutputstophysicsnemo.diffusionfor models that need more than one diffusion time orproduce auxiliary outputs. The primary
tand prediction remain requiredtensors. Named extra fields are independently optional and default to
None.The reserved fields are the MeanFlow destination time
rand adaptive lossweighting log-scale
logvar. Custom consumers define their own fields' meaning.Pass
(t, DiffusionExtraTimes(r=r, batch_size=[B]))when a model needs adestination time. Return
(prediction, DiffusionExtraOutputs(logvar=logvar, batch_size=[B]))when its training loss needs the auxiliary log-scale.Affine preconditioners encode every supplied time tensor with the same mapping
and scale only the prediction. Conditioning wrappers pass supported tuples
unchanged. Existing DSM and flow-matching losses and sampling APIs use tensors.
Checklist
Dependencies
Depends on
mainand has no prerequisite PR.Depends on this PR
Later follow-ups
Parallel FastGen work
Conditional follow-up
If FastGen maintainers decline FastGen #44, we would close PhysicsNeMo #2205.
The preceding PhysicsNeMo stack would remain available.
Review process
This draft replaces PhysicsNeMo #2094 and comes from the personal fork. This migration preserves the implementation. The first commit also includes the requested documentation clarifications.
Review the isolated commit diff for this layer. Each branch adds one commit to its prerequisite branch. All replacement PRs target upstream
main, so later PRs include prerequisite commits awaiting merge in their Files changed tab. After prerequisites merge, update the remaining branches to remove them from those diffs.