Repository navigation
Add optional extra diffusion times and outputs - #2094
Closed
CharlelieLrt wants to merge 1 commit into
Closed
CharlelieLrt wants to merge 1 commit into
CharlelieLrt wants to merge 1 commit into
Conversation
Contributor
CODEOWNERS review mapCurrent for commit ⏳ @CharlelieLrt — 7 file(s)
⏳ @megnvidia — 2 file(s)
No CODEOWNER
Comment |
This was referenced Oct 14, 2026
CharlelieLrt
force-pushed
the
codex/diffusion-structured-io
branch
4 times, most recently
from
October 17, 2026 01:44
a11d86e to
b0b607e
Compare
CharlelieLrt
force-pushed
the
codex/diffusion-structured-io
branch
from
October 28, 2026 03:42
b0b607e to
5b5e3a9
Compare
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
CharlelieLrt
force-pushed
the
codex/diffusion-structured-io
branch
from
October 29, 2026 02:23
5b5e3a9 to
ee0ab8d
Compare
This was referenced Oct 29, 2026
Collaborator
Author
|
Continued in PhysicsNeMo #2199, from branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
DiffusionExtraTimesandDiffusionExtraOutputstophysicsnemo.diffusionfor models that need more than one diffusion time orproduce auxiliary outputs. The primary
tand prediction remain requiredtensors. Named extra fields are independently optional and default to
None.The reserved fields are the MeanFlow destination time
rand adaptive lossweighting log-scale
logvar. Custom consumers define their own fields' meaning.Pass
(t, DiffusionExtraTimes(r=r, batch_size=[B]))when a model needs adestination time. Return
(prediction, DiffusionExtraOutputs(logvar=logvar, batch_size=[B]))when its training loss needs the auxiliary log-scale.Affine preconditioners encode every supplied time tensor with the same mapping
and scale only the prediction. Conditioning wrappers pass supported tuples
unchanged. Existing DSM and flow-matching losses and sampling APIs use tensors.
Checklist
Dependencies
Depends on
mainand has no prerequisite PR.Depends on this PR
Later follow-ups
Parallel FastGen work
Conditional follow-up
If FastGen maintainers decline FastGen #44, we would close PhysicsNeMo #2100.
The preceding PhysicsNeMo stack would remain available.
Review process
Reviewers can compare this PR with its immediate parent. After a parent merges,
we update the remaining branches and their PR bases to keep each diff focused.