Repository navigation
Adopt proposed FastGen loss hooks conditionally - #2100
Closed
CharlelieLrt wants to merge 1 commit into
Closed
CharlelieLrt wants to merge 1 commit into
CharlelieLrt wants to merge 1 commit into
Conversation
Contributor
CODEOWNERS review mapCurrent for commit ⏳ @CharlelieLrt — 7 file(s)
⏳ @coreyjadams — 1 file(s)
⏳ @ktangsali — 1 file(s)
⏳ @megnvidia — 1 file(s)
No CODEOWNER
Comment |
This was referenced Oct 14, 2026
CharlelieLrt
force-pushed
the
codex/diffusion-fastgen-hooks-adoption
branch
from
October 14, 2026 17:03
0162d88 to
640b8dc
Compare
CharlelieLrt
force-pushed
the
codex/diffusion-distillation-strategy
branch
from
October 14, 2026 17:03
b8c31db to
859b1c8
Compare
CharlelieLrt
force-pushed
the
codex/diffusion-fastgen-hooks-adoption
branch
from
October 16, 2026 01:19
640b8dc to
d8ec72a
Compare
CharlelieLrt
force-pushed
the
codex/diffusion-distillation-strategy
branch
2 times, most recently
from
October 16, 2026 02:52
71c4445 to
b7f4957
Compare
CharlelieLrt
force-pushed
the
codex/diffusion-fastgen-hooks-adoption
branch
2 times, most recently
from
October 16, 2026 20:15
9c1587f to
aa7226b
Compare
CharlelieLrt
force-pushed
the
codex/diffusion-distillation-strategy
branch
2 times, most recently
from
October 17, 2026 01:44
7ac3370 to
5ed9710
Compare
CharlelieLrt
force-pushed
the
codex/diffusion-fastgen-hooks-adoption
branch
from
October 17, 2026 01:44
aa7226b to
b5267fc
Compare
CharlelieLrt
force-pushed
the
codex/diffusion-distillation-strategy
branch
from
October 28, 2026 03:42
5ed9710 to
f7ae646
Compare
CharlelieLrt
force-pushed
the
codex/diffusion-fastgen-hooks-adoption
branch
from
October 28, 2026 03:42
b5267fc to
7247f2e
Compare
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
CharlelieLrt
force-pushed
the
codex/diffusion-distillation-strategy
branch
from
October 29, 2026 02:23
f7ae646 to
78c4e28
Compare
CharlelieLrt
force-pushed
the
codex/diffusion-fastgen-hooks-adoption
branch
from
October 29, 2026 02:23
7247f2e to
657660b
Compare
This was referenced Oct 29, 2026
This was referenced Oct 29, 2026
Collaborator
Author
|
Continued in PhysicsNeMo #2205, from branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adopts the shared loss hooks proposed in FastGen #44 and removes the
corresponding private compatibility code from PhysicsNeMo. It does not change
the public
DistillationLossAPI, model roles, masks, or checkpoint state.This is a conditional follow-up, not a prerequisite for the initial integration.
The earlier PhysicsNeMo PRs work without the proposed hooks. The dependency pin
combines FastGen #43 and #44 on the user fork so development can proceed in
parallel. Before merging this PR, we would replace that pin with an accepted
upstream revision. If FastGen maintainers decline the hooks, we would close
this PR and keep the earlier implementation.
Checklist
Dependencies
Depends on
Earlier prerequisites
Depends on this PR
If FastGen maintainers decline FastGen #44, we would close PhysicsNeMo #2100.
The preceding PhysicsNeMo stack would remain available.
Review process
Reviewers can compare this PR with its immediate parent. After a parent merges,
we update the remaining branches and their PR bases to keep each diff focused.