Skip to content

Adopt proposed FastGen loss hooks conditionally - #2100

Closed
CharlelieLrt wants to merge 1 commit into
codex/diffusion-distillation-strategyfrom
codex/diffusion-fastgen-hooks-adoption
Closed

CharlelieLrt wants to merge 1 commit into
codex/diffusion-distillation-strategyfrom
codex/diffusion-fastgen-hooks-adoption

Conversation

@CharlelieLrt

@CharlelieLrt CharlelieLrt commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Description

This PR adopts the shared loss hooks proposed in FastGen #44 and removes the
corresponding private compatibility code from PhysicsNeMo. It does not change
the public DistillationLoss API, model roles, masks, or checkpoint state.

This is a conditional follow-up, not a prerequisite for the initial integration.
The earlier PhysicsNeMo PRs work without the proposed hooks. The dependency pin
combines FastGen #43 and #44 on the user fork so development can proceed in
parallel. Before merging this PR, we would replace that pin with an accepted
upstream revision. If FastGen maintainers decline the hooks, we would close
this PR and keep the earlier implementation.

Checklist

  • This PR follows the contribution guidelines.
  • The documentation describes the API and its role in the stack.
  • This PR remains a draft.

Dependencies

  • Depends on

    • PhysicsNeMo #2099 adds the optional training strategy and the grouped changelog entry. This is the immediate parent branch.
    • FastGen #44 provides shared loss hooks for external training loops. This PR requires acceptance of those hooks.
    • FastGen #43 allows the NumPy 2 dependency used by PhysicsNeMo. The current fork pin includes this metadata change as well.
  • Earlier prerequisites

  • Depends on this PR

    • No PR in this stack depends on this conditional follow-up.

If FastGen maintainers decline FastGen #44, we would close PhysicsNeMo #2100.
The preceding PhysicsNeMo stack would remain available.

Review process

Reviewers can compare this PR with its immediate parent. After a parent merges,
we update the remaining branches and their PR bases to keep each diff focused.

@CharlelieLrt CharlelieLrt added 2 - In Progress Currently a work in progress 5 - DO NOT MERGE Hold off on merging; see PR for details 5 - Merge After Dependencies Depends on another PR: do not merge out of order labels Oct 14, 2026
@copy-pr-bot

copy-pr-bot Bot commented Oct 14, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS review map

Current for commit 0162d882cf08. An approval covers every file listed for that owner; one owner is sufficient for shared files.

⏳ @CharlelieLrt — 7 file(s)
  • docs/api/diffusion/distillation.rst
  • physicsnemo/diffusion/distillation/_fastgen.py
  • physicsnemo/diffusion/distillation/methods/dmd2/_fastgen.py
  • physicsnemo/diffusion/distillation/methods/f_distill/_fastgen.py
  • physicsnemo/diffusion/distillation/methods/meanflow/_fastgen.py
  • physicsnemo/diffusion/distillation/methods/scm/_fastgen.py
  • test/diffusion/test_distillation_losses.py
⏳ @coreyjadams — 1 file(s)
  • pyproject.toml
⏳ @ktangsali — 1 file(s)
  • pyproject.toml
⏳ @megnvidia — 1 file(s)
  • docs/api/diffusion/distillation.rst

No CODEOWNER

  • CHANGELOG.md
  • uv.lock

Comment /codeowners-info to refresh.

@CharlelieLrt
CharlelieLrt force-pushed the codex/diffusion-fastgen-hooks-adoption branch from 0162d88 to 640b8dc Compare October 14, 2026 17:03
@CharlelieLrt
CharlelieLrt force-pushed the codex/diffusion-distillation-strategy branch from b8c31db to 859b1c8 Compare October 14, 2026 17:03
@CharlelieLrt
CharlelieLrt force-pushed the codex/diffusion-fastgen-hooks-adoption branch from 640b8dc to d8ec72a Compare October 16, 2026 01:19
@CharlelieLrt
CharlelieLrt force-pushed the codex/diffusion-distillation-strategy branch 2 times, most recently from 71c4445 to b7f4957 Compare October 16, 2026 02:52
@CharlelieLrt
CharlelieLrt force-pushed the codex/diffusion-fastgen-hooks-adoption branch 2 times, most recently from 9c1587f to aa7226b Compare October 16, 2026 20:15
@CharlelieLrt
CharlelieLrt force-pushed the codex/diffusion-distillation-strategy branch 2 times, most recently from 7ac3370 to 5ed9710 Compare October 17, 2026 01:44
@CharlelieLrt
CharlelieLrt force-pushed the codex/diffusion-fastgen-hooks-adoption branch from aa7226b to b5267fc Compare October 17, 2026 01:44
@CharlelieLrt
CharlelieLrt force-pushed the codex/diffusion-distillation-strategy branch from 5ed9710 to f7ae646 Compare October 28, 2026 03:42
@CharlelieLrt
CharlelieLrt force-pushed the codex/diffusion-fastgen-hooks-adoption branch from b5267fc to 7247f2e Compare October 28, 2026 03:42
Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
@CharlelieLrt
CharlelieLrt force-pushed the codex/diffusion-distillation-strategy branch from f7ae646 to 78c4e28 Compare October 29, 2026 02:23
@CharlelieLrt
CharlelieLrt force-pushed the codex/diffusion-fastgen-hooks-adoption branch from 7247f2e to 657660b Compare October 29, 2026 02:23
@CharlelieLrt

Copy link
Copy Markdown
Collaborator Author

Continued in PhysicsNeMo #2205, from branch diffusion-fastgen-hooks-adoption in CharlelieLrt/modulus. The replacement preserves this implementation and includes the requested documentation clarifications. Please continue the review there. This PR retains the earlier discussion.

@CharlelieLrt
CharlelieLrt deleted the codex/diffusion-fastgen-hooks-adoption branch October 29, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 - In Progress Currently a work in progress 5 - DO NOT MERGE Hold off on merging; see PR for details 5 - Merge After Dependencies Depends on another PR: do not merge out of order

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant