Repository navigation
test(e2e): people journeys (users and companies) - #1156
Merged
Merged
Conversation
This was referenced Nov 20, 2026
Member
Author
|
Once #1193 (metadata writes on an existing user) is on main, lift the quarantine for PPL-U-60, PPL-U-61, PPL-U-66:
|
mortondev
force-pushed
the
test/product-e2e-harness
branch
from
November 20, 2026 10:20
b16d3d9 to
aa14deb
Compare
mortondev
force-pushed
the
test/product-e2e-people
branch
from
November 20, 2026 10:37
da38c49 to
5300f19
Compare
mortondev
force-pushed
the
test/product-e2e-people
branch
from
November 20, 2026 10:59
5300f19 to
7d4425e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End-to-end journeys for People: users and companies (PPL-U, PPL-C), part 1 of 3. Segments (PPL-G) and team access / portal account (PPL-T, PPL-ACC) are separate PRs on the same base.
Helpers:
apps/web/e2e/product/people.ts(portal users with real sessions, boards, posts/votes/comments through the portal server functions, leads, attribute definitions, REST keys, a GET-aware server-function caller).Covered
people/users.spec.ts(21 tests): PPL-U-42 (@smoke);@core: U-01, U-02, U-11, U-14, U-19, U-20, U-21, U-23, U-24, U-26, U-29, U-31 (quarantined), U-32, U-36, U-41, U-43 (quarantined), U-75people/users-api.spec.ts(20 tests):@core: U-39, U-45, U-46, U-47, U-57, U-59 (+ quarantined copy), U-60 (+ quarantined attribute write), U-61 (+ quarantined), U-64 (+ quarantined copy), U-65, U-66 (+ quarantined), U-70, U-72;@nightly: U-69 (two tests)people/user-attributes.spec.ts(3 tests,@core): U-50, U-55, U-56people/companies.spec.ts(16 tests,@core): C-01, C-02, C-03 (quarantined), C-04, C-07, C-08, C-10, C-12 + C-14, C-15, C-23 + C-25, C-26, C-29 + C-30, C-31 (quarantined), C-36, C-37Every passing test was broken once (wrong role, wrong expected value, mutated precondition) and went red.
Quarantined (product bugs, entries in
e2e/QUARANTINE.md)posts.vote_countone too high (user.service.ts:514letspost_votescascade).principal-repoint.ts:220drops the vote, no decrement)./api/v1/users/:idfor a non-portal id says "Portal user not found not found" ($principalId.ts:46)./api/v1/users/:idfor an unknown id says "Member not found" (responses.ts:182).externalIdwrite on an EXISTING user over REST (PATCH and identify) is a 500.user.identify.ts:81and:257interpolate a JS array into${metadataRemovals}::text[], which drizzle expands to()(syntax error) or($4)(malformed array literal). Fix: bind the array as one parameter.source='api'(company.service.ts:94default;createCompanyFnpasses none).scalar-attribute-list.tsx:299has no catch).Not covered here (handed back)
*.manage), U-68 (identify on teammates).EMAIL_CHANGEDrace branches (need an identity provider / are a race).@core): DB-backed export test for the users/leads boundary not written yet.@nightlyrows of PPL-U and PPL-C.Local runs
Fresh database,
--workers=2 --retries=0, wholetests/people/folder: 3 of 3 runs green (47 tests, quarantined ones excluded). Each quarantined test confirmed red on its bug assertion.