Repository navigation
Update choropleth maps - #170
Merged
Merged
Conversation
patrickbrown4
left a comment
Contributor
There was a problem hiding this comment.
Thanks Claire and sorry for the slow followup. Some high-level questions first and then I'll take another closer look.
patrickbrown4
approved these changes
Oct 8, 2026
patrickbrown4
left a comment
Contributor
There was a problem hiding this comment.
Thanks and sorry for the slow response. Some minor suggestions (happy to chat if helpful) but overall it looks good. Thanks for reorganizing to make the new package optional.
Co-authored-by: Patrick Brown <25125211+patrickbrown4@users.noreply.github.com>
Co-authored-by: Patrick Brown <25125211+patrickbrown4@users.noreply.github.com>
Co-authored-by: Patrick Brown <25125211+patrickbrown4@users.noreply.github.com>
Co-authored-by: Patrick Brown <25125211+patrickbrown4@users.noreply.github.com>
Co-authored-by: Patrick Brown <25125211+patrickbrown4@users.noreply.github.com>
Co-authored-by: Patrick Brown <25125211+patrickbrown4@users.noreply.github.com>
clairehalloran
force-pushed
the
ch/update-maps
branch
from
October 9, 2026 19:40
2d212ab to
cda61aa
Compare
jvcarag
reviewed
Oct 19, 2026
| ax=ax[coords[case]], column='GW', cmap=cmap, vmin=vmin, vmax=vmax, | ||
| legend=False, | ||
| ) | ||
| reedsplots.label_region_value(dfplot, ax=ax[coords[case]], column="GW", fontsize=5) |
Collaborator
There was a problem hiding this comment.
Hi Claire, thanks for this PR update - love the new colors!
Small correction - I believe the fontsize parameter was changed to a dictionary entry in the new text_kwargs parameter:
Suggested change
| reedsplots.label_region_value(dfplot, ax=ax[coords[case]], column="GW", fontsize=5) | |
| reedsplots.label_region_value(dfplot, ax=ax[coords[case]], column="GW", text_kwargs={'fontsize': 5}) |
This would also need to be fixed in the other call to reedsplots.label_region_value() below
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds adjustText package to environment as an optional package to avoid label overlap in maps and adds regional labels to some maps.
Before:

After:

Technical details
Added labels to net import, technology capacity, and H2 capacity maps in
single_case_plots.py:Added labels to difference maps in

compare_cases.pyfor both 2-case and multi-case comparison:In

hourly_plots.py, NaN values (such as for land-locked regions' offshore wind cf) are now colored white and unlabeled:Implementation notes
I incorporated the
adjust_textfunction into the existingreedsplots.label_region_valuefunction for easy reuse.Additional changes
plot_diff_mapsused for 2-case comparison incompare_cases.pyplot_diff_mapsfunction inreedsplots.pydiagnostic_plots.pyValidation, testing, and comparison report(s)
I compared USA_defaults run on this branch with a run from main. There were no changes in results, and a negligible increase in runtime (0.15 hours). Note that the difference in directory size is because I was saving vre_gen, max_cap, and load files from PRAS to run
diagnostic_plots.py.Full results here: results-main,update-maps.pptx
Checklist for author
Details to double-check
- [ ] Documentation updated if necessaryGeneral information to guide review
Did you use LLM tools (chatbot or copilot) in the preparation of this PR? If so, describe how
Yes, I used Copilot to simplify techs to their maptechs groups in
plot_diff_mapsfunction inreedsplots.py. I attempted this change manually and couldn't find a more elegant solution.Tag points of contact here if you would like additional review of the relevant parts of the model