Repository navigation
fix/feat: lint resolution, test script, and transaction feedback with duplicate prevention - #988
Merged
IbrahimIjai merged 2 commits intoOct 17, 2026
Conversation
feat: introduce transaction feedback controller with duplicate submission prevention **Lint fixes (SO4-Markets#824):** - Import order: reorder imports in TVChartContainer, DepthLadder, ConfirmationDialog so external/builtin imports precede internal/relative, and type imports follow value imports. - Logic: remove unnecessary nullish coalescing operators in DepthLadder (line 222) and ConfirmationDialog (lines 135-136) that the linter flagged. - Test: remove unnecessary type assertion in useSourceFreshness.test.ts (line 152). **Test script (SO4-Markets#823):** - Add `test` and `test:coverage` scripts to apps/web/package.json so turbo and CI properly run the web test suite. **Transaction feedback controller (SO4-Markets#732, OB-093):** - Create useTxFeedback hook to manage transaction lifecycle with typed events (signing, submitted, confirmed, ordering, settled, error, unknown_outcome). - Each transaction attempt gets a stable toast ID that is updated across lifecycle stages without relying on English message matching. - Multiple concurrent transactions maintain separate identities. **Duplicate submission prevention (SO4-Markets#733, OB-078):** - Add duplicate submission prevention to useTxSubmit via submitInProgress flag and attempt tracking. - Guard against double-click, Enter+click, component rerender, and provider timeout. - Detect unknown submission outcomes and signal for status lookup by hash. - Extend useTxSubmit to export submitWithFeedback() for order book flows. Closes SO4-Markets#824 Closes SO4-Markets#823 Closes SO4-Markets#732 Closes SO4-Markets#733
|
@QueenGiba is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidated fix and feature work across 4 issues: #824, #823, #732, #733.
Lint & Test (#824, #823)
mainfailsbun lint: 9 errors in web #824: Fix 9 lint errors blocking CIWeb app tests never run in CI: 145 tests fail unnoticed #823: Add missing test script
testandtest:coveragescripts to apps/web/package.jsonTransaction Handling (#732, #733)
OB-093: Introduce a transaction feedback controller with stable toast IDs #732 (OB-093): Transaction feedback controller with stable toast IDs
OB-078: Prevent duplicate submission and unsafe automatic retries #733 (OB-078): Duplicate submission prevention
Closes #824
Closes #823
Closes #732
Closes #733