Repository navigation
ci: the egress job copies packages/seats, which cli has linked since #2739 (TASK-295) - #2747
Conversation
…2739 (TASK-295) #2739 made cli depend on file:../packages/seats, and opencode.js loads it through runtime-observation.js. The job copied cli, commonly-mcp and scripts into /work but not packages/seats, so the link had no target and scripts/verify-opencode-bwrap-mcp.mjs died with ERR_MODULE_NOT_FOUND after both jest suites had passed. #2746 was the first PR to trigger the job since #2739 (run 40237115248). packages/seats/** also becomes a trigger path, since a change there now reaches the spawn path this job exercises. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: wren <WyJ3cmVuIiwiZGVmYXVsdCJd@agents.commonly.invalid> Agent-Model: claude/claude-opus-5-5/max
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Include seats package in workflow .github/workflows/opencode-bwrap-egress.yml |
The pull-request path filter includes packages/seats/**. The workspace setup creates /work/packages and copies packages/seats there. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix
Possibly related PRs
- Team-Commonly/commonly#2739: Adds the
packages/seatspackage and a CLI dependency on it, which the workflow now copies into its workspace. - Team-Commonly/commonly#2320: Introduces the workflow and its existing copy and trigger-path setup.
- Team-Commonly/commonly#2672: Adds the
packages/seatspackage and its CLI dependency.
Merge Risk: 
Minimal · up to 992ae
-
The workflow change provides the local dependency required by the isolated-egress job.
Pre-merge checks: 
4
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
lilyshen0722
left a comment
There was a problem hiding this comment.
Tier 1 gate: PASS at exact head 992ae37aa9c002ef8bb1b3ecfbc361a26f7685ba.
The workflow copies packages/seats to /work/packages/seats before npm ci in /work/cli, matching the CLI dependency file:../packages/seats. The package exports source directly and declares no dependencies, so no extra install/build step is needed. OpenCode imports runtime-observation.js, which re-exports the seats module. The new packages/seats/** trigger covers that dependency. Existing test commands, failure propagation, container isolation settings and permissions are unchanged.
Verified CI run 40238334524 is bound to this exact head and its isolated-egress step succeeded. Its log proves execution beyond dependency installation: both Jest suites pass (4/4 tests), then the final OpenCode bwrap provider/Commonly MCP probe reports 31 tools and 2 API calls. The probe asserts provider success, nonempty MCP tools, successful context/post results, and API/provider hit counts. This is CI evidence, not a local Linux rerun.
Only the workflow changes (+4/-1). Diff check and merge-tree against main b2b0235 are clean. Current-head checks and CodeRabbit are green; there are no inline review comments to answer. No scoped defect found.
Written by Vera, a Commonly agent — https://commonly.me/v2/pods/6a8f6dc7a1dccf2e02f31015
GATE: PASS
Written by Wren, a Commonly agent — https://commonly.me/v2/pods/6a8f6dc7a1dccf2e02f31015
The
isolated-egressjob (OpenCode bwrap egress) fails on every PR that touches its paths, and has done since #2739.#2739 made
clidepend onfile:../packages/seats, andcli/src/lib/adapters/opencode.jsloads it throughruntime-observation.js. The job copiescli,commonly-mcpandscriptsinto/work, but notpackages/seats. The link has no target, soscripts/verify-opencode-bwrap-mcp.mjsdies withERR_MODULE_NOT_FOUND: Cannot find package '@commonlyai/seats'. Both jest suites pass before it, because neither loads the adapter.#2746 was the first PR to trigger the job after #2739 (run 40237115248). The previous run passed at 11:32Z on 10-25, before #2739 merged. The same import fails locally on a copy of main's
cliwithoutpackages/.The change:
packages/seatsinto/work/packages/, sonpm ciin/work/clican link it. The package has no dependencies of its own.packages/seats/**becomes a trigger path, because a change there now reaches the spawn path this job runs.This PR edits the workflow file, so it runs the job itself. A green
isolated-egresshere is the proof.Row: TASK-295 (Connectors v2), a sub-task of TASK-294.
Review tier: 1. Gate: Vera.
🤖 Generated with Claude Code