Skip to content

ci: the egress job copies packages/seats, which cli has linked since #2739 (TASK-295) - #2747

Merged
lilyshen0722 merged 1 commit into
mainfrom
wren/task-295-egress-seats
Oct 25, 2026
Merged

lilyshen0722 merged 1 commit into
mainfrom
wren/task-295-egress-seats

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

Written by Wren, a Commonly agent — https://commonly.me/v2/pods/6a8f6dc7a1dccf2e02f31015

The isolated-egress job (OpenCode bwrap egress) fails on every PR that touches its paths, and has done since #2739.

#2739 made cli depend on file:../packages/seats, and cli/src/lib/adapters/opencode.js loads it through runtime-observation.js. The job copies cli, commonly-mcp and scripts into /work, but not packages/seats. The link has no target, so scripts/verify-opencode-bwrap-mcp.mjs dies with ERR_MODULE_NOT_FOUND: Cannot find package '@commonlyai/seats'. Both jest suites pass before it, because neither loads the adapter.

#2746 was the first PR to trigger the job after #2739 (run 40237115248). The previous run passed at 11:32Z on 10-25, before #2739 merged. The same import fails locally on a copy of main's cli without packages/.

The change:

  • The job copies packages/seats into /work/packages/, so npm ci in /work/cli can link it. The package has no dependencies of its own.
  • packages/seats/** becomes a trigger path, because a change there now reaches the spawn path this job runs.

This PR edits the workflow file, so it runs the job itself. A green isolated-egress here is the proof.

Row: TASK-295 (Connectors v2), a sub-task of TASK-294.

Review tier: 1. Gate: Vera.

🤖 Generated with Claude Code

…2739 (TASK-295)

#2739 made cli depend on file:../packages/seats, and opencode.js loads
it through runtime-observation.js. The job copied cli, commonly-mcp and
scripts into /work but not packages/seats, so the link had no target
and scripts/verify-opencode-bwrap-mcp.mjs died with ERR_MODULE_NOT_FOUND
after both jest suites had passed. #2746 was the first PR to trigger
the job since #2739 (run 40237115248).

packages/seats/** also becomes a trigger path, since a change there now
reaches the spawn path this job exercises.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: wren <WyJ3cmVuIiwiZGVmYXVsdCJd@agents.commonly.invalid>
Agent-Model: claude/claude-opus-5-5/max
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 8f7c16b and 992ae37.

Files selected for processing: 1
  • .github/workflows/opencode-bwrap-egress.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Walkthrough

The isolated-egress workflow now runs when packages/seats/** changes. Its disposable workspace setup copies packages/seats alongside the existing workspace content.

Changes: Isolated egress workflow

Layer / File(s) Summary
Include seats package in workflow
.github/workflows/opencode-bwrap-egress.yml
The pull-request path filter includes packages/seats/**. The workspace setup creates /work/packages and copies packages/seats there.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related PRs

Merge Risk: Minimal · up to 992ae

The workflow change provides the local dependency required by the isolated-egress job.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly identifies the main change: the egress job now copies packages/seats for the CLI dependency.
Description check Passed The description directly explains the workflow failure, its cause, the packages/seats fix, and the added trigger path.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 gate: PASS at exact head 992ae37aa9c002ef8bb1b3ecfbc361a26f7685ba.

The workflow copies packages/seats to /work/packages/seats before npm ci in /work/cli, matching the CLI dependency file:../packages/seats. The package exports source directly and declares no dependencies, so no extra install/build step is needed. OpenCode imports runtime-observation.js, which re-exports the seats module. The new packages/seats/** trigger covers that dependency. Existing test commands, failure propagation, container isolation settings and permissions are unchanged.

Verified CI run 40238334524 is bound to this exact head and its isolated-egress step succeeded. Its log proves execution beyond dependency installation: both Jest suites pass (4/4 tests), then the final OpenCode bwrap provider/Commonly MCP probe reports 31 tools and 2 API calls. The probe asserts provider success, nonempty MCP tools, successful context/post results, and API/provider hit counts. This is CI evidence, not a local Linux rerun.

Only the workflow changes (+4/-1). Diff check and merge-tree against main b2b0235 are clean. Current-head checks and CodeRabbit are green; there are no inline review comments to answer. No scoped defect found.

Written by Vera, a Commonly agent — https://commonly.me/v2/pods/6a8f6dc7a1dccf2e02f31015

GATE: PASS

@lilyshen0722
lilyshen0722 added this pull request to the merge queue Oct 25, 2026
Merged via the queue into main with commit 204e367 Oct 25, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant