Repository navigation
chore(helm): load the hosted-MCP allowlist from a runner-only overlay - #2950
lilyshen0722 wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MDs9DRK3nqxjeAV7xL8uhg
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Move allowlist to runner overlay .github/workflows/deploy-dev.yml, k8s/helm/commonly/values-dev.yaml |
The workflow creates allowlist.yaml from DEV_HELM_HIDDENMCP_ALLOWLIST. When the secret is unset, the chart default ({}) applies. The development values file no longer contains the Atlassian, Sentry, and Airtable user-ID lists. |
Apply overlay to gateway deployment .github/workflows/deploy-dev.yml |
The workflow includes the overlay in the Helm values used to check whether the gateway template renders and in the Helm upgrade. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Possibly related issues
- Team-Commonly/commonly#2168: The issue concerns access gates for hidden hosted-MCP entries. This change supplies the allowlist used by that gate through the deployment workflow.
Possibly related PRs
- Team-Commonly/commonly#2649: Defines the allowlist setting that this change supplies through a runner-only overlay.
- Team-Commonly/commonly#2705: Changes the gateway check and upgrade logic in the same workflow.
- Team-Commonly/commonly#2655: Adds a Sentry allowlist entry that this change removes from
values-dev.yamland moves to the secret.
Merge Risk: 
Minimal · up to 47f98
-
No actionable code issue is established. Confirm that the deployment secret includes Atlassian, Sentry, and Airtable before lifting the stated launch hold.
Pre-merge checks: 
4
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
# Conflicts: # k8s/helm/commonly/values-dev.yaml
|
Merged main in (new head 47f9892). Main had added an |
Hold: press after launch. The
DEV_HELM_HIDDENMCP_ALLOWLISTsecret is set with all six entries (2026-10-28). Before this merges it does nothing, since nothing reads it yet.Deploy Dev writes
hostedMcp.hiddenEntryUserAllowlistfrom that secret to a runner-only overlay, which loads after the private values in both the gateway check and the upgrade. The value leavesvalues-dev.yaml. When the secret is unset, the overlay is empty and the chart default applies.Checked with
helm template: an empty overlay renders{}, and an overlay with entries renders them intoHOSTED_MCP_HIDDEN_ENTRY_USER_ALLOWLIST.🤖 Generated with Claude Code
https://claude.ai/code/session_01MDs9DRK3nqxjeAV7xL8uhg