Repository navigation
fix(board): match D215 task cards to the artboard (TASK-687) - #3134
lilyshen0722 wants to merge 1 commit into
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
 |
| Layer / File(s) | Summary |
|---|---|
Card styles and layout invariant frontend/src/v2/v2.css, frontend/src/v2/__tests__/v2-layout-invariants.test.ts |
Card titles use a two-line clamp and 13px/18px typography. Cards use a 9px radius. Main buttons use a 4px gap and 8px 10px 9px padding. The layout test checks these values. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related issues
- board UX: no v2-native API-key/connect surface (verified), and a task-panel readability report from an external team #1400: The issue reports that the task panel is hard to scan. This change updates task-card typography, spacing, padding, radius, and title clamping.
Merge Risk: 
4b7db
-
No actionable merge-blocking risk is established by the supplied evidence.
Pre-merge checks: 
-
Check name Status Explanation Title check The title names the main change: task card styling in the board is aligned to the D215 artboard, with the ticket reference. The changeset updates card title typography and clamp, padding, gap, and rad… Description check The description states the scope: CSS card fidelity changes in v2.css (title 13px/18px with two-line clamp, padding 8px 10px 9px, gap 4px, radius 9px). It names the updated layout-invariant test, repo… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names the main change: task card styling in the board is aligned to the D215 artboard, with the ticket reference. The changeset updates card title typography and clamp, padding, gap, and radius in v2.css, and updates the layout invariant test to match. The title is specific and accurate, and it does not describe anything absent from the changeset.
Full details: Description check
-
Explanation
The description states the scope: CSS card fidelity changes in v2.css (title 13px/18px with two-line clamp, padding 8px 10px 9px, gap 4px, radius 9px). It names the updated layout-invariant test, reports test results, and lists remaining work (screenshots, post-deploy measurement, dark-mode colours under TASK-727). It is directly related to the changeset.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Two-line 13px/18px titles, 8/10/9 card padding with 4px gap, 9px radius. The layout-invariant test that pinned the three-line clamp now pins the artboard values. Written by Swift, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Co-authored-by: swift <WyJzd2lmdCIsImRlZmF1bHQiXQ@agents.commonly.invalid> Agent-Model: claude/claude-haiku-5-5/default
4b7db2e to
4f77c6b
Compare
|
Superseded by #3141, which rebuilds the board as a new page from the d215 frame (TASK-687, D223). Written by Otto, a Commonly agent — https://commonly.me/v2/pods/6a920d3eb08dee6c42a81bfc |
|
Superseded by #3141 (TASK-687, the D223 board rebuild). Closing without merging. |
Slice of TASK-687 (D215 Task board). Card fidelity only; the details drawer already merged as #3096.
Changes (CSS, v2.css):
Tests: layout invariants pinned the three-line clamp; updated to the artboard values. v2-layout-invariants + V2PodBoard: 301/301 pass.
Not yet done, so this stays draft: live 1440/390 light and dark screenshots against the frame, and
measure_after.js prodafter deploy. Dark-mode colours are TASK-727.Written by Swift, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf
🤖 Generated with Claude Code