Skip to content

feat(agents): agent settings shell, Wake first (TASK-731) - #3146

Merged
lilyshen0722 merged 1 commit into
mainfrom
kite/task-731-agent-settings-rebuild
Nov 1, 2026
Merged

lilyshen0722 merged 1 commit into
mainfrom
kite/task-731-agent-settings-rebuild

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

Written by Kite, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

TASK-731: agent settings shell, Wake first

First slice of the D223 agent settings rebuild. Follows the D215 artboard section order: Wake, then Identity & access (Key, Identity), then the runtime, policy and skills sections.

  • V2AgentSettingsPage.tsx: V2AgentWakePods moves directly under the control loader. Nothing else in the page changes.
  • V2AgentSettingsPage.test.tsx: the pinned order assertion now expects Wake < Key < Identity < How it runs. The rest of the order is unchanged.

Decision: Lily ruled option 1 (follow the artboard) on the card 6ae6b1aaf44c1179586d71ab. The earlier __probe__ value was a test write, and Lily corrected it in pod message 125806.

Not in this PR: the memory textarea move, the How-it-runs fold, the Wake table rebuild on the v2 primitives, and the 1440/390 light and dark frame diff. Those follow on this branch.

Tests: V2AgentSettingsPage.test.tsx and V2AgentWakePods pass, 43/43.

🤖 Generated with Claude Code

Follows the D215 artboard: Wake, then Identity & access (Key, Identity).
The pinned order test now asserts the artboard order.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-authored-by: kite <WyJraXRlIiwiZGVmYXVsdCJd@agents.commonly.invalid>
Agent-Model: claude/claude-haiku-5-5/default
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between fb06a81 and 9932a6b.

Files selected for processing: 2
  • frontend/src/v2/__tests__/V2AgentSettingsPage.test.tsx
  • frontend/src/v2/agents/V2AgentSettingsPage.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

Walkthrough

The agent settings page now renders the Wake section before the Key section. The runtime editor test asserts the order Wake, Key, Identity, then How it runs.

Changes: Agent settings order

Layer / File(s) Summary
Wake section placement
frontend/src/v2/agents/V2AgentSettingsPage.tsx, frontend/src/v2/__tests__/V2AgentSettingsPage.test.tsx
The page renders V2AgentWakePods before the agent-key section. The test asserts Wake, Key, Identity, then How it runs.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Possibly related issues

Possibly related PRs

Merge Risk: Minimal · up to 9932a

The scoped ordering change is internally consistent and presents no concrete merge-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: moving Wake first in the agent settings page for TASK-731.
Description check Passed The description directly explains the Wake section reorder, the updated test assertion, the intended artboard order, and the changes excluded from this pull request.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HEAD: 9932a6b — GATE: PASS

Review of the agent settings shell (2 files, +4 −3 against merge-base). Checked:

  • V2AgentSettingsPage.tsx: V2AgentWakePods moves from after the Identity section to directly after the control loader. Props are unchanged, and no other element moves.
  • V2AgentSettingsPage.test.tsx: the pinned order assertion now expects Wake < Key < Identity < How it runs, plus the existing How it runs < Connector grants < Policy < Skills. The Key < How it runs line is dropped because the chain already implies it.
  • Ran V2AgentSettingsPage.test.tsx and V2AgentWakePods: 43/43 pass locally.
  • Order matches the D215 artboard, and Lily's ruling is on the card 6ae6b1aaf44c1179586d71ab (re-ruled in pod message 125820).

Not in this PR, and not counted here: the 1440/390 light and dark frame diff against docs/design/artboards/d215, which the TASK-731 done test requires before the row closes. The rest of the rebuild (memory move, How-it-runs fold, Wake table on primitives) follows on this branch.

Written by Kite, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

GATE: PASS

@lilyshen0722
lilyshen0722 added this pull request to the merge queue Nov 1, 2026
Merged via the queue into main with commit dc937de Nov 1, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant