Repository navigation
feat(agents): agent settings shell, Wake first (TASK-731) - #3146
Conversation
Follows the D215 artboard: Wake, then Identity & access (Key, Identity). The pinned order test now asserts the artboard order. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Co-authored-by: kite <WyJraXRlIiwiZGVmYXVsdCJd@agents.commonly.invalid> Agent-Model: claude/claude-haiku-5-5/default
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Wake section placement frontend/src/v2/agents/V2AgentSettingsPage.tsx, frontend/src/v2/__tests__/V2AgentSettingsPage.test.tsx |
The page renders V2AgentWakePods before the agent-key section. The test asserts Wake, Key, Identity, then How it runs. |
Estimated code review effort: 1 (Trivial) | ~4 minutes
Change: Other
Possibly related issues
- No UI control for per-agent wakeOnMessage — backend PATCH and CLI exist, frontend has nothing #1395: The change repositions the Wake controls referenced by the issue, but does not establish the full API read and write contract noted in the issue summary.
Possibly related PRs
- Team-Commonly/commonly#2519: Adds
V2AgentWakePods, the component whose placement changes here. - Team-Commonly/commonly#2520: Adds the Key section, which now follows Wake.
- Team-Commonly/commonly#2729: Changes the agent Settings section structure and ordering.
Merge Risk: 
Minimal · up to 9932a
-
The scoped ordering change is internally consistent and presents no concrete merge-blocking risk.
Pre-merge checks: 
4
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
lilyshen0722
left a comment
There was a problem hiding this comment.
HEAD: 9932a6b — GATE: PASS
Review of the agent settings shell (2 files, +4 −3 against merge-base). Checked:
V2AgentSettingsPage.tsx:V2AgentWakePodsmoves from after the Identity section to directly after the control loader. Props are unchanged, and no other element moves.V2AgentSettingsPage.test.tsx: the pinned order assertion now expects Wake < Key < Identity < How it runs, plus the existing How it runs < Connector grants < Policy < Skills. TheKey < How it runsline is dropped because the chain already implies it.- Ran
V2AgentSettingsPage.test.tsxandV2AgentWakePods: 43/43 pass locally. - Order matches the D215 artboard, and Lily's ruling is on the card 6ae6b1aaf44c1179586d71ab (re-ruled in pod message 125820).
Not in this PR, and not counted here: the 1440/390 light and dark frame diff against docs/design/artboards/d215, which the TASK-731 done test requires before the row closes. The rest of the rebuild (memory move, How-it-runs fold, Wake table on primitives) follows on this branch.
Written by Kite, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf
GATE: PASS
Written by Kite, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf
TASK-731: agent settings shell, Wake first
First slice of the D223 agent settings rebuild. Follows the D215 artboard section order: Wake, then Identity & access (Key, Identity), then the runtime, policy and skills sections.
V2AgentSettingsPage.tsx:V2AgentWakePodsmoves directly under the control loader. Nothing else in the page changes.V2AgentSettingsPage.test.tsx: the pinned order assertion now expects Wake < Key < Identity < How it runs. The rest of the order is unchanged.Decision: Lily ruled option 1 (follow the artboard) on the card 6ae6b1aaf44c1179586d71ab. The earlier
__probe__value was a test write, and Lily corrected it in pod message 125806.Not in this PR: the memory textarea move, the How-it-runs fold, the Wake table rebuild on the v2 primitives, and the 1440/390 light and dark frame diff. Those follow on this branch.
Tests:
V2AgentSettingsPage.test.tsxandV2AgentWakePodspass, 43/43.🤖 Generated with Claude Code