Skip to content

design(d215): task record frames at 1440 and 390 (TASK-757) - #3216

Closed
lilyshen0722 wants to merge 1 commit into
ux/task-757-profilefrom
ux/task-757-taskrecord
Closed

lilyshen0722 wants to merge 1 commit into
ux/task-757-profilefrom
ux/task-757-taskrecord

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

Written by Ux Lead, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

TASK-757 item 10: draws the task record (/v2/pods/:podId/tasks/:taskId/record) into the d215 artboard at 1440 and 390, light and dark.

Stacked on #3215 (→ #3214 → #3209). Retarget to main as those merge.

States (3 surfaces, 38 → 44 targets): record with entries, nothing recorded yet, record not available.

Design calls

  • The two downloads are bordered keys; nothing is ink, because the page has no primary act.
  • Entry marks are 16px, 2px stroke; key/value pairs are mono.
  • No Retry on the not-available state: the live errors for access and members are not recoverable by retrying, so the only way out is Back to board.
  • Copy is lifted from en.json taskRecord.*.

Measured (node cap/measure_after.js, targets.json regenerated, node --test cap/measure_after.test.js 10/10): helper words 58 / 32, scroll 1.0× at both sizes. No contrast or 44px exceptions.

Shared v2-run-trace__* CSS is emitted here; the Run trace PR (item 11) stacks on this one.

🤖 Generated with Claude Code

…able at 1440 and 390 (TASK-757)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-authored-by: ux-lead <WyJ1eC1sZWFkIiwiZGVmYXVsdCJd@agents.commonly.invalid>
Agent-Model: claude/claude-opus-5-5/high
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX-GATE: PASS @ e35edb0 — three task-record frames render at 1440 and 390 in light and dark; copy matches the live page

Rendered all 12 frame/theme combinations and read them against V2TaskRecord.tsx and V2RunTrace.css.

  • Copy lifted from en.json taskRecord.*: Back to board, the intro, the two downloads, the empty line, "This record isn't available. The pod may not keep records, or you no longer have access to it."
  • Fit: every frame scrolls 1.0×. targets.json has 44 rows; node --test cap/measure_after.test.js 10/10.
  • Identity bar: no ink key (no primary act on this page), 16px 2px-stroke marks, mono key/value pairs, 44px acts at 390 and 32px at 1440, no shadows, "pod" never "room". Contrast and 44px exceptions: none.
  • Deliberate departure: no Retry on the not-available state, since access and member errors are not retryable.

Written by Ux Lead, a Commonly agent — https://commonly.me/v2/pods/6a692a1be833c668acdb84cf

GATE: PASS

@lilyshen0722

Copy link
Copy Markdown
Contributor Author

Closing: replaced by #3345, which carries the approved task record frames (loaded and not available, 1440 and 390). The branch is kept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant