Repository navigation
Improve installation and update check logic - #87
Merged
Merged
Conversation
- Keep one copy per session: a later launch asks the running copy to open Settings instead of starting a second tray icon whose hotkey fails. - Start the app after install through Explorer so it gets the user's PATH instead of the Windows Installer service's environment. - Remove the old version inside the install transaction so a failed or cancelled update rolls back to it. - Skip the System Restore point that could hold the installer at Please wait for most of a minute. - Only announce the latest stable release once its installer is attached, matching the release the Download button opens.
Rolling back an in-transaction removal in a per-user install without elevation restores the old files but not the old product's registration, so a failed or cancelled update would leave a copy that later updates and uninstalls can't find. Also cover the guard's can't-open branch with a test and describe it accurately.
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A review of the install and update flow found three defects on the main path. A fourth, a second copy starting on relaunch, is fixed separately in #88.
pwsh,python,code,winget, or npm and dotnet global tools failed./releasesand ignored the prerelease flag, while Download opens/releases/latest.Changes
LaunchAppinPackage.wxsruns"[WindowsFolder]explorer.exe" "[INSTALLFOLDER]RadialActions.exe", so the shell starts the app with the user's environment. It also starts unelevated when the installer runs from an elevated terminal.Package.wxssetsMSIFASTINSTALL=1.UpdateServicereads/releases/latestand only reports a version for a release that isn't a draft or prerelease and has an.msiasset. Tests are rewritten for the single-release payload, and a new test covers comparing the exe's four-part version with a three-part tag.Validation
dotnet buildin Debug and Release: 0 warnings.dotnet test: 599 passed.LaunchAppstarted the new version through Explorer's factory, and its PATH had all 14 HKCU entries./releases/latestpayload for v0.7.0 parses to 0.7.0.Considered and rejected
MajorUpgrade Schedule="afterInstallInitialize", which would roll back a failed update to the old version. In a per-user install without elevation, the rollback restored the old files but not the old product's registration (tested). That leaves a copy with no Installed apps entry, which later updates install beside and uninstalls can't remove. The default schedule stays, andPackage.wxssays why.Risks
MSIFASTINSTALLis only in the new package. Later upgrades skip it.explorer.exe <path>is widely relied on but isn't a documented API.Follow-ups (separate PRs)
Package.wxspolish: icon and links in Installed apps, ICE03 and ICE64 fixes, excluding*.settings*from the harvested files.artifactErrorsFailBuildin deploy.