Repository navigation
CI reliability: the census names the child that left its unit (#433); Assistant keeps the finished reply in view - #533
Merged
Merged
Conversation
Keep the first missing-child snapshot through cleanup. Record retained and current PID, parent, start tick, command, cgroup and pidfd observations. Keep raw arguments in a private runner log and safe fields in the uploaded receipt. Preserve the immediate failure and existing cleanup gates. Verification: 35 finite-journey tests pass. The diagnostic fixture fails on the base; the first-capture regression fails before its keep-first guard and passes after.
Compare saved scroll pins with the current reachable scroll limit, so a layout clamp keeps the follow through deferred Markdown finalization. Keep the generation guard and reader scroll controls. The pinned Chromium regression holds the idle render, resizes the viewport under 4x CPU throttling, and checks the settled reply with the existing assertions. Before: 3/3 failures, reply 66 px behind the composer. After: 10/10 passes, reply 36 px above it. The exact 774 px CI interleaving was unreproduced in 50 throttled and 15 CPU-load runs. Checks: elastos-heavy ./scripts/test-behaviour.sh (2055 passed); elastos-heavy ./scripts/test-source-gate.sh (exit 0); git diff --check. Failure recorded as lesson 923.
This was referenced Nov 5, 2026
Open
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deepen notes
scripts/ci-installed-journeys.py:468-687at fa4d905 and the original failed receipts. Assistant at d497f78:scripts/assistant-reply-layout-browser-smoke.mjs:199-236already polls for five seconds;capsules/assistant/browser/agent-stream.js:2078-2087,2924-2946,3139-3151controls the final scroll;agent-harness.js:469-487changes composer clearance. CI run 41933322796 and the unrelated G5 Private Browser: Jetson support #90 remote gate show the same -774 px failure.Problem
#433: the installed journey in source-home-linux (ubuntu-24.04) fails intermittently with "finite journey live child left its unit census" on changes that do not touch it (3 Nov develop, #526, #532). The receipts do not say which child left its unit or where it went, so a real escape and an early census sample cannot be told apart.
Change
Diagnostics only; the census assertion and cleanup checks are unchanged (no retry, wait or skip). On failure the receipt records, for the missing child and its parent: pid, start tick, state, role, executable hash, pidfd state and current cgroup, plus a re-read of the expected unit's
cgroup.procs. Public cgroup paths keep systemd unit names and replace other components with<name>; full arguments go to a 0600 private log. The first failure snapshot is kept before cleanup.Next failure decides product bug (escape) or census bug; #433 stays open until then.
Local Assistant follow-up (awaits publication)
Commit
fe0073c47preserves the final scroll follow when layout clamps the saved scroll position while the Markdown render is pending. The browser regression holds that render, increases viewport height from 800 to 1600 under 4x CPU throttling, then checks the completed presentation with the existing end-position and composer-clearance assertions. It restores the desktop viewport for the remaining reader-scroll checks.The commit is local, directly after
d497f7892. The published PR head remains the census candidate. Anders owns publication; current-candidate independent review and CI confirmation remain before integration.Also: Assistant keeps the finished reply in view (fe0073c)
The Assistant reply layout smoke failed twice on 4 Nov (remote gate for #531, CI for this PR): after a streamed reply finished, the newest reply was left above the composer. Codex reproduced a real product bug: when the layout shrinks the scroll range, the saved scroll pin is clamped and Assistant wrongly concluded the reader had scrolled up, so it stopped following. The guard now compares against the reachable scroll limit; a reader who really scrolled up still keeps control. Throttled regression: 3/3 fail before, 10/10 pass after. The exact 774 px interleaving from CI was not reproduced (50 throttled and 15 loaded runs). Reviewed by Main (Claude).