Repository navigation
analog: linear_zoh.t27 -- rename struct Ring to RingPeak, it collided with another type named Ring and moved the types ratchet 107 -> 108 (Closes #10503) - #10539
Merged
Conversation
… with another type named Ring and moved the types ratchet 107 -> 108 (Closes #10503) PR #10528 merged specs/analog/linear_zoh.t27 with `pub struct Ring`. The corpus-ratchet job ran `tri types ratchet` and failed: ledger 107 names, observed 108, "+ Ring NEW conflict" -- a type name with two definitions in the corpus. The job is not a required check, so the merge went through; master is red on it until this lands. The struct holds the peak amplitude of the scheme and the analytic one in the tank test. Renamed to RingPeak (no other definition of that name). Nothing else changes: the same 15 tests pass with 0 vacuous, the seal is re-saved (15/15), `tri types ratchet` is CLEAN at 107/107, dupe_scan says ok. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
October 18, 2026 16:46
This was referenced Oct 18, 2026
Merged
Contributor
4 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10503
Follow-up to #10528 (M1c,
specs/analog/linear_zoh.t27), which merged with a defect that its own gates did not catch.What went wrong
#10528 declared
pub struct Ringfor the tank test. The corpus-ratchet job runstri types ratchet, and on that PR it failed:ledger 107 name(s), observed 108,+ Ring NEW conflict, i.e. a type name with two definitions in the corpus. The job is not a required check, so auto-merge went through and master is now red on it (master's run at the base commit 1d8477c was green). I had runtest-report,tri test,seal --verifyanddupe_scanlocally, but nottri types ratchet.Fix
Rename the struct
RingtoRingPeak(no other definition of that name exists). Nothing else changes: 2 files, 14 lines each way (the struct, its two return types, two constructors, threeconst ... : RingPeakin the tank test, plus the re-saved seal).Evidence
tri types ratchet:ledger 107 name(s), observed 107,RATCHET: CLEAN(wasobserved 108before the rename, on the same tree).t27c test-report specs/analog/linear_zoh.t27: 15 of 15 pass,vacuous passes 0 of 15.tri test specs/analog/linear_zoh.t27: exit 0, 15/15.t27c seal --savethen--verify: all hashes MATCH, seal records 15/15, vacuous 0.python3 tools/dupe_scan.py: ok.Left as it is
claw-sariffails on analog: linear_zoh.t27 -- exact zero-order-hold constants for the linear cell, and the h/2 convergence check (Closes #10503) #10528 with the known GitHub App permission error (owner steps indocs/claw/README.md); it is red on other PRs too.t27b-native-ratchetwill list the spec as UNLISTED, becauset27brejects the libm builtins (@sin,@cos,@exp,@log2) the analytic solution needs. The steward job adds ledger rows from master runs;docs/reports/t27b_expectations.jsonis not touched here.🤖 Generated with Claude Code