Skip to content

seal(t27f): re-seal frontend.t27, stale since 2e561c612 -- Seal Coverage green again (Closes #10811) - #10814

Merged
gHashTag merged 2 commits into
masterfrom
fix/reseal-t27f-frontend
Oct 19, 2026
Merged

gHashTag merged 2 commits into
masterfrom
fix/reseal-t27f-frontend

Conversation

@gHashTag

Copy link
Copy Markdown
Owner

Closes #10811.

Why. On master, 2e561c6 (#10782 M4) changed specs/t27f/frontend.t27 without re-sealing it. Since then tools/check_seal_coverage.py ("Every seal still describes its spec") has failed on every PR, #10799 among them.

What. t27c seal specs/t27f/frontend.t27 --save refreshes .trinity/seals/t27f_T27fFrontend.json, plus a NOW entry. The spec itself is not touched.

Verified. I ran these with a t27c built from this branch's base, which includes the gen-rust change 0131f31. The first commit had used an older t27c, and the second commit corrects its rust hash.


Generated by Claude Code

2e561c6 (#10782 M4) changed specs/t27f/frontend.t27 without re-sealing it, so
check_seal_coverage failed on every pull request. t27c seal --save; the spec is untouched.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k
…refs #10811)

The first save used a t27c from 239b4b0, older than the gen-rust change 0131f31, so its
rust gen hash described the old emitter. Re-saved with a t27c built from this branch's base;
check_seal_coverage: none newly broken.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k

Copy link
Copy Markdown
Owner Author

Documented t27c subcommands exist is red on 80e55a5, and this PR did not cause it. I ran tools/check_documented_commands_exist.py locally, with t27c and tri built from this branch's base. It reports dead tri mentions rose 138 -> 139.

This PR changes only .trinity/seals/t27f_T27fFrontend.json and one NOW entry, and its diff mentions no tri command (git diff origin/master...HEAD | grep 'tri ' is empty). So the 139th dead mention is already in the base. The check is not required. The repair is to remove that mention, or to lower MAX_DEAD_TRI together with it in the commit that fixes it; that belongs to whoever added it.


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

The required check duplicate-bodies is red on 80e55a5, and this PR is not the cause. It checks the merge with current master. On master 088a559, tools/dupe_scan.py reports two new copies: bytes_contain, copied 11 times, and saturating_add, copied 2 times. Both came in with 72f1280 (t27o std methods). On this branch alone the scan passes: "no new duplicate body, and none of the known groups grew".

The fix is already open as #10817, "t27o: pay down the duplicate bodies of the A2 methods". I am not porting it here, because it rewrites specs this PR does not touch. Once #10817 merges, this PR's checks will run against the fixed master.


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-19 03:51:43 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 42
PRs with All Checks Green 8
READY 1
FAILING 42
PENDING 0
NO CHECKS YET 0

These columns do not partition: 1 + 42 + 0 + 0 = 43, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=03f3de4a3582 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag enabled auto-merge (squash) October 19, 2026 04:00
@gHashTag
gHashTag merged commit 20c284f into master Oct 19, 2026
29 of 31 checks passed
gHashTag pushed a commit that referenced this pull request Oct 19, 2026
GitHub's update-branch reported a conflict; the merge is clean locally (git merge-tree). Picks up master's re-sealed specs/t27f/frontend.t27 (#10814), which this branch's coverage and spec-guards reds came from.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-seal specs/t27f/frontend.t27: its seal went stale on master in 2e561c612, Seal Coverage red on every PR

2 participants