Repository navigation
PTX: the 12 emitter helpers live once in ptx_emit.t27 and both kernel specs use it (Closes #10947) - #10948
Merged
Conversation
… specs use it (Closes #10947) duplicate-bodies has been red on master since #10855: put_s, put_u, ins, put_quad, emit_lds, emit_mma_step, emit_store, emit_epilogue, code_at, weight, at_text and count_text were byte copies between ternary_gemm_ptx.t27 and hslm_bwd_ptx.t27, in no ledger. They move to specs/igla/coder/ptx_emit.t27 (10 tests of its own); both kernel specs `use` it. Seals regenerated, gen-rust output regenerated by t27c (it inlines the imported functions, so no Rust edit). Existing tests: 21/21 and 19/19, 0 vacuous, unchanged. No ledger row added. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 19, 2026
Merged
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10947
What
The
Duplicate Body Ratchetworkflow has been red on master since #10855: twelve helpers (at_text, code_at, count_text, emit_epilogue, emit_lds, emit_mma_step, emit_store, ins, put_quad, put_s, put_u, weight) were byte copies betweenspecs/igla/coder/ternary_gemm_ptx.t27andspecs/igla/coder/hslm_bwd_ptx.t27, with no ledger row. The red blocks every open PR (for example #10572). It was previously tracked in #10930 and #10935, both closed by the issue-shape gate.Fix
specs/igla/coder/ptx_emit.t27holds the twelve helpers once (bodies unchanged) plus 10 tests of its own.use igla::coder::ptx_emit;and drop their copies (about 360 lines deleted)..trinity/seals/regenerated witht27c seal --save;bootstrap/gen/rust/igla/coder/{ternary_gemm_ptx,hslm_bwd_ptx}.rsregenerated byt27c gen-rust, which inlines the imported functions. No Rust source edit and no ledger bless.Checked (Railway lab, not the Mac)
tools/dupe_scan.py: ok, no new group, no growth; self-test ok.t27c seal --verify: all hashes MATCH for the three specs;parseok.Not run: the full
t27c suiteandptx-run(needs a GPU); CI covers the suite.🤖 Generated with Claude Code