Repository navigation
analog M4b-q: the dynamic comparator with the devices charge and the body effect at 27 C, decision time within 1.8 percent of ngspice; acceptance 7 PASS, 0 FAIL, 6 NOT MODELLED - #11325
Merged
Conversation
… the body effect at 27 C -- decision time +1.75 percent from ngspice's own run (613.07 ps against 602.54 ps), accept_sar now 7 PASS, 0 FAIL, 6 NOT MODELLED of 13 blocks (Closes #11312) specs/analog/sar_comparator_q.t27 (new): the eight-node latch of sar_comparator.t27 on the tt 27 C PSP103 log tables read on the source-to-bulk axis (M3e), with the drain, gate and source charge of the M3c tables and the same backward Euler charge step, 1.6 ps, K = 4 Newton iterations. The source terminal's charge, whose bulk part is not tabulated, is closed by its two edges (Qs = Qd at Vds = 0, Qs = 0 at a gate drive of 0, exactly); without it the Newton step does not converge. The tables are extended linearly beyond 0 and 1.5 V so that charge and slope are one function. Decision time at +2 and -2 mV: 613.07 ps and 613.15 ps against ngspice-47 on the golden comparator at 27 C, 602.54 ps (settled start): +1.75 and +1.76 percent, +1.62 percent against ngspice's backward Euler on the same grid, +1.00 percent against the report's 607 ps; +1.75 to +3.11 percent over every input down to 1 unit. End levels at 2 ns within 0.5 mV and reset levels 1.4 ns after the clock falls within 0.2 mV of ngspice's. Negative controls: charge removed 5.40 ps (FAIL), no body effect -5.30 percent, no closure / swapped tables / K = 2 refused by the residual. Decks (specs/analog/decks/sar_cmp_q_*.cir): the comparator written out (no golden file read), proven to be the golden comparator by reproducing its 523.032 / 528.006 / 529.386 / 529.741 ps at 50 C; the settled, golden-deck (uic, disturbed by the devices' internal nodes) and free starts; the backward Euler grids. The settled and free starts give 602.54 and 607.145 ps, the report's 607 ps. sar_comparator.t27: sc_stamp_chan split in two (sc_stamp_chan_w, with a body slope that is 0 for every old caller): its 20 tests and pinned folds are unchanged. accept_sar.t27: the dynamic_comparator rows recomputed from the new model, a row PASS only inside the report's limit and within the bar of ngspice (10 percent for the time, 5 mV for a level); the block is PASS. docs/analog/accept-sar-2026-10-20.md: counts, table, section 3d, controls. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…body effect at 27 C, decision time within 1.8 percent of ngspice; acceptance 7 PASS, 0 FAIL, 6 NOT MODELLED (Closes #11312) Merge of master plus sealing, gates run on the merged tree with t27c from master: tests clean with vacuous passes 0, seal --verify MATCH, tri types ratchet CLEAN, dupe_scan failure set a subset of master's. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
October 20, 2026 11:00
Contributor
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11312
analog M4b-q: the dynamic comparator with the devices charge and the body effect at 27 C, decision time within 1.8 percent of ngspice; acceptance 7 PASS, 0 FAIL, 6 NOT MODELLED
Gates run on the merged tree (t27c from master): 3 spec(s) with tests clean and vacuous passes 0, seal --verify MATCH, tri types ratchet CLEAN, dupe_scan failure set a subset of master's (inherited red).
TEST specs/analog/sar_comparator_q.t27 tests=[8] fail=[0] vacuous=[0]
TEST specs/analog/sar_comparator.t27 tests=[20] fail=[0] vacuous=[0]
TEST specs/analog/accept_sar.t27 tests=[15] fail=[0] vacuous=[0]
SEAL specs/analog/sar_comparator_q.t27 :: all hashes MATCH
SEAL specs/analog/sar_comparator.t27 :: all hashes MATCH
SEAL specs/analog/accept_sar.t27 :: all hashes MATCH
TYPES RATCHET: CLEAN
DUPE failing=4 extra-vs-master=[]
🤖 Generated with Claude Code