Skip to content

feat: Jev-backed decision layer (decide) with shadow-first router, skill rerank and SDD judge comparison - #858

Closed
getappz wants to merge 7 commits into
masterfrom
task/338-feat-jev-backed-decision-layer-decide-wi
Closed

getappz wants to merge 7 commits into
masterfrom
task/338-feat-jev-backed-decision-layer-decide-wi

Conversation

@getappz

@getappz getappz commented Oct 5, 2026

Copy link
Copy Markdown
Owner

Implementing the typed-decision layer — checking worktree state.
Work looks complete — running verification.
Decide tests pass — running remaining suites.
Work complete — no new edits needed; branch task/338-feat-jev-backed-decision-layer-decide-wi already contains the full Jev decision layer (#701–#705 + agent_model + review-fix commit), working tree clean.

Tests run (foreground, all pass):

  • cargo test -p agentflare --bin agentflare decide: 45 passed
  • jev: 13, skill_rerank: 11, agent_model: 7, jev_router: 10, judge: 32 — all passed
  • cargo clippy with the documented flags (-D warnings -A unsafe_code -A clippy::pedantic): clean; cargo fmt --all --check: clean
  • Full cargo test --workspace timed out in this env (>10 min cold); targeted suites cover all new code.

Concerns:

  • Pre-existing pedantic doc lints in unrelated crates/agent-registry fail under bare -D warnings without -A clippy::pedantic; not touched by this task.
  • Live-path caveats from the plan stand: hook/judge paths only tested against fake backends, Cloudflare provider unverified live.

Opened by opencode on flared:51bb8de6c33b for item #338 via agentflare.

…pen ask(), vault-aware credentials, decide ping (#701)

Agentflare-Agent: claude-code_2-1-288_harness
Agentflare-Branch: task/701-jev-client-module-provider-key-resolutio
Agentflare-Item: 701
Agentflare-Session: b333d2f1-8f5b-4379-883f-eadf5c7238dc
…nostic in 'decide ping' (#702)

Agentflare-Agent: claude-code_2-1-288_harness
Agentflare-Branch: task/701-jev-client-module-provider-key-resolutio
Agentflare-Item: 701
Agentflare-Session: b333d2f1-8f5b-4379-883f-eadf5c7238dc
…ev with shadow logging and keyword fallback (#703)

Agentflare-Agent: claude-code_2-1-288_harness
Agentflare-Branch: task/701-jev-client-module-provider-key-resolutio
Agentflare-Item: 701
Agentflare-Session: b333d2f1-8f5b-4379-883f-eadf5c7238dc
…t tail, claude config) for model routing

Agentflare-Agent: claude-code_2-1-288_harness
Agentflare-Branch: task/701-jev-client-module-provider-key-resolutio
Agentflare-Item: 701
Agentflare-Session: b333d2f1-8f5b-4379-883f-eadf5c7238dc
…via AGENTFLARE_JEV_SKILLS) with fail-open fallback (#704)

Agentflare-Agent: claude-code_2-1-288_harness
Agentflare-Branch: task/701-jev-client-module-provider-key-resolutio
Agentflare-Item: 701
Agentflare-Session: b333d2f1-8f5b-4379-883f-eadf5c7238dc
…pt-in AGENTFLARE_JEV_JUDGE=shadow) (#705)

Agentflare-Agent: claude-code_2-1-288_harness
Agentflare-Branch: task/701-jev-client-module-provider-key-resolutio
Agentflare-Item: 701
Agentflare-Session: b333d2f1-8f5b-4379-883f-eadf5c7238dc
… in hooks, base-URL guard, router labels, skill baseline)

Agentflare-Agent: opencode
Agentflare-Branch: task/701-jev-client-module-provider-key-resolutio
Agentflare-Item: 701
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 55 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: getappz/agentflare/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 5068e783-d812-434b-b521-9a8f0713c3b2
📥 Commits

Reviewing files that changed from the base of the PR and between 2e8f4b2 and 50f4fed.

📒 Files selected for processing (19)
  • src/agent_model.rs
  • src/cli/decide.rs
  • src/cli/mod.rs
  • src/decide/client.rs
  • src/decide/mod.rs
  • src/decide/provider.rs
  • src/decide/shadow.rs
  • src/decide/types.rs
  • src/dev_vars.rs
  • src/hook.rs
  • src/main.rs
  • src/optimize/jev_router.rs
  • src/optimize/mod.rs
  • src/optimize/runtime.rs
  • src/skill_rerank.rs
  • src/vault.rs
  • src/work_item_pipeline.rs
  • src/work_item_pipeline/judge_shadow.rs
  • src/work_item_pipeline/judge_shadow_tests.rs
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@getappz

getappz commented Oct 5, 2026

Copy link
Copy Markdown
Owner Author

Closing as superseded, same as #854. #851 was squash-merged at 06:27Z and already contains the review fixes (54c79c1). This branch re-pushes the same seven commits (including 50f4fed, a parallel version of those fixes) from another workstation (flared:51bb8de6c33b) and conflicts with master. Root cause is tracked in agentflare item #712 (done must recognise a hand-opened merged PR on the item's own branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant