Repository navigation
chore(i18n): rename Crew Members to Agents across the dashboard - #11869
kyleseaman wants to merge 1 commit into
Conversation
|
Intent: Make the dashboard call a standing agent by one name. The rail, the page it opens, that page's create form and the Settings switch that reveals it all said different things — "Crew Members", "member", "Crews" — for the same object; every user-visible string on that surface now says "Agents", and the preview switch says "Agent Mode". |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify the untouched "New members get private Memory V2. Existing members keep…" notice is intentional — it renders beside strings this PR renamed on the same page. Suggestions
[DESIGN-REVIEWED] d4cdc03 |
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS "Agent Mode" coins a switch-only name by preference, and two "member" strings survive on the surfaces the description declares fully renamed. Not justified as shipped
What this change shipsInventory (10 items) — 6 justifiedIntent: make every name a user reads for a standing agent say "Agents", ending the member/crew/agent three-way split (#2622's sibling surface) — a FIX.
[FIRST-PRINCIPLES-REVIEWED] d4cdc03 |
Opus 4.8 Review — ✅ no blocking findingsReviewed Review detailsThe change is a value-only i18n rename. The one behavioral surface — the deep-link plumbing — is internally consistent: registry id No findings. [OPUS-REVIEWED] d4cdc03 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Fable 5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The rename leaks: "Open agent editor" lands on an always-visible notice still calling agents "members" twice, and the avatar builder still says "crew editor." Watch
Suggestions
[UX-REVIEWED] d4cdc03 |
The product had three nouns for one thing. The rail said "Crew Members",
the page it opened called every row a "member", and three of its filters
said "Crews". All of them are the standing agents you hold a thread with,
so all of them now say "Agents".
The nav rail, the sidebar create-menu entry and the page title are
"Agents". The page's own vocabulary follows: "Add agent", "Search agents",
"No agents yet.", "{{count}} agents", the four status-filter descriptions,
the side-panel "Agent summary" tab and every error notice. The Settings >
Developer > Feature Previews switch that reveals the page is "Agent Mode".
Values only: no catalog KEY was renamed, so no call site, parity gate or
dead-key gate moves. All eleven target catalogs carry the same rename,
each reusing the rendering of "agent" already in its own
nav.agent_capabilities. The pseudolocale and both settings-registry
artifacts are regenerated.
The registry derives a card id from its label, so the Feature Previews
card id becomes developer.agent-mode. Both earlier spellings join
LEGACY_ID_EXACT so a saved deep link still lands on the switch.
The route, the filenames and the membersPage.* catalog keys keep the
"member" spelling; none of it is user-visible.
01d4455 to
d4cdc03
Compare
|
FIXED — both evidence gaps closed, and the Watch item was real. Cannot-evaluate #1 (create-agent dialog) and #2 (sort-and-filter popover): both Watch (five missed strings): correct on all five, and they were missed because Two grammar defects surfaced while fixing them, both caused by the rename and
|
|
ACCEPT AND DEFER — the finding is correct; the fix belongs outside this PR. "Open agent editor" does navigate to Deferred because the destination is the Capabilities surface, which this PR Filing a linked follow-up for the Capabilities vocabulary rather than widening a |
|
ACCEPTED AS AN OWNER DECISION — not reversed, but the stale rationale it cited The label is the repository owner's explicit instruction: the page is "Agents" The lane is right that the change left a contradiction behind, though. The pin at |
|
FIXED — row deleted. Correct, and verified before removing: The history comment above the map was wrong in the same way and is corrected: it |
|
ACCEPTED — declared, and it follows the existing per-surface convention.
One design point on it, recorded here in case it is read as the stale-evidence |
|
🤖 Kiro Crew [operator: dwu96#8c08bee0]: This PR has been inactive with failing CI and a merge conflict. I've assessed the blockers and they appear resolvable — I'll push fixes directly to this branch as a co-author. Assessment: The only test failure is stale base drift, not a defect in this PR. If you'd prefer I don't touch this PR, add the |
|
🤖 Kiro Crew [operator: chenmingwei23#de330d0c]: This PR has been inactive for 7+ days with a merge conflict blocking PR Readiness. I've assessed the blockers and they appear resolvable — I'll push fixes directly to this branch as a co-author. Assessment: All AI review lanes (GPT, Opus, Design, First Principles, Security) pass; the only red is PR Readiness caused by a merge conflict against current main (39-file i18n rename "Crew Members → Agents"). Fix plan: rebase onto origin/main, take main's structure where the rename overlaps, re-run. If you'd prefer I don't touch this PR, add the |
|
Closing: superseded by PR #12924 under the accepted Crewmates RFC Thanks for the careful work here, especially the locale pronoun fixes. I'm closing this PR because, after it opened, the product settled on a different name for the same object, and PR #12924 now carries the same page copy using that name. Overlap. Both PRs rewrite the same
Why #12924 is the host
Harvest. This is not a literal duplicate. Neither #12924 nor main touches the navigation surfaces yet. They should get a follow-up in crewmate vocabulary that reuses the mechanics here but not the values:
One change is vocabulary-neutral and can be ported as is:
If the RFC's vocabulary isn't meant to apply to this surface, reply here and reopen. From a full open-PR audit against origin/main c66f95b (2026-09-25); findings were checked by independent reviewers reading the code. Reply here if this is wrong. |
Problem / Motivation
The dashboard had three names for one thing. The left rail said Crew Members. The page it opened called every row a member — "Add member", "Search members…", "No crew members yet." And three of that page's own filters described their contents as Crews: "Crews that ship with Kiro Crew".
They are all the same object: a standing agent you hold a thread with.
Why it matters
A reader cannot tell whether a "crew member", an "agent" and a "crew" are three things or one. That doubt is expensive in the surface where it lands: the rail row, the roster, the create form, and the switch in Settings that reveals the page. Issue #2622 recorded the same split one page over, on the Agents tab, and was closed by renaming only that tab — this page kept its old vocabulary.
What changed (motivation → approach → change)
Everything a user reads on this surface now says Agents, from the rail row down to the create form's last field hint. The switch in Settings → Developer → Feature Previews that reveals the page is Agent Mode — it names a mode rather than the page, because that is what a preview toggle is.
🟩 added · 🟨 changed · 🟥 removed · 🟦 unchanged
The create form carries two parallel vocabularies —
*_memberkeys for the roster origin, unsuffixed ones for the Capabilities origin — so renaming only the dialog title would have left the form calling an agent a member one field in, whichCrewRoster.test.tsxexists to forbid. The roster origin's fourteen strings move with the title, in every catalog. Three of those_membervalues are now identical to their unsuffixed siblings, because carrying the old noun was the only thing they ever did; collapsing them removes a key from thirteen catalogs and is left to a follow-up.Only catalog VALUES moved. No key was renamed, so no call site, no parity gate and no dead-key gate moves with it, and the eleven translated catalogs under
website/src/i18n/locales/carry the same rename — each reusing the word for "agent" its ownnav.agent_capabilitiesalready used, and the word for "mode" its ownfocus_modealready used.en-XA.jsonis regenerated, as is the translator context inwebsite/src/i18n/en.context.json. Russian'smember_count_fewand_manyhave no English counterpart, so they are renamed too; left alone, one key family would have shipped "1 агент / 2 участника". The CJK roster counters move off people-counters (名 · 명 · 位) onto object-counters, because the noun is software now.website/src/surfaces/builtins.tsxholds the surface's English label fallback, so it moves with the catalog. The settings registry derives a card's id from its label, so the Feature Previews card id becomesdeveloper.agent-modein the regeneratedwebsite/src/components/commandPalette/settingsRegistry.gen.tsandsrc/kiro_crew/docs/settings-registry.generated.json;website/src/hooks/useSettingHighlight.tspoints at the new id and keeps every older spelling in its legacy map.Backwards compatibility
Compatible: no catalog key, API field, route or config value changes, so nothing that reads this data stops working. The one renamed identifier is the settings-registry card id (
developer.crew-members→developer.agent-mode), which is derived from the label and only ever addresses a highlight;resolveLegacyHighlightIdmaps that id and the olderdeveloper.crew-members-and-crew-modeanddeveloper.agentsonto the new one, so a saved link or palette entry still lands on the switch.Tests
website/src/pages/members/,website/src/test/andwebsite/playwright/carry the assertions that pin this copy: the roster's empty state, counts, search, sort-and-filter label, summary-tab accessible name, edit affordances, memory-binding notices, the create dialog's name and body, the private-memory guidance, plus the preview-switch name and the surface label. Each one asserts the shipped string, so a partial rename fails rather than passing quietly. The form-coherence test inCrewRoster.test.tsxstill asserts that the dialog title and its body use ONE noun — now "agent" — and the edit-later-note test now asserts both origins read the same, which is what the collapse of the two vocabularies means.website/scripts/capture-agent-mode-card.mjsis new. It shoots the Settings card gateway-free and refuses to write a PNG unless the rendered text starts with the expected label, names the Agents page, and contains no "Crew Members" — so a stale frame cannot be attached as evidence for a rename that did not land.Manual verification
Both frames below are real renders, not mockups: the roster comes from the existing
capture-members-page.mjsentry mounting the real page, the card from the new gated capture against the built SPA. Reading them is what caught two strings a text search had missed — the drawer's memory-binding notice and its "Open crew manager" button.Screenshots / video
The Agents page — rail row, roster, counts, search, the "Agent summary" tab, and the drawer's renamed notice and button:
Settings → Developer → Feature Previews:
The create-agent dialog, reached from the roster's add entry. Added for the UX review, which could not evaluate this surface from the earlier frames:
The sort-and-filter popover open on the roster. Its source descriptions are hover
titleattributes, so the capture proves the surface while the script asserts the exact renamed copy:Related Issues
no linked issue: #2622 covered the same split on the Agents tab and is already closed; this is the sibling surface, tracked by nothing open.
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)