Skip to content

refactor(i18n): restore the Crew vocabulary for remote crews - #12697

Merged
iamwhatever merged 1 commit into
mainfrom
chore/remote-crew-vocabulary
Sep 22, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
chore/remote-crew-vocabulary

Conversation

@kyleseaman

@kyleseaman kyleseaman commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

What changed

The remote-crew feature's user-visible text goes back to Crew. PR #6950 renamed it to "Remote Instances" and #7378 swept the docs to match; this restores the original vocabulary across all 14 i18n catalogs, the guides and system specs, the shipped user docs, and the tests and capture harnesses that pin the strings.

Reverting #6950's key set alone would have shipped a broken product. Nine strings adopted "Remote Instances" in the three weeks after it merged and were never in its key set, and four of those are cross-references: they tell the reader to open "Remote Instances in Settings", a panel this change renames. A user following that instruction would look for a panel that no longer exists. Those nine move too, and each locale's reference now names that locale's own panel label rather than a translation of the English one.

"Instance" stays wherever it means a machine, an EC2 box, a gateway process or a code identifier: backend keys and routes, the instances.json registry, the apps.mochi.instances.* namespace (internally consistent machine vocabulary — "every Kiro Crew runs its own", "This computer"), the gui_user remote-instances slug, and the filed Fargate RFC. Catalog keys are untouched; only values move, exactly as #6950 did. CHANGELOG history is not rewritten, and the changelog-history gate confirms all nine shipped sections are intact.

One derived identifier does move, and it is not a catalog key. Settings-registry ids are generated from the label, so relabelling the preview card shifted developer.remote-instance-sessions to developer.remote-crew-sessions — which would silently break a saved ?highlight=developer.remote-instance-sessions bookmark. A LEGACY_ID_EXACT entry in website/src/hooks/useSettingHighlight.ts now maps the old id onto the new one, the same mechanism the Slack-tab collapse and the Polly relabel use, with a revert-verified test in website/src/test/settingHighlightAliases.test.ts (removing the alias fails 2 of its 8 tests). Caught by the First Principles lane, not by me; my earlier claim that nothing but values moved was wrong.

The mechanical revert restored a pre-existing inconsistency, so the per-locale terms were normalized against each catalog's own precedent rather than shipped as found.

Two passages are authored, not restored

docs/system-specs/modules/crew-mode.md existed to say "a crew is not a Remote Instance". With both labels reading "crew", a literal swap disambiguates nothing, and the file post-dates both merges so there is no earlier text to recover — it now carries a short gloss naming the feature.

docs/system-specs/modules/instances.md carried a note from #6950 stating "Remote Crew" was retired in favour of "instance". A faithful revert deletes it, but the UI/code mismatch it documents is real and is more confusing inverted, so it states the restored direction instead.

Both are flagged for review as prose I wrote rather than text I restored.

Deliberate divergence

src/kiro_crew/docs/remote-instances.md (shipped last week by #12581) has its content and title restored to "Remote Crew" but keeps its filename, because that filename is a published URL and renaming it breaks inbound links. Its glossary row now carries both names. Renaming the file with redirects is filed as #12750 rather than buried here, at the Design lane's request, so the documented displayed/stored split does not quietly become permanent.

Files touched

Catalogs and the pseudolocale: website/src/i18n/locales/en.json, en.manual.json, the 11 translations and the regenerated en-XA.json, plus website/src/i18n/instancesDisconnectHint.test.ts.

Product surfaces, all panel-name references in copy or comments: website/src/pages/settings/RemoteCrewPanel.tsx, website/src/pages/settings/InstancesPanel.tsx, website/src/pages/members/DeployMyCrew.tsx, website/src/pages/members/FargateCrewView.tsx, website/src/pages/members/MembersPage.tsx, website/src/pages/ChatSidebar.tsx, website/src/components/InstanceTabBar.tsx, website/src/surfaces/builtins.tsx, website/src/utils/previewFlags.ts.

Tests re-pinned to the restored wording: website/src/test/InstancesPanel.test.tsx, InstanceTabBar.test.tsx, InstancesViewport.test.tsx, InstancesViewport.winElectron.test.tsx, RemoteCrewPanel.test.tsx, RemoteCrewPanelSigninRecovery.test.tsx, SettingsRemoteCrewPanelCoverage.test.tsx, settingsLinkMigrations.test.tsx, EmbeddedSwitcher.test.tsx, App.mobileCrewSwitcher.test.tsx, plus website/src/pages/members/DeployMyCrew.test.tsx and FargateCrewView.test.tsx.

Harnesses and specs whose selectors and assertions track the restored strings: website/scripts/capture-deploy-my-crew.mjs, capture-browser-tabs-demo.mjs, capture-crew-pin-chips.mjs, capture-crew-chip-shrink.mjs, capture-crew-tab-stable-order.mjs, capture-chat-on-crew-toggle-move.mjs, record-crew-pin-chips.mjs, and website/playwright/settings.spec.ts. Five of these were already broken on this branch — they waited on [aria-label^="Switch instance"] while the catalog renders "Switch crew".

Docs and data: website/docs/extension-seams.md, website/docs/narrow-viewport.md, docs/build/desktop-app.md, docs/guides/README.md, docs/guides/remote-crew-on-ec2.md, docs/guides/cloud-instance-ssm-vs-ssh.md, docs/guides/adding-a-remote-provisioner.md, docs/system-specs/modules/platform-context.md, docs/feature-map/README.md, src/kiro_crew/data/tips_curated.json, and the test/gui_user catalog (features.json, features_catalog.py, scenarios.py, regenerated FEATURES.md) whose display label moved while its remote-instances slug stayed.

The revert also erased 99 real translations

Nine pages.settings.remoteCrewPanel.* keys (changed_outside_this_form, crews_you_can_switch_to, launch_done, new_cloud_crew, no_crews, remove_warning, sign_in_unconfirmed, use_my_edits_anyway, your_crews) were untranslated English placeholders before #6950. #6950 translated them. A faithful revert therefore restores the placeholders — 99 values across 11 locales that would have shipped in English inside otherwise-translated panels.

Those are restored to #6949-era translations with the instance-term swapped to each locale's crew term, rather than re-authored. This is a deliberate departure from a pure revert and the largest judgment call in the change. The [changed-passthrough] gate — zero tolerance — now reports 0 changed values still reading as English, which is the check that would have caught the regression had it shipped.

Per-locale renderings follow each catalog's own untouched precedent rather than the English: de Remote-Crew, es crew remoto (masc.), fr crew distante (fem.), it crew remota, pt crew remota, ru удалённая команда, ja リモートクルー, ko 원격 크루, zh-CN 远程 Crew, bn রিমোট ক্রু, hi रिमोट क्रू. Where the revert restored a split — fr used three renderings, ko three, ru two — the locale was normalized to one, and article, gender and case agreement moved with it.

Two fixes to pre-existing defects

launch_done_unsigned told users the crew "appears in Your instances" while the list it names is labelled your_crews — "Your crews". #6950 never touched that key, so neither the rename nor this revert fixed it; it has pointed at a non-existent list the whole time. All 12 locales now name their own label.

ru.transport_locked_note was the one value still carrying экипаж, the term the rest of the ru catalog abandoned. The English source is "matches this crew to its AWS resources", so the possessive points at the crew itself; moving the noun to feminine команда carries этот → эту and его → её. A Russian speaker should confirm that agreement.

Known residual splits, left alone

ru components.kiroPrerequisiteGate.your_crew_is_almost_ready still says Ваш экипаж; it is unchanged by this branch, belongs to a different component and is not a remote-crew string. pt/es/zh-CN disagree with other features' precedent for "crew" (Issue Radar uses equipo, 小队, and masculine crew in pt) — each catalog is internally consistent here, and picking one gender product-wide is a separate decision. de mixes Sie and du, ko still shows 원격 크루 above untouched 리모트 호스트 field labels, and bn/hi mix register in these panels. All predate this change. Three more surfaced while translating the row-entity keys and are also left alone: es disagrees with itself on the gender of "crew" (the row/list cluster is masculine el crew, the five identity* keys are feminine la crew); hi does the same (translated values treat क्रू as masculine, the values that leave the English token crew untranslated treat it as feminine); and every locale mixes the latin token crew with its localized form in auto_connect, identity, identity_center_hint, identity_choose and identity_region_hint. That last one is pre-#6950 text this revert restored faithfully rather than a defect it introduced — the same reason the two ru auto_connect values were fixed only once they appeared inside an evidence frame. Settling any of them means picking one gender or one rendering product-wide, which is a vocabulary decision rather than part of this revert.

Fixed after the UX lane's Watch item

UX caught a sentence this change had made self-contradictory. The remote-tab hint read "disconnect the instance in Settings → Remote Crew" — I renamed the panel inside that string and left the entity, so one sentence used both vocabularies while the tab above it says "Switch crew" and the destination panel lists "Your crews". Every remote-tab user would read a term the destination never uses for that thing. Fixed in all 12 locales, each keeping its own article, gender and case (ru accusative feminine команду, fr/it la crew, es masculine el crew), plus the test and the capture harness that pinned the old English.

While capturing the Russian spot-check UX asked for, the frame showed Автоподключение crew — latin "crew" sitting directly under the Удалённая команда heading. Pre-existing on main and not caused by this change, but it is the same incoherence inside the very screenshot this PR submits as evidence, so those two ru values now read команд / каждую команду … к ней like the rest of the panel.

UX's second pass found one more of the dangling-pointer class, and it was a genuine miss: pages.membersPage.deploy_state_gone said the machine "is no longer in your instances list" while the list it points at is labelled your_crews. launch_done_unsigned got that fix in the earlier round and this sibling did not, because my sweep matched the panel's name rather than the list it names. Fixed in all 12 locales, each referencing its own label exactly as launch_done already does (de „Deine Crews“, ja 「あなたのクルー」, ru в твоём списке команд keeping that value's own informal register), plus the two test assertions and three capture-harness assertions that pinned the old English. The harness was re-run against a fresh build, so the new sentence is a verified render rather than a string swap.

The row entity is a crew again, not an "instance"

UX's third pass named the real shape of that class: sign_in_unconfirmed said "then connect the crew" while its neighbours said "keep the instance" and "This instance exists" — one panel calling one row two things. The scope question is settled by the baseline rather than by taste: sign_in_unconfirmed is byte-identical to its pre-#6950 text, while 13 of its neighbours did not exist pre-#6950. They were authored during the three weeks "instance" was the shipped word, which makes them the same category as the residual keys already fixed here.

A sweep of all 43 bare-"instance" values split them: 17 postdate #6950, and 15 of those are remoteCrewPanel row-entity strings (the sign-in, cancel/remove and provisioner clusters) now reading "crew" in English and all 11 locales. The other 26 predate the rename and stay — including the whole apps.opsMissionControl.* namespace, where "this instance" means the gateway itself, and stamped_ec2_note, where "Its instance may still be running and billing" genuinely names the EC2 box.

Two tests asserted the opposite premise and had to be inverted rather than deleted: both a unit test and a capture harness required the Cancel label to not contain "crew", each with a comment explaining that "instance" was the word the panel headers used. Those comments now state the deliberate split — the row is a crew, instance is reserved for the machine — and the inverted assertion is mutation-verified (reverting the English to "instance" fails it).

Backend copy was in this class too: src/kiro_crew/cloud/launch_job.py hard-codes "Added to your instances.", rendered verbatim as a launch step's detail, so it pointed at the renamed list from Python where no catalog sweep could see it. Its siblings in that file ("Create the instance", "Could not reach the instance") name the machine and are unchanged. One curated tip was the same shape from a third direction: tips_curated.json's Remote Crew tip told users to "switch between instances from the header" while the control it names now reads "Switch crew". Its "route": "/settings/instances" deliberately stays — routes are on the stored side of the split.

Screenshots

Every frame below postdates the dist/ build that carries this change.

Settings, three renames in one frame: the nav item reads Remote Crew, the preview card reads Remote crew sessions, and the "Chat on a crew" description now points at "Settings > Remote Crew" — that last one is the cross-reference that used to send readers to a panel this change renames.

Settings → Developer showing the Remote Crew nav item, the Remote crew sessions preview card, and the Chat on a crew description pointing at Settings > Remote Crew

The dangling reference, fixed and rendered. This button read "Open Remote Instances in Settings" while the panel it opens is now "Remote Crew".

The cloud panel with no deploy, showing the action button reading Open Remote Crew in Settings

The scope boundary holding in the product: the list is Crews you can switch to, while the row below still says "Its instance may still be running and billing" for the EC2 box. Crew for the thing you talk to, instance for the machine.

The Remote Crew settings panel listing four crews under the heading Crews you can switch to, with EC2 and SSH type badges and a row menu open

The panel's empty state and its buttons, which UX listed as an uncovered surface — "No crews yet. Set one up, or add a machine you already have." above Add remote crew.

The Remote Crew panel with no crews configured, showing Your crews 0, the empty state No crews yet, and the Add remote crew form

One non-English locale — the spot-check UX asked for against the 99 re-authored translations. Russian renders the feature as Удалённая команда in the nav, the heading, the tab (Ваши команды), the list (Команды, на которые можно переключиться) and the button (Добавить удалённую команду): one term throughout, no экипаж. The row beneath still reads Его экземпляр может всё ещё работать for the EC2 machine, so the crew/instance split survives translation. The remaining English words here (Set up a new one, Disconnected, Added by you) are pre-existing untranslated passthrough that i18n:check counts at baseline, not values this PR touched.

The Remote Crew settings panel rendered in Russian, titled Удалённая команда, with Ваши команды and Добавить удалённую команду

The top-bar crew switcher, whose control carries the restored Switch crew label. Five committed capture harnesses were waiting on [aria-label^="Switch instance"] and were therefore already broken on this branch until this change fixed their selectors.

The top bar crew switcher menu open, listing Local plus four connected crews with pin controls

Verification

tsc -b clean, eslint clean, i18n:check all green under I18N_BASE_REF=origin/main (en-XA regenerated, 46 changed lines matching exactly its 36 + 10 English source lines), lint:i18n and i18n:render at baseline, phantom-classes clean, docs-lint passing, and the black / isort / flake8 / mypy (1680 files) / brand / comment-history / focus-cue / harness-parity / changelog-history / feature-map / loop-bound-locks / testpaths / vendor-manifest gates all pass diff-scoped.

Frontend: the full scoped set, 395 files and 9931 tests, all pass. That matters here: an earlier run of only the obviously-related files missed three that pin the renamed strings — previewSurfaces.test.tsx (the toggle's accessible name), ChatSidebar.instanceSessionsMerge.test.tsx (five checking remote instances regexes) and test_remote_instances_doc.py (the doc page's pinned label). All three were genuinely red and are fixed.

Backend scoped: 95 failures reduce to 1 caused by this change — the doc test above, now green. The remaining 94 were measured against a pristine worktree at the merge-base: 93 fail identically there (host-environmental — faiss, no Node ≥ 20, ssh -G, env --default-signal, process reaping, Windows path rules), and 1 (test_perf_sampler) is a load flake that passes 3/3 in isolation on both trees.

The two per-locale style gates were the last to go green. bn register (§5, no আপনি forms) and fr spacing (§1, U+202F before double punctuation) hold a branch responsible for every value it touches, and the restored translator text predates both guides — so 22 values were brought into line. Generated artifacts are idempotent: regenerating twice is byte-identical.

Rebasing onto a moving main surfaced a live conflict worth noting: #12603 landed a Fargate view whose test asserted the old string, so it was red against the restored catalog until fixed here, along with four new harness assertions it added.

Every value change was applied by script with an explicit per-locale map and a machine check that each term introduced is attested in translator-authored text in the same catalog — that check caught eight Korean values corrupted by hand-written escapes (원감 for 원격, 여기 for 열기).

Why this change exists

This is a maintainer decision, recorded here: the repo owner asked for the "Remote Instances" vocabulary to go back to "Crew". It is a relabel, not a defect fix, and I am not claiming a user report — there is none.

What it is grounded in is a concrete incoherence rather than symmetry with the past. Shipped main labels the feature "Remote Instances", while in-flight work on feat/remote-crew-rail presents the same objects as "crews" in the rail header, hover and switcher. Those two cannot both ship: whichever lands second makes the product say both words for one thing. This PR settles it in the direction the owner chose, which also happens to be the direction the rail already assumes.

The counter-argument deserves stating, because the First Principles lane is right that it exists: #6950 retired "Remote Crew" precisely so the label would match the code and config it sits on (/api/instances, instances.json, InstancesPanel), and that reason has not evaporated — this change reinstates a displayed/stored split. The judgment is that a displayed name should read for the person using it and a stored name for the person maintaining it, and that "Remote Crew" beside "Kiro Crew", "Crew Member" and "Issue Radar crew" is the coherent product vocabulary even though it diverges from the route names. remote-instances.md's glossary now carries both names so the split is documented rather than hidden. If you disagree with that premise, this PR is the wrong shape and the three pre-existing fixes (launch_done_unsigned, deploy_state_gone, the ru term) can be lifted out and shipped alone — say so and I will split them.

The UX lane raises the sharpest version of the objection: after this change "crew" names two different things — the machine you connect to, and the group of agents ("Crew Members"). That overload is real on main today. It is also being resolved from the other side: #11869 (chore/agents-vocabulary, open) renames Crew Members → Agents across the dashboard, which leaves "crew" meaning only the remote machine. The two PRs are complementary rather than competing, and whichever lands second ends the ambiguity. If #11869 is abandoned, the overload becomes permanent and UX's suggested mitigation — a one-line gloss where the two senses collide — is worth taking. I have deliberately not invented that gloss here: it would be new product copy in 12 locales for a naming problem whose better fix may be the other PR.

Reviewer note

Anyone who learned "Remote Instances" from the shipped docs sees the term change under them. That is the deliberate call this PR asks you to confirm.

No linked issue: this reverses a shipped rename at the maintainer's request rather than closing a tracked defect.

@kyleseaman
kyleseaman requested review from a team and dwu96 September 22, 2026 02:57
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — 🟡 CONCERNS

Design-level review of 2c2dd3631566a06050f618f5af5e5243372aa079 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

"Crew" now names both the remote machine and the agent group; disambiguation hangs entirely on the open, unmerged #11869.

Watch

  • The PR re-introduces the overload it admits ("after this change 'crew' names two different things") and deliberately ships no gloss, betting chore(i18n): rename Crew Members to Agents across the dashboard #11869 (Crew Members → Agents) lands. If that PR is abandoned, the ambiguity is permanent product copy in 12 locales with no tracked owner.
    Clears when: #11869 merges, or a tracked follow-up commits to the one-line gloss where the two senses collide.
  • ru.transport_locked_note's gender/case agreement (эту/её) is self-flagged as unconfirmed machine judgment across 99 re-authored translations.
    Clears when: a Russian speaker confirms the agreement, as the description requests.

[DESIGN-REVIEWED] 2c2dd36

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 2c2dd3631566a06050f618f5af5e5243372aa079 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 2c2dd36

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 2c2dd3631566a06050f618f5af5e5243372aa079: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — 🟡 CONCERNS

UX-level review of 2c2dd3631566a06050f618f5af5e5243372aa079 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

"Crew" now means two things — the agent team (shot-02, "your crew runs only on this computer") and a connected machine (shots 03–06) — and the blind reader couldn't connect them.

Watch

  • Vocabulary collision, re-introduced by this diff: base disambiguated machines as "instances"; restoring "crew" makes shot-01 show "Crew Members" (agents) beside "Remote crew sessions" (machines), and "Your crews" (machine tab) sits one letter from "your crew" (agents). Blind reader: "I could not have guessed those are the same word for both." Every remote-crew user, every surface, permanent until learned; friction, not task failure — and the PR's gloss lives in developer docs, not the UI.

Suggestions

  • Bridge the two senses where machines first appear: change settings.instances.description from "Manage remote crews over SSH tunnels…" to wording like "Run your crew on other machines and switch between them from the top header".
  • Same-panel, same-catalog leftovers the blind reader hit on the Russian page: set_up_a_new_one, up_to_warm, added_by_you are still English in ru — cheap to sweep alongside the 99 restored translations.

[UX-REVIEWED] 2c2dd36

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — 🟡 CONCERNS

Premise-level review of 2c2dd3631566a06050f618f5af5e5243372aa079 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The relabel's only ground is "restores the original vocabulary" — nobody is named as failed by "Remote Instances", and it reverses #6950's pinned rationale.

Not justified as shipped

  • Item 1 — unjustified move (inherited; item 9 merges here): the description's provenance is "this restores the original vocabulary across all 14 i18n catalogs" — precedent, not harm. No report, misclick or confused user is named for "Remote Instances", while the spec pin this diff rewrites recorded the opposite decision with its own reason: "that wording was retired in favour of 'instance' to match the code and config it already sits on (/api/instances, instances.json …)". The reversal is declared honestly, but no evidence the retirement was wrong is offered, and the displayed/stored split that pin existed to remove comes back for good ("crew" over instances.* keys, /settings/instances, the kept remote-instances.md URL); every existing user also relearns a memorised label a third time.
    Clears when: a linked issue/report naming who was failing under "Remote Instances", or a maintainer's recorded decision for this restore on the PR.

What this change ships

Inventory (10 items) — 8 justified

Intent: give the remote-gateway feature back its "Crew" name across UI, catalogs, docs and pins — a RELABEL (framed as a restore), not a fix or addition.

  1. Every surface naming the feature reads "Remote Crew"/"crew" again — settings tab, header switcher, preview card, cloud-launch copy, in all 14 catalogs — unjustified move (no named harm; provenance is precedent)
  2. Cross-references now name each locale's own panel label (nine keys outside refactor(i18n): rename remote-crew instance feature to 'Remote Instances' #6950's set) — justified
  3. Nine panel keys restored as translations, not pre-refactor(i18n): rename remote-crew instance feature to 'Remote Instances' #6950 English placeholders (99 values, passthrough-gated) — justified
  4. fr/ko/ru term splits normalized to one rendering per locale — justified
  5. launch_done_unsigned names the actual list label in all 12 locales — justified
  6. ru.transport_locked_note moved to the catalog's term with gender/case agreement — justified
  7. Saved developer.remote-instance-sessions highlight links still resolve, via the existing LEGACY_ID_EXACT map — justified
  8. Shipped doc retitled but keeps its remote-instances.md URL; rename deferred to docs: rename remote-instances.md to remote-crew.md with a redirect #12750 — justified
  9. The spec note recording why "Remote Crew" was retired now records the opposite direction — unjustified move (same root as item 1, merged there)
  10. Tests, Playwright and capture harnesses re-pinned to the restored strings (incl. flipping the "must not call the instance a crew" assertion, whose own premise flipped) — justified

[FIRST-PRINCIPLES-REVIEWED] 2c2dd36

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed 2c2dd3631566a06050f618f5af5e5243372aa079 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 2c2dd36

Verdict parsed from the review's SHA-scoped output markers for commit 2c2dd3631566a06050f618f5af5e5243372aa079.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 2c2dd3631566a06050f618f5af5e5243372aa079: <one-sentence reason>

@kyleseaman
kyleseaman force-pushed the chore/remote-crew-vocabulary branch from 6ef9895 to 708cf0b Compare September 22, 2026 03:11
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 22, 2026
@kyleseaman
kyleseaman force-pushed the chore/remote-crew-vocabulary branch 2 times, most recently from 1cc4090 to e2ed916 Compare September 22, 2026 03:31
@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ⚠️ review incomplete

GPT 5.6 did not produce a complete verdict for e2ed91617870d898dd96d7e77f7d951f85b5b8ea; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 5.6 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt e2ed91617870d898dd96d7e77f7d951f85b5b8ea: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 22, 2026
@kyleseaman
kyleseaman force-pushed the chore/remote-crew-vocabulary branch from e2ed916 to f1bc1ea Compare September 22, 2026 07:59
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 22, 2026
@kyleseaman

kyleseaman commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Design (Fable 5) — PASS, authorization item

Design returned PASS with no item sections, so this item carries no finding span. Answering without one rather than inventing an identity.

  • Authorization for the reversal — answered, and recorded here because it is genuinely not derivable from the diff. Design is right that the premise is unverifiable from the change itself. The reversal was requested explicitly by the repository owner (@kyleseaman, also this PR's actor), who asked for a PR renaming "Remote Instances" back to "Crew" after reviewing the scope. The concrete trigger was a live inconsistency rather than a taste preference: shipped main labels the feature "Remote Instances" while in-flight branch feat/remote-crew-rail presents the same objects as "crews", so the product was going to say both words and one side had to give. There is no linked user report and this PR does not claim one. If the owner's recorded request is not sufficient authorization for a product-wide relabel, that is a legitimate objection — but it is a decision for the owner, not something this PR can manufacture evidence for.

@kyleseaman

kyleseaman commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Design (Fable 5) — PASS, follow-up-filing suggestion

Design's suggestion section carries no finding span; answering without one.

  • Follow-up filed — docs: rename remote-instances.md to remote-crew.md with a redirect #12750. Design asked that the remote-instances.md rename be filed now so the documented displayed/stored split does not quietly become permanent. Done: docs: rename remote-instances.md to remote-crew.md with a redirect #12750 covers renaming the file to remote-crew.md with a redirect, updating index.md's link targets and the test_remote_instances_doc.py pin, and states explicitly which "instance" surfaces stay (backend keys and routes, instances.json, apps.mochi.instances.*, the filed Fargate RFC, the gui_user slug). Kept out of this PR deliberately: the filename is a published URL, and renaming it here would break existing links with no redirect in place.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Sep 22, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Sep 22, 2026
@kyleseaman

Copy link
Copy Markdown
Contributor Author

First Principles — Item 2, the re-authored naming note (span=6f66c85ed6e3)

  • accepted as stated — it is correctly classified as riding along, and it falls with item 1 rather than standing on its own (span=6f66c85ed6e3). The lane has this exactly right and there is nothing to rebut: the rewritten instances.md naming note does invert the pin that recorded the retirement, and it stands only if item 1 stands. I want to be precise about what it is, because "authored prose" could sound like something snuck in: the original pin said the feature was renamed away from "Remote Crew" and gave the reason; a literal term-swap would have produced a sentence claiming the opposite of what actually happened, which is why it was re-authored rather than swapped, and why the PR description flags it as one of two authored, not restored passages. The glossary in that same file now carries both names so a reader meets the split rather than a silent reversal. But the lane's structural point stands: this text asserts the premise under review. If @kyleseaman rejects item 1, this passage must be reverted with it — it is not separable, and I would not argue to keep it.

@kyleseaman

kyleseaman commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

UX — Watch, collision at first contact (span=76d8ef03a1f2)

  • escalated — the lane itself frames this as confirmation of a cost for the merging human to weigh, and its suggested softening is ready but deliberately not applied (span=76d8ef03a1f2). UX is explicit that this is "confirmation of its cost, not news", and I am recording it that way rather than dressing it up as resolved. The blind reader's words are the evidence that matters and they belong in front of whoever merges: "the word 'crew' seems to mean two different things… which I only worked out from context" — the agent group against a machine that is "a host with a port", with shot-02 putting both senses in one dialog. On the suggested softening: making deploy_action_deploy self-explaining ("Open Remote Crew settings to connect another machine") is a good idea, it is cheap, and it targets the collision at the point of contact rather than adding a gloss line. I have not applied it, for one reason I want on the record rather than hidden: it is one English string plus 12 machine-composed locale values, landing on the exact review surface the sibling item and the Design lane are asking a human to verify — and if @kyleseaman rejects the premise on the First Principles lane's item 1, the string is reverted along with everything else. It is a one-line change I will apply on request, and it is the first thing I would do if the premise is accepted. Related: docs/ui: disambiguate "crew" if the Crew Members → Agents rename does not land #12767 carries the fallback gloss if chore(i18n): rename Crew Members to Agents across the dashboard #11869 does not land.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Sep 22, 2026
dimwael pushed a commit to dimwael/KiroCrew that referenced this pull request Sep 22, 2026
The Remote Crew feature's page kept its remote-instances filename after
the kirodotdev#12697 vocabulary pass because the filename is a published URL.
Rename it to remote-crew.md and leave a stub at the old path so existing
links keep resolving.

There is no docs site generator in this repository — these pages ship
inside the Python package and are linked externally as GitHub blob URLs
— so no true redirect mechanism exists; the stub page is the fallback
the issue sanctions for that case.

Referring links in index.md and README.md now target remote-crew.md,
and test_remote_instances_doc.py moves to test_remote_crew_doc.py with
its pinned path updated. The test/gui_user scenario slug and backend
'instance' vocabulary are deliberately untouched.

Fixes kirodotdev#12750
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 22, 2026
PR #6950 renamed the remote-crew feature's user-visible text to "Remote
Instances" and #7378 swept the docs to match. This restores the original
"Crew" vocabulary across every catalog, the docs, and the tests and
harnesses that pin it.

Reverting #6950's key set alone would have been incomplete: nine strings
adopted "Remote Instances" in the three weeks after it merged and were
never in its key set. Four of those are cross-references that tell the
reader to open a panel this change renames, so they move too.

The word "instance" stays wherever it means a machine, an EC2 box, a
gateway process, or a code identifier -- backend keys and routes, the
`instances.json` registry, the Mochi multi-instance namespace, the
gui_user `remote-instances` slug, and the filed Fargate RFC. CHANGELOG
history is not rewritten.
@kyleseaman
kyleseaman force-pushed the chore/remote-crew-vocabulary branch from 8be8656 to 2c2dd36 Compare September 22, 2026 12:58
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Sep 22, 2026
@iamwhatever
iamwhatever merged commit 8b13cff into main Sep 22, 2026
93 checks passed
@iamwhatever
iamwhatever deleted the chore/remote-crew-vocabulary branch September 22, 2026 15:17
dimwael pushed a commit to dimwael/KiroCrew that referenced this pull request Sep 22, 2026
The Remote Crew feature's page kept its remote-instances filename after
the kirodotdev#12697 vocabulary pass because the filename is a published URL.
Rename it to remote-crew.md and leave a stub at the old path so existing
links keep resolving.

There is no docs site generator in this repository — these pages ship
inside the Python package and are linked externally as GitHub blob URLs
— so no true redirect mechanism exists; the stub page is the fallback
the issue sanctions for that case.

Referring links in index.md and README.md now target remote-crew.md,
and test_remote_instances_doc.py moves to test_remote_crew_doc.py with
its pinned path updated. The test/gui_user scenario slug and backend
'instance' vocabulary are deliberately untouched.

Fixes kirodotdev#12750
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 22, 2026
dimwael pushed a commit to dimwael/KiroCrew that referenced this pull request Sep 22, 2026
The Remote Crew feature's page kept its remote-instances filename after
the kirodotdev#12697 vocabulary pass because the filename is a published URL.
Rename it to remote-crew.md and leave a stub at the old path so existing
links keep resolving.

There is no docs site generator in this repository — these pages ship
inside the Python package and are linked externally as GitHub blob URLs
— so no true redirect mechanism exists; the stub page is the fallback
the issue sanctions for that case.

Referring links in index.md and README.md now target remote-crew.md,
and test_remote_instances_doc.py moves to test_remote_crew_doc.py with
its pinned path updated. The test/gui_user scenario slug and backend
'instance' vocabulary are deliberately untouched.

Fixes kirodotdev#12750
dimwael pushed a commit to dimwael/KiroCrew that referenced this pull request Sep 22, 2026
The Remote Crew feature's page kept its remote-instances filename after
the kirodotdev#12697 vocabulary pass because the filename is a published URL.
Rename it to remote-crew.md and leave a stub at the old path so existing
links keep resolving.

There is no docs site generator in this repository — these pages ship
inside the Python package and are linked externally as GitHub blob URLs
— so no true redirect mechanism exists; the stub page is the fallback
the issue sanctions for that case.

Referring links in index.md and README.md now target remote-crew.md,
and test_remote_instances_doc.py moves to test_remote_crew_doc.py with
its pinned path updated. The test/gui_user scenario slug and backend
'instance' vocabulary are deliberately untouched.

Fixes kirodotdev#12750
dimwael pushed a commit to dimwael/KiroCrew that referenced this pull request Sep 22, 2026
The Remote Crew feature's page kept its remote-instances filename after
the kirodotdev#12697 vocabulary pass because the filename is a published URL.
Rename it to remote-crew.md and leave a stub at the old path so existing
links keep resolving.

There is no docs site generator in this repository — these pages ship
inside the Python package and are linked externally as GitHub blob URLs
— so no true redirect mechanism exists; the stub page is the fallback
the issue sanctions for that case.

Referring links in index.md and README.md now target remote-crew.md,
and test_remote_instances_doc.py moves to test_remote_crew_doc.py with
its pinned path updated. The test/gui_user scenario slug and backend
'instance' vocabulary are deliberately untouched.

Fixes kirodotdev#12750
dimwael pushed a commit to dimwael/KiroCrew that referenced this pull request Sep 22, 2026
The Remote Crew feature's page kept its remote-instances filename after
the kirodotdev#12697 vocabulary pass because the filename is a published URL.
Rename it to remote-crew.md and leave a stub at the old path so existing
links keep resolving.

There is no docs site generator in this repository — these pages ship
inside the Python package and are linked externally as GitHub blob URLs
— so no true redirect mechanism exists; the stub page is the fallback
the issue sanctions for that case.

Referring links in index.md and README.md now target remote-crew.md,
and test_remote_instances_doc.py moves to test_remote_crew_doc.py with
its pinned path updated. The test/gui_user scenario slug and backend
'instance' vocabulary are deliberately untouched.

Fixes kirodotdev#12750
iamwhatever pushed a commit that referenced this pull request Sep 23, 2026
)

The Remote Crew feature's page kept its remote-instances filename after
the #12697 vocabulary pass because the filename is a published URL.
Rename it to remote-crew.md and leave a stub at the old path so existing
links keep resolving.

There is no docs site generator in this repository — these pages ship
inside the Python package and are linked externally as GitHub blob URLs
— so no true redirect mechanism exists; the stub page is the fallback
the issue sanctions for that case.

Referring links in index.md and README.md now target remote-crew.md,
and test_remote_instances_doc.py moves to test_remote_crew_doc.py with
its pinned path updated. The test/gui_user scenario slug and backend
'instance' vocabulary are deliberately untouched.

Fixes #12750

Co-authored-by: Wael Dimassi <ydimawae@amazon.com>
wknight1 pushed a commit to wknight1/KiroCrew that referenced this pull request Oct 5, 2026
…dev#12697)

PR kirodotdev#6950 renamed the remote-crew feature's user-visible text to "Remote
Instances" and kirodotdev#7378 swept the docs to match. This restores the original
"Crew" vocabulary across every catalog, the docs, and the tests and
harnesses that pin it.

Reverting kirodotdev#6950's key set alone would have been incomplete: nine strings
adopted "Remote Instances" in the three weeks after it merged and were
never in its key set. Four of those are cross-references that tell the
reader to open a panel this change renames, so they move too.

The word "instance" stays wherever it means a machine, an EC2 box, a
gateway process, or a code identifier -- backend keys and routes, the
`instances.json` registry, the Mochi multi-instance namespace, the
gui_user `remote-instances` slug, and the filed Fargate RFC. CHANGELOG
history is not rewritten.
wknight1 pushed a commit to wknight1/KiroCrew that referenced this pull request Oct 5, 2026
…odotdev#12752)

The Remote Crew feature's page kept its remote-instances filename after
the kirodotdev#12697 vocabulary pass because the filename is a published URL.
Rename it to remote-crew.md and leave a stub at the old path so existing
links keep resolving.

There is no docs site generator in this repository — these pages ship
inside the Python package and are linked externally as GitHub blob URLs
— so no true redirect mechanism exists; the stub page is the fallback
the issue sanctions for that case.

Referring links in index.md and README.md now target remote-crew.md,
and test_remote_instances_doc.py moves to test_remote_crew_doc.py with
its pinned path updated. The test/gui_user scenario slug and backend
'instance' vocabulary are deliberately untouched.

Fixes kirodotdev#12750

Co-authored-by: Wael Dimassi <ydimawae@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants