Skip to content

docs: add RFC for the Crewmates launch - #12813

Merged
CrysisDeu merged 1 commit into
mainfrom
docs/rfc-crewmates-launch
Sep 22, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
docs/rfc-crewmates-launch

Conversation

@CrysisDeu

Copy link
Copy Markdown
Contributor

Problem / Motivation

The CrewMates launch changes what a person sees: the "Agent Capabilities" page becomes Customize, the crewmate panel's "Crew summary" tab is replaced by Notes / Work log / Dashboard, a crewmate's chat shows only what it says to you, and crewmates can be grouped into teams. Nothing under docs/request-for-change/ records any of it. The First Principles lane has already blocked #12805 and #12806 for exactly that: "product-shape change without accepted RFC".

Why it matters

Every launch PR replaces or removes something a person can see today. Under the RFC README's status vocabulary, that kind of change must trace to an accepted document on the base branch. Without one, each of the eight launch PRs needs its own maintainer override, and the reasoning behind the launch lives only in a review nobody in the repository can read.

What changed (motivation → approach → change)

One new document, docs/request-for-change/rfc-crewmates-launch.md, status accepted, recording the product owner's review of 2026-09-22. It fixes the vocabulary (crewmate, custom agent, Built from, chat, thread, team, Customize; "agent" is no longer a top-level word), states the positioning line, and records screens 01 to 09 as decisions: the Customize page and its two tabs, the empty state and New crewmate dialog, the one-time opt-in for existing custom agents with the most recently used chat opening by default, the detail page as the one place to configure, the chat that shows only what the crewmate says with the bubble corner rule, the three-tab panel with Crew summary removed, reply threads, the four-step Meet CrewMates flow, and teams with the grouped roster and team view. It names what is out of scope, the acceptance conditions, the four open PRs and the five branches still to open.

The RFC index in docs/request-for-change/README.md gains the row and its audit sentence, both verified against 87553ba866.

Backwards compatibility

Compatible: documentation only; no code, route, key or string changes.

Tests

N/A — no code. scripts/docs-lint.sh passes (the new document is indexed and every link resolves).

Manual verification

scripts/docs-lint.sh, check_brand_name.py, check_changelog_history.py, check_comment_history.py and check_feature_map.py run locally against the merge base; all pass. Grepped the document for internal identifiers, hostnames and paths: none.

Related Issues

no linked issue: decision record for the CrewMates launch; the implementing PRs are #12797, #12798, #12805 and #12806.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@CrysisDeu
CrysisDeu requested review from a team and smeyffret September 22, 2026 13:19
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Intent: Put the CrewMates launch decisions (vocabulary, screens 01-09, out of scope) on main as an accepted RFC, so the launch PRs cite a recorded decision instead of proposing one.
Not a goal: No code, copy or behaviour change; no new decision beyond what the product owner review of 2026-09-22 settled; the PR-specific control removals the review did not rule on stay a maintainer call on their own PRs.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of e710d41bcb46379459f7ba1fbeb0f35ab64da102 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] e710d41

False positive or not applicable? A repository writer can comment:
/ai-review override gpt e710d41bcb46379459f7ba1fbeb0f35ab64da102: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed e710d41bcb46379459f7ba1fbeb0f35ab64da102 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] e710d41

Verdict parsed from the review's SHA-scoped output markers for commit e710d41bcb46379459f7ba1fbeb0f35ab64da102.

False positive or not applicable? A repository writer can comment:
/ai-review override fable e710d41bcb46379459f7ba1fbeb0f35ab64da102: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of e710d41bcb46379459f7ba1fbeb0f35ab64da102 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Merging is the acceptance act for all nine screens at once — the maintainer should consciously ratify the born-accepted status, not treat this as routine docs.

[DESIGN-REVIEWED] e710d41

@CrysisDeu
CrysisDeu force-pushed the docs/rfc-crewmates-launch branch from 2116aa5 to 8fcade9 Compare September 22, 2026 13:28
@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ⚠️ review incomplete

GPT 5.6 did not produce a complete verdict for 8fcade90438f04adf4a82fe8d878fbb25ce45c4c; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 5.6 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 8fcade90438f04adf4a82fe8d878fbb25ce45c4c: <one-sentence reason>

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ⚠️ review incomplete

GPT 5.6 did not produce a complete verdict for 8fcade90438f04adf4a82fe8d878fbb25ce45c4c; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 5.6 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 8fcade90438f04adf4a82fe8d878fbb25ce45c4c: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Sep 22, 2026
@CrysisDeu
CrysisDeu force-pushed the docs/rfc-crewmates-launch branch from 8fcade9 to ab14ad4 Compare September 22, 2026 16:16
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Inherited CI red on ab14ad4ef577ffe23005e77de6d1e2c3b1e1762c (docs-only diff)

Backend Tests (3.12, 1) and Backend Tests (Windows) (1) both fail on one test: test/test_mcp_debug.py::TestTheRouteAuthorizationMatrix::test_the_three_diag_routes_relay_501_until_diag_lands (AssertionError: api_debug_processes). Coverage Gate is red only because it requires those two jobs to succeed.

This PR changes two Markdown files under docs/request-for-change/ and touches neither the test nor kiro_crew.dashboard.handlers.debug. The test, added by #12731, pins api_debug_processes to answer 501 "until worker B lands"; #12745 then landed kiro_crew.diag.procs on main, so the handler now serves the real view and the pin fails on main itself. The fix belongs to that test on main, not here. Not chasing on this PR.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 22, 2026
@CrysisDeu
CrysisDeu force-pushed the docs/rfc-crewmates-launch branch from ab14ad4 to d4db7b5 Compare September 22, 2026 17:58
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 22, 2026
cixuuz
cixuuz previously approved these changes Sep 22, 2026

@cixuuz cixuuz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs-only RFC addition recording the CrewMates launch decisions that First Principles had already blocked #12805/#12806 for lacking. All review lanes clean; the previously-noted inherited CI red (test_mcp_debug.py pin, unrelated to this docs-only diff) is now green on main.

@CrysisDeu
CrysisDeu force-pushed the docs/rfc-crewmates-launch branch from d4db7b5 to e710d41 Compare September 22, 2026 21:10
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Sep 22, 2026
@CrysisDeu
CrysisDeu merged commit cc38521 into main Sep 22, 2026
92 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants