Skip to content

feat(onboarding): default to Kiro CLI, offer other coding agents - #13888

Merged
iamwhatever merged 1 commit into
mainfrom
feat/onboarding-other-agents
Oct 2, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
feat/onboarding-other-agents

Conversation

@kyleseaman

@kyleseaman kyleseaman commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Let a first-run operator start Kiro Crew with a usable coding harness without first installing or signing in to Kiro CLI, and let them change harness later without Developer Mode.

The first-run gate only knew Kiro CLI. Someone using Claude Code, Codex, or another selectable ACP harness was held at "Set up Kiro" even when that harness was ready. A new Kiro CLI user saw only a docs link instead of an install command. The only place to switch harness afterwards was Developer > Agent Backend, which is hidden unless Developer Mode is on.

Why it matters

Operators using another harness could not finish onboarding; Kiro CLI newcomers had to leave the page to find the right gateway-host command; and an operator who set up with Claude Code had no visible way to switch back to Kiro CLI or sign in to Kiro later.

Not a goal

  • Install or authenticate a harness from inside Kiro Crew.
  • Change chat, session, or history-rerun behaviour. Reruns keep main's readiness check; rerun support for non-Kiro harnesses is tracked in Restore safe history reruns for non-Kiro ACP harnesses #14512.
  • Change the host sandbox requirement shared by ACP harnesses.
  • Add a new harness or change the agent.acp_backend contract.

What changed (motivation → approach → change)

First-run gate. The gate shows the gateway OS, a Kiro CLI card with a copyable install or sign-in command and its own Check again, and a collapsed "Use other coding agents" picker for the selectable harnesses. The picker reads the same /api/acp-backends probes and writes the same agent.acp_backend setting as the Settings tab. A configured independent harness whose install is confirmed opens the dashboard without Kiro CLI; one whose install check failed keeps setup open, matching the gateway's setup-marker rule. The bypass requires what a session on that host requires: an OS sandbox, or unsandboxed execution permitted (the native-Windows default, or an operator opt-in); a harness that needs Kiro Crew's credential mask (for example Codex) stays blocked without the sandbox. A gateway that omits the new unsandboxed_exec_permitted field is read as not permitted. When the host has a sandbox but agent.sandbox turns it off, the agent's detail names that setting instead of blaming the host, and offers no Check again. The two badges differ: "Host can't sandbox" and "Sandbox turned off". The Update Kiro CLI button says it runs kiro-cli update on the gateway host (hidden for the desktop app's bundled CLI, which it cannot update). KAS stays subject to the Kiro CLI ACP compatibility check, which now runs whether or not Kiro CLI is signed in (KAS needs no Kiro CLI sign-in), and it also needs Kiro Crew's agent specs present and accepted: a missing or rejected spec keeps the repair card. The out-of-date card no longer claims the CLI is signed in. An unknown gateway OS gets platform-free copy (the old "local" filler is dropped). Probe failure keeps the Kiro setup fallback. If the screen's automatic setup record fails after the configured agent turns ready, the dashboard still opens and an error notice floats over it with Try again and a close button; it does not retry on its own. No install or sign-in command is executed by the dashboard.

Gateway, first-run only. /api/acp-backends rows carry an independent_setup flag from a fixed list of harnesses that can finish setup without Kiro CLI, and the prerequisite status reports whether the host sandbox can run them. Picking a ready independent harness, pressing Check again on it, or the screen's own poll seeing the configured harness turn ready (once), records setup as finished, and the status reports it immediately, so later browsers and non-owners get in without a restart. If recording fails after the setting is saved, the API returns a coded partial-success error with a retry. unsandboxed_exec_permitted is false when the governance floor (sandbox.min_level) mandates a sandbox, using the same floor check wrap_argv applies, so setup cannot finish onto sessions that are then refused. While Kiro CLI is signed out (KAS's normal state, and kiro-cli agent validate refuses to run signed out), Kiro Crew's agent specs are checked against KAS's own loading steps (load_agent_spec, then prompt resolution) instead; a spec KAS cannot load is reported as rejected, raises the repair card, and blocks the KAS setup record, which re-checks at record time. Because the probe does not know the configured backend, a signed-out user on Kiro CLI with such a spec also sees the repair card. None of this runs once setup is finished.

Settings > Agent Harness. The harness switch moves out of Developer > Agent Backend into an ordinary Settings tab (/settings/agent, under Preferences), laid out like the onboarding picker: one list of radio rows with the onboarding status badges and an "In use" marker, the checked row's detail opening under it, and Kiro sign-in only inside the KAS row. A checked row that is not the one in use says what its Use button does ("New sessions switch from Claude Code to codex."), and the restart-needed line uses the same sentence as first-run setup. Kiro CLI and KAS are listed for everyone. The rows, badges, detail block and copy box are shared components (website/src/components/agentHarness/) used by both screens. The radio is drawn by hand so an unchecked row reads as unchecked under a dark color-scheme. "Settings > Agent Harness" replaces "Developer > Agent Backend" in the setup text, the Overview signpost and the gateway's sign-in and sandbox messages, in all 12 locales.

Changed areas: src/kiro_crew/agent_sdk, src/kiro_crew/kiro_prerequisite.py, src/kiro_crew/dashboard, test, website/src/api, website/src/components, website/src/pages, website/src/hooks, website/src/i18n, website/src/test, website/scripts, website/capture, docs, and .github/screenshots/pr-13888.

Backwards compatibility

  • Developer > Agent Backend is removed. /developer?tab=agent-backend links, including the chat's "Sign in to Kiro" link, forward to Settings > Agent Harness and still land on the Kiro sign-in.
  • Nine catalog keys only the old tab used are removed from every locale.
  • No config key, API route or chat/session behaviour changes. The new independent_setup field and sandbox status fields are additive.

Tests

  • Review round on ad73f4b22e, after rebasing onto main 8ae5dff6ee: the KAS version re-check at setup record, the fresh probe in the Check again error response, the Agent Harness save-succeeded-but-record-failed state and the restored Change default crewmate highlight each have a test that fails with the fix removed. 553 backend tests (prerequisite status, config PATCH, error surface, backend cards) and 1,045 frontend tests (gate, Agent Harness, Settings, Developer, all of src/i18n with I18N_BASE_REF=origin/main) pass, with typecheck, eslint, black, flake8, the SDK-boundary gate and the comment-history gate.
  • Review round on 55ce021bc9: a KAS setup record that arrives before the boot probe has resolved a kiro-cli now runs the probe and requires the resolved binary to pass the acp --help check, and is refused when no kiro-cli resolves. The new tests fail with the fix removed; 278 prerequisite tests and 1,162 backend tests pass, with black, flake8, the SDK-boundary gate and the comment-history gate.
  • Review round on 6648366755: the governance-floor rule (20 cases, 12 fail without the fix), KAS spec loading while signed out (6 cases, 4 fail without the fix) and the setup-record failure notice (4 tests, all fail without it) are new. 396 backend tests (prerequisite status, error surface, editable config) with black and flake8, and 1,033 frontend tests (gate, Agent Harness, all of src/i18n with I18N_BASE_REF=origin/main, which is what caught the five locales using the formal register) with typecheck, i18n:check and eslint pass. The 22 backend modules importing kiro_prerequisite pass (1,824).
  • Full frontend suite: 41,333 tests pass. After the final rebase onto main, 38,485 tests across src/test, src/pages, src/components, src/hooks and src/i18n pass again.
  • New tests cover the Settings tab, the old-link forward (fails 2 tests when removed), the "In use" marker (fails 4 when removed), and the KAS sign-in deep link (fails 2 when removed).
  • 732 focused backend tests pass across config PATCH, the prerequisite status, backend cards, tool gate, host auth and KAS.
  • TypeScript typecheck, i18n:check, gen:settings (no drift), the web build, eslint on the touched files, and black pass.
  • Review round on 2e992f5ba0, after rebasing onto main f10a74d412: 3,673 frontend tests (gate, Agent Harness, Settings, Developer, Overview, i18n) and 2,130 backend tests (prerequisite status, config PATCH, backend install, tool gate, host auth, KAS, onboarding) pass, with typecheck, lint:i18n, i18n:check, gen:settings (no drift), black and flake8. The poll-driven setup record, the immediate status refresh, the native-Windows rule and the distinct sandbox badges each have a test that fails with the fix removed.
  • Review round on bde3aca46d: 1,017 focused frontend tests (gate, Agent Harness, Settings, i18n) and 472 backend tests (prerequisite status, backend cards, config PATCH) pass. The signed-out ACP probe, the KAS spec rule (client and marker), sandbox-off copy, the switch-outcome line, the shared restart line and the signed-out out-of-date copy each have a test that fails with the fix removed.

Manual verification

  • Ran this branch as a real preview gateway with no Kiro CLI on the path and Claude Code installed: selecting Claude Code on the setup screen opened the dashboard.
  • Rendered the gate and the Settings tab on a localhost Vite server with mocked gateway responses, captured them in headless Chromium with animations frozen, and inspected each image. The capture scripts are in the PR.

Screenshots / video

Settings > Agent Harness, Claude Code in use (light and dark):

Settings Agent Harness: radio rows with status badges, Claude Code checked and in use, detail open under its row with an Experimental tag

Settings Agent Harness in dark theme: unchecked radios render as hollow rings

More Agent Harness states

KAS checked, compact Kiro sign-in inside its detail

Codex checked and not installed, copyable install command, a line saying new sessions switch from Claude Code to codex, and Check again

Harness installed after gateway start, Check again to use it

The Overview page with KAS selected (cropped to the stat row and the signpost):

Overview with KAS selected: a one-line Kiro sign-in moved to Settings > Agent Harness signpost under the stat row

First-run setup, Kiro CLI missing and signed out:

Kiro CLI missing, install command and scoped re-check

Kiro CLI installed but signed out, sign-in commands and scoped re-check

First-run setup, other coding agents:

Claude Code installed and ready to use without Kiro CLI

Use other coding agents opened on a build that offers none: This build offers no other coding agents

Codex missing, install command

Claude Code installed after gateway start, restart remedy

More first-run states

Windows PowerShell installer

Native Windows without an OS sandbox: Claude Code is still usable because unsandboxed execution is the platform default

Unknown platform: intro and eyebrow name the gateway host, card shows both installers

Config-read error with Try again

Configured Codex blocked because the host has no sandbox: reason, doctor command, disabled Use, Check again, and Kiro fallback

Configured Codex blocked because agent.sandbox is off: Sandbox turned off badge, the setting named, no Check again

Kiro CLI too old for acp, signed out: update card without a sign-in claim

Claude Code install check failed: Use disabled until Check again confirms it; setup stays open

Other coding agents probe failure with Try again

Saving the Claude Code choice failed; the notice sits under that agent's Use button

Switching back to Kiro CLI failed; the notice sits under Use Kiro CLI instead

Claude Code recheck failure with one Check again action

The configured agent turned ready and the dashboard opened, but recording setup failed: a notice floats over the dashboard with Try again and a close button

Related Issues

no linked issue: first-run onboarding change requested directly by the maintainer.

History reruns for non-Kiro harnesses are out of scope here and tracked in Restore safe history reruns for non-Kiro ACP harnesses #14512.

Pattern harvest

Not generalizable: this first-run gate was written when Kiro CLI was the only selectable agent and assumed its readiness represented every harness.

Checklist

  • At most two commits, with Conventional Commits titles
  • Existing focused tests pass and regression tests cover new behavior
  • Self-review completed; code follows project style guidelines
  • Documentation updated
  • No secrets, credentials, or internal references in the diff

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 25, 2026
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of ae2a5149e8b034e7b9f0059a79fee15653b6be3c and found no blocking issues.

This comment is updated in place on each push.

Review details

FINDING -- src/kiro_crew/kiro_prerequisite.py:2979 -- "and not status.get(\"authenticated\")" skips the record-time KAS spec check when signed in, so a newly invalid spec can be marked setup-complete before the first KAS session is refused -> Fix: run _probe_kas_spec_loading() for every KAS setup-record attempt.
[GPT-REVIEWED] ae2a514

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ae2a5149e8b034e7b9f0059a79fee15653b6be3c: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of ae2a5149e8b034e7b9f0059a79fee15653b6be3c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify the six ACP_BACKENDS_INDEPENDENT_SETUP members (goose, pi, deepseek, opencode included) were each really exercised on a host, as the set's comment claims.

Suggestions

  • Expose one public sandbox helper for "unsandboxed exec permitted under the governance floor" and call it from both wrap_argv and _dashboard_snapshot, instead of composing sandbox._floor_mandates_sandbox(sandbox._governance_sandbox_floor()) from private helpers in kiro_prerequisite.py — one owner for the rule that keeps setup from completing onto refused sessions.
  • The admit/deny bypass predicate exists twice ("kept in lock-step": TS gate eligibility vs. record_independent_backend_setup); have the status payload carry a server-computed per-backend eligibility bit so the client renders a verdict rather than recomputing it.

[DESIGN-REVIEWED] ae2a514

Description read

[DESCRIPTION-READ] a3c50682bf8bdbf875a51a7d8845e053d5bfd6d0723e16be7db4ac02de1afeb4

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 25, 2026
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of ae2a5149e8b034e7b9f0059a79fee15653b6be3c — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Confirm maintainers intend the harness switch to shed its Developer-Mode-preview gating — kas-auth.md's deleted "KAS is a Developer Mode preview" pin recorded that hiding as deliberate.

The reversal is declared and carries in-diff cause (first-run now creates users with no Developer Mode path to the switch), so it is not a hidden pin deletion; it is still the one prior decision this PR overturns. Every new surface counted real consumers: independent_setup and the three sandbox status fields are read by KiroPrerequisiteGate.tsx and record_independent_backend_setup (grepped: 48 uses across 5 frontend files, 2 backend callers); the shared helpers (acpBackendName, setupMarkerErrorBody) each serve both screens. ACP_BACKENDS_INDEPENDENT_SETUP as a named positive set is mandated by the harness-parity invariant. The bypass rests on existing runtime verdicts (unsandboxed_exec_permitted_by, credential_mask_applies) rather than asserted platform claims, and fails closed on older gateways. Screenshots and PR-numbered capture scripts follow established convention (capture-9646-closeout.mjs, .github/screenshots/crew18688-*).

What this change ships

Inventory (10 items) — 10 justified

Intent: Let a first-run operator finish setup with a non-Kiro coding harness, and switch harness later without Developer Mode — an ADDITION.

  1. First-run gate adds a collapsed "Use other coding agents" picker beside the Kiro CLI card — justified
  2. Kiro CLI card now shows copyable install/sign-in commands instead of only a docs link — justified
  3. A configured, verified non-Kiro harness opens the dashboard without Kiro CLI, gated on sandbox facts, fail-closed — justified
  4. Setup completion is now recorded server-side, so later browsers and non-owners get in without a restart — justified
  5. Harness switch moved from Developer > Agent Backend to Settings > Agent Harness; old links redirect — justified
  6. Kiro sign-in moved inside the KAS row's detail; Overview signpost retargeted — justified
  7. KAS setup: ACP-support check runs signed out; specs checked via KAS's own loader (signed-out Kiro users with such a spec also see the repair card — declared) — justified
  8. New API surface: independent_setup flag, three sandbox status fields, coded setup_marker_write_failed 503 with retry — justified
  9. A failed setup-record after the agent turns ready floats an error notice with Try again over the open dashboard — justified
  10. Nine old-tab locale keys removed across 12 locales; screenshots and capture scripts added per repo convention — justified

[FIRST-PRINCIPLES-REVIEWED] ae2a514

Description read

[DESCRIPTION-READ] cee13aa95bcc1d1a5673bd2ebef195ed6224f2704af3c2e2e61c0e775197a98b

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — 🟡 CONCERNS

UX-level review of ae2a5149e8b034e7b9f0059a79fee15653b6be3c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

"Sandbox turned off" strands the user with no action or link, and "Agent Harness" is a label the setup errors point at but nobody can decode.

Watch

  • Dead end: sandbox_off_agent_detail says "turned off in {{productName}}'s settings (agent.sandbox). Turn it back on" but the row deliberately renders no Check again, no link, no command — blind reader (shot sandbox-off.png): "I have no button or link to the setting it blames — I would be stuck there." Rare state × stuck-at-the-gate impact × persists every visit. Smallest fix: one copyable command or one sentence saying where that setting is edited.
  • Vocabulary split: the gate says "coding agent" everywhere ("Use other coding agents", "Get a coding agent running"), then every remedy points to "Settings > Agent Harness" — reader: "a phrase I'd never guess the meaning of; I only learned it's a settings page because the errors kept pointing me there." Hits every user the gate redirects × navigation friction × every error message. Fix: use one term on both surfaces (e.g. tab label "Coding agent", keeping the existing description line).

Suggestions

  • agent_restart_required_detail ends "restart {{productName}} on that host" — reader: "I don't know how to restart it." In Settings the replaced string named the in-app route (Settings > About); restore a how (route or command) at least on the Settings surface.

[UX-REVIEWED] ae2a514

Description read

[DESCRIPTION-READ] ba38ede94b1096f6aff4e4855d284363ba14ad1132d6144cbed919b08765c785

That sha256 names everything this verdict read: the PR description, plus the 28 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 25, 2026
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed ae2a5149e8b034e7b9f0059a79fee15653b6be3c — this comment is updated in place on each push.

Review details

Two advisory findings; nothing blocks.

FINDING — website/src/pages/developer/AgentBackendTab.tsx:1440 — the badge is hardcoded blocked={false} and cannotUse checks only notInstalled || needsRestart, so with agent.sandbox in a mode where credential_mask_applies is false an enforced harness (e.g. codex) listed in sandbox_blocked_backends shows a green "Installed" badge and a live Use button, and every session after the switch dies in enforce_sandbox_floor with ToolGateUnroutable — while the first-run gate, using the same AgentStatusBadge, correctly withholds it → Fix: add a kiro-prerequisite query to this tab and thread sandbox_blocked_backends/sandboxOffFor into both AgentStatusBadge and cannotUse, as KiroPrerequisiteGate already does (gap inherited from the pre-existing Developer tab, so the remedy is new machinery rather than an in-hunk fix).

FINDING — test/gui_user/scenarios/auth-sign-in-card-signed-out.yaml:26 — the scenario's route and first step were moved to Settings › Agent Harness but step 2 still says Scroll down past the backend switch until you find a card titled "Kiro sign-in", and the card now mounts only inside the checked row's detail (value === KIRO_SIGN_IN_BACKEND && offered.includes(...)) while shown falls back to the active backend '' on a seeded target, so the card never renders and all three expectations fail → Fix: insert a step checking the Kiro (KAS) row before the scroll step.

[OPUS-REVIEWED] ae2a514

Verdict parsed from the review's SHA-scoped output markers for commit ae2a5149e8b034e7b9f0059a79fee15653b6be3c.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ae2a5149e8b034e7b9f0059a79fee15653b6be3c: <one-sentence reason>

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 25, 2026
@kyleseaman
kyleseaman force-pushed the feat/onboarding-other-agents branch 2 times, most recently from a8f3158 to 012a256 Compare September 25, 2026 21:38
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 25, 2026
@kyleseaman
kyleseaman marked this pull request as ready for review September 27, 2026 02:10
@kyleseaman
kyleseaman requested review from a team September 27, 2026 02:10
@kyleseaman
kyleseaman force-pushed the feat/onboarding-other-agents branch from 5b320f0 to 613a892 Compare September 27, 2026 18:29
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 27, 2026
@kyleseaman
kyleseaman force-pushed the feat/onboarding-other-agents branch 3 times, most recently from 78db12e to 4526169 Compare September 27, 2026 18:48
@kyleseaman
kyleseaman force-pushed the feat/onboarding-other-agents branch from 4526169 to 6b03e2d Compare September 27, 2026 18:59
@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • accepted-and-deferred — span=def997a88a56: Non-Kiro history reruns remain disabled because the current path persists truncated history before authentication can fail. The restriction is exposed by history_rerun_supported, while ordinary sends and SDK completions work. Issue #14512 owns the recoverable rerun design and tests, with an assignee and due date. This PR keeps the pre-mutation safety guard.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • accepted-and-deferred — span=7be34a0e8d64: The probe-level missing/restart/selectability reading can be shared, while onboarding's host sandbox and independent-setup checks remain specific to the first-run gate. Issue #14517 tracks the extraction and cross-surface tests with an assignee and due date.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • rebutted — span=e2bbb8dea1db: The Electron identity-inventory change is a test-only synchronization with the gateway supervisor's current API. The branch's rebase exposed a failing test already present on main; leaving it unchanged would keep this PR's shell gate red independent of onboarding. It adds no runtime behavior to the feature, and extracting a separate PR would make this branch depend on that PR landing first.

@kyleseaman
kyleseaman force-pushed the feat/onboarding-other-agents branch 3 times, most recently from 1c5ced7 to b4d76c5 Compare September 27, 2026 19:58
@kyleseaman

Copy link
Copy Markdown
Contributor Author

@iamwhatever Could you review this onboarding flow when you have a chance? It defaults to Kiro CLI while allowing other ACP coding agents, with probe/recheck and sandbox handling. I have addressed the latest automated review findings and CI is running on the current head. Thanks!

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • rebutted — span=497901dde49a: The maintainer chose the tab name "Agent Harness" deliberately, replacing an earlier "Coding Agent" label in this same PR. The label is the product vocabulary for this surface; the rows under it still say "coding agent" in their prose. A rename, if wanted later, is a single catalog key plus the three pointer strings.

@kyleseaman

kyleseaman commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor Author
  • accepted-and-deferred — span=2e044890af77: A server-owned per-row "can finish setup" verdict would replace the mirrored client rule, and is the right long-term shape. This PR keeps the two copies in lock-step with tests on both sides (gate predicate and record_independent_backend_setup, including the KAS and sandbox branches), and the gate now persists the marker through the same recheck POST, so a divergence surfaces as a refused recheck rather than a silent lockout. Issue #14517 tracks sharing the probe reading between onboarding and Settings; I added this suggestion there so the extraction can move the composed verdict to the gateway instead of keeping a client copy.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • rebutted — span=d17fa8c026d2: The function-local imports follow each file's existing convention on main (for example acp_backend_status.py already imports kiro_crew.agent_sdk and handlers.core inside its handlers, and kiro_prerequisite.py imports kiro_crew.agent locally for a documented circular import). The new ones sit beside those and avoid pulling the agent SDK and config loader into the prerequisite service at import time. Moving them is an unrelated refactor.

The first-run setup gate checked Kiro CLI alone, so an operator configured
for another ACP harness (Claude Code, Codex, ...) with no Kiro CLI was held
on "Set up Kiro" indefinitely.

- Kiro CLI stays the default and its card is the only Kiro step: it states
  where things stand, shows the one-line installer for the gateway's
  platform (copy-only; Kiro Crew still runs nothing), swaps in the two
  sign-in commands once installed but signed out, and carries its own
  Check again. The separate Sign in to Kiro card and the page footer are
  gone.
- A collapsed "Use other coding agents" section, modelled on Developer >
  Agent Backend, lists the selectable third-party harnesses with their
  install state. The picked agent's panel opens under its own row: install
  command, sign-in note, Use, and Check again (none for a ready agent).
  Use writes agent.acp_backend.
- The gate reads the configured backend once Kiro is not ready: a usable
  non-Kiro backend opens the dashboard; one that is not ready keeps setup up
  with the section open and a way back to Kiro CLI.
- The intro no longer calls Kiro CLI the engine and is one translatable
  sentence rendered with <Trans>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants