Repository navigation
Conversation
Design Review (Fable 5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS No recorded maintainer decision backs superseding the RFC's first-run flow and Crewmates landing — the description itself defers that call to a maintainer. Watch
[DESIGN-REVIEWED] 8bfbeda Description read[DESCRIPTION-READ] 0b0137666cc792085dcd503e9dcdac637fec0a2eb3f77e1f5f15524a11f1a5a8 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK Product-shape change without accepted RFC: every install now gets Captain and lands in its chat, and the Meet CrewMates chapter no longer opens on its own. Not justified as shipped
What this change shipsInventory (8 items) — 5 justifiedIntent: let anyone ask a built-in assistant to find, point at, and (after one confirmation) apply Kiro Crew changes. ADDITION.
Blockers
[FIRST-PRINCIPLES-REVIEWED] 1567f43 Description read[DESCRIPTION-READ] 0d4bd2c00fc8f093684a1341800264c9ee38637be17bfef3d32a18f69f12dc93 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Fable 5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS Draft-vs-suggestion ambiguity, a self-contradicting empty roster, and a stale settings highlight each left the blind reader unable to tell what state they were in. Watch
Suggestions
[UX-REVIEWED] 8bfbeda Description read[DESCRIPTION-READ] c138055888daaafd3a0c65e6c8e999eb8c6d65df67c4b4a0daaaec555236d806 That sha256 names everything this verdict read: the PR description, plus the 25 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
|
First-open Assistant welcome, desktop and mobile. These captures use the real production SPA with synthetic API fixtures; they are layout evidence, not live-agent verification. The welcome UI matches published head 42111fa. The local two-ghost redesign previews have been withdrawn. The author requested preserving the original onboarding composition. No redesign commit was pushed. |
0ff7ab8 to
37f99ac
Compare
|
span=00f168ba45d8
Disposition: needs-a-decision
|
|
span=61b329078faa
Disposition: needs-a-decision
|
|
span=9e80944c85d8
Disposition: needs-a-decision
|
|
span=5a348f0f44b5
Disposition: needs-a-decision
|
|
span=1966778e66f9
Disposition: needs-a-decision
|
|
span=229dea81cf85
Disposition: needs-a-decision
|
37f99ac to
abb5250
Compare
|
span=2f6082500a24
Disposition: fixed
|
|
span=975deb4da91b
Disposition: rebutted
|
|
span=de5ca72c07d2
Disposition: rebutted
|
|
span=408c1f389f9a
Disposition: rebutted
|
|
span=9c48c46c4d79
Disposition: rebutted
|
|
/ai-review override first-principles f86ca3c: maintainer decision — every install gets a built-in personal Assistant member, the Crewmates page lands on the Assistant chat, Meet CrewMates opens only on an explicit create action, and the four-field New crewmate dialog moves behind Advanced; this supersedes rfc-crewmates-launch §02 and the §08 2026-09-28 amendment |
Human judgment recorded@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
Opus 5 findings on
Not changed: Frontend Tests (1)/(2) on |
|
Fixed in
Frontend Tests ( |
|
Fixed in
Frontend Tests ( |
|
/ai-review override first-principles b23b629: maintainer decision — every install gets a built-in personal Assistant member, the Crewmates page lands on the Assistant chat, Meet CrewMates opens only on an explicit create action, and the four-field New crewmate dialog moves behind Advanced; this supersedes rfc-crewmates-launch §02 and the §08 2026-09-28 amendment |
Human judgment recorded@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
GPT 5.6 F1 ( Confirmed in source: Fix: Test: |
|
/ai-review override first-principles 5497406: maintainer decision — every install gets a built-in personal Assistant member, the Crewmates page lands on the Assistant chat, Meet CrewMates opens only on an explicit create action, and the four-field New crewmate dialog moves behind Advanced; this supersedes rfc-crewmates-launch §02 and the §08 2026-09-28 amendment |
Human judgment recorded@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
GPT 5.6 F1 ( Confirmed in source: Fix: Test: This push also rebases onto main (the PR was conflicting): |
|
GPT 5.6 F1 ( Confirmed in source: Fix: one predicate, Test: |
|
The Goal, Why it matters and Not a goal sections were rewritten at the PR owner's explicit request, to match the PR's current scope: the built-in assistant is now Captain, with |
|
PR triage (automated, evidence-based) — head 1. Name collision with #16376 (open PR) — needs a merge discussion. Both PRs reserve the same agent/template id
If both land, whichever installer runs second either refuses the other's file (this PR's marker check) or overwrites it. Worse, this PR's Captain is a person-opened crew member on the 2. Rebase needed. 3. Security blocker already raised, so no separate review. The forged No merged PR on main implements this feature, and no other open PR duplicates it. |
|
Scope update, requested by @buluoray (the PR owner): the Goal, Why it matters and Not a goal sections were rewritten because the scope was widened on request, not by an agent on its own. What was added beyond the earlier revision:
Head is now 5da66ff on origin/main 3343351. Screenshots and a short video are in the description. |
Captain is a built-in crewmate that answers how-to and where-is questions, points at the page with a guide, and prepares Kiro Crew changes the user confirms with one press instead of hand-editing settings. - Captain agent template, private memory identity and read-only access to the user's Global preferences; first-open greeting turn. - kirocrew-guide MCP: find_ui (packaged dashboard location index), search_docs, guide actions, settings diagnosis, and propose_change / get_change_status for change cards (settings, schedules, crewmates, tools, MCP servers, connections, secrets, app trust, denied rules). - Change-card store and routes: the gateway owns the plan, risk and status; apply and undo replay it through existing routes. One-shot reminders resolve their run time server-side. - Guide runs: one tab claims a guide, progress and finish reasons go to the crew log. - Docs: MCP architecture, crew-log session types, crew mode, feature map.
The dashboard renders Captain's proposals as change cards in the conversation, runs on-page guides, and keeps crewmate creation inside the Crewmates page. - Change cards: one card from proposal to its result line; reminder cards say "Set reminder", count down to the run time and retire the button the moment that time passes instead of failing on press. - Guide layer: arrow and panel on the target control, cross-tab claim, recovery after navigation, leave guards. - Crewmates page: Captain conversation, guided creation flow with receipts and Advanced form, phone roster view. - uiLocations descriptors and the generator for the find_ui index; strings in all 12 locales.
Sensitive Change ReviewSensitive files changed:
A human reviewer with write access must approve the CURRENT head and |
| raise GuideCatalogError( | ||
| "invalid_text", f"{field_name}: no links; the guide points at the dashboard itself" | ||
| ) | ||
| if any(ch in text for ch in _GUIDE_TEXT_MARKUP) or _GUIDE_TEXT_MD_LINK_RE.search(text): |
|
Closing in favour of #18301. After the team review, the guides and change cards became a platform capability that every crewmate and dashboard session gets, instead of belonging to one built-in assistant. #18301 carries that platform half (tracked in #18300), including the review fixes from this PR's rounds. The first-crewmate welcome will follow as a separate PR stacked on #18301. |


Problem / Motivation
Goal: Give every user a built-in assistant, Captain, that finds things in Kiro Crew, walks them to the exact control on the live page, and makes the changes they ask for after a single confirmation, so nobody has to learn the dashboard first.
New users land in a dashboard full of pages and settings they have not seen, and the answer to "where is X?" or "turn on Y" is a search through Settings or the docs. Creating a crewmate opens a technical dialog. There is no one in the product a person can simply ask, and nothing that can make a setting, schedule or crewmate change for them while keeping them in control. A static map of locations is also not enough: the control a person needs is often behind a collapsed sidebar, a closed menu, an unselected item or an off switch, and is placed differently on a phone.
Why it matters
The first minutes decide whether someone keeps using Kiro Crew. A newcomer who can ask in their own words, see the exact control highlighted on the screen in front of them, and confirm a prepared change with one press gets real work done on day one, and learns the product by using it. Existing users get the same help for the long tail of settings without reading docs.
Not a goal
defaultmember, its template or its conversations.What changed (motivation → approach → change)
Approach: one built-in crewmate with a narrow, approval-free toolset that can only READ or PROPOSE. Everything that changes state is a card the user presses; the gateway, not the model, owns what the card does. Pointing at the UI uses the live page, not a remembered map.
kirocrew-captain): installed once, protected from delete and re-keying, private memory, a read-only view of the user's Global preferences. First open of the dashboard lands in Captain's conversation. Its pre-tool narration is folded into the turn's activity row, so a turn shows one answer.kirocrew-guideMCP:find_ui,search_docs,find_setting,diagnose_settings, guide actions andpropose_change/get_change_status. Labels come back in the dashboard's own language (the tab sends it with each chat request), so Captain quotes what the screen shows.Product direction was agreed with the maintainer in the design discussion; no accepted RFC is claimed, so the First Principles lane may need a maintainer decision.
Backwards compatibility
Compatible: the
defaultmember, its template and conversations are untouched; Captain is an added member and every change it makes goes through routes that already exist. Existing create/update/delete routes refuse only the reservedkirocrew-captainkey and Captain's display name, which no existing member can hold. The first-run landing moves from the plain chat to Captain only when Captain exists.Removes nothing: no route, key, file or capability is taken away; the new refusals apply only to the new reserved Captain identity.
Tests
test_crew_log_writer.pyappear only under xdist and the file passes alone.gen:ui --check, docs-lint, production build.Manual verification
Several rounds of new-user QA in isolated pods built from this branch (desktop 1280×800 and phone 390×844, English and 中文 UI): "where is my chat history" / 会话历史在哪里, adding an MCP server, editing a crewmate's tools, the Developer Mode setting, a reminder card proposed, set and undone, first-run Skip all landing in Captain. Each issue found was fixed and re-checked in a fresh pod.
Screenshots / video
A new question gets one answer with the guide card in the same reply:
The guide panel sits beside its target, with Captain's own note under the step:
A reminder card, then the same card after Set reminder:
The whole guide flow:
09-guide-flow.webm
More
First open lands in Captain:
First-run Skip all lands in Captain's conversation:
Editing a crewmate's tools: confirm the selected crewmate, then the panel beside Permissions:
A setting guide highlights the switch on its settings page:
A setting Captain cannot change gets a path instead of a card:
中文 UI: labels match the screen:
Phone (390×844):
Related Issues
Follows #15097 (goal-focused crewmate onboarding).
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement