Repository navigation
fix(website): repair hover policy and SessionActionsMenu tests after #14807 - #16223
Conversation
|
note: the full website vitest run on this head, with a fresh |
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
|
note: #16210 and #16227 fix the same main breakage. All three relabel the duplicate test to "Fork chat". They differ on the hover policy. #16210 and #16227 delete the WelcomeView DECORATIVE entry. This PR keeps it and teaches the scan bracketed and stacked variant prefixes ( I won't push again over either of them. If one merges first, I'll rebase this PR down to whatever is left (the scan prefixes and the glyph) or close it as superseded. |
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
1 similar comment
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (5 items) — 5 justifiedIntent: make the touch sidebar menu's "Fork chat" icon match the sidebar fork button, and bring a hover site behind a custom breakpoint back into the touch-reachability test. FIX.
[FIRST-PRINCIPLES-REVIEWED] 207512a Description read[DESCRIPTION-READ] 9a94f4aee588bb1377afe8d33bb6d821988760c730c774114345980dab0a678c That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 207512a Description read[DESCRIPTION-READ] 9e4e94829487f404ed2ab764e25c4196ee00238a85096eab42cbbcb056fb6b83 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS No first-time reader has checked that the GitFork glyph next to "Fork chat" reads as "fork"; both screenshots show it, but this lane has no blind read. Watch
[UX-REVIEWED] 207512a Description read[DESCRIPTION-READ] e8dffd1f6a8910cada3d75eef9179d8730991c075839db496339614f3d6b504f That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
79aa1ac to
600bd7c
Compare
|
Rebased onto main after #16227 landed (79aa1ac -> 600bd7c). Conflicts in the two test files were resolved by keeping this PR's version: same "Fork chat" labels as #16227, plus the widened REVEAL/HIDDEN prefixes so the WelcomeView hover site stays in the scan instead of dropping out. Both tests pass locally (41/41). |
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
1 similar comment
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
…irodotdev#14807 hover-policy scan did not parse, so the site left the scan and its DECORATIVE entry matched nothing. Accept arbitrary and stacked variant prefixes and point the entry at the new snippet. GitFork glyph; the session menu item kirodotdev#14807 added still used Copy and its test looked for "Duplicate". Use GitFork and test for "Fork chat".
600bd7c to
207512a
Compare
|
Rebased onto main ( |
Problem / Motivation
Goal: The touch sidebar menu's "Fork chat" item shows the same fork glyph as the sidebar button, and the hover-policy test keeps scanning hover sites that sit behind custom breakpoints.
Two things were left behind after #14807, #15820 and #16101 crossed on main:
Copyglyph, while the sidebar's own fork button usesGitFork(fix(sidebar): name the session-row fork action "Fork chat" #16101).hoverVariantPolicy.test.tsonly read one plain-word variant prefix (sm:,md:). fix(chat): keep floating composer chrome off the transcript and hero #15820 moved the WelcomeView suggestion unclamp behind[@media(min-width:640px)_and_(min-height:600px)]:, so that hover site dropped out of the scan. test(website): update two frontend tests left red on main #16227 then deleted its DECORATIVE entry to get main green, which leaves the site unchecked.Why it matters
A touch user sees two different icons for one action. And any hover-only reveal moved behind an arbitrary-value breakpoint silently escapes the touch-reachability check, so a control that touch users cannot reach could land without the test noticing.
Not a goal
What changed (motivation → approach → change)
Copy→SessionActionsMenu.tsxnow rendersGitFork, and its doc comment says "Fork chat".REVEALaccepted one plain-word prefix andHIDDENnone in brackets →REVEALnow accepts stacked prefixes including bracketed arbitrary values, andHIDDENaccepts one bracketed prefix. The WelcomeView DECORATIVE entry is back, naming the new snippet.SessionActionsMenu.duplicate.test.tsxnow describes the "Fork chat" item; its assertions already matched main after test(website): update two frontend tests left red on main #16227.Backwards compatibility
Compatible: no API, config or stored data changes; one icon swap and test-only edits.
Removes nothing: the diff only swaps an icon and widens a test's matcher.
Tests
hoverVariantPolicy.test.ts: the widened matcher puts the WelcomeView site back in the scan. Deleting its DECORATIVE entry makes the offender check fail oncomponents/WelcomeView.tsx:130.SessionActionsMenu.duplicate.test.tsx: the menu renders "Fork chat" when the row passes a handler, and no item otherwise.Manual verification
Opened the touch sidebar row's ⋯ menu in the built SPA (Playwright, touch context, stubbed API) in dark and light. A script asserted the "Fork chat" item renders the
lucide-git-forkglyph in both.Screenshots / video
Touch sidebar row ⋯ menu, "Fork chat" with the
GitForkglyph:Related Issues
Closes #16575
Follows #14807, #15820, #16101 and #16227. Supersedes the scan part of #16210 (closed).
Pattern harvest
Rule candidate: review-prompt
Pattern: a source-scanning test regex that cannot parse a new syntax silently drops the site instead of failing.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)