Skip to content

fix(website): repair hover policy and SessionActionsMenu tests after #14807 - #16223

Merged
bolichen97 merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/hover-policy-after-14807
Oct 4, 2026
Merged

bolichen97 merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/hover-policy-after-14807

Conversation

@Pearcekieser

@Pearcekieser Pearcekieser commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The touch sidebar menu's "Fork chat" item shows the same fork glyph as the sidebar button, and the hover-policy test keeps scanning hover sites that sit behind custom breakpoints.

Two things were left behind after #14807, #15820 and #16101 crossed on main:

Why it matters

A touch user sees two different icons for one action. And any hover-only reveal moved behind an arbitrary-value breakpoint silently escapes the touch-reachability check, so a control that touch users cannot reach could land without the test noticing.

Not a goal

  • Changing the "Fork chat" label or any other menu item.
  • Changing the WelcomeView hover behaviour itself.
  • Reworking the rest of the hover-policy scan.

What changed (motivation → approach → change)

  • Glyph: symptom is a mismatched icon → the menu item still imported Copy → SessionActionsMenu.tsx now renders GitFork, and its doc comment says "Fork chat".
  • Scan: symptom is a hover site missing from the scan → REVEAL accepted one plain-word prefix and HIDDEN none in brackets → REVEAL now accepts stacked prefixes including bracketed arbitrary values, and HIDDEN accepts one bracketed prefix. The WelcomeView DECORATIVE entry is back, naming the new snippet.
  • Test naming: SessionActionsMenu.duplicate.test.tsx now describes the "Fork chat" item; its assertions already matched main after test(website): update two frontend tests left red on main #16227.

Backwards compatibility

Compatible: no API, config or stored data changes; one icon swap and test-only edits.

Removes nothing: the diff only swaps an icon and widens a test's matcher.

Tests

  • hoverVariantPolicy.test.ts: the widened matcher puts the WelcomeView site back in the scan. Deleting its DECORATIVE entry makes the offender check fail on components/WelcomeView.tsx:130.
  • SessionActionsMenu.duplicate.test.tsx: the menu renders "Fork chat" when the row passes a handler, and no item otherwise.
  • Both files pass locally on the rebased head (41/41).

Manual verification

Opened the touch sidebar row's ⋯ menu in the built SPA (Playwright, touch context, stubbed API) in dark and light. A script asserted the "Fork chat" item renders the lucide-git-fork glyph in both.

Screenshots / video

Touch sidebar row ⋯ menu, "Fork chat" with the GitFork glyph:

Fork chat menu item, dark

Fork chat menu item, light

Related Issues

Closes #16575

Follows #14807, #15820, #16101 and #16227. Supersedes the scan part of #16210 (closed).

Pattern harvest

Rule candidate: review-prompt
Pattern: a source-scanning test regex that cannot parse a new syntax silently drops the site instead of failing.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@Pearcekieser
Pearcekieser requested a review from a team October 2, 2026 18:16
@Pearcekieser
Pearcekieser requested a review from a team as a code owner October 2, 2026 18:16
@Pearcekieser
Pearcekieser requested a review from CrysisDeu October 2, 2026 18:16
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Oct 2, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: the full website vitest run on this head, with a fresh npm ci, finished green: 2,583 files passed, and 43,562 tests passed with 1 expected fail and 2 skipped (exit 0). This completes the Testing section above.

@dwu96

dwu96 commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note: #16210 and #16227 fix the same main breakage. All three relabel the duplicate test to "Fork chat". They differ on the hover policy. #16210 and #16227 delete the WelcomeView DECORATIVE entry. This PR keeps it and teaches the scan bracketed and stacked variant prefixes ([@media(...)]:group-hover:). With that, the site #15820 moved behind a custom breakpoint is scanned again instead of dropping out unseen. This PR also gives the session menu's fork item the GitFork glyph #16101 gave the sidebar button.

I won't push again over either of them. If one merges first, I'll rebase this PR down to whatever is left (the scan prefixes and the glyph) or close it as superseded.

@dwu96

dwu96 commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

1 similar comment
@dwu96

dwu96 commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@dwu96

dwu96 commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 207512ac5198d4146f98e00943d7c058d15ae189 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 207512a

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of 207512ac5198d4146f98e00943d7c058d15ae189 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (5 items) — 5 justified

Intent: make the touch sidebar menu's "Fork chat" icon match the sidebar fork button, and bring a hover site behind a custom breakpoint back into the touch-reachability test. FIX.

  1. On touch screens, the ⋯ menu's "Fork chat" item shows the fork icon instead of the copy icon — justified
  2. The hover-policy test now sees reveal variants behind stacked or bracketed breakpoint prefixes — justified
  3. The hover-policy test now sees hidden resting states behind one bracketed breakpoint prefix — justified
  4. The WelcomeView suggestion-unclamp site is back in the decorative allow-list — justified
  5. The menu prop's doc comment and the test suite are renamed from "Duplicate" to "Fork chat" — justified

[FIRST-PRINCIPLES-REVIEWED] 207512a

Description read

[DESCRIPTION-READ] 9a94f4aee588bb1377afe8d33bb6d821988760c730c774114345980dab0a678c

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 207512ac5198d4146f98e00943d7c058d15ae189 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 207512a

Description read

[DESCRIPTION-READ] 9e4e94829487f404ed2ab764e25c4196ee00238a85096eab42cbbcb056fb6b83

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — 🟡 CONCERNS

UX-level review of 207512ac5198d4146f98e00943d7c058d15ae189 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

No first-time reader has checked that the GitFork glyph next to "Fork chat" reads as "fork"; both screenshots show it, but this lane has no blind read.

Watch

  • The only change a user sees is the Copy → GitFork icon on the touch ⋯ menu's "Fork chat" item. attachment-01 (dark) and attachment-02 (light) both show it rendering, aligned with its sibling items. Because no first-time reader has looked at it, this review can only rate it CONCERNS. The new icon now matches the sidebar's own fork button and no longer looks like "Copy link" a few rows below, so the risk is low. A maintainer can get the blind read by pushing the branch to this repository.

[UX-REVIEWED] 207512a

Description read

[DESCRIPTION-READ] e8dffd1f6a8910cada3d75eef9179d8730991c075839db496339614f3d6b504f

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 207512ac5198d4146f98e00943d7c058d15ae189 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 207512a

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 2, 2026
@iamwhatever
iamwhatever force-pushed the fix/hover-policy-after-14807 branch from 79aa1ac to 600bd7c Compare October 2, 2026 23:32
@iamwhatever

Copy link
Copy Markdown
Contributor

Rebased onto main after #16227 landed (79aa1ac -> 600bd7c). Conflicts in the two test files were resolved by keeping this PR's version: same "Fork chat" labels as #16227, plus the widened REVEAL/HIDDEN prefixes so the WelcomeView hover site stays in the scan instead of dropping out. Both tests pass locally (41/41).

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 2, 2026
@dwu96

dwu96 commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

1 similar comment
@dwu96

dwu96 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated.

Missing sections:

  • ## Problem / Motivation
  • ## Why it matters
  • ## What changed
  • ## Tests

Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle.

@bolichen97

Copy link
Copy Markdown
Contributor

Heads-up: #16227 has merged and repairs the same two tests on main, so this PR now overlaps it. Thanks for the fix. Your SessionActionsMenu.tsx change is the only part #16227 does not carry; if it is still wanted, a rebase onto main keeping just that change would make it easy to review.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 3, 2026
…irodotdev#14807

hover-policy scan did not parse, so the site left the scan and its
DECORATIVE entry matched nothing. Accept arbitrary and stacked variant
prefixes and point the entry at the new snippet.

GitFork glyph; the session menu item kirodotdev#14807 added still used Copy and its
test looked for "Duplicate". Use GitFork and test for "Fork chat".
@iamwhatever
iamwhatever force-pushed the fix/hover-policy-after-14807 branch from 600bd7c to 207512a Compare October 3, 2026 17:46
@iamwhatever

Copy link
Copy Markdown
Contributor

Rebased onto main (ff007b88b8) so PR Hygiene reads the updated description; no code change. CI re-running.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 3, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 3, 2026
@bolichen97
bolichen97 merged commit c315c25 into kirodotdev:main Oct 4, 2026
109 of 110 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Touch Fork chat menu item uses the wrong glyph; hover policy scan misses arbitrary-value breakpoints

4 participants