Repository navigation
revert: back out crew mode toggle (#16088) - #16257
Conversation
UX Review (Fable 5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. [UX-REVIEWED] 9ec43cc Description read[DESCRIPTION-READ] f6a5dc24c327ea0651347853bc0b133ca32326bdbb0cc2d8e198398a931ce380 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Confirm [DESIGN-REVIEWED] 9ec43cc Description read[DESCRIPTION-READ] 7d7fe5e8d5c008f03b23be5915117f39adf2015a12e4f1d160b06ceb949c1210 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
92b2189 to
7a58ce1
Compare
First Principles Review (Fable 5) — ✅ human override accepted@bolichen97 overrode this lane for |
PR #16088 was merged into main before the owner meant to land it. This reverts merge commit e53499f so main no longer carries the crew mode toggle; everything else that landed on main since stays intact. The feature itself is not lost: it stays on feat/conductor-mode-toggle (restored at b4551ba, the PR head) and will come back to main through a fresh PR when it is ready. This reverts commit e53499f.
Opus 5 Review — ✅ no blocking findingsReviewed Review detailsNothing blocks; one advisory — the conductor's shipped system prompt still names the dashboard switch this revert removes. FINDING — src/kiro_crew/agent.py:3951 — the "Talking to the person" section added by #16088 and kept here still tells every [OPUS-REVIEWED] 9ec43cc Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
7a58ce1 to
9ec43cc
Compare
|
Round-2 dispositions, applied in 9ec43cc:
|
|
Round 3 on 9ec43cc: GPT 5.6 cleared (no findings), Screenshot Evidence, Brand Name Gate, Decision Ledger Gate and Build Windows Installer (x64) are green. Three reds remain, none from this diff:
|
|
/ai-review override first-principles 9ec43cc: owner backed the Crew Mode toggle out of main until he lands it himself; the feature stays on feat/conductor-mode-toggle |
Human judgment recorded@bolichen97 marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Human judgment recorded@bolichen97 marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for |
A Crew Mode chip right of "Choose memory mode" switches a plain chat to the existing kirocrew-conductor through the ordinary agent switch, and back again. An empty chat with it on shows the Crew Mode welcome page. The switch is not offered when the conductor itself is the default agent, since off would have nothing to switch back to. There is no new setting, route, config key or session field. Re-lands the switch backed out in #16257 on the current page owners. Co-authored-by: Bolin Chen <17506219+bolichen97@users.noreply.github.com>
A Crew Mode chip right of "Choose memory mode" switches a plain chat to the existing kirocrew-conductor through the ordinary agent switch, and back again. An empty chat with it on shows the Crew Mode welcome page. The switch is not offered when the conductor itself is the default agent, since off would have nothing to switch back to. There is no new setting, route, config key or session field. Re-lands the switch backed out in #16257 on the current page owners. Co-authored-by: Bolin Chen <17506219+bolichen97@users.noreply.github.com>
A Crew Mode chip right of "Choose memory mode" switches a plain chat to the existing kirocrew-conductor through the ordinary agent switch, and back again. An empty chat with it on shows the Crew Mode welcome page. The switch is not offered when the conductor itself is the default agent, since off would have nothing to switch back to. There is no new setting, route, config key or session field. Re-lands the switch backed out in #16257 on the current page owners. Co-authored-by: Bolin Chen <17506219+bolichen97@users.noreply.github.com>
A Crew Mode chip right of "Choose memory mode" switches a plain chat to the existing kirocrew-conductor through the ordinary agent switch, and back again. An empty chat with it on shows the Crew Mode welcome page. The switch is not offered when the conductor itself is the default agent, since off would have nothing to switch back to. There is no new setting, route, config key or session field. Re-lands the switch backed out in #16257 on the current page owners. Co-authored-by: Bolin Chen <17506219+bolichen97@users.noreply.github.com>
A Crew Mode chip right of "Choose memory mode" switches a plain chat to
the existing kirocrew-conductor through the ordinary agent switch, and
back again. Turning it on in a root session opens the side panel
Dashboard view, whose Overview is that session's own Dynamic Dashboard.
Turning it off leaves the side panel and the page alone. A dispatched or
adopted session switches without opening it.
On the server, the switch to the conductor template on a root session
adopts the shipped goal-board on that session's page with the ordinary
instance.adopt, only while nothing is adopted there yet, and tells an
open Overview to re-read. Each dashboard turn of a root session with an
adopted page carries its own [DASHBOARD] block (the crewmate block keyed
by the session's store key), so the conductor's existing rule skips its
inline task board.
The empty-chat welcome page keeps its title, tagline, four capability
lines and ghost art, and drops the sample board: one line and an "Open
task board" button point at the side panel instead.
The chip keeps one accessible name ("Crew Mode") with aria-pressed
carrying on and off, stays focusable while a reply runs, and its busy
and on hints show as a visible line it names with aria-describedby.
The client root test (isRootSession) is the side panel's existing one,
moved into command-center/model.ts so the panel and the switch share it.
There is no new setting, route, agent, template or session field.
Re-lands the switch backed out in #16257 on the current page owners.
Co-authored-by: zejiangg <zejiangg@amazon.com>
Co-authored-by: Joe Guo <12429733+iamwhatever@users.noreply.github.com>
A Crew Mode chip right of "Choose memory mode" switches a plain chat to
the existing kirocrew-conductor through the ordinary agent switch, and
back again. Turning it on in a root session opens the side panel
Dashboard view, whose Overview is that session's own Dynamic Dashboard.
Turning it off leaves the side panel and the page alone. A dispatched or
adopted session switches without opening it.
On the server, the switch to the conductor template on a root session
adopts the shipped goal-board on that session's page with the ordinary
instance.adopt, only while nothing is adopted there yet, and tells an
open Overview to re-read. Each dashboard turn of a root session with an
adopted page carries its own [DASHBOARD] block (the crewmate block keyed
by the session's store key), so the conductor's existing rule skips its
inline task board.
The empty-chat welcome page keeps its title, tagline, four capability
lines and ghost art, and drops the sample board: one line and an "Open
task board" button point at the side panel instead.
The chip keeps one accessible name ("Crew Mode") with aria-pressed
carrying on and off, stays focusable while a reply runs, and its busy
and on hints show as a visible line it names with aria-describedby.
The client root test (isRootSession) is the side panel's existing one,
moved into command-center/model.ts so the panel and the switch share it.
There is no new setting, route, agent, template or session field.
Re-lands the switch backed out in #16257 on the current page owners.
Co-authored-by: zejiangg <zejiangg@amazon.com>
Co-authored-by: Joe Guo <12429733+iamwhatever@users.noreply.github.com>
A Crew Mode chip right of "Choose memory mode" switches a plain chat to
the existing kirocrew-conductor through the ordinary agent switch, and
back again. Turning it on in a root session opens the side panel
Dashboard view, whose Overview is that session's own Dynamic Dashboard.
Turning it off leaves the side panel and the page alone. A dispatched or
adopted session switches without opening it.
On the server, the switch to the conductor template on a root session
adopts the shipped goal-board on that session's page with the ordinary
instance.adopt, only while nothing is adopted there yet, and tells an
open Overview to re-read. Each dashboard turn of a root session with an
adopted page carries its own [DASHBOARD] block (the crewmate block keyed
by the session's store key), so the conductor's existing rule skips its
inline task board.
The empty-chat welcome page keeps its title, tagline, four capability
lines and ghost art, and drops the sample board: one line and an "Open
task board" button point at the side panel instead.
The chip keeps one accessible name ("Crew Mode") with aria-pressed
carrying on and off, stays focusable while a reply runs, and its busy
and on hints show as a visible line it names with aria-describedby.
The client root test (isRootSession) is the side panel's existing one,
moved into command-center/model.ts so the panel and the switch share it.
There is no new setting, route, agent, template or session field.
Re-lands the switch backed out in #16257 on the current page owners.
Co-authored-by: zejiangg <zejiangg@amazon.com>
Co-authored-by: Joe Guo <12429733+iamwhatever@users.noreply.github.com>
A Crew Mode chip right of "Choose memory mode" switches a plain chat to
the existing kirocrew-conductor through the ordinary agent switch, and
back again. Turning it on in a root session opens the side panel
Dashboard view, whose Overview is that session's own Dynamic Dashboard.
Turning it off leaves the side panel and the page alone. A dispatched or
adopted session switches without opening it.
On the server, the switch to the conductor template on a root session
adopts the shipped goal-board on that session's page with the ordinary
instance.adopt, only while nothing is adopted there yet, and tells an
open Overview to re-read. Each dashboard turn of a root session with an
adopted page carries its own [DASHBOARD] block (the crewmate block keyed
by the session's store key), so the conductor's existing rule skips its
inline task board.
The empty-chat welcome page keeps its title, tagline, four capability
lines and ghost art, and drops the sample board: one line and an "Open
task board" button point at the side panel instead.
The chip keeps one accessible name ("Crew Mode") with aria-pressed
carrying on and off, stays focusable while a reply runs, and its busy
and on hints show as a visible line it names with aria-describedby.
The client root test (isRootSession) is the side panel's existing one,
moved into command-center/model.ts so the panel and the switch share it.
There is no new setting, route, agent, template or session field.
Re-lands the switch backed out in #16257 on the current page owners.
Co-authored-by: zejiangg <zejiangg@amazon.com>
Co-authored-by: Joe Guo <12429733+iamwhatever@users.noreply.github.com>
A Crew Mode chip right of "Choose memory mode" switches a plain chat to
the existing kirocrew-conductor through the ordinary agent switch, and
back again. Turning it on in a root session opens the side panel
Dashboard view, whose Overview is that session's own Dynamic Dashboard.
Turning it off leaves the side panel and the page alone. A dispatched or
adopted session switches without opening it.
On the server, the switch to the conductor template on a root session
adopts the shipped goal-board on that session's page with the ordinary
instance.adopt, only while nothing is adopted there yet, and tells an
open Overview to re-read. Each dashboard turn of a root session with an
adopted page carries its own [DASHBOARD] block (the crewmate block keyed
by the session's store key), so the conductor's existing rule skips its
inline task board.
The empty-chat welcome page keeps its title, tagline, four capability
lines and ghost art, and drops the sample board: one line and an "Open
task board" button point at the side panel instead.
The chip keeps one accessible name ("Crew Mode") with aria-pressed
carrying on and off, stays focusable while a reply runs, and its busy
and on hints show as a visible line it names with aria-describedby.
The client root test (isRootSession) is the side panel's existing one,
moved into command-center/model.ts so the panel and the switch share it.
There is no new setting, route, agent, template or session field.
Re-lands the switch backed out in #16257 on the current page owners.
Co-authored-by: zejiangg <zejiangg@amazon.com>
Co-authored-by: Joe Guo <12429733+iamwhatever@users.noreply.github.com>
A Crew Mode chip right of "Choose memory mode" switches a plain chat to
the existing kirocrew-conductor through the ordinary agent switch, and
back again. Turning it on in a root session opens the side panel
Dashboard view, whose Overview is that session's own Dynamic Dashboard.
Turning it off leaves the side panel and the page alone. A dispatched or
adopted session switches without opening it.
On the server, the switch to the conductor template on a root session
adopts the shipped goal-board on that session's page with the ordinary
instance.adopt, only while nothing is adopted there yet, and tells an
open Overview to re-read. Each dashboard turn of a root session with an
adopted page carries its own [DASHBOARD] block (the crewmate block keyed
by the session's store key), so the conductor's existing rule skips its
inline task board.
The empty-chat welcome page keeps its title, tagline, four capability
lines and ghost art, and drops the sample board: one line and an "Open
task board" button point at the side panel instead.
The chip keeps one accessible name ("Crew Mode") with aria-pressed
carrying on and off, stays focusable while a reply runs, and its busy
and on hints show as a visible line it names with aria-describedby.
The client root test (isRootSession) is the side panel's existing one,
moved into command-center/model.ts so the panel and the switch share it.
There is no new setting, route, agent, template or session field.
Re-lands the switch backed out in #16257 on the current page owners.
Co-authored-by: zejiangg <zejiangg@amazon.com>
Co-authored-by: Joe Guo <12429733+iamwhatever@users.noreply.github.com>
A Crew Mode chip right of "Choose memory mode" switches a plain chat to
the existing kirocrew-conductor through the ordinary agent switch, and
back again. Turning it on in a root session opens the side panel
Dashboard view, whose Overview is that session's own Dynamic Dashboard.
Turning it off leaves the side panel and the page alone. A dispatched or
adopted session switches without opening it.
On the server, the switch to the conductor template on a root session
adopts the shipped goal-board on that session's page with the ordinary
instance.adopt, only while nothing is adopted there yet, and tells an
open Overview to re-read. Each dashboard turn of a root session with an
adopted page carries its own [DASHBOARD] block (the crewmate block keyed
by the session's store key), so the conductor's existing rule skips its
inline task board.
The empty-chat welcome page keeps its title, tagline, four capability
lines and ghost art, and drops the sample board: one line and an "Open
task board" button point at the side panel instead.
The chip keeps one accessible name ("Crew Mode") with aria-pressed
carrying on and off, stays focusable while a reply runs, and its busy
and on hints show as a visible line it names with aria-describedby.
The client root test (isRootSession) is the side panel's existing one,
moved into command-center/model.ts so the panel and the switch share it.
There is no new setting, route, agent, template or session field.
Re-lands the switch backed out in #16257 on the current page owners.
Co-authored-by: zejiangg <zejiangg@amazon.com>
Co-authored-by: Joe Guo <12429733+iamwhatever@users.noreply.github.com>
Problem / Motivation
Goal: Take the Crew Mode toggle back out of main so main is exactly what it was before #16088 landed, while the feature keeps living on its own branch.
PR #16088 ("feat: add crew mode toggle to chat sessions") was meant to stay on the dedicated branch
feat/conductor-mode-toggleuntil the owner chose to land it. It was approved and merged into main (merge commite53499fe4221df65eb847e2dbb1f010e8f7d706b) before that point, so main now ships a composer chip, a welcome page, adashboard.default_crew_modesetting, 27 i18n keys in 12 catalogs, a conductor prompt section and a decision entry the owner had not yet signed off for release.Why it matters
Anyone building from main today gets a user-visible feature (and a persisted setting) that is still being decided on. If it stays, the next release carries it, the i18n catalogs and the settings registry freeze around it, and taking it out later means a real removal with migration work instead of a clean revert while nothing downstream depends on it yet.
Not a goal
feat/conductor-mode-togglewhen the owner is ready.git revert -m 1of the one merge commit; the 22 files other PRs changed in the meantime keep those changes.What changed (motivation → approach → change)
Symptom: main carries #16088 ahead of the owner's decision. Cause: the PR was approved and merged by another maintainer while it was meant to stay parked on its branch. Change: one commit,
git revert -m 1 e53499fe4221df65eb847e2dbb1f010e8f7d706b, which applied cleanly with no conflicts, plus three deliberate departures from a byte-exact revert, each forced by a gate or a recorded decision (all caught by CI rounds 1 and 2):docs/decisions/2026-10-02-conductor-introduces-itself-in-every-chat.mdand its row indocs/decisions/README.mdstay. The decision ledger is append-only (decisions/README.mdrule 2, enforced by the Decision Ledger Gate): an entry is never deleted, and an agent may not write a superseding one. The decision Bolin recorded there still stands, and it binds every Conductor chat, not only Crew Mode chats.kirocrew-conductorprompt insrc/kiro_crew/agent.pystays, byte-identical to what feat: add crew mode toggle to chat sessions #16088 merged, together with the two spec-digest pins that lock it in (test/test_agent_refactor_contracts.py,test/test_agent_refactor_spec_bytes.py). The section's one mention of the Crew Mode switch is an example of who may be reading, not a dependency on it; it is left as the maintainer approved it so the pins stay unchanged. Main therefore keeps doing what the decision entry says. (The first head of this PR deleted the section; the GPT and First Principles lanes both blocked onrecorded-decisions-are-not-regressions, correctly.)docs/system-specs/modules/learn-cron-dashboard.md("KiroCrew logo" -> "Kiro Crew logo") is kept, because reverting it re-adds a misspelling the Brand Name Gate rejects.Net: 42 files, 22 insertions, 1229 deletions, the mirror of the merge minus those three items.
What goes away, all of it added by #16088:
DashboardConfig.default_crew_modeand its loader line; thedefault_crew_moderead/validate/echo branches inapi_dashboard_config; thechat.turn-on-crew-mode-for-new-sessions-by-defaultrow insettings-registry.generated.json. The conductor prompt section stays (see above).CrewModeChip,CrewModeWelcome,lib/crewMode.ts, the chip and welcome wiring inChatPage.tsx, thenewChatAgenthook-ins inchat-sidebar/create.ts,shellKeyboard.ts,paletteActions.ts,actionsProvider.ts, the Settings → Chat → Sessions row inChatPanel.tsx, the generatedsettingsRegistry.gen.tsentry, theglossary.jsonterm and the 27 keys in every locale catalog includingen-XA.docs/feature-map/README.md, and the paragraphs added tosession.md,learn-cron-dashboard.md,config.md,crew-mode.md,agents.md,work-ledger.md. The decision entry stays (see above).Nothing left on main references the removed code: a grep for
crewMode,CrewMode,crew_mode,default_crew_mode,CREW_MODEacrosssrc/andwebsite/src/(locales included) returns nothing; the only remaining mention ofconductor-introducesunderdocs/is the kept decision entry and its README row. The pre-existingcrew-mode.mdspec and its "Retired: Crew Mode" references are about the older retired slot mode and are untouched by both the merge and this revert.The feature branch was restored first:
feat/conductor-mode-toggleis back on this repository at the PR's head,b4551ba8b95bba0633db210a27dc758fdfbff9d1, with no PR open from it.Backwards compatibility
Breaking: the optional
dashboard.default_crew_modesetting, on main for a few hours, is removed again. Writer sweep on origin/main @af162847d6: the only writers were the Settings → Chat → Sessions switch (ChatPanel.tsx) andapi_dashboard_configitself, both removed here; nothing else on main, in cron, subagent, app or release code, writes it.Reader: src/kiro_crew/config/loader.py:_build_dashboard_config -- chat -- a
default_crew_modevalue a user already saved inconfig.yamlis kept as an unknown in-section key and ignored, the same path every unmodelled key takes; nothing loads as an error.Reader: src/kiro_crew/dashboard/handlers/files.py:api_dashboard_config -- chat -- a stale, not-yet-reloaded dashboard tab that still PUTs
default_crew_modegets the existingUnknown fields400 and nothing is written; a reload clears it.test/test_dashboard_files_coverage.pykeeps pinning theUnknown fields400.Reader: website/src/pages/chat-sidebar/create.ts:createSlot -- chat -- new chats start on the default agent again, exactly as before the merge;
ChatPage.memoryChip.test.tsxis restored to its pre-merge assertion.Tests
No tests are added; the ones #16088 added go away with the code they covered:
test/test_crew_mode.py(deleted) covered the setting default, PUT/GET round-trip and the prompt section.test/test_agent_refactor_spec_bytes.pyandtest/test_agent_refactor_contracts.pykeep the digests and prompt fingerprint feat: add crew mode toggle to chat sessions #16088 pinned forkirocrew-conductor/kirocrew-ledger-conductor, which lock in that the kept prompt section is byte-for-byte what the maintainer approved (74 tests, pass locally).website/src/lib/crewMode.test.ts,CrewModeChip.test.tsx,ChatPage.crewMode.test.tsx(deleted);ChatPage.memoryChip.test.tsxback to asserting the chip row leaves once the session has messages.Local gate on this worktree:
scripts/check_black_formatting.py(pinned black, fresh cache) pass,check_subprocess_encoding.pypass,isort --check-onlypass,flake8clean,mypy --platform linux src/kiro_crewclean (2062 files),scripts/docs_lint.pypass,check_decisions_history.pyandcheck_brand_name.pyagainstorigin/mainpass,cd website && npm run buildpass;scripts/local-gate.pyandnpm run testresults are posted in a PR comment as they finish.Manual verification
N/A — this is a mechanical revert of one merge commit with no conflicts; the identifier grep above and the spec-byte pins are the check that nothing dangles.
Screenshots / video
Why no screenshot: the diff removes the Crew Mode chip, welcome page and settings row, taking the chat composer and Settings → Chat → Sessions back to exactly the surfaces main rendered before #16088; there is no new rendered state to show.
Related Issues
Reverts #16088. The feature continues on
feat/conductor-mode-toggle.Pattern harvest
Not generalizable: a process slip, a parked PR got approved and merged by a second maintainer; the fix is the merge-hold convention on the PR, not a code rule.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement