Skip to content

fix(autonudge): resume a paused goal loop from its cycle count - #16353

Merged
iamwhatever merged 1 commit into
mainfrom
fix/autonudge-resume-from-breakpoint
Oct 3, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
fix/autonudge-resume-from-breakpoint

Conversation

@pepmach

@pepmach pepmach commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Resume a manually paused goal loop from the cycle it stopped at, instead of restarting its cycle count and clock.

Since #16030, pressing Play on a paused goal loop resets its cycle count and runtime clock, so a loop paused at cycle 7 of 24 comes back as cycle 1 of 24 and the popover reads "Goal active (cycle 1)". That reset was meant for a loop that ran out of budget, where Play would otherwise be a dead press. For a loop a person paused, it throws away where the loop was. This PR keeps the reset for the cycle-limit and time-limit endings only, and resumes every other paused loop from its breakpoint.

Why it matters

Max cycles is a lifetime limit a person typed. A pause should not quietly turn it into a fresh allowance, and the cycle readout after Play should match what actually ran.

Not a goal

  • Changing how a loop ends, or the fresh-budget resume for a loop whose cycle cap or time limit was reached.
  • Any change to the Pause, Lightning and Play controls or the Clear link.
  • The Done state for a finished loop (separate PR in flight).

What changed (motivation → approach → change)

Symptom: Play on a loop paused by hand at cycle 7 of 24 revived it at cycle 1 of 24. Root cause: the dashboard PATCH /api/autonudge/{loop_id} route (src/kiro_crew/dashboard/handlers/autonudge.py) passes fresh_run=True on every press, and _update_unserialized in src/kiro_crew/autonudge_service/mutations.py applied cycle_count = 0 and created_ts = time.time() on any revival carrying that flag. The reset exists for a spent bound, where Play would otherwise be re-stopped on its first tick; a pause with allowance left spent nothing.

Change: src/kiro_crew/autonudge_service/model.py names the two budget endings as CYCLE_CAP_REASON and RUNTIME_BUDGET_REASON (together _BUDGET_EXHAUSTED_REASONS, from which _TERMINAL_BOUND_REASONS is built) and adds two type-safe predicates, cap_reached and budget_elapsed, the timer's two pre-fire checks read through _positive_number because the store is agent-writable. The revival branch in mutations.py now resets each counter on its own, under fresh_run only: cycle_count is zeroed when the cycle cap is spent (the loop stopped on cycle_cap, or cycle_count >= max_cycles with a non-zero cap as the bounds stand after the same update); created_ts is re-anchored when the time budget is spent (it stopped on runtime_budget, or the clock has run a non-zero budget out by the press). The at-the-press readings exist because the wall clock keeps running through a pause, so a hand-paused loop whose budget elapsed, or paused at exactly its cap, gets the same one-press resume instead of a re-stop on the first press; no time-spent-paused field is added. The other counter is kept: a loop paused by hand at 7 of 24 with an hour of budget and resumed the next morning comes back at 7 of 24 on a fresh clock (rows budget-elapsed-during-pause, paused-at-cap, both-spent). The stop reason is read from the pre-write snapshot since the revival clears the field; a non-string reason matches neither bound. Because a resume now preserves the counters, _load in src/kiro_crew/autonudge.py repairs a malformed cycle_count or created_ts at the store boundary with the _repair_number idiom already used for idle_secs and the start-failure streak; max_cycles and max_runtime_secs are left as stored, because repairing a malformed limit to 0 would quietly remove it. The facade re-exports the two reason constants for the tests. A loop paused by hand (manual), stopped by the agent (autonudge_stop), stood down on an unanswered approval (approval_stalled), or whose last cycle could not run (structural_terminal, session_start_failures) keeps both counters while cycles and time remain. Agent monitor_update bound raises and the apps' reconciler re-arms pass no fresh_run and are unchanged. The update() docstring, the max_runtime_secs field comment, the route comment and the authorize_and_update_nudge docstring in src/kiro_crew/autonudge_authz.py state the rule.

Prose: the owning spec docs/system-specs/modules/learn-cron-dashboard.md (AutoNudge paragraph), the RFC docs/request-for-change/rfc-goal-popover-pause-play-controls.md (title, summary, resume section, compatibility, alternatives: the coupled reset is recorded as rejected) and two comments in website/src/components/AutoNudgePopover.tsx now state the per-bound rule. No user-facing string changes: paused_cycle_cap / paused_runtime_budget still say "Play resumes it with a fresh budget", which stays true.

Backwards compatibility

Compatible: no route, field or key changes. The only behaviour change is that the dashboard route's revival now resets only the counter behind a spent bound and keeps the rest, which for a pause with allowance left is what every revival did before #16030.

Removes nothing: the fresh-budget reset still applies to every spent bound; the change narrows what it resets, hides no path and deletes no record.

Tests

  • test/test_autonudge.py::test_the_users_resume_resets_only_the_counter_behind_a_spent_bound (parametrized, 12 rows): a loop armed 600 s ago is deactivated with each stop reason, then revived through authorize_and_update_nudge(active=True, fresh_run=True). The five non-budget reasons with cycles and time left keep both counters (the manual row carries a 3600 s budget to pin "budget left, breakpoint kept"); cycle_cap zeroes the count and keeps the clock; runtime_budget re-anchors the clock and keeps the count; a manual pause at exactly the cap (24 of 24) zeroes the count only; a manual pause whose 300 s budget elapsed while paused re-anchors the clock only; both spent resets both; an agent-written row whose reason is a list, and one whose cap and budget are strings, reset nothing instead of raising. Red first on unmodified origin/main (9eb318e): the five non-budget rows failed with AssertionError: assert (0 == 7) while the two budget rows passed, which is the reported symptom.
  • The existing test_revival_runs_a_fresh_budget_and_a_running_save_keeps_the_old_one and test_a_bare_revival_keeps_the_count_so_a_reconciler_cannot_mint_a_fresh_allowance still pass, pinning the one-press resume for a cap- and a budget-stopped loop and the no-reset rule for a bare revival.
  • test/test_autonudge_start_failures.py::test_a_malformed_persisted_counter_is_normalised_at_load (the existing streak table, now also over cycle_count and created_ts): a string, null, negative, fractional, NaN or oversized value stored in any of them loads as a finite non-negative number and the timer's first wake does not raise.

Manual verification

N/A — unit coverage sufficient: the fix is one condition in the service's revival branch, exercised through the same chokepoint the dashboard route calls; the frontend change is comments only, with npm run build and the popover's vitest spec (70 tests) green.

Screenshots / video

Why no screenshot: the only frontend change is two code comments in website/src/components/AutoNudgePopover.tsx; no rendered string or markup changes.

Related Issues

Follow-up to #16030.

Pattern harvest

Not generalizable: a single opt-in flag applied without the stop-reason qualifier it was documented to depend on; the reason set now lives beside the flag's consumer, so a second site cannot drift from it.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@pepmach
pepmach requested a review from a team October 3, 2026 01:43
@pepmach
pepmach requested a review from a team as a code owner October 3, 2026 01:43
@pepmach
pepmach requested a review from kyleseaman October 3, 2026 01:43
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 3, 2026
@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 213cb4d40e576cc4863fe303fa8cb68b1d839865 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Check one case: Play on a loop stopped at its cycle limit now keeps the time already used, but the copy still promises "a fresh budget".

Suggestions

  • paused_cycle_cap reads "Play resumes it with a fresh budget." After this PR, Play on a cycle-capped loop restarts the cycle count but keeps the time already used. If that loop also has a time limit, it can stop again on "time limit reached" soon after Play. Change the string to "Play restarts the cycle count."

[UX-REVIEWED] 213cb4d

Description read

[DESCRIPTION-READ] 32c94db50c1fb8a53b788d00e27364b63336f1c74c4d670840a7502ada89eb53

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 213cb4d40e576cc4863fe303fa8cb68b1d839865 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check one case before merge: paused time still counts against the time budget. A loop resumed shortly before its budget runs out gets only seconds of running time.

[DESIGN-REVIEWED] 213cb4d

Description read

[DESCRIPTION-READ] 41e7e95fb4a55ab5e25e7c6776d9fdb017a1356c218543a22c086f8a98f694f3

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 213cb4d40e576cc4863fe303fa8cb68b1d839865 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 213cb4d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 213cb4d40e576cc4863fe303fa8cb68b1d839865: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@pepmach overrode this lane for 213cb4d40e576cc4863fe303fa8cb68b1d839865 via /ai-review override (this commit only).

@pepmach pepmach added the no-screenshots PR has no visual delta; screenshot gate exempt label Oct 3, 2026
@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 213cb4d40e576cc4863fe303fa8cb68b1d839865 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 213cb4d

Verdict parsed from the review's SHA-scoped output markers for commit 213cb4d40e576cc4863fe303fa8cb68b1d839865.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 213cb4d40e576cc4863fe303fa8cb68b1d839865: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 3, 2026
@pepmach
pepmach force-pushed the fix/autonudge-resume-from-breakpoint branch from 9a9b623 to f21161c Compare October 3, 2026 02:42
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 3, 2026
@pepmach

pepmach commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles f21161c: Product-owner ruling on 2026-10-02 (repo owner): a paused goal loop resumes from its breakpoint, not from cycle 1; the fresh-budget reset stays only for the two endings where the budget itself ran out (cycle_cap, runtime_budget), since Play there is otherwise a dead press. The RFC edit in this PR records that decision rather than proposes one; the RFC's own motivation for the reset named limit stops only.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@pepmach marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for f21161c1e8c39546f4deb817b0e624dbe63f6b27.

Product-owner ruling on 2026-10-02 (repo owner): a paused goal loop resumes from its breakpoint, not from cycle 1; the fresh-budget reset stays only for the two endings where the budget itself ran out (cycle_cap, runtime_budget), since Play there is otherwise a dead press. The RFC edit in this PR records that decision rather than proposes one; the RFC's own motivation for the reset named limit stops only.

This decision applies only to this commit. A new push requires a new judgment.

@pepmach
pepmach force-pushed the fix/autonudge-resume-from-breakpoint branch from f21161c to 51603c3 Compare October 3, 2026 03:02
@pepmach

pepmach commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Re the Opus and Design advisories on the two-press edge (budget elapsed during a manual pause; paused by hand at exactly the cap): folded into 51603c3. Play now also resets when the allowance is already spent at the press -- cap reached, or the timer's own runtime_budget_exceeded -- not only when the stored reason is cycle_cap/runtime_budget. A pause with cycles and time left still resumes from its breakpoint. No time-spent-paused bookkeeping is added; the budget stays a wall-clock bound from created_ts (recorded under Alternatives in the RFC). Two new table rows pin both cases.

@pepmach

pepmach commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 51603c3: Product-owner ruling on 2026-10-02 (repo owner): a paused goal loop resumes from its breakpoint, not from cycle 1; the fresh-budget reset stays for a loop whose allowance is spent (stopped on cycle_cap/runtime_budget, or its cap or budget already spent at the press), since Play there is otherwise a dead press. The RFC edit in this PR records that decision rather than proposes one; the RFC's own motivation for the reset named limit stops only.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@pepmach marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 51603c346a003bfe1a0fac283387dcd64135e72e.

Product-owner ruling on 2026-10-02 (repo owner): a paused goal loop resumes from its breakpoint, not from cycle 1; the fresh-budget reset stays for a loop whose allowance is spent (stopped on cycle_cap/runtime_budget, or its cap or budget already spent at the press), since Play there is otherwise a dead press. The RFC edit in this PR records that decision rather than proposes one; the RFC's own motivation for the reset named limit stops only.

This decision applies only to this commit. A new push requires a new judgment.

@pepmach
pepmach force-pushed the fix/autonudge-resume-from-breakpoint branch from 51603c3 to 60f6a8a Compare October 3, 2026 03:42
@pepmach

pepmach commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 60f6a8a: Product-owner ruling on 2026-10-02 (repo owner): a paused goal loop resumes from its breakpoint, not from cycle 1; the fresh-budget reset stays for a loop whose allowance is spent (stopped on cycle_cap/runtime_budget, or its cap or budget already spent at the press), since Play there is otherwise a dead press. The RFC edit in this PR records that decision rather than proposes one; the RFC's own motivation for the reset named limit stops only.

@pepmach

pepmach commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

60f6a8a: the GPT/Opus finding is fixed -- spent-ness is now model.allowance_spent, the timer's two pre-fire checks read through _positive_number and evaluated only under fresh_run, so a malformed bound reads as no bound and no revival path reaches a raising comparison (row malformed-bounds pins it). Design's per-bound-reset alternative is recorded as rejected under the RFC's Alternatives: a resume from a spent allowance is one fresh run, and the two counters describe that run together.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@pepmach marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 60f6a8a6eeeb15777e84cb85faa5a7f310965a9f.

Product-owner ruling on 2026-10-02 (repo owner): a paused goal loop resumes from its breakpoint, not from cycle 1; the fresh-budget reset stays for a loop whose allowance is spent (stopped on cycle_cap/runtime_budget, or its cap or budget already spent at the press), since Play there is otherwise a dead press. The RFC edit in this PR records that decision rather than proposes one; the RFC's own motivation for the reset named limit stops only.

This decision applies only to this commit. A new push requires a new judgment.

@pepmach
pepmach force-pushed the fix/autonudge-resume-from-breakpoint branch from 60f6a8a to 150a255 Compare October 3, 2026 04:02
@pepmach

pepmach commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 150a255: Product-owner ruling on 2026-10-02 (repo owner): a paused goal loop resumes from its breakpoint, not from cycle 1; the fresh-budget reset stays for a loop whose allowance is spent (stopped on cycle_cap/runtime_budget, or its cap or budget already spent at the press), since Play there is otherwise a dead press. The RFC edit in this PR records that decision rather than proposes one; the RFC's own motivation for the reset named limit stops only.

@pepmach

pepmach commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

150a255: the GPT finding on preserved malformed counters is fixed at the boundary the adjudication named -- _load now repairs cycle_count, created_ts, max_cycles and max_runtime_secs with the same _repair_number idiom as idle_secs and the start-failure streak, so a resume that preserves the breakpoint cannot hand the timer a value it would raise on. The existing streak load test now runs over those fields too (30 cases).

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@pepmach marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 150a25504e6c85a5e8eec92e9f0458357795ce44.

Product-owner ruling on 2026-10-02 (repo owner): a paused goal loop resumes from its breakpoint, not from cycle 1; the fresh-budget reset stays for a loop whose allowance is spent (stopped on cycle_cap/runtime_budget, or its cap or budget already spent at the press), since Play there is otherwise a dead press. The RFC edit in this PR records that decision rather than proposes one; the RFC's own motivation for the reset named limit stops only.

This decision applies only to this commit. A new push requires a new judgment.

@pepmach
pepmach force-pushed the fix/autonudge-resume-from-breakpoint branch from 150a255 to 430716a Compare October 3, 2026 04:11
@pepmach

pepmach commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 430716a: Product-owner ruling on 2026-10-02 (repo owner): a paused goal loop resumes from its breakpoint, not from cycle 1; the fresh-budget reset stays for a loop whose allowance is spent (stopped on cycle_cap/runtime_budget, or its cap or budget already spent at the press), since Play there is otherwise a dead press. The RFC edit in this PR records that decision rather than proposes one; the RFC's own motivation for the reset named limit stops only.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@pepmach marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 430716a63d5430644e558792cbcdf986241d8c7d.

Product-owner ruling on 2026-10-02 (repo owner): a paused goal loop resumes from its breakpoint, not from cycle 1; the fresh-budget reset stays for a loop whose allowance is spent (stopped on cycle_cap/runtime_budget, or its cap or budget already spent at the press), since Play there is otherwise a dead press. The RFC edit in this PR records that decision rather than proposes one; the RFC's own motivation for the reset named limit stops only.

This decision applies only to this commit. A new push requires a new judgment.

Play on a paused goal loop reset its cycle count and runtime clock
whatever had stopped it, so a loop a person paused at cycle 7 of 24
came back as cycle 1 of 24. The fresh-budget reset exists for a spent
bound, where Play would otherwise be re-stopped on its first tick; a
pause with allowance left spent nothing.

Reset each counter on its own, and only when the bound behind it is
spent: a spent cycle cap (the loop stopped on cycle_cap, or its count
has reached a non-zero cap) zeroes cycle_count; a spent time budget
(it stopped on runtime_budget, or the clock ran a non-zero budget out
by the press, since the clock keeps running through a pause)
re-anchors created_ts. The other counter is kept, so an overnight
pause at 7 of 24 comes back at 7 of 24 on a fresh clock. The reason is
read from the pre-write snapshot since the revival clears the field;
the bounds are read type-safely because the store is agent-writable,
and _load now repairs a malformed cycle_count or created_ts at the
boundary since a resume no longer overwrites them. monitor_update
bound raises and reconciler re-arms were never reset and stay that
way.

Pin the rule as a parametrized test through authorize_and_update_nudge
(red first on main for the five non-budget reasons), and make the RFC,
the owning spec, the route and authz comments and the popover comments
say what the code now does.
@pepmach
pepmach force-pushed the fix/autonudge-resume-from-breakpoint branch from 430716a to 213cb4d Compare October 3, 2026 04:42
@pepmach

pepmach commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 213cb4d: Product-owner ruling on 2026-10-02 (repo owner): a paused goal loop resumes from its breakpoint, not from cycle 1; a spent bound resets only its own counter (a spent cycle cap zeroes the count, a spent time budget re-anchors the clock), since Play there is otherwise a dead press. The RFC edit in this PR records that decision rather than proposes one; the RFC's own motivation for the reset named limit stops only.

@pepmach

pepmach commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Design disposition, 213cb4d: the per-bound reset is adopted. cycle_count is zeroed only when the cycle cap is spent (stop reason cycle_cap, or the count reached a non-zero cap); created_ts is re-anchored only when the time budget is spent (stop reason runtime_budget, or the clock ran a non-zero budget out, including during a pause). A loop paused by hand at 7 of 24 with an hour of budget and resumed the next morning comes back at 7 of 24 on a fresh clock. Rows budget-elapsed-during-pause (clock only), paused-at-cap (count only), both-spent (both) and the five keep rows pin it; the coupled reset is recorded as rejected under the RFC's Alternatives. The earlier max_cycles/max_runtime_secs load repair was dropped one head ago for the reason the lane gave.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@pepmach marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 213cb4d40e576cc4863fe303fa8cb68b1d839865.

Product-owner ruling on 2026-10-02 (repo owner): a paused goal loop resumes from its breakpoint, not from cycle 1; a spent bound resets only its own counter (a spent cycle cap zeroes the count, a spent time budget re-anchors the clock), since Play there is otherwise a dead press. The RFC edit in this PR records that decision rather than proposes one; the RFC's own motivation for the reset named limit stops only.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 3, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: Play now resumes a paused loop from its cycle count, and a spent limit resets only its own counter, so a pause at 7 of 24 comes back at 7 of 24. No runaway path: only the dashboard route sends fresh_run, and the timer's cap check matches cap_reached. Tests were red first. Nits: firing.py still writes stop reasons as literal strings rather than the new constants; a cap-stopped loop with little time left gets only seconds after Play, though the copy promises a fresh budget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-screenshots PR has no visual delta; screenshot gate exempt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants