Skip to content

feat(onboarding): meet your mates, a launch intro in the poster style - #17156

Merged
CrysisDeu merged 1 commit into
mainfrom
feat/crewmates-intro-modal
Oct 23, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
feat/crewmates-intro-modal

Conversation

@xuejinT

@xuejinT xuejinT commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On the first launch after it ships, a person meets their Mates through one short dialog in the style of the launch poster and is one click from Mate's chat.

Crewmates (Mates) ship without an introduction. The four-step Meet CrewMates wizard was retired, and the clip-based intro this PR first proposed (a looping video with "Try it") was redirected by the product owner in #17154: the intro should be the launch poster itself -- "Meet your Mates.", one line, a sample of what a Mate says, the crew drifting past -- not a video asset to ship, fetch and keep playable.

Why it matters

A new install never learns that Mates exist or what they do: that they find work, do it, and only ask when they need you. Without an intro the Mates page is a rail item with no story behind it, and the first Mate's chat is something a person stumbles into rather than is invited to. A clip would need an asset shipped and fetched for a seven-second loop, and a missing or unplayable asset is the one failure a launch intro cannot afford.

Not a goal

  • The first Mate's entrance in its chat -- how Mate appears the first time its chat opens, and whether anything travels from this dialog to its avatar. That is feat(members): the first Mate enters center stage, then flies into its avatar before greeting #23207; the dialog-to-avatar ghost flight this PR once carried is removed, not moved.
  • Creating a crewmate from the intro. "Try now" opens Mate's chat; the New mate card is unchanged.
  • Any change to the clip library (hosted manifest, cache, download policy) or to the "Got it" dialog a clip renders.
  • Theming the poster: its cream card and ink are fixed by design in every theme; only the accent is the theme's own.

What changed (motivation → approach → change)

Goal: introduce Mates once, at launch, in the poster's own words, without shipping media.

Approach: ride the feature-intro plumbing that already exists (one offer per launch, the seen / dismissed verdict) and add what a launch intro needs that a clip never did: default_on (offered while dashboard.feature_videos_enabled still ships off, since a saved false cannot be told from "never touched"), a cta_route the dialog's Try now opens, the retire probes (crewmates_exist, crewmates_onboarded) and the "New" tag Not now leaves on the rail and let a catalog entry name a dialog body the dashboard draws instead of a clip. Alternatives considered: a new first-run chapter (re-adds a wizard the product owner retired; the intro has to show on an existing install too), and the clip this PR first carried (an asset to ship and fetch, a 404 nothing could recover from, a ghost flight that belongs to #23207). Product shape: RFC rfc-crewmates-launch.md (implemented, on main) screen 08; this PR records the 2026-10-22 ruling there.

Change:

  • src/kiro_crew/feature_videos.py: VideoEntry.component / Offer.component. A component intro carries no src/poster (a path on one is a catalog mistake and the entry is dropped), is offerable() with nothing on disk, and its payload carries component. The crewmates entry becomes component="crewmates", title "Meet your Mates.", line "They find the work, do it, and ask only when they need you.", cta_route="/members?member=mate" (ASSISTANT_MEMBER_NAME, never default). _probe_crewmates_exist ignores default and the first Mate, which every install creates by itself. The crewmates.mp4 / .jpg assets are gone. src/kiro_crew/tips_allowlist.py admits crew-members.md, the entry's doc.
  • website/src/api/client/featureDiscovery.ts: FeatureVideo.component? beside cta_route?, both documented as absent on older gateways.
  • website/src/components/MeetYourMatesIntro.tsx (new): the poster body -- headline, line, a sample message from Mate (two bubbles, two pills, static), two rows of avatarPoses faces over the icon palette, laid twice each and slid with framer-motion (top row left, bottom row right; still under prefers-reduced-motion), running off the card's edges with a hard clip and no fade over them, Not now / Try now. Mate's avatar in the sample card is exposed by ref: it is what Not now flies to the rail.
  • website/src/components/StartupVideoModal.tsx: draws MeetYourMatesIntro inside the shared dialog shell (scrim, focus trap, verdict) for component === "crewmates"; a component this bundle cannot draw is not offered and records no verdict. "Try now" records seen and navigates behind the leave guard; "Not now" measures Mate's avatar at click time, records seen and hands the rail item its tag together with that origin (deliverFeatureNewTag). The dialog portals through OverlayPortal (lint refuses document.body). The Try-it ghost flight to the chat avatar and its clip-geometry constants are removed (feat(members): the first Mate enters center stage, then flies into its avatar before greeting #23207).
  • website/src/utils/featureNewTag.ts: the stored tag (useFeatureNewTag returns 'arriving' | 'shown' | null, clearFeatureNewTag, featureNewTagRoute) and the hand-over of the flight: deliverFeatureNewTag(navId, origin, route) stores the tag FIRST (as arriving, so the rail pill renders invisible and can be measured), then parks the origin for the rail row to claim once (takeFeatureNewTagFlight); landFeatureNewTag turns arriving into shown. Under reduced motion, with no origin, or with no rail row on screen (a closed phone drawer) the tag is stored shown and nothing flies; if no row claims the flight within a frame (a collapsed rail whose corner the unread dot holds) the tag shows too. The standing-ghost SVG courier and landFeatureGhost are gone.
  • website/src/shell/nav/featureNewTagFlight.tsx (new): useFeatureNewTagFlight claims the flight when the row's pill is on screen and measures the pill; FeatureNewTagFlyer is an <img> of the card's avatar (same src) portalled through OverlayPortal, arcing with framer-motion from the avatar's box to the pill in 0.8 s while shrinking to the pill's height and fading out as it arrives; onAnimationComplete lands it. A pointerdown anywhere skips to the landing. A tag cleared mid-flight (the page opened) drops the flyer and brings no tag back.
  • website/src/shell/nav/navRow.tsx (NavBadge): renders the tag (visibility: hidden while arriving, data-feature-new-tag-state), hosts the flyer, pops the pill (scale 0.6 → 1.18 → 1) when a flight lands, redirects a bare /members arrival to the stored route, and clears the tag the first time the route opens by any path.
  • Copy: components.startupVideoModal.{crewmates_title, crewmates_description, new_tag, not_now, try_now} and components.meetYourMatesIntro.{sample_line_1, sample_line_2, sample_merge, sample_show_first} in en.manual.json and the 11 other catalogs, en-XA regenerated, translator context in en.context.json. The sender name reuses components.assistantWelcome.default_name. The catalog English in feature_videos.py equals the bundle's English (pinned by a test).
  • Docs: RFC screen 08 amendment (points to feat(members): the first Mate enters center stage, then flies into its avatar before greeting #23207 for the entrance), feature map row, learn-cron-dashboard.md API line (cta_route, component), feature-videos.md, configuration.md, crew-pod-harness.mjs / capture-crewmate-panel-ia.mjs comments and storage keys.

Backwards compatibility

Compatible: component is a new optional field, "" on every clip; an older dashboard reads the crewmates offer with an empty src and opens nothing, and a dashboard of this build against an older gateway sees no component and behaves as before. The mc-feature-new-tags store reads an older build's 'shown' / 'arriving' strings as a tag.

Reader: website/src/components/StartupVideoModal.tsx:tryNow -- crew page -- the dialog-to-avatar flight (landFeatureGhost, data-feature-landing, FEATURE_LANDED_EVENT) is removed; its only caller was this file's "Try it", and MembersPageThreadHeader.tsx no longer carries the anchor. Pinned by StartupVideoModal.test.tsx "Try now records seen, closes, and opens Mate's chat".
Reader: website/src/shell/nav/navRow.tsx:NavBadge -- crew page -- the Not-now flight changes shape: the standing-ghost SVG courier carrying a copy of the pill is replaced by Mate's avatar from the sample card flying to the pill, which pops in where it lands. The tag is stored before the flight starts, so a reload or a cleared tag mid-flight cannot lose or resurrect it. Pinned by NavBadge.featureNewTag.test.tsx "flies the intro's avatar to an invisible pill, then shows the pill where it landed" and featureNewTag.test.ts "stores the tag as arriving before the flight".
Reader: website/public/app-assets/feature-videos/crewmates.mp4 -- release -- deleted; nothing references it: the entry's src is "" and offerable() skips the disk check for a component intro (test_a_component_intro_is_offered_with_nothing_on_disk).
Reader: website/src/components/StartupVideoModal.tsx:INTRO_COPY -- crew page -- the key components.startupVideoModal.try_it is renamed to try_now in every catalog; the clip footer and the poster both read the new key (keeps the clip card with Not now / Try now in its footer).

Tests

  • test/test_feature_videos.py: the crewmates entry is the one component intro and ships no media; its copy equals the dashboard catalog; a component intro naming media is dropped, one without media is valid, a clip still needs its media; a component intro is offerable() with nothing on disk and its payload carries component/empty src/poster; a clip sends component: ""; crewmates_exist ignores default and the first Mate and fires on a user-made mate; the CTA route is /members?member=mate.
  • website/src/components/StartupVideoModal.test.tsx (Meet your Mates block): not offered behind the preview or for an unknown component (no verdict either way); draws the poster and no player, no probe, no catalog header; dialog named by the title and described by the line; copy equals the catalog English; sample message and pills present with only two buttons; each row laid twice and hidden from the tree; focus on Try now; Try now guarded, then seen + /members?member=mate and no tag; Not now seen + deliverFeatureNewTag('members', <the avatar's measured box and src>, '/members?member=mate'), the avatar being poseDataUri(POSE_IDS[0], BRAND_PURPLE); Escape = Not now; scrim click closes with no verdict; Share hidden. A separate block keeps the clip-with-CTA footer covered.
  • website/src/utils/featureNewTag.test.ts: route kept with the tag until cleared; off-root route refused; tag shows at once with no origin, with no rail row on screen, and under reduced motion (no flight parked in each case); with an origin and a row the tag is stored arriving with its route before anything flies, the row claims the flight exactly once, landing makes it shown; an unclaimed flight shows the tag by the next frame; a tag cleared mid-flight stays cleared; other-tab storage events read a mid-flight arriving and an older build's value as shown; clears for good; corrupt storage survives; featureNewTagOriginOf measures a laid-out avatar and is null otherwise.
  • website/src/test/NavBadge.featureNewTag.test.tsx: tag renders (expanded and collapsed, shown, visible, no flyer); set while on the page only clears; arriving at /members opens the stored route and clears; page load onto the route counts as arriving; a link to another crewmate keeps its target. Flight (framer-motion mocked so the test lands it): the pill renders arriving and invisible, the row claims the flight, the flyer carries the avatar's src and is aria-hidden; landing removes the flyer, shows the pill and stores shown; a pointerdown skips to the landing; opening the page mid-flight drops the flyer and brings no tag back; a collapsed app row whose corner the unread dot holds renders no pill and no flyer and the tag shows by the next frame.

Run locally with explicit paths: the three vitest files (91 tests), test_feature_videos.py + test_feature_videos_hosted.py (291, -n0), test_flake_pattern_ratchet.py; tsc, eslint src --max-warnings 0, jscpd (0 clones), I18N_BASE_REF=origin/main npm run i18n:check, phantom-classes, restyle ratchet, black / isort / flake8 / mypy, comment-history, brand, feature-map and docs lint.

Manual verification

website/scripts/capture-mates-intro.mjs runs the REAL built bundle from this branch behind a stubbed API (fixtures, no gateway) as a fresh install whose only mate is Mate, light and dark, and asserts each frame: no <video> in the dialog, two buttons, both rows moving in opposite directions and hidden from the tree, no gradient painted over the rows (the container clips), Tab stays inside the dialog; Not now closes the dialog, a flyer with the sample card's own avatar src is on screen while the tag waits arriving and invisible, then the flyer is gone and the tag is shown, posts seen, the tag reads "New" and remembers /members?member=mate; clicking the Mates row from the tag opens Mate's chat, clears the tag and forgets the route; Try now posts seen, opens Mate's chat and leaves no tag.

Not verified live: a real gateway (the stub answers /api/feature-videos/next), and the composer-focus race noted below.

Screenshots / video

Not now: Mate's avatar flies from the sample card to the Mates rail row and lands as the "New" tag (dark):

Not now: the avatar flies to the rail and becomes the New tag

The dialog opening, the rows drifting, Try now, Mate's chat (dark):

Meet your Mates intro: rows drifting, Try now, Mate's chat

The dialog, light / dark:

Meet your Mates intro, light
Meet your Mates intro, dark

Mid-flight after Not now, the dialog gone and the avatar on its way (light / dark):

Not now mid-flight, light
Not now mid-flight, dark

Landed: the "New" tag on the Mates rail row (light / dark):

New tag on the Mates row, light
New tag on the Mates row, dark

Mate's chat opened from the tag, tag cleared (light / dark)

From the tag: Mate's chat, light
From the tag: Mate's chat, dark

Media is committed under .github/screenshots/mates-intro/ at the maintainer's request and referenced by commit-pinned URLs. All frames were re-recorded after the last code change (2026-10-23: no edge fade on the rows, the Not now flight); the 02-not-now-* stills and intro-not-now.gif are new.

Known, pre-existing: in the full shell the chat page behind the dialog mounts late and its composer takes focus for a moment, so a keyboard user's focus can end up outside the dialog on open; the clip dialog on main has the same race. The unit test pins focus on Try now; the capture asserts the trap (Tab stays inside).

Related Issues

Closes #17154
Refs #23207 (the first Mate's entrance)

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@xuejinT
xuejinT requested a review from a team as a code owner October 5, 2026 22:16
@xuejinT
xuejinT requested a review from chenmingwei23 October 5, 2026 22:16
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@CrysisDeu overrode this lane for ebb9b4ae2601a7321b40de3cf6b170ef3ce6e336 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of ebb9b4ae2601a7321b40de3cf6b170ef3ce6e336 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the primary controls "Try now" and "Not now" were read correctly, and the Not now flight has a recording. "Try now" was read only as "a guess", which is a note.

Notes

  • The sample pills "Merge it" and "Show me first" (MeetYourMatesIntro.tsx:127-128) are spans styled like the real Try now / Not now pair: a filled accent pill next to an ink-outlined one. The blind reader "can't tell if they're live" and "wouldn't press". Make the card look like a picture: smaller, muted pills with no filled accent, or a "For example" caption on the card.
  • The reader read "Try now" only as "starts using a Mate -> a guess". It opens Mate's chat, so label the outcome: "Chat with Mate".
  • The sample lines "flaky test", "PR" and "merge" lost a cold reader. Pick a sample task anyone would recognise if the intro is meant for every install.

[UX-REVIEWED] ebb9b4a

Description read

[DESCRIPTION-READ] 896b97d4ab80984b63680766c0d9e5057523f95af1e43c0e90c1290edde6348c

That sha256 names everything this verdict read: the PR description, plus the 13 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of ebb9b4ae2601a7321b40de3cf6b170ef3ce6e336 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

No design-level concerns: the intro reuses the existing one-offer-per-launch and verdict plumbing and adds a media-free component entry. Rendered evidence is committed.

Notes

  • default_on shows the intro to an operator who saved feature_videos_enabled: false on purpose. That is reversible: one dismissal retires it. A later change could give a deliberate opt-out its own key, since the code cannot tell a chosen false from the default one.
  • feature_videos.py now imports dashboard.handlers.members._member_name_is_addressable. That ties a catalog module to a private handler helper, and the filter belongs in a shared roster utility.
  • The description was cut off in the middle of ## Backwards compatibility, so the reader list was only checked as far as the cut.

[DESIGN-REVIEWED] ebb9b4a

Description read

[DESCRIPTION-READ] 07513877ae7f6bdd99f82a4bf9cd5f36c873ed141ed5693d7a070db8a0c9dc17

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ human override accepted

Human judgment by @CrysisDeu overrides the GPT 6.1 finding for ebb9b4ae2601a7321b40de3cf6b170ef3ce6e336; the recorded reason is authoritative for this commit.

[GPT-OVERRIDE] ebb9b4a

This comment is updated in place on each push.

The model was not re-run because an authorized human decision supersedes it.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ebb9b4ae2601a7321b40de3cf6b170ef3ce6e336: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed ebb9b4ae2601a7321b40de3cf6b170ef3ce6e336 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ebb9b4a

Verdict parsed from the review's SHA-scoped output markers for commit ebb9b4ae2601a7321b40de3cf6b170ef3ce6e336.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ebb9b4ae2601a7321b40de3cf6b170ef3ce6e336: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 5, 2026
@xuejinT
xuejinT force-pushed the feat/crewmates-intro-modal branch from 881494d to 24de17a Compare October 6, 2026 18:12
@xuejinT

xuejinT commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=cc3d73fb322b needs-a-decision

Replacing RFC screen 08's four-step flow is a product-owner call. Asked on #17154; awaiting a maintainer override or an RFC amendment on main.

@xuejinT

xuejinT commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=59d40885b281 needs-a-decision

Removing the page's Meet CrewMates entry follows from replacing screen 08; same ruling as span cc3d73fb322b, asked on #17154.

@xuejinT

xuejinT commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=33ad9ad3d254 needs-a-decision

Retiring the intro once a crewmate exists reverses the #14914 amendment on purpose: an intro for a feature already in use is noise. Needs the owner's ruling with the rest of screen 08 (#17154).

@xuejinT

xuejinT commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=d34154a5c805 needs-a-decision

Clears only by a maintainer override or an RFC change on main replacing screen 08. Not overridden by the author; asked on #17154.

@xuejinT

xuejinT commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=b83bccd7a18f rebutted

The product owner reviewed the copy and kept "Try it"; it is the intro's call to action, and the clip plus title say what it opens.

@xuejinT

xuejinT commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=c4c2741d50ed rebutted

Out of goal: the walkthrough that starts on mc-feature-landed is listed under Not a goal and is separate work.

@xuejinT

xuejinT commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=316baf6ff87d fixed

The dialog now opens with focus on Try it (24de17a); test: opens with focus on Try it, the main choice.

@xuejinT

xuejinT commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=7ec60d75a295 needs-a-decision

Same ruling as the First Principles block: the owner's decision goes on #17154, and the record lands with it.

@xuejinT

xuejinT commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=3f60fb61d8b2 fixed

The feature_videos_enabled description now names dashboard.crewmates_onboarded: true as the Crewmates intro's off switch (24de17a).

@xuejinT

xuejinT commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=3721afde10b6 fixed

Hosted-manifest cta_route parsing removed in 24de17a; only the bundled catalog carries a CTA.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Oct 6, 2026
@xuejinT
xuejinT force-pushed the feat/crewmates-intro-modal branch from 24de17a to 74b04a9 Compare October 6, 2026 21:02
@xuejinT

xuejinT commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author
  • span=93e3d00571b4 fixed

The two CTA tests wait for the Try it button with findByTestId instead of timed act loops (74b04a9).

@xuejinT

xuejinT commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author
  • span=cf24d0f7d829 fixed

The autouse catalog fixture patches through _floor_monkeypatch, so monkeypatch.undo() in a test cannot lift it (74b04a9).

@xuejinT

xuejinT commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author
  • span=0ec7e638e180 needs-a-decision

The product owner approved this shape; the 2026-10-08 screen 08 amendment in this diff records the replacement, the removed entry and the new retire rule.
An in-diff amendment does not count for this lane, so it needs a maintainer override on this head.

@xuejinT

xuejinT commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author
  • span=5088ec1a28b4 needs-a-decision

The product owner approved this shape; the 2026-10-08 screen 08 amendment in this diff records the single-card replacement.
An in-diff amendment does not count for this lane, so it needs a maintainer override on this head.

@xuejinT

xuejinT commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author
  • span=723e7fda17b2 needs-a-decision

The product owner approved this shape; the 2026-10-08 screen 08 amendment in this diff records removing the on-demand entry.
An in-diff amendment does not count for this lane, so it needs a maintainer override on this head.

@xuejinT

xuejinT commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author
  • span=a60da9f6cb43 needs-a-decision

The product owner approved this shape; the 2026-10-08 screen 08 amendment in this diff records retiring the intro once a crewmate exists.
An in-diff amendment does not count for this lane, so it needs a maintainer override on this head.

@xuejinT

xuejinT commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author
  • span=d7a3e1951850 rebutted

cta_route reaches navigate() in the dialog and the New tag, so the validator keeps any bundled entry from routing outside the dashboard.
It is three lines, and removing it would leave that path checked only by review.

@xuejinT

xuejinT commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author
  • span=9b3c40fd7781 rebutted

Landing on default's chat is the owner's chosen destination: the ghost that arrives is default, and its chat is where the first goal gets typed.
The walkthrough that fills this chat is separate work.

@xuejinT

xuejinT commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author
  • span=14bd73a0a691 rebutted

The lower-right corner placement was picked by the owner from three mocks on the real collapsed rail; the top placement hid the Crewmates icon.

@xuejinT

xuejinT commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author
  • span=e6c099d23af6 rebutted

The Feature intro header is shared by every feature video and not added here; renaming it changes all intros and is out of scope.

@xuejinT

xuejinT commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author
  • span=44f1ae218379 rebutted

Showing the intro on a later launch, not straight after the tour, is intended: the startup gate yields a launch that already showed onboarding, so a new user is not hit with a second card.
This is stated in the PR description and the screen 08 amendment ('shown on a later launch once first run is finished'), and the existing startupVideo gate tests pin that launch rule.

@xuejinT

xuejinT commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author
  • span=61785fc57eb9 rebutted

The uniform draw is the existing selection rule for all intros; the Crewmates intro stays eligible until seen, so it still shows on a later launch.
Adding a priority tier for one entry is a selection-policy change outside this PR.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 9, 2026
@CrysisDeu CrysisDeu changed the title feat(onboarding): replace Meet CrewMates with a Crewmates intro feat(onboarding): meet your mates, a launch intro in the poster style Oct 22, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/crewmates-intro-modal branch from ccb7129 to 78f3421 Compare October 22, 2026 23:36
@CrysisDeu

Copy link
Copy Markdown
Contributor

The PR's goal, Why it matters and Not a goal were rewritten at the maintainer's request: the product owner redirected the scope in #17154 (comment) from a looping clip to the poster-style "Meet your Mates." dialog. Head 78f3421fc6df66b688f9510bc2a212b6a9779eba is that re-scope, squashed into one commit with the original author kept as co-author; the dialog-to-avatar ghost flight is removed here and belongs to #23207.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 22, 2026
Crewmates are introduced by one startup dialog in the style of the launch
poster: "Meet your Mates." with the line "They find the work, do it, and ask
only when they need you.", a sample message from Mate with the two answers it
offers, and two rows of crewmate faces drifting past in opposite directions
(still under reduced motion), running off the card's edges with a hard clip.
Buttons: Not now / Try now, Try now focused.

The dialog is a rendered component, not a clip. The `crewmates` catalog entry
carries `component: "crewmates"` and no media, so nothing is shipped, fetched
or able to 404; the offer, the one-launch gate, the `seen` verdict, `default_on`
and the retire probes are the same plumbing a clip rides. `StartupVideoModal`
draws `MeetYourMatesIntro` for that component and refuses a component this
bundle cannot draw, recording no verdict.

- Try now records seen and opens Mate's chat (`/members?member=mate`), behind
  the leave guard. No ghost flight from the dialog to the avatar; the first
  Mate's entrance is #23207.
- Not now records seen, and Mate's avatar from the sample card flies to the
  Mates rail item and lands as its "New" tag (`NavBadge`), which opens the
  same chat and clears the first time the page is opened by any path. The tag
  is stored before the flight starts (`arriving`, the pill measured invisible)
  and shown on landing; a press skips to the landing; under reduced motion or
  with the row off screen the tag just appears. The flyer is drawn by the rail
  row through the overlay root, since the dialog is gone a frame later.
- Retires once seen, when `dashboard.crewmates_onboarded` is true, or when a
  mate besides `default` and the first Mate exists.
- Copy is translated in every catalog, with the catalog English kept equal to
  the bundle's English.
- RFC screen 08 records the product owner's 2026-10-22 ruling (#17154); the
  feature map, the API spec line and the user docs follow.

Evidence: `website/scripts/capture-mates-intro.mjs` runs the built bundle
behind a stubbed API and asserts each frame under
`.github/screenshots/mates-intro/`, the Not now flight included.

Closes #17154

Co-authored-by: Serena Tan <xuejint02@gmail.com>
@CrysisDeu

Copy link
Copy Markdown
Contributor

/ai-review override first-principles ebb9b4a: Product owner decision 2026-10-22 (issue #17154 comment): the Mates launch intro is a one-time launch-week dialog, shown by default while the Mates preview is on because the feature-video switch ships off; the RFC screen 08 amendment in this PR is that decision's record.

@CrysisDeu

Copy link
Copy Markdown
Contributor

/ai-review override gpt ebb9b4a: Pre-existing on main (StartupVideoModal.tsx offered = !isError && ..., retry:false, "error path renders nothing" comment); this PR only adds two more gates on that line. A launch intro that fails to load must stay silent at boot; the error journal is the record, as the existing comment states.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for ebb9b4ae2601a7321b40de3cf6b170ef3ce6e336.

Product owner decision 2026-10-22 (issue #17154 comment): the Mates launch intro is a one-time launch-week dialog, shown by default while the Mates preview is on because the feature-video switch ships off; the RFC screen 08 amendment in this PR is that decision's record.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu marked the gpt AI finding as false positive, not applicable, or explicitly accepted for ebb9b4ae2601a7321b40de3cf6b170ef3ce6e336.

Pre-existing on main (StartupVideoModal.tsx offered = !isError && ..., retry:false, "error path renders nothing" comment); this PR only adds two more gates on that line. A launch intro that fails to load must stay silent at boot; the error journal is the record, as the existing comment states.

This decision applies only to this commit. A new push requires a new judgment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace the Meet CrewMates wizard with a Crewmates feature intro

2 participants