Repository navigation
feat(onboarding): meet your mates, a launch intro in the poster style - #17156
Conversation
First Principles Review (Opus 5.5) — ✅ human override accepted@CrysisDeu overrode this lane for |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the primary controls "Try now" and "Not now" were read correctly, and the Not now flight has a recording. "Try now" was read only as "a guess", which is a note. Notes
[UX-REVIEWED] ebb9b4a Description read[DESCRIPTION-READ] 896b97d4ab80984b63680766c0d9e5057523f95af1e43c0e90c1290edde6348c That sha256 names everything this verdict read: the PR description, plus the 13 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS No design-level concerns: the intro reuses the existing one-offer-per-launch and verdict plumbing and adds a media-free component entry. Rendered evidence is committed. Notes
[DESIGN-REVIEWED] ebb9b4a Description read[DESCRIPTION-READ] 07513877ae7f6bdd99f82a4bf9cd5f36c873ed141ed5693d7a070db8a0c9dc17 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ human override acceptedHuman judgment by @CrysisDeu overrides the GPT 6.1 finding for [GPT-OVERRIDE] ebb9b4a This comment is updated in place on each push. The model was not re-run because an authorized human decision supersedes it. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
881494d to
24de17a
Compare
|
|
|
|
|
|
|
|
|
24de17a to
74b04a9
Compare
|
|
|
|
|
|
|
|
|
|
|
|
ccb7129 to
78f3421
Compare
|
The PR's goal, Why it matters and Not a goal were rewritten at the maintainer's request: the product owner redirected the scope in #17154 (comment) from a looping clip to the poster-style "Meet your Mates." dialog. Head |
Crewmates are introduced by one startup dialog in the style of the launch poster: "Meet your Mates." with the line "They find the work, do it, and ask only when they need you.", a sample message from Mate with the two answers it offers, and two rows of crewmate faces drifting past in opposite directions (still under reduced motion), running off the card's edges with a hard clip. Buttons: Not now / Try now, Try now focused. The dialog is a rendered component, not a clip. The `crewmates` catalog entry carries `component: "crewmates"` and no media, so nothing is shipped, fetched or able to 404; the offer, the one-launch gate, the `seen` verdict, `default_on` and the retire probes are the same plumbing a clip rides. `StartupVideoModal` draws `MeetYourMatesIntro` for that component and refuses a component this bundle cannot draw, recording no verdict. - Try now records seen and opens Mate's chat (`/members?member=mate`), behind the leave guard. No ghost flight from the dialog to the avatar; the first Mate's entrance is #23207. - Not now records seen, and Mate's avatar from the sample card flies to the Mates rail item and lands as its "New" tag (`NavBadge`), which opens the same chat and clears the first time the page is opened by any path. The tag is stored before the flight starts (`arriving`, the pill measured invisible) and shown on landing; a press skips to the landing; under reduced motion or with the row off screen the tag just appears. The flyer is drawn by the rail row through the overlay root, since the dialog is gone a frame later. - Retires once seen, when `dashboard.crewmates_onboarded` is true, or when a mate besides `default` and the first Mate exists. - Copy is translated in every catalog, with the catalog English kept equal to the bundle's English. - RFC screen 08 records the product owner's 2026-10-22 ruling (#17154); the feature map, the API spec line and the user docs follow. Evidence: `website/scripts/capture-mates-intro.mjs` runs the built bundle behind a stubbed API and asserts each frame under `.github/screenshots/mates-intro/`, the Not now flight included. Closes #17154 Co-authored-by: Serena Tan <xuejint02@gmail.com>
|
/ai-review override first-principles ebb9b4a: Product owner decision 2026-10-22 (issue #17154 comment): the Mates launch intro is a one-time launch-week dialog, shown by default while the Mates preview is on because the feature-video switch ships off; the RFC screen 08 amendment in this PR is that decision's record. |
|
/ai-review override gpt ebb9b4a: Pre-existing on main (StartupVideoModal.tsx offered = !isError && ..., retry:false, "error path renders nothing" comment); this PR only adds two more gates on that line. A launch intro that fails to load must stay silent at boot; the error journal is the record, as the existing comment states. |
Human judgment recorded@CrysisDeu marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Human judgment recorded@CrysisDeu marked the gpt AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Problem / Motivation
Goal: On the first launch after it ships, a person meets their Mates through one short dialog in the style of the launch poster and is one click from Mate's chat.
Crewmates (Mates) ship without an introduction. The four-step Meet CrewMates wizard was retired, and the clip-based intro this PR first proposed (a looping video with "Try it") was redirected by the product owner in #17154: the intro should be the launch poster itself -- "Meet your Mates.", one line, a sample of what a Mate says, the crew drifting past -- not a video asset to ship, fetch and keep playable.
Why it matters
A new install never learns that Mates exist or what they do: that they find work, do it, and only ask when they need you. Without an intro the Mates page is a rail item with no story behind it, and the first Mate's chat is something a person stumbles into rather than is invited to. A clip would need an asset shipped and fetched for a seven-second loop, and a missing or unplayable asset is the one failure a launch intro cannot afford.
Not a goal
What changed (motivation → approach → change)
Goal: introduce Mates once, at launch, in the poster's own words, without shipping media.
Approach: ride the feature-intro plumbing that already exists (one offer per launch, the
seen/dismissedverdict) and add what a launch intro needs that a clip never did:default_on(offered whiledashboard.feature_videos_enabledstill ships off, since a savedfalsecannot be told from "never touched"), acta_routethe dialog's Try now opens, the retire probes (crewmates_exist,crewmates_onboarded) and the "New" tag Not now leaves on the rail and let a catalog entry name a dialog body the dashboard draws instead of a clip. Alternatives considered: a new first-run chapter (re-adds a wizard the product owner retired; the intro has to show on an existing install too), and the clip this PR first carried (an asset to ship and fetch, a 404 nothing could recover from, a ghost flight that belongs to #23207). Product shape: RFC rfc-crewmates-launch.md (implemented, on main) screen 08; this PR records the 2026-10-22 ruling there.Change:
src/kiro_crew/feature_videos.py:VideoEntry.component/Offer.component. A component intro carries nosrc/poster(a path on one is a catalog mistake and the entry is dropped), isofferable()with nothing on disk, and its payload carriescomponent. Thecrewmatesentry becomescomponent="crewmates", title "Meet your Mates.", line "They find the work, do it, and ask only when they need you.",cta_route="/members?member=mate"(ASSISTANT_MEMBER_NAME, neverdefault)._probe_crewmates_existignoresdefaultand the first Mate, which every install creates by itself. Thecrewmates.mp4/.jpgassets are gone.src/kiro_crew/tips_allowlist.pyadmitscrew-members.md, the entry's doc.website/src/api/client/featureDiscovery.ts:FeatureVideo.component?besidecta_route?, both documented as absent on older gateways.website/src/components/MeetYourMatesIntro.tsx(new): the poster body -- headline, line, a sample message from Mate (two bubbles, two pills, static), two rows ofavatarPosesfaces over the icon palette, laid twice each and slid with framer-motion (top row left, bottom row right; still underprefers-reduced-motion), running off the card's edges with a hard clip and no fade over them, Not now / Try now. Mate's avatar in the sample card is exposed by ref: it is what Not now flies to the rail.website/src/components/StartupVideoModal.tsx: drawsMeetYourMatesIntroinside the shared dialog shell (scrim, focus trap, verdict) forcomponent === "crewmates"; a component this bundle cannot draw is not offered and records no verdict. "Try now" recordsseenand navigates behind the leave guard; "Not now" measures Mate's avatar at click time, recordsseenand hands the rail item its tag together with that origin (deliverFeatureNewTag). The dialog portals throughOverlayPortal(lint refusesdocument.body). The Try-it ghost flight to the chat avatar and its clip-geometry constants are removed (feat(members): the first Mate enters center stage, then flies into its avatar before greeting #23207).website/src/utils/featureNewTag.ts: the stored tag (useFeatureNewTagreturns'arriving' | 'shown' | null,clearFeatureNewTag,featureNewTagRoute) and the hand-over of the flight:deliverFeatureNewTag(navId, origin, route)stores the tag FIRST (asarriving, so the rail pill renders invisible and can be measured), then parks the origin for the rail row to claim once (takeFeatureNewTagFlight);landFeatureNewTagturnsarrivingintoshown. Under reduced motion, with no origin, or with no rail row on screen (a closed phone drawer) the tag is storedshownand nothing flies; if no row claims the flight within a frame (a collapsed rail whose corner the unread dot holds) the tag shows too. The standing-ghost SVG courier andlandFeatureGhostare gone.website/src/shell/nav/featureNewTagFlight.tsx(new):useFeatureNewTagFlightclaims the flight when the row's pill is on screen and measures the pill;FeatureNewTagFlyeris an<img>of the card's avatar (samesrc) portalled throughOverlayPortal, arcing with framer-motion from the avatar's box to the pill in 0.8 s while shrinking to the pill's height and fading out as it arrives;onAnimationCompletelands it. Apointerdownanywhere skips to the landing. A tag cleared mid-flight (the page opened) drops the flyer and brings no tag back.website/src/shell/nav/navRow.tsx(NavBadge): renders the tag (visibility: hiddenwhilearriving,data-feature-new-tag-state), hosts the flyer, pops the pill (scale0.6 → 1.18 → 1) when a flight lands, redirects a bare/membersarrival to the stored route, and clears the tag the first time the route opens by any path.components.startupVideoModal.{crewmates_title, crewmates_description, new_tag, not_now, try_now}andcomponents.meetYourMatesIntro.{sample_line_1, sample_line_2, sample_merge, sample_show_first}inen.manual.jsonand the 11 other catalogs,en-XAregenerated, translator context inen.context.json. The sender name reusescomponents.assistantWelcome.default_name. The catalog English infeature_videos.pyequals the bundle's English (pinned by a test).learn-cron-dashboard.mdAPI line (cta_route,component),feature-videos.md,configuration.md,crew-pod-harness.mjs/capture-crewmate-panel-ia.mjscomments and storage keys.Backwards compatibility
Compatible:
componentis a new optional field,""on every clip; an older dashboard reads thecrewmatesoffer with an emptysrcand opens nothing, and a dashboard of this build against an older gateway sees nocomponentand behaves as before. Themc-feature-new-tagsstore reads an older build's'shown'/'arriving'strings as a tag.Reader: website/src/components/StartupVideoModal.tsx:tryNow -- crew page -- the dialog-to-avatar flight (
landFeatureGhost,data-feature-landing,FEATURE_LANDED_EVENT) is removed; its only caller was this file's "Try it", andMembersPageThreadHeader.tsxno longer carries the anchor. Pinned byStartupVideoModal.test.tsx"Try now records seen, closes, and opens Mate's chat".Reader: website/src/shell/nav/navRow.tsx:NavBadge -- crew page -- the Not-now flight changes shape: the standing-ghost SVG courier carrying a copy of the pill is replaced by Mate's avatar from the sample card flying to the pill, which pops in where it lands. The tag is stored before the flight starts, so a reload or a cleared tag mid-flight cannot lose or resurrect it. Pinned by
NavBadge.featureNewTag.test.tsx"flies the intro's avatar to an invisible pill, then shows the pill where it landed" andfeatureNewTag.test.ts"stores the tag as arriving before the flight".Reader: website/public/app-assets/feature-videos/crewmates.mp4 -- release -- deleted; nothing references it: the entry's
srcis""andofferable()skips the disk check for a component intro (test_a_component_intro_is_offered_with_nothing_on_disk).Reader: website/src/components/StartupVideoModal.tsx:INTRO_COPY -- crew page -- the key
components.startupVideoModal.try_itis renamed totry_nowin every catalog; the clip footer and the poster both read the new key (keeps the clip card with Not now / Try now in its footer).Tests
test/test_feature_videos.py: thecrewmatesentry is the one component intro and ships no media; its copy equals the dashboard catalog; a component intro naming media is dropped, one without media is valid, a clip still needs its media; a component intro isofferable()with nothing on disk and its payload carriescomponent/emptysrc/poster; a clip sendscomponent: "";crewmates_existignoresdefaultand the first Mate and fires on a user-made mate; the CTA route is/members?member=mate.website/src/components/StartupVideoModal.test.tsx(Meet your Mates block): not offered behind the preview or for an unknown component (no verdict either way); draws the poster and no player, no probe, no catalog header; dialog named by the title and described by the line; copy equals the catalog English; sample message and pills present with only two buttons; each row laid twice and hidden from the tree; focus on Try now; Try now guarded, thenseen+/members?member=mateand no tag; Not nowseen+deliverFeatureNewTag('members', <the avatar's measured box and src>, '/members?member=mate'), the avatar beingposeDataUri(POSE_IDS[0], BRAND_PURPLE); Escape = Not now; scrim click closes with no verdict; Share hidden. A separate block keeps the clip-with-CTA footer covered.website/src/utils/featureNewTag.test.ts: route kept with the tag until cleared; off-root route refused; tag shows at once with no origin, with no rail row on screen, and under reduced motion (no flight parked in each case); with an origin and a row the tag is storedarrivingwith its route before anything flies, the row claims the flight exactly once, landing makes itshown; an unclaimed flight shows the tag by the next frame; a tag cleared mid-flight stays cleared; other-tab storage events read a mid-flightarrivingand an older build's value as shown; clears for good; corrupt storage survives;featureNewTagOriginOfmeasures a laid-out avatar and is null otherwise.website/src/test/NavBadge.featureNewTag.test.tsx: tag renders (expanded and collapsed,shown, visible, no flyer); set while on the page only clears; arriving at/membersopens the stored route and clears; page load onto the route counts as arriving; a link to another crewmate keeps its target. Flight (framer-motion mocked so the test lands it): the pill rendersarrivingand invisible, the row claims the flight, the flyer carries the avatar'ssrcand isaria-hidden; landing removes the flyer, shows the pill and storesshown; apointerdownskips to the landing; opening the page mid-flight drops the flyer and brings no tag back; a collapsed app row whose corner the unread dot holds renders no pill and no flyer and the tag shows by the next frame.Run locally with explicit paths: the three vitest files (91 tests),
test_feature_videos.py+test_feature_videos_hosted.py(291,-n0),test_flake_pattern_ratchet.py;tsc,eslint src --max-warnings 0,jscpd(0 clones),I18N_BASE_REF=origin/main npm run i18n:check, phantom-classes, restyle ratchet, black / isort / flake8 / mypy, comment-history, brand, feature-map and docs lint.Manual verification
website/scripts/capture-mates-intro.mjsruns the REAL built bundle from this branch behind a stubbed API (fixtures, no gateway) as a fresh install whose only mate is Mate, light and dark, and asserts each frame: no<video>in the dialog, two buttons, both rows moving in opposite directions and hidden from the tree, no gradient painted over the rows (the container clips), Tab stays inside the dialog; Not now closes the dialog, a flyer with the sample card's own avatarsrcis on screen while the tag waitsarrivingand invisible, then the flyer is gone and the tag isshown, postsseen, the tag reads "New" and remembers/members?member=mate; clicking the Mates row from the tag opens Mate's chat, clears the tag and forgets the route; Try now postsseen, opens Mate's chat and leaves no tag.Not verified live: a real gateway (the stub answers
/api/feature-videos/next), and the composer-focus race noted below.Screenshots / video
Not now: Mate's avatar flies from the sample card to the Mates rail row and lands as the "New" tag (dark):
The dialog opening, the rows drifting, Try now, Mate's chat (dark):
The dialog, light / dark:
Mid-flight after Not now, the dialog gone and the avatar on its way (light / dark):
Landed: the "New" tag on the Mates rail row (light / dark):
Mate's chat opened from the tag, tag cleared (light / dark)
Media is committed under
.github/screenshots/mates-intro/at the maintainer's request and referenced by commit-pinned URLs. All frames were re-recorded after the last code change (2026-10-23: no edge fade on the rows, the Not now flight); the02-not-now-*stills andintro-not-now.gifare new.Known, pre-existing: in the full shell the chat page behind the dialog mounts late and its composer takes focus for a moment, so a keyboard user's focus can end up outside the dialog on open; the clip dialog on main has the same race. The unit test pins focus on Try now; the capture asserts the trap (Tab stays inside).
Related Issues
Closes #17154
Refs #23207 (the first Mate's entrance)
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.