Skip to content

docs(session-control): drop refusal row removed in #17662 - #17903

Closed
iamwhatever wants to merge 1 commit into
mainfrom
fix/session-control-doc-stale-row
Closed

iamwhatever wants to merge 1 commit into
mainfrom
fix/session-control-doc-stale-row

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Turn main's backend test shard green again by dropping a doc row for a refusal code the code no longer raises.

The session-control page still lists remote_target_unsupported, so its doc-vs-source test fails on main.

Why it matters

test/test_session_control_doc.py::test_every_tabulated_refusal_code_is_one_the_source_raises is red on main and on every PR based on it.

Not a goal

  • Rewording any other part of the session-control docs.

What changed (motivation → approach → change)

Row Code status Test
remote_target_unsupported in src/kiro_crew/docs/session-control.md removed from session_control.py by #17662 red → green

Why: #17662 deleted the remote-crew relay and its refusal code; #17450 kept the docs table row, which the test above rejects.

Backwards compatibility

Compatible: the code was already gone; only the doc catches up.

Reader: src/kiro_crew/docs/session-control.md:refusal-code table -- release -- test_session_control_doc.py reads it and now passes (10 passed locally).

Tests

No new tests; test/test_session_control_doc.py passes locally (10 passed).

Manual verification

N/A — doc-only change covered by the doc test.

Related Issues

Closes #17902

Pattern harvest

Not generalizable: the doc test already guards this class; it caught the drift as designed.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 23e307ae3bb77b50af5cc406bf57128a513f4390 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 23e307ae3bb77b50af5cc406bf57128a513f4390 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

One thing to check: docs/feature-map/README.md:238 still lists remote_target_unsupported as a refusal for remote-crew targets, so the same stale doc text is still in the tree.

[DESIGN-REVIEWED] 23e307a

Description read

[DESCRIPTION-READ] 0e6d6fb7d8998d9c9f23c4b1345df64dc7ca301fa1861f0bc0bebc03a28ebac6

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🟡 CONCERNS

Premise-level review of 23e307ae3bb77b50af5cc406bf57128a513f4390 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The PR fixes the one doc row the test checks, but docs/feature-map/README.md:238 still names the refusal code #17662 deleted.

Not justified as shipped

  • Item 1 — symptom-level: the cause is docs drifting after feat(remote-crew): delete the turn relay; old relay chats are read-only #17662 removed the remote-crew relay. A grep for remote_target_unsupported finds 1 more stale mention, outside the tested table: the feature map still says reload refuses "self, remote-crew and busy targets … with self_target, remote_target_unsupported and target_busy".
    Subtraction: in docs/feature-map/README.md:238, delete "remote-crew" and remote_target_unsupported from the reload entry.
    Clears when: a grep for remote_target_unsupported finds no matches anywhere in the repository.

What this change ships

Inventory (1 items) — 0 justified

Intent: get main's backend test shard green by removing a doc row for a refusal code that no longer exists. This is a FIX.

  1. The session-control refusal table no longer lists remote_target_unsupported. Tag: symptom-level, because 1 sibling mention is left in the feature map.

[FIRST-PRINCIPLES-REVIEWED] 23e307a

Description read

[DESCRIPTION-READ] 4576b646f246f1a1347e633a2463d5a7541865759c662699f8a23561b8889dd2

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 23e307ae3bb77b50af5cc406bf57128a513f4390 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 23e307a

Verdict parsed from the review's SHA-scoped output markers for commit 23e307ae3bb77b50af5cc406bf57128a513f4390.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 23e307ae3bb77b50af5cc406bf57128a513f4390: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 23e307ae3bb77b50af5cc406bf57128a513f4390 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 23e307a

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 23e307ae3bb77b50af5cc406bf57128a513f4390: <one-sentence reason>

@bolichen97

Copy link
Copy Markdown
Contributor

#17907 now carries both halves, so each PR can go green alone; whichever lands first, the other only needs a rebase.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 7, 2026
iamwhatever pushed a commit that referenced this pull request Oct 7, 2026
#17662 deleted the turn relay and with it every session_control.py raise of
remote_target_unsupported, but the session-control page still tabulates it, so
test_session_control_doc.py::test_every_tabulated_refusal_code_is_one_the_source_raises
is red on main (shard 6, both Linux and Windows).

This is the same one-line deletion as the open PR #17903. Carrying it here lets
both base reds -- the HTTPServer bind ratchet (shard 2, this PR's own fix) and
the doc row (shard 6) -- clear together, since #17903 fails on shard 2 and this
PR failed on shard 6, so neither could go green alone.
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Heads up: these two PRs are in a shard deadlock on current main. #17903 (this PR) is green except shard 2's test_http_server_bind_ratchet (16 bare HTTPServer sites vs recorded baseline 15), and #17909 is green except shard 6's test_session_control_doc — the exact doc row this PR deletes. Neither can go fully green on its own.

To break it, #17909 now carries this PR's identical one-line deletion from session-control.md as a second commit (credited to you in its body), alongside its own ratchet fix. So either PR can merge first — whichever lands, the other rebases clean onto a fully-green main. I'm not closing this PR; it's yours to land or close as you prefer.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Main has two reds: test/test_session_control_doc.py::test_every_tabulated_refusal_code_is_one_the_source_raises and test/test_http_server_bind_ratchet.py::test_bare_http_server_constructions_match_the_recorded_count. Each single fix is still red on the other test, so neither can go green by itself:

PR Fixes Red on
#17903 doc row bind ratchet
#17906 bind ratchet (budget 15 → 16) doc test
#17907 bind ratchet (subclass, budget stays 15) doc test
#17909 both (design-tweak _Server.server_bind + doc row) —

We are backing #17909, which carries both fixes and keeps the ratchet at 15. This PR stays open until #17909 merges.

chenmingwei23 pushed a commit that referenced this pull request Oct 8, 2026
…anctioned _Server subclass (#17909)

* fix(design-tweak): route the dev proxy through _Server so the HTTPServer bind ratchet matches its baseline

test_http_server_bind_ratchet records _BASELINE_SITES = 15 but the tree
carries 16 bare HTTPServer((host, port), ...) constructions, so the ratchet
has been red on every main head since it was added in #17450 (which itself
shipped with 16 sites and a baseline of 15 -- the count was recorded one low).

Rather than bump the baseline, apply the fix the ratchet's own docstring
prescribes: subclass and call socketserver.TCPServer.server_bind so no host
name is resolved. _Server already subclasses ThreadingHTTPServer for the
address-reuse flag; give it the server_bind override (mirroring
plumb_cpu.LoopbackServer) and construct it from start_inject_proxy instead of
the stock ThreadingHTTPServer. That removes exactly one bare construction
(16 -> 15) and hardens the overlay-injecting dev proxy against the macOS
getfqdn stall the ratchet exists to prevent.

The bind-failure test's patch target moves with the construction
(ThreadingHTTPServer -> _Server); its assertion is unchanged.

Fixes #17908

* docs(session-control): drop the remote_target_unsupported refusal row

#17662 deleted the turn relay and with it every session_control.py raise of
remote_target_unsupported, but the session-control page still tabulates it, so
test_session_control_doc.py::test_every_tabulated_refusal_code_is_one_the_source_raises
is red on main (shard 6, both Linux and Windows).

This is the same one-line deletion as the open PR #17903. Carrying it here lets
both base reds -- the HTTPServer bind ratchet (shard 2, this PR's own fix) and
the doc row (shard 6) -- clear together, since #17903 fails on shard 2 and this
PR failed on shard 6, so neither could go green alone.

---------

Co-authored-by: cixuuz <26782336+cixuuz@users.noreply.github.com>
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Closing in favour of #17909, which carries this fix together with the other main-red fix (each alone stays red on the other test). Reopen if #17909 is not merged.

@iamwhatever iamwhatever closed this Oct 8, 2026
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 8, 2026
@iamwhatever
iamwhatever deleted the fix/session-control-doc-stale-row branch October 8, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main red: session-control doc tabulates removed refusal code remote_target_unsupported

2 participants