Repository navigation
docs(session-control): drop refusal row removed in #17662 - #17903
iamwhatever wants to merge 1 commit into
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS One thing to check: [DESIGN-REVIEWED] 23e307a Description read[DESCRIPTION-READ] 0e6d6fb7d8998d9c9f23c4b1345df64dc7ca301fa1861f0bc0bebc03a28ebac6 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The PR fixes the one doc row the test checks, but Not justified as shipped
What this change shipsInventory (1 items) — 0 justifiedIntent: get main's backend test shard green by removing a doc row for a refusal code that no longer exists. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 23e307a Description read[DESCRIPTION-READ] 4576b646f246f1a1347e633a2463d5a7541865759c662699f8a23561b8889dd2 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
#17907 now carries both halves, so each PR can go green alone; whichever lands first, the other only needs a rebase. |
#17662 deleted the turn relay and with it every session_control.py raise of remote_target_unsupported, but the session-control page still tabulates it, so test_session_control_doc.py::test_every_tabulated_refusal_code_is_one_the_source_raises is red on main (shard 6, both Linux and Windows). This is the same one-line deletion as the open PR #17903. Carrying it here lets both base reds -- the HTTPServer bind ratchet (shard 2, this PR's own fix) and the doc row (shard 6) -- clear together, since #17903 fails on shard 2 and this PR failed on shard 6, so neither could go green alone.
|
Heads up: these two PRs are in a shard deadlock on current To break it, #17909 now carries this PR's identical one-line deletion from |
|
Main has two reds:
We are backing #17909, which carries both fixes and keeps the ratchet at 15. This PR stays open until #17909 merges. |
…anctioned _Server subclass (#17909) * fix(design-tweak): route the dev proxy through _Server so the HTTPServer bind ratchet matches its baseline test_http_server_bind_ratchet records _BASELINE_SITES = 15 but the tree carries 16 bare HTTPServer((host, port), ...) constructions, so the ratchet has been red on every main head since it was added in #17450 (which itself shipped with 16 sites and a baseline of 15 -- the count was recorded one low). Rather than bump the baseline, apply the fix the ratchet's own docstring prescribes: subclass and call socketserver.TCPServer.server_bind so no host name is resolved. _Server already subclasses ThreadingHTTPServer for the address-reuse flag; give it the server_bind override (mirroring plumb_cpu.LoopbackServer) and construct it from start_inject_proxy instead of the stock ThreadingHTTPServer. That removes exactly one bare construction (16 -> 15) and hardens the overlay-injecting dev proxy against the macOS getfqdn stall the ratchet exists to prevent. The bind-failure test's patch target moves with the construction (ThreadingHTTPServer -> _Server); its assertion is unchanged. Fixes #17908 * docs(session-control): drop the remote_target_unsupported refusal row #17662 deleted the turn relay and with it every session_control.py raise of remote_target_unsupported, but the session-control page still tabulates it, so test_session_control_doc.py::test_every_tabulated_refusal_code_is_one_the_source_raises is red on main (shard 6, both Linux and Windows). This is the same one-line deletion as the open PR #17903. Carrying it here lets both base reds -- the HTTPServer bind ratchet (shard 2, this PR's own fix) and the doc row (shard 6) -- clear together, since #17903 fails on shard 2 and this PR failed on shard 6, so neither could go green alone. --------- Co-authored-by: cixuuz <26782336+cixuuz@users.noreply.github.com>
Problem / Motivation
Goal: Turn main's backend test shard green again by dropping a doc row for a refusal code the code no longer raises.
The session-control page still lists
remote_target_unsupported, so its doc-vs-source test fails on main.Why it matters
test/test_session_control_doc.py::test_every_tabulated_refusal_code_is_one_the_source_raisesis red on main and on every PR based on it.Not a goal
What changed (motivation → approach → change)
remote_target_unsupportedinsrc/kiro_crew/docs/session-control.mdsession_control.pyby #17662Why: #17662 deleted the remote-crew relay and its refusal code; #17450 kept the docs table row, which the test above rejects.
Backwards compatibility
Compatible: the code was already gone; only the doc catches up.
Reader: src/kiro_crew/docs/session-control.md:refusal-code table -- release --
test_session_control_doc.pyreads it and now passes (10 passed locally).Tests
No new tests;
test/test_session_control_doc.pypasses locally (10 passed).Manual verification
N/A — doc-only change covered by the doc test.
Related Issues
Closes #17902
Pattern harvest
Not generalizable: the doc test already guards this class; it caught the drift as designed.
Checklist