Repository navigation
feat: root session side panel shows its own Dynamic Dashboard - #18105
Conversation
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Opus 5.5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Session pages are filed by slot key, and slot keys are reused, so a new conversation in a reused slot inherits the previous conversation's dashboard. Watch
[DESIGN-REVIEWED] a193a00 Description read[DESCRIPTION-READ] df287559b6eea3392f94a180ef8f91684f81a3ec90e4281eea0a064c99f0a40d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The session store adds a second, pinned-descriptor write path. Member pages, written by the same gateway into the same data home, still use the plain path. Not justified as shipped
What this change shipsInventory (8 items) — 7 justifiedIntent: give a root session its own template-based dashboard in the chat side panel and retire the two overlapping preview surfaces. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] a193a00 Description read[DESCRIPTION-READ] f21bd8b8d73a46d84361fab3b07e1dd8fa35d7d8bda28b641a73109804e18126 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ human override accepted@chenmingwei23 overrode this lane for |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings that block the merge; one advisory finding below. FINDING — src/kiro_crew/dashboard/handlers/agent_panel.py:297 — [OPUS-REVIEWED] a193a00 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
7cf5a65 to
6866edb
Compare
6866edb to
dac0c26
Compare
|
This PR gives a root session's chat side panel its own template-based Dynamic Dashboard (new |
dac0c26 to
c0d0a44
Compare
|
Both blocking findings fixed in d941db4.
Local: tsc, eslint, i18n lint, and the full |
|
/ai-review override ux a457e1a: maintainer asked not to commit binaries; screenshots are linked in the description from branch screenshots/18022; collector cannot read them |
|
Rebased onto current On the rebased tree: isort/black/flake8/mypy clean on the changed Python; the backend tests for this change pass (including the dashboard server composition contract, so the MCP route table is unchanged); tsc and eslint clean; the 16 touched vitest files pass (615 tests); the static i18n checks and UX Review disposition: the BLOCK is "cannot evaluate: missing the Overview error states" — the two new states ( The two "Watch" items (the no-dashboard line on a non-root session should name and link the starting session; the reply inserted into the composer should drop the internal id) and the "Suggestions" item are advisory on this verdict and are tracked in the Follow-ups section of the description, not folded into this push. |
Human judgment recorded@chenmingwei23 marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
buluoray
left a comment
There was a problem hiding this comment.
Approving on a457e1a. This supersedes my earlier comment review on 994229c.
What was holding it, and where it stands on this head:
- Design sign-off -- posted on #18022.
- Spec drift -- fixed.
pipeline-conductor.mdnow says no panel reads atask-dashboardartifact and that the Overview is the session's catalog page, which matchesartifacts.md. - Staged session preview (iamwhatever's second point) -- fixed.
dashboardPreview.tsaddsSESSION_PREVIEW_PATH_REfor/api/chat/slots/<slot>/dashboard,CrewDynamicDashboardpassesstagedintoapi.sessionDashboard, anddashboardPreview.link.test.tsxpins the session link, the round-trip and the side-panel open. - Crewmate DM slot (third point) -- fixed.
CommandCenterPanel.tsx:87-89mounts the member target when the roster binds this slot to a crewmate, mounts nothing while the roster is pending, and shows an error instead of guessing when the roster read fails.commandCenterPanel.test.tsxcovers the DM page and both failure cases.
Checked against source on this head; I did not run the suites locally. At review time 88 checks passed, 8 skipped, 10 pending (review lanes and readiness), 0 failed.
Non-blocking, still open from my earlier pass: _writer_key has no test, and is_root_session returning True when the projection raises would read safer as fail-closed on the write gate.
|
/ai-review override ux a9109df |
|
AI-review override not recorded. Use |
Human judgment recorded@chenmingwei23 marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
Re: review 2026-10-10. Per-point status on the current head 1. pipeline-conductor spec (buluoray's open point). Fixed in 2. Session preview link. Fixed in 3. Crewmate DM slot gets the member target. Fixed in 4. Dispositions for Design, First Principles and UX. All three checks are green on this head: Design Review, First Principles Review and UX Review all report success, as do GPT 6.1 Review, PR Scope, Security scope candidates (Opus 5.5), and Publish readiness. The First Principles note that Head stays |
Human judgment recorded@chenmingwei23 marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
The chat side panel's Dashboard Overview now renders the root session's own
template-based Dynamic Dashboard, from the shared built-in catalog, with every
field folded from that session's own work ledger and crew log. Dispatched and
adopted sessions get no Overview.
- GET /api/chat/slots/{slot}/dashboard: the member dashboard read keyed by a
root session's slot, owner-only, app-denied, same render and redaction.
- Instance store gains a slot-keyed directory beside the member one.
- Dashboard MCP tools accept a root session writing its own page; dispatched,
adopted and slotless callers stay refused, and the crew webview publish
route is unchanged.
- CrewDynamicDashboard takes a member or session target.
- Removes the status-tile HUD above the composer and the agent-published
task-dashboard Overview, with their tests, i18n keys and prompt text.
Behind PREVIEW_DASHBOARD as before.
Refs #18022
A dashboard-only ErrorBoundary now wraps the lazy Overview Suspense, so a failed chunk import stays contained and the Questions tab's unsent answer draft survives instead of being unmounted with the whole panel. A failed roster refresh is reported even when a cached DM row remains: rosterFailed is roster.isError, so the error notice renders while the cached DM dashboard stays mounted.
|
/ai-review override ux a193a00: Rebase-only head onto current main with no UI change since the human-accepted a457e1a, a9109df and 7fef09e; the UX BLOCK is evidence-only (the two transient error-state notices command-center-roster-error and command-center-overview-error cannot be screenshotted into the committed stills). Error-state screenshots are embedded in the PR body / linked from branch screenshots/18022; the collector cannot read them. |
Human judgment recorded@chenmingwei23 marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Problem / Motivation
Goal: A root session's chat side panel shows that session's own template-based Dynamic Dashboard, and the two older dashboard surfaces go away.
Three surfaces do one job today. A crewmate's Dashboard tab is composed from declared fields plus a shipped template (
CrewDynamicDashboard,GET /api/members/{slug}/dashboard). The chat side panel's Dashboard is HTML the agent writes itself (TaskDashboardFrame, atask-dashboardartifact). The status-tile HUD above the composer (CommandCenterDock,StatusTiles,TileList) is a third, hand-built readout. A session gets no template-based page at all.Why it matters
A model-written page spends tokens on every refresh and can state a number the crew log does not support; the declared-field path cannot. The surfaces drift, so the same work reads differently depending on where you look. The tiles take vertical space above the composer in every session, including worker and subagent sessions that have nothing session-level to report.
Not a goal
project-reportonly gains session wording for its heading.SessionStatusFrame) or the all-session page beyond dropping its published-view selector.What changed (motivation → approach → change)
Approach: reuse the declared-field dashboard that already serves a crewmate, keyed by a root session's slot instead of a member slug, rather than building a fourth surface.
GET /api/chat/slots/{slot}/dashboard(member_dashboard.api_session_dashboard) shares the member route's body (_serve,_render,_safe_body,_page_saferedaction). It is owner-only and denies app callers, like the member route. Root is the existingcard_lifecycle.is_root_session(slot), with no new root test; a dispatched or adopted session is answered 404not_root_session. Every fold a field reads comes from that slot (read_fields(..., slot=)). The route is bound through the deferred binder.instance.session_instance_key(slot)files a session's instance undersession-dashboards/<sha256[:32]>, beside the member directories. A key not exactly that shape is refused before it reaches a path.subject(crewmate|session), soproject-reportreads "What this session is doing" on a session page (English only; the zh-CN string waits on feat(dashboard): render built-in dashboard pages in the reader's UI language #18014)._resolve_publishing_crewinsrc/kiro_crew/dashboard/handlers/agent_panel.pygains aroot_sessionbranch, passed only by_resolve_dashboard_caller(thedashboard_fields/write/templates/preview/apply/rollbackroutes). It runs after every existing gate: internal secret,agent.crew_panel, app denial, strict session identity, restricted mode, slot check. A caller bound to no crew then resolves to its OWN slot's store key, and only whenis_root_session(slot)holds. Otherwise it gets 403not_root_session, audited like every other refusal. A slotless subagent still getsno_dashboard_slot. The crew webview publish route does not take the branch and still answersno_crew. An unseeded session tree fails closed. Session writes broadcast{slot}.CommandCenterPanelpassesonActto the session dashboard;SidePanelforwards it fromChatPage, which merges the reply into this chat's composer and focuses it. Nothing is sent until the person sends it.commandCenter.no_dashboard_here, in place of the missing Overview.CommandCenterPanel's Overview mountsCrewDynamicDashboardwith a session target. The component takesDashboardTarget = member | sessionrather than being copied. A non-root session loses the Overview segment and opens on Questions.CommandCenterDock.tsx,StatusTiles.tsx,TileList.tsxand their wiring inChatPane.tsx/ChatPage.tsx), and the agent-published task-dashboard Overview (TaskDashboardFrame.tsx,commandCenter.prompt.ts/REQUEST_PUBLISHED_VIEW, thetask-dashboardartifact source inuseCommandCenter, the all-session page's published-view selector). Their tests, 26 deadcommandCenter.*i18n keys and the dock capture script went with them.PREVIEW_DASHBOARDfeature preview.agent.pyand the artifacts, goal-conductor and pipeline-conductor skills still describe publishing atask-dashboardartifact. Those prompts reach every user whether or not the preview is on, so changing them is left out of this PR. Retiring that text is a follow-up for afterPREVIEW_DASHBOARDdefaults on.RFC:
docs/request-for-change/rfc-crewmate-dynamic-dashboard.md(in-progress) records the declared-field dashboard. It does not record removing the HUD and the published Overview. That decision was taken on #18022 by the issue's owner.Backwards compatibility
Compatible: every route that answers today still answers the same body. The new route and the store directory are additive. The gate change only admits a caller that was refused
no_crewbefore, and only to its own slot.Reader:
website/src/components/ChatPane.tsx:CommandCenterDock-- chat -- render andonOpenCommandCenterprop removed;ChatPage.dockSearchClose.test.tsxasserts no dock rendersReader:
website/src/pages/ChatPage.tsx:CommandCenterDock/openCommandCenter-- chat -- removed; the side-panel tab is still opened from the + menuReader:
website/src/pages/chat/command-center/CommandCenterPanel.tsx:TaskDashboardFrame,REQUEST_PUBLISHED_VIEW-- chat -- replaced byCrewDynamicDashboard;commandCenterPanel.test.tsxReader:
website/src/pages/chat/command-center/SessionDashboardsPage.tsx:TaskDashboardFrame-- crew page (/session-dashboards) -- selector removed, automatic card kept;sessionDashboards.test.tsxReader:
website/src/pages/chat/command-center/SessionStatusFrame.tsx:TASK_DASHBOARD_SANDBOX-- chat -- constant moved into this fileReader:
website/src/pages/chat/command-center/useCommandCenter.ts:TASK_DASHBOARD_TAG,dock,relevant,finished-- chat -- only the dock read them;commandCenterSources.test.tsxReader:
website/src/i18n/locales/*.json:commandCenter.*(26 keys) -- release -- no remaining source reference;commandCenterRetired.test.tsguards the namesReader:
website/src/utils/storageGc.ts:mc-task-dashboard-dismissed:-- chat -- kept so old browsers still collect itTests
test/test_session_dashboard.py(new, 19):not_root_session; an unknown slot gets 404;subject: session, a crewmate pagecrewmate, andproject-reportswitches its heading.test_agent_panel_routes(the resolver refusal count goes from 7 to 8),test_member_dashboard_routes(structural test admits the session read),test_dashboard_frame(payload shape gainssubject).commandCenterPanelcovers root vs worker vs adopted, no mount while inactive, and questions kept out of the Overview;CrewDynamicDashboardcovers the session target reading the slot route and invalidation by slot;commandCenterRetiredchecks that no source names the removed HUD or published-Overview parts;commandCenterSources,sessionDashboards,ChatPage.dockSearchClose,statusStackLayering,Glass.thickness,MembersPage,CrewDashboardTabandstorageGcwere trimmed to match.Manual verification
Pod for this branch with the preview on. Seeding:
created_byset to the root.What the shots show:
project-reportfrom its own ledger: "Ship the 0.9 release", 3 in flight, 1 of 4 accepted, the blocked item under Needs you.command-center-dockorstatus-tiles.Screenshots / video
Root session: the Overview is its own Dynamic Dashboard, the heading reads "What this session is doing", and nothing sits above the composer.
Root session: clicking a reply option on the page ("Re-dispatch it") puts that reply in this session's composer, where the person sends it.
Dispatched worker session, on this head: no Overview segment. The muted line reads "This session's work shows on the dashboard of the session that started it." The session's
created_bynames the root.One
/session-dashboardscard after the change: the published-view selector and its "no published view" line are gone. The card keeps its status, the automatic card notice and the saved summary.The earlier stills of the dispatched and adopted sessions came from a revision before the no-dashboard line, and they show only Questions and Approvals. The two stills above replace them as evidence for this head.
Roster read forced to fail (
/api/members500): the Overview shows oneErrorNoticeabove where the page would be, and mounts no page.Overview chunk forced to fail (
CrewDynamicDashboardchunk aborted): the boundary shows the same notice, and the Questions and Approvals tabs stay usable.Related Issues
Fixes #18022
Follow-up, after
PREVIEW_DASHBOARDdefaults on: retire thetask-dashboardprompt text inagent.pyand the three skills.Sequenced with #18014 (dashboard i18n); the zh-CN heading string lands after it.
Follow-ups
Out of scope here, tracked for later:
task-dashboardprompt text inagent.pyand the artifacts, goal-conductor and pipeline-conductor skills, afterPREVIEW_DASHBOARDdefaults on.KIROCREW_CREW_LOGoff the session tree never seeds, sois_root_sessionanswers false and every root session's Overview gets 404not_root_sessionwhile the panel still offers it. Align the client and server root tests.project-reporttitle stays "Project report". Using the session title needs a new payload field, redaction and template code, so it is more than a one-line change.dashboard_none_yetsession wording.onOpenSession.pinned_fs.create_and_open_dir_atand the two_refuse_linked_*helpers ininstance.pywithpinned_fs.open_pinned_descendant_dir(data_home(), ("session-dashboards", digest), create=True), keeping the race and junction tests.session-tags-e2e.spec.ts17b fails in CI on unrelated PRs on the same main base too (e.g. fix/crew-warm-greeting, feat/default-template-picker-18411, feat/mate-first-crewmate, fix/publish-visibility-p0). Locally the spec passes alone and as a whole file on both origin/main 3387bdd and this branch. In the CI trace, rowA.click scrolls row A to the top of the session list, so row B sits under the sticky search bar and the backdrop right-click at y=105 lands on the bar instead of row B. Left for a separate fix of the spec geometry.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.