Skip to content

feat(members): swipe drawers on the phone Crewmates page - #19086

Merged
buluoray merged 1 commit into
mainfrom
feat/crewmates-mobile-drawer
Oct 12, 2026
Merged

buluoray merged 1 commit into
mainfrom
feat/crewmates-mobile-drawer

Conversation

@buluoray

@buluoray buluoray commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On a phone, the Crewmates page works like the Sessions page: it opens on a chat, a rightward swipe brings in a drawer with the nav rail and the crewmate list, and a leftward swipe opens the side panel.

On a phone the Crewmates page is a two-level list today. The roster is its own page, a tap opens a chat, and the back arrow returns to the list. The Sessions page lands on a chat and keeps its list in a swipe-in drawer beside the nav rail. Going between the two pages means switching between two ways of getting around, and a rightward swipe on Crewmates only reaches the shell's nav drawer.

Why it matters

Sessions and Crewmates are the two conversation lists, and on a phone they should behave the same way. With one drawer model, a user who has learned to swipe for their sessions can do the same for their crewmates, and can open the side panel on either page with the same leftward swipe.

Not a goal

  • Changing the desktop or tablet layout. Above the mobile breakpoint nothing moves.
  • Changing the roster's own rows, filters, sort or search.
  • Changing the chat page's own drawer, apart from the rail's Home button no longer closing a drawer when its host is not the chat page.

What changed (motivation → approach → change)

Before (phone) After (phone)
Open Crewmates full-page roster the remembered crewmate's chat
Swipe right shell nav drawer drawer: nav rail + crewmate roster
Swipe left nothing side panel (Dashboard, Files)
Header left button back arrow to the roster page the Sessions page's drawer toggle; opens the drawer
Back with drawer open n/a closes the drawer, stays on the crewmate

The Sessions page's drawer is already built from shared parts, so this page reuses them rather than building its own: useDrawerSwipe for the finger-tracked gesture, animateDrawer/registerDrawerTargets for the compositor settle, OverlayDrawer for the panel, and MobileNavRailContext for the rail (website/src/components/MobileNavRailContext.ts), which App.tsx now also provides on /members. The roster aside is portaled into the drawer while a chat or a team is open. With nothing open, the roster is still the page, and the page claims no swipe.

The drawer pushes a duplicate history entry the way the Sessions drawer does, so Back closes it. A pick in the drawer pops that entry first and then switches crewmates on the entry below. Otherwise the switch would land on the duplicate and Back would bring back the crewmate just left. The rail's Home button navigates without closing the drawer when its host is not the chat page, for the same reason, and asks the page's leave guard first, as every rail row does, so an unsaved Profile schedule draft is not dropped. The drawer and its scrim follow the visible area above the software keyboard, as the chat drawer does. When the leave guard has already parked its own duplicate entry (an unsaved Profile schedule), the drawer adds no entry of its own, so closing it cannot carry the user past the guard. Opening a crewmate always replaces the entry, so Back leaves the page in one press after the first crewmate is created from an empty roster.

On a phone the header's left control wears the Sessions page's own drawer toggle icon (PanelLeftSolid / PanelLeftLight, with aria-expanded) instead of a back arrow, since it now opens a drawer rather than leaving the page. The phone's "no auto-open" rule in MembersPage.tsx is removed, so the phone lands like a wide window. The side panel's phone overlay slides on its own motion value, so a leftward drag can open it and a rightward drag can close it. The Dashboard tab is a sandboxed iframe, and a touch on an iframe never reaches the page, so the Dashboard frames (CrewDynamicDashboard.tsx, CrewWebview.tsx) are built with a new opt-in relayTouches in website/src/lib/widgetSrcdoc.ts: the frame posts its one-finger touches to the page, which replays them onto the frame element only while the panel is open, so the one gesture they can drive is that panel's close. The relay stays silent inside a horizontal scroller, an editable or a text selection. website/docs/narrow-viewport.md gains a paragraph on the Crewmates drawer.

Backwards compatibility

Compatible: desktop and tablet widths render exactly as before, and the phone keeps every destination it had (roster, team views, create flows, side panel). Only the way you reach them changes.

Removes nothing: the phone roster still exists and still has every control. It is shown in a drawer instead of as a page. The header control keeps its members.back UI location and opens the drawer, so guides that point at it still reveal the roster. Its label changes from "Back to crewmates" (back_to_roster) to "Toggle crewmates" (toggle_roster), the same form as the Sessions page's "Toggle sessions", because it now opens and closes a drawer. The guide index is regenerated to match.

Tests

  • MembersPage.test.tsx (phone block): lands on the remembered crewmate with the drawer closed, and the header control draws the drawer-toggle panel glyph (no back arrow) with aria-expanded false, then true once the drawer opens; a real touch drag right opens the roster drawer, then a drag left opens the side panel overlay, and a drag right closes it again; the back arrow pushes one duplicate entry, and a pick pops it (navigate(-1)) before switching; Back with the drawer open closes it and the next Back leaves the page; a scrim tap closes it; a team header in the drawer opens the team view and its Back reopens the drawer; the guided flow retires the drawer; a stale ?member= opens a stand-in with the notice; Profile does not follow a drawer switch; with no crewmates the page claims no swipe. The old two-level-list cases are replaced.
  • App.mobileSingleTopbar.test.tsx: /members on a phone gets the rail; its Home button stays put while the page's leave guard refuses, then leaves without closing the host drawer.
  • A drawer "+" spends the drawer's history entry; a guide pushing the create link over the open drawer does not pop the guide's entry.
  • MembersPage.test.tsx (phone block, continued): on the leave guard's own duplicate entry the drawer pushes and pops nothing; the first crewmate created from an empty roster opens on a replace, so one Back leaves the page; a drag relayed by a frame in the open panel closes it, and the same messages from any other window do nothing.
  • widgetSrcdocTouchRelay.test.tsx runs the real relay script: injected only on request and ahead of the page body; a one-finger drag reports start, move and end; a touch in a horizontal scroller or an input reports nothing; a second finger cancels.
  • mobilePanels.compositor.test.ts: MembersPage.tsx joins the files that must declare data-owns-swipe when they bind a drawer gesture.
  • Mutation checks: each of these goes red when undone — the rail Home close, the Home leave-guard ask, the roster swipe's enabled, pop-before-switch, the data-owns-swipe claim, both directions of the create-flow entry check, the leave-guard duplicate check, and the replace on open.
  • No test is time- or order-dependent: the drags are synthetic touch events and the settles finish in framer's test path.

Manual verification

Ran an isolated pod for this worktree with an iPhone 13 profile in Playwright and dispatched real CDP touch drags: the page landed on a crewmate, a right drag opened the drawer with the rail and roster, and a left drag opened the side panel. The drawer was checked against the Sessions drawer in the same pod: same height, same rail, "Search all" fully visible. With a sandboxed frame carrying the relay mounted in the Dashboard tab, a real touch drag from the middle of the frame closed the side panel; without the relay the same drag did nothing.

#18447 (an automated GUI lane) reports that a desktop visit landing straight in a chat surprised a first-time tester. This PR does not change desktop, but it does bring that landing to the phone, which is the behaviour this PR is asked to add.

Screenshots / video

Phone (iPhone 13 profile), isolated pod:

Lands on the remembered crewmate

Captured on an earlier head, before the header change: the left control is still the old back arrow. The header screenshot below shows the current drawer toggle.

Swipe right: nav rail and crewmate roster

Header: the Sessions-style drawer toggle on the left

Swipe left: side panel

Recording (phone profile, isolated pod, about 20 s). It shows the Sessions page's drawer for comparison, then the Crewmates page: landing on the remembered crewmate, a finger drag right that opens the nav rail and roster drawer, and a drag left that opens the side panel. It was recorded on an earlier head, so the header's left control is still a back arrow. That control is now the Sessions-style drawer toggle shown in the header screenshot above. The gestures are the same.

phone-crewmates-drawers.mp4

Related Issues

Closes #19084

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners October 11, 2026 10:37
@buluoray
buluoray requested a review from bolichen97 October 11, 2026 10:37
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 11, 2026
@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🟡 CONCERNS

Premise-level review of 1c7470854e58e9213fdc1c65b8ea8866e1dbb526 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The phone landing reversal rests only on symmetry with Sessions, and the touch relay out of the Dashboard frame is a large mechanism for a gesture the panel's toggle already covers.

Not justified as shipped

  • Item 1 — inherited: the only grounds given are "on a phone they should behave the same way". This reverses a recorded rule ("Below md the page is a two-level list->detail navigation: no ?member= IS the roster") and its test ("nothing auto-opens, as on main"). No report shows phone users failing with the list.
    Clears when: a linked issue or report shows phone users struggling with the two-level roster.
  • Item 8 — oversized: relayTouches adds an injected script, a new mc-frame-touch message type and a replay path. All of that exists only so that "the phone side panel's closing drag starts over this frame". The overlay's opener still closes the panel, and a swipe still works on Files.
    Subtraction: delete relayTouches / FRAME_TOUCH_RELAY_BODY and the page-side replay; the Dashboard tab closes with the existing toggle.
    Clears when: the relay is removed, or a report shows the toggle is not enough.

What this change ships

Inventory (8 items) — 6 justified

Intent: on a phone, get around Crewmates with the same drawers as Sessions. ADDITION.

  1. Phone Crewmates opens on the remembered crewmate's chat, not the roster — inherited
  2. A right swipe opens a drawer with the nav rail and the roster — justified
  3. A left swipe opens the side panel; a right swipe closes it — justified
  4. The header's back arrow becomes a drawer toggle, relabelled "Toggle crewmates" — justified
  5. Back closes the drawer; a pick pops the drawer's history entry first — justified
  6. The nav rail is provided on /members — justified
  7. The rail's Home button asks the leave guard and no longer closes another page's drawer — justified
  8. The Dashboard frames relay touches to the page so a drag over them closes the panel — oversized

[FIRST-PRINCIPLES-REVIEWED] 1c74708

Description read

[DESCRIPTION-READ] 4afd10df74e83e4b163019cdb64db49c46d122ba8d78743da2cd589534ec5e95

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 1c7470854e58e9213fdc1c65b8ea8866e1dbb526 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Before merge, check on a real iOS Safari device that Back works with an unsaved Profile schedule draft open. The drawer's pop-then-switch history handling is only proven in synthetic tests.

[DESIGN-REVIEWED] 1c74708

Description read

[DESCRIPTION-READ] 9c8101262f47004a9a80604850b9521dbd8f06db3c0fb796a0e09b05d0f71f05

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of 1c7470854e58e9213fdc1c65b8ea8866e1dbb526 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The new header button that opens the crewmate drawer only got "a guess" from a cold reader, and nothing on screen shows that the swipes exist.

Watch

  • Main control was only guessed at. The back arrow is replaced by PanelLeftSolid/PanelLeftLight, labelled "Toggle crewmates". The blind reader read shot-03's button correctly ("opens the left menu (the one in shot 2)") but rated it "a guess". Their reason: "I'm not sure why there's a back arrow in shot 1 but a menu button here". Shot-01 is the before state, so the confusion comes from the evidence, not the UI. Still, this button is the only visible way into the roster now. Users who don't know the swipe rely on it every time they switch crewmates, so the risk is moderate. It uses the same icon as the Sessions page's toggle, which helps anyone who has learned that page; first-time phone users get no hint.
  • Swipes are invisible. A swipe right opens the roster drawer and a swipe left opens the side panel, and no screen hints at either. On this page that's acceptable only because the header buttons cover both, so keep both toggles visible. Low severity.

Suggestions

  • In the description, mark shot-01 as "before" and shot-03 as "after". Otherwise human reviewers will hit the same arrow-versus-toggle confusion the blind reader did.

[UX-REVIEWED] 1c74708

Description read

[DESCRIPTION-READ] 25ee87d8b03354ed4f1b5952e9bf5af3e1d4e4f06786d4401a5e7d6a9a9f7c1b

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 1c7470854e58e9213fdc1c65b8ea8866e1dbb526 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 1c74708

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 1c7470854e58e9213fdc1c65b8ea8866e1dbb526: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 1c7470854e58e9213fdc1c65b8ea8866e1dbb526 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1c74708

Verdict parsed from the review's SHA-scoped output markers for commit 1c7470854e58e9213fdc1c65b8ea8866e1dbb526.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 1c7470854e58e9213fdc1c65b8ea8866e1dbb526: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 11, 2026
@buluoray
buluoray force-pushed the feat/crewmates-mobile-drawer branch from 4b81f0a to c0f5e2e Compare October 11, 2026 19:46
@buluoray

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles c0f5e2e: agent, on Ray's (buluoray) explicit instruction: the product owner decided the phone Crewmates page should work like the phone Sessions page (land on a chat, roster in the swipe drawer beside the nav rail, side panel on a left swipe), superseding rfc-crewmates-launch.md resolution 3 for narrow viewports.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for c0f5e2ec953242f0c01f29b38ce91c9fed5f864f.

agent, on Ray's (buluoray) explicit instruction: the product owner decided the phone Crewmates page should work like the phone Sessions page (land on a chat, roster in the swipe drawer beside the nav rail, side panel on a left swipe), superseding rfc-crewmates-launch.md resolution 3 for narrow viewports.

This decision applies only to this commit. A new push requires a new judgment.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • Drawer dismissal disarms the unsaved-draft Back guard span=e7ac5689c151 (fixed)

fixed in c0f5e2e: standing on NavigationBackGuard's own duplicate (isTrapEntry), the drawer pushes no entry and so pops none on close; Back with the drawer open is the guard's own question.
Test: "on the leave guard's own duplicate entry the drawer pushes and pops nothing"; removing the isTrapEntry check reddens it.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • Mark the click-away backdrop presentational span=e7ac5689c151 (fixed)

fixed in c0f5e2e: role="presentation" on the roster drawer backdrop.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • Give lazy-route waits explicit deadlines span=945e1c4a2840 (fixed)

fixed in c0f5e2e: both waits behind App's React.lazy /members and /chat routes carry LAZY_ROUTE (5000ms) with a comment naming the lazy boundary.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • openMember still pushes fromRoster on a phone span=84c72a0aa725 (fixed)

fixed in c0f5e2e: opening a crewmate always replaces the entry; the phone lands a bare /members on a crewmate itself, so a pushed step would bounce Back into it.
Test: "the first crewmate created from an empty roster opens on a replace, so one Back still leaves the page"; restoring the push reddens it.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • The pop-before-switch order depends on a timeout span=2938aa959d33 (fixed)

fixed in c0f5e2e: the switch runs only from the router's report of the matching POP. The timeout no longer runs the pick; it only drops a pick whose pop never reported, so a late pop cannot reopen the previous crewmate.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • The history handling is copied, not shared span=0943f36ac22c (rebutted)

The two implementations are kept separate on purpose. ChatPage's entry handling is coupled to its sid effect (drawerPopRef tells that effect a POP is bookkeeping), which MembersPage does not have, and MembersPage needs pop-then-pick and the leave-guard duplicate check, which ChatPage does not.
Extracting one shared hook means changing ChatPage's drawer, which is outside this PR's frozen goal; the gesture, settle, panel and rail are the shared parts and are reused unchanged.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • The back arrow no longer goes back span=2003d67be993 (rebutted)

The control still takes the user to the crewmate list, which is what its label "Back to crewmates" names; only the list is now a drawer instead of a page.
Keeping it in place keeps existing phone users' muscle memory and the members.back UI location that guides point at.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • The side panel shows nothing of the chat behind it span=da461b5109aa (rebutted)

The phone side panel fills the window on the Sessions page too (the #9979 fillWidth rule this page already follows); this PR keeps the two pages identical rather than giving Crewmates a different panel shape.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • Leave a visible strip of chat beside the phone side panel span=ad3c3e692575 (rebutted)

Same reason as the previous item: a strip would make the Crewmates panel differ from the Sessions panel it mirrors, and changing both is a separate UI decision outside this PR's goal.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • Product-shape change without accepted RFC span=7a9d54ffac6b (rebutted)

The product owner (buluoray) decided the phone Crewmates page should work like the phone Sessions page, superseding rfc-crewmates-launch.md resolution 3 for narrow viewports.
Recorded as /ai-review override first-principles on the new head c0f5e2e (issuecomment-6113001478).

@buluoray

Copy link
Copy Markdown
Contributor Author
  • Product-shape change without accepted RFC span=48a66e5738c8 (rebutted)

The product owner (buluoray) decided the phone Crewmates page should work like the phone Sessions page, superseding rfc-crewmates-launch.md resolution 3 for narrow viewports.
Recorded as /ai-review override first-principles on the new head c0f5e2e (issuecomment-6113001478).

@buluoray

Copy link
Copy Markdown
Contributor Author
  • Product-shape change without accepted RFC span=7df0fbc1ae58 (rebutted)

The product owner (buluoray) decided the phone Crewmates page should work like the phone Sessions page, superseding rfc-crewmates-launch.md resolution 3 for narrow viewports.
Recorded as /ai-review override first-principles on the new head c0f5e2e (issuecomment-6113001478).

@buluoray

Copy link
Copy Markdown
Contributor Author
  • Product-shape change without accepted RFC span=fd38be7f3bb3 (rebutted)

The product owner (buluoray) decided the phone Crewmates page should work like the phone Sessions page, superseding rfc-crewmates-launch.md resolution 3 for narrow viewports.
Recorded as /ai-review override first-principles on the new head c0f5e2e (issuecomment-6113001478).

@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 11, 2026
@buluoray

Copy link
Copy Markdown
Contributor Author

Rebased onto main 38eb463 (new head 22460cd) for a conflict in the generated src/kiro_crew/docs/ui-index.generated.json only, after #18438 landed. Took main's copy and regenerated with npm run gen:ui; a second run leaves the tree clean. The range-diff changes only that generated file. src/uiLocations and src/pages/members: 40 files, 1066 tests pass.

@buluoray

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 22460cd: agent, on Ray's (buluoray) explicit instruction: the product owner decided the phone Crewmates page should work like the phone Sessions page (land on a chat, roster in the swipe drawer beside the nav rail, side panel on a left swipe), superseding rfc-crewmates-launch.md resolution 3 for narrow viewports.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • only reason given is symmetry span=3499fa720eb2 (overridden)

The product owner ruled on this; see the override on this head, which restates issuecomment-6113001478. The symmetry with the phone Sessions page is the decision itself, not an inference from it.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • header control moves from Back to Toggle crewmates span=35f687ccd6fc (overridden)

The product owner ruled on this; see the override on this head, which restates issuecomment-6113001478. The Sessions-style drawer toggle replaced the back arrow on Ray's (buluoray) ruling 6115985539, so the two pages open their drawer the same way.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • product-shape change without accepted RFC span=9ff738513847 (overridden)

The product owner ruled on this; see the override on this head, which restates issuecomment-6113001478. It supersedes rfc-crewmates-launch.md resolution 3 for narrow viewports.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • history logic duplicated, not shared span=4a0da8f655c1 (rebutted)

Re-raise of spans 0943f36ac22c and b73bde28229f, answered in issuecomment-6113032160: extracting one hook changes ChatPage's drawer, outside this PR's goal, and the two copies differ (ChatPage couples to its sid effect; MembersPage needs pop-then-pick and the leave-guard duplicate check).

@buluoray

Copy link
Copy Markdown
Contributor Author
  • move the iframe touch replay into OverlayDrawer span=ed315c3e6bf0 (declined)

Only the two crewmate frames need the relay today, so it stays with the page that owns them. Moving it into OverlayDrawer would also change the Sessions drawer, which is outside this PR's goal.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • header toggle only guessed at span=5fb84ff69358 (kept)

The reader guessed right. It is the Sessions page's own drawer toggle, used here on Ray's (buluoray) ruling (6115985539). It is named Toggle crewmates and reports aria-expanded. The first screenshot is now captioned as taken before the header change.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • last rail label in the drawer is cut off span=1779afeba3e8 (kept)

This is the shared navigation rail, rendered by the same App rail component the phone Sessions drawer uses, and its label looks the same there. This PR does not change the rail.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • Toggle names the mechanism, not the result span=8bdfbccee652 (declined)

The label mirrors the Sessions page's Toggle sessions on the same control, and aria-expanded carries the open state. Renaming one page alone would split the pair; renaming both touches the Sessions page, outside this PR's goal.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 22460cd547b87ab3d581d3b40af16fef279e7e3c.

agent, on Ray's (buluoray) explicit instruction: the product owner decided the phone Crewmates page should work like the phone Sessions page (land on a chat, roster in the swipe drawer beside the nav rail, side panel on a left swipe), superseding rfc-crewmates-launch.md resolution 3 for narrow viewports.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 12, 2026
On a phone the Crewmates page now works like the Sessions page. A bare
visit lands on the remembered crewmate, a rightward swipe or the header
back arrow slides in a drawer with the navigation rail beside the
roster, and a leftward swipe opens the side panel. A pick in the drawer
pops the drawer's history entry before switching, so Back never reopens
the crewmate just left.

Closes #19084
@buluoray
buluoray force-pushed the feat/crewmates-mobile-drawer branch from 22460cd to 1c74708 Compare October 12, 2026 16:20
@buluoray

Copy link
Copy Markdown
Contributor Author
  • phone side panel starts at its open position span=84c72a0aa725 (fixed)

Fixed in 1c74708: sidePanelX now starts at the window width, so the panel is inserted offscreen and an open that is not a discrete event cannot paint it at rest before the seating effect runs. The new test the side panel first mounts offscreen... reads the slide's transform at the moment React inserts it; it is none without the fix and translateX(390px) with it. src/pages/members: 28 files, 664 tests pass; tsc and eslint clean.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • phone landing reversal rests only on symmetry span=0e7e24270df8 (rebutted)

The product owner (buluoray) ruled on this; see issuecomment-6113001478, restated in every override on this PR. The symmetry with the phone Sessions page is the decision itself, not an inference from it.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • touch relay is oversized for a gesture the toggle covers span=c4a28b15fa70 (rebutted)

The phone Sessions side panel closes by a drag from anywhere, and this page matches it on the owner's ruling. An edge grip was tried on this branch first and removed: a strip narrow enough to leave the Dashboard usable is hard to hit. The relay is opt-in per host, carries only touch coordinates, is accepted only from the frame's own window while the panel is open, and only the two crewmate frames enable it.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • check Back with an unsaved Profile schedule draft on real iOS Safari (rebutted)

The product owner (buluoray) ran this build on a real iPhone and reports the drawers and the side panel all work. Back with a schedule draft open is a browser history pop, the same POP the tests drive through the router: on the guard's duplicate entry the drawer pushes and pops nothing, so Back still asks before dropping the draft.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • main control only guessed at span=2a95ec5f0851 (kept)

The reader guessed right. It is the Sessions page's own drawer toggle, used here on Ray's (buluoray) ruling (6115985539). It is named Toggle crewmates and reports aria-expanded. The first screenshot is now captioned as taken before the header change.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • swipes are invisible span=e4270cfbbcd0 (kept)

Same affordance as the phone Sessions page: visible header buttons open both drawers, and the swipe is a shortcut on top. A swipe hint was answered in 6114289402 and left out to match Sessions.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • mark shot-01 as before and shot-03 as after span=7592b58ee3a1 (fixed)

The PR description now captions the first screenshot as captured on an earlier head with the old back arrow, and points to the header screenshot for the current toggle.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 12, 2026
@buluoray
buluoray merged commit 2c2419d into main Oct 12, 2026
102 checks passed
@buluoray
buluoray deleted the feat/crewmates-mobile-drawer branch October 12, 2026 17:30
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crewmates on a phone: swipe drawers like the Sessions page

2 participants