Repository navigation
feat(members): swipe drawers on the phone Crewmates page - #19086
Conversation
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The phone landing reversal rests only on symmetry with Sessions, and the touch relay out of the Dashboard frame is a large mechanism for a gesture the panel's toggle already covers. Not justified as shipped
What this change shipsInventory (8 items) — 6 justifiedIntent: on a phone, get around Crewmates with the same drawers as Sessions. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 1c74708 Description read[DESCRIPTION-READ] 4afd10df74e83e4b163019cdb64db49c46d122ba8d78743da2cd589534ec5e95 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Before merge, check on a real iOS Safari device that Back works with an unsaved Profile schedule draft open. The drawer's pop-then-switch history handling is only proven in synthetic tests. [DESIGN-REVIEWED] 1c74708 Description read[DESCRIPTION-READ] 9c8101262f47004a9a80604850b9521dbd8f06db3c0fb796a0e09b05d0f71f05 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The new header button that opens the crewmate drawer only got "a guess" from a cold reader, and nothing on screen shows that the swipes exist. Watch
Suggestions
[UX-REVIEWED] 1c74708 Description read[DESCRIPTION-READ] 25ee87d8b03354ed4f1b5952e9bf5af3e1d4e4f06786d4401a5e7d6a9a9f7c1b That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
4b81f0a to
c0f5e2e
Compare
|
/ai-review override first-principles c0f5e2e: agent, on Ray's (buluoray) explicit instruction: the product owner decided the phone Crewmates page should work like the phone Sessions page (land on a chat, roster in the swipe drawer beside the nav rail, side panel on a left swipe), superseding rfc-crewmates-launch.md resolution 3 for narrow viewports. |
Human judgment recorded@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Rebased onto main 38eb463 (new head 22460cd) for a conflict in the generated |
|
/ai-review override first-principles 22460cd: agent, on Ray's (buluoray) explicit instruction: the product owner decided the phone Crewmates page should work like the phone Sessions page (land on a chat, roster in the swipe drawer beside the nav rail, side panel on a left swipe), superseding rfc-crewmates-launch.md resolution 3 for narrow viewports. |
|
|
|
|
|
|
|
|
Human judgment recorded@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
On a phone the Crewmates page now works like the Sessions page. A bare visit lands on the remembered crewmate, a rightward swipe or the header back arrow slides in a drawer with the navigation rail beside the roster, and a leftward swipe opens the side panel. A pick in the drawer pops the drawer's history entry before switching, so Back never reopens the crewmate just left. Closes #19084
22460cd to
1c74708
Compare
|
|
|
|
|
|
|
Problem / Motivation
Goal: On a phone, the Crewmates page works like the Sessions page: it opens on a chat, a rightward swipe brings in a drawer with the nav rail and the crewmate list, and a leftward swipe opens the side panel.
On a phone the Crewmates page is a two-level list today. The roster is its own page, a tap opens a chat, and the back arrow returns to the list. The Sessions page lands on a chat and keeps its list in a swipe-in drawer beside the nav rail. Going between the two pages means switching between two ways of getting around, and a rightward swipe on Crewmates only reaches the shell's nav drawer.
Why it matters
Sessions and Crewmates are the two conversation lists, and on a phone they should behave the same way. With one drawer model, a user who has learned to swipe for their sessions can do the same for their crewmates, and can open the side panel on either page with the same leftward swipe.
Not a goal
What changed (motivation → approach → change)
The Sessions page's drawer is already built from shared parts, so this page reuses them rather than building its own:
useDrawerSwipefor the finger-tracked gesture,animateDrawer/registerDrawerTargetsfor the compositor settle,OverlayDrawerfor the panel, andMobileNavRailContextfor the rail (website/src/components/MobileNavRailContext.ts), whichApp.tsxnow also provides on/members. The roster aside is portaled into the drawer while a chat or a team is open. With nothing open, the roster is still the page, and the page claims no swipe.The drawer pushes a duplicate history entry the way the Sessions drawer does, so Back closes it. A pick in the drawer pops that entry first and then switches crewmates on the entry below. Otherwise the switch would land on the duplicate and Back would bring back the crewmate just left. The rail's Home button navigates without closing the drawer when its host is not the chat page, for the same reason, and asks the page's leave guard first, as every rail row does, so an unsaved Profile schedule draft is not dropped. The drawer and its scrim follow the visible area above the software keyboard, as the chat drawer does. When the leave guard has already parked its own duplicate entry (an unsaved Profile schedule), the drawer adds no entry of its own, so closing it cannot carry the user past the guard. Opening a crewmate always replaces the entry, so Back leaves the page in one press after the first crewmate is created from an empty roster.
On a phone the header's left control wears the Sessions page's own drawer toggle icon (
PanelLeftSolid/PanelLeftLight, witharia-expanded) instead of a back arrow, since it now opens a drawer rather than leaving the page. The phone's "no auto-open" rule inMembersPage.tsxis removed, so the phone lands like a wide window. The side panel's phone overlay slides on its own motion value, so a leftward drag can open it and a rightward drag can close it. The Dashboard tab is a sandboxed iframe, and a touch on an iframe never reaches the page, so the Dashboard frames (CrewDynamicDashboard.tsx,CrewWebview.tsx) are built with a new opt-inrelayTouchesinwebsite/src/lib/widgetSrcdoc.ts: the frame posts its one-finger touches to the page, which replays them onto the frame element only while the panel is open, so the one gesture they can drive is that panel's close. The relay stays silent inside a horizontal scroller, an editable or a text selection.website/docs/narrow-viewport.mdgains a paragraph on the Crewmates drawer.Backwards compatibility
Compatible: desktop and tablet widths render exactly as before, and the phone keeps every destination it had (roster, team views, create flows, side panel). Only the way you reach them changes.
Removes nothing: the phone roster still exists and still has every control. It is shown in a drawer instead of as a page. The header control keeps its
members.backUI location and opens the drawer, so guides that point at it still reveal the roster. Its label changes from "Back to crewmates" (back_to_roster) to "Toggle crewmates" (toggle_roster), the same form as the Sessions page's "Toggle sessions", because it now opens and closes a drawer. The guide index is regenerated to match.Tests
MembersPage.test.tsx(phone block): lands on the remembered crewmate with the drawer closed, and the header control draws the drawer-toggle panel glyph (no back arrow) witharia-expandedfalse, then true once the drawer opens; a real touch drag right opens the roster drawer, then a drag left opens the side panel overlay, and a drag right closes it again; the back arrow pushes one duplicate entry, and a pick pops it (navigate(-1)) before switching; Back with the drawer open closes it and the next Back leaves the page; a scrim tap closes it; a team header in the drawer opens the team view and its Back reopens the drawer; the guided flow retires the drawer; a stale?member=opens a stand-in with the notice; Profile does not follow a drawer switch; with no crewmates the page claims no swipe. The old two-level-list cases are replaced.App.mobileSingleTopbar.test.tsx:/memberson a phone gets the rail; its Home button stays put while the page's leave guard refuses, then leaves without closing the host drawer.MembersPage.test.tsx(phone block, continued): on the leave guard's own duplicate entry the drawer pushes and pops nothing; the first crewmate created from an empty roster opens on a replace, so one Back leaves the page; a drag relayed by a frame in the open panel closes it, and the same messages from any other window do nothing.widgetSrcdocTouchRelay.test.tsxruns the real relay script: injected only on request and ahead of the page body; a one-finger drag reports start, move and end; a touch in a horizontal scroller or an input reports nothing; a second finger cancels.mobilePanels.compositor.test.ts:MembersPage.tsxjoins the files that must declaredata-owns-swipewhen they bind a drawer gesture.enabled, pop-before-switch, thedata-owns-swipeclaim, both directions of the create-flow entry check, the leave-guard duplicate check, and the replace on open.Manual verification
Ran an isolated pod for this worktree with an iPhone 13 profile in Playwright and dispatched real CDP touch drags: the page landed on a crewmate, a right drag opened the drawer with the rail and roster, and a left drag opened the side panel. The drawer was checked against the Sessions drawer in the same pod: same height, same rail, "Search all" fully visible. With a sandboxed frame carrying the relay mounted in the Dashboard tab, a real touch drag from the middle of the frame closed the side panel; without the relay the same drag did nothing.
#18447 (an automated GUI lane) reports that a desktop visit landing straight in a chat surprised a first-time tester. This PR does not change desktop, but it does bring that landing to the phone, which is the behaviour this PR is asked to add.
Screenshots / video
Phone (iPhone 13 profile), isolated pod:
Captured on an earlier head, before the header change: the left control is still the old back arrow. The header screenshot below shows the current drawer toggle.
Recording (phone profile, isolated pod, about 20 s). It shows the Sessions page's drawer for comparison, then the Crewmates page: landing on the remembered crewmate, a finger drag right that opens the nav rail and roster drawer, and a drag left that opens the side panel. It was recorded on an earlier head, so the header's left control is still a back arrow. That control is now the Sessions-style drawer toggle shown in the header screenshot above. The gestures are the same.
phone-crewmates-drawers.mp4
Related Issues
Closes #19084
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)