Skip to content

docs(rfc): conductor default patrol covers session_create and system-stopped re-arm - #19893

Merged
bolichen97 merged 1 commit into
mainfrom
docs/rfc-dispatch-patrol-create
Oct 13, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
docs/rfc-dispatch-patrol-create

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record the maintainer's decision that every dispatch, a bind or a session_create, ends with a patrol on the dispatching session or a reply saying why not, so its implementation can land.

The implementation PR #19742 changes what session_create does by default and widens the bind-time re-arm. Its First Principles lane reads the decision off the base branch, and the base RFC covers bind only, so the lane blocks. This RFC revision lands first.

Why it matters

Without a recorded decision on main, #19742 stays blocked, and a conductor whose loop finished one round dispatches the next with nobody reading its workers (#19741).

Not a goal

What changed (motivation → approach → change)

Amends docs/request-for-change/rfc-conductor-default-patrol.md in place to revision v2, and updates its index row in docs/request-for-change/README.md.

Why amend, not a new RFC: the README says an RFC is the record of a decision and that a document which disagrees with the code is a bug to fix in place. The new rules change the same function (conductor_patrol.ensure_patrol), the same reply fields, and one sentence of section 3 of this RFC. A second document would leave two records of one rule, with the old one still saying "default-only". The repo has done this before: rfc-appstore-official-registry.md was revised in place with a note on what changed.

Status partial, per the README vocabulary: phase 1 (arm on bind) is on main, and phase 2 is open. partial is in the set the First Principles lane accepts.

New section 9 records, as accepted decisions:

  1. Re-arm on bind covers any loop the system stopped, not only the default patrol. A loop a person stopped stays stopped, and the reply says refused (user-stopped).
  2. session_create from a non-member caller that holds a work ledger arms the same default patrol as bind, because a create is the same dispatch act.
  3. session_create from a caller with no ledger arms nothing and appends one note telling the agent to arm a monitor. Cost: one extra instruction per create.
  4. Member and crew slots get no outside arm on either route. Self-arm (option D) is out of scope; the seam it would need is session_directive.DIRECTIVE_TOOLS pinned to CORE_MCP_SERVER, plus mcp_core.derive_directive, which re-runs the tool.
  5. The monitor gate is unchanged. Loosening the member gate (option C) is rejected.

It also covers the motivating defect, what a user sees, how to undo it, security, alternatives and exit criteria. Every code claim was checked at ac8a96a242.

#19742 also edits this RFC's text. This PR is the source of truth for it. After this merges, #19742 rebases onto it and drops its own edit to this file.

The comment-history gate (scripts/check_comment_history.py) reads Python comments and docstrings only, so it does not apply to this docs diff.

Backwards compatibility

Compatible: documentation only.

Removes nothing: amends one document and one index row.

Tests

N/A — docs only. scripts/docs-lint.sh reports no findings. test/test_docs_lint_fact_checks.py, test/test_pipeline_conductor_skill_contract.py, test/test_pr_quality_gates.py, test/test_work_ledger_tools.py and test/test_prepare_pr_findings.py pass (476 passed).

Manual verification

N/A — docs only.

Related Issues

Refs #19741

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

…stopped re-arm

Amend rfc-conductor-default-patrol to revision v2, status partial. Section 9 records the accepted phase 2 decisions: re-arm any system-stopped loop on bind, arm the same default patrol on session_create for a ledger-holding non-member caller, a no-ledger note instead of an arm, no outside arm on member or crew slots, and an unchanged monitor gate.
@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 13, 2026 19:09
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 44ae9c28235a7c15ee282b6e56db6e51f3262a77 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 44ae9c28235a7c15ee282b6e56db6e51f3262a77 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 44ae9c28235a7c15ee282b6e56db6e51f3262a77 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

A maintainer should confirm on this PR that they accepted the §9.2 decisions on 2026-10-13. The document asserts that acceptance itself, and merging it unblocks #19742's First Principles lane.

[DESIGN-REVIEWED] 44ae9c2

Description read

[DESCRIPTION-READ] 1c1cbf4dcb301bfd3eaa26d56a0facbad32bfacae582b976831736f5ffc1e0e1

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 44ae9c28235a7c15ee282b6e56db6e51f3262a77 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 44ae9c2

Verdict parsed from the review's SHA-scoped output markers for commit 44ae9c28235a7c15ee282b6e56db6e51f3262a77.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 44ae9c28235a7c15ee282b6e56db6e51f3262a77: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 44ae9c28235a7c15ee282b6e56db6e51f3262a77 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 44ae9c2

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 44ae9c28235a7c15ee282b6e56db6e51f3262a77: <one-sentence reason>

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Disposition, Design Review note at 44ae9c2 (PASS, advisory): agreed. The section 9.2 decisions were handed to this PR's author as the maintainer's decisions. This comment does not confirm them for the maintainer. A maintainer should reply here confirming acceptance of section 9.2 before merge. No code or text change is needed for this note.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 13, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff: the change matches its stated goal and tests cover it. Readiness passed at this head.

Posted by an AI assistant at bolichen97's request.

@bolichen97
bolichen97 merged commit 2c237a2 into main Oct 13, 2026
101 checks passed
@bolichen97
bolichen97 deleted the docs/rfc-dispatch-patrol-create branch October 13, 2026 23:22
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants