Repository navigation
docs(rfc): conductor default patrol covers session_create and system-stopped re-arm - #19893
Conversation
…stopped re-arm Amend rfc-conductor-default-patrol to revision v2, status partial. Section 9 records the accepted phase 2 decisions: re-arm any system-stopped loop on bind, arm the same default patrol on session_create for a ledger-holding non-member caller, a no-ledger note instead of an arm, no outside arm on member or crew slots, and an unchanged monitor gate.
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS A maintainer should confirm on this PR that they accepted the §9.2 decisions on 2026-10-13. The document asserts that acceptance itself, and merging it unblocks #19742's First Principles lane. [DESIGN-REVIEWED] 44ae9c2 Description read[DESCRIPTION-READ] 1c1cbf4dcb301bfd3eaa26d56a0facbad32bfacae582b976831736f5ffc1e0e1 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Disposition, Design Review note at 44ae9c2 (PASS, advisory): agreed. The section 9.2 decisions were handed to this PR's author as the maintainer's decisions. This comment does not confirm them for the maintainer. A maintainer should reply here confirming acceptance of section 9.2 before merge. No code or text change is needed for this note. |
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed the diff: the change matches its stated goal and tests cover it. Readiness passed at this head.
Posted by an AI assistant at bolichen97's request.
Problem / Motivation
Goal: Record the maintainer's decision that every dispatch, a bind or a
session_create, ends with a patrol on the dispatching session or a reply saying why not, so its implementation can land.The implementation PR #19742 changes what
session_createdoes by default and widens the bind-time re-arm. Its First Principles lane reads the decision off the base branch, and the base RFC covers bind only, so the lane blocks. This RFC revision lands first.Why it matters
Without a recorded decision on main, #19742 stays blocked, and a conductor whose loop finished one round dispatches the next with nobody reading its workers (#19741).
Not a goal
What changed (motivation → approach → change)
Amends
docs/request-for-change/rfc-conductor-default-patrol.mdin place to revision v2, and updates its index row indocs/request-for-change/README.md.Why amend, not a new RFC: the README says an RFC is the record of a decision and that a document which disagrees with the code is a bug to fix in place. The new rules change the same function (
conductor_patrol.ensure_patrol), the same reply fields, and one sentence of section 3 of this RFC. A second document would leave two records of one rule, with the old one still saying "default-only". The repo has done this before:rfc-appstore-official-registry.mdwas revised in place with a note on what changed.Status
partial, per the README vocabulary: phase 1 (arm on bind) is on main, and phase 2 is open.partialis in the set the First Principles lane accepts.New section 9 records, as accepted decisions:
refused (user-stopped).session_createfrom a non-member caller that holds a work ledger arms the same default patrol as bind, because a create is the same dispatch act.session_createfrom a caller with no ledger arms nothing and appends one note telling the agent to arm a monitor. Cost: one extra instruction per create.session_directive.DIRECTIVE_TOOLSpinned toCORE_MCP_SERVER, plusmcp_core.derive_directive, which re-runs the tool.It also covers the motivating defect, what a user sees, how to undo it, security, alternatives and exit criteria. Every code claim was checked at
ac8a96a242.#19742 also edits this RFC's text. This PR is the source of truth for it. After this merges, #19742 rebases onto it and drops its own edit to this file.
The comment-history gate (
scripts/check_comment_history.py) reads Python comments and docstrings only, so it does not apply to this docs diff.Backwards compatibility
Compatible: documentation only.
Removes nothing: amends one document and one index row.
Tests
N/A — docs only.
scripts/docs-lint.shreports no findings.test/test_docs_lint_fact_checks.py,test/test_pipeline_conductor_skill_contract.py,test/test_pr_quality_gates.py,test/test_work_ledger_tools.pyandtest/test_prepare_pr_findings.pypass (476 passed).Manual verification
N/A — docs only.
Related Issues
Refs #19741
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.