Skip to content

docs: keep posted warm brief messages as plain history - #20979

Merged
chenmingwei23 merged 1 commit into
mainfrom
docs/rfc-warm-brief-plain-messages
Oct 16, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
docs/rfc-warm-brief-plain-messages

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make the warm task brief RFC match the simple plain-message shape now implemented in #20422.

#20778 described stale generated messages being retracted by row id and every row being withheld until its disk write succeeded. The user chose simpler behavior: a posted crewmate message is ordinary history and stays.

Why it matters

The implementation must read one accepted, non-conflicting design from main. Without this amendment, review correctly blocks #20422 for not retracting rows the RFC still says it retracts.

Not a goal

  • Changing the explicit leave, 30-minute absence, return, task-change, claim, or deduplication rules.
  • Changing the cold welcome.
  • Implementing the feature in this PR.

What changed (motivation → approach → change)

docs/request-for-change/rfc-delayed-task-brief.md:

  • Posted preparing, result, and failure messages stay as ordinary history; a stale result is discarded unposted. The retraction, persist-before-surface, and row-rewrite clauses are removed from the lifecycle table, the outcome table, the sequence diagram, validation, and undo.
  • The fixed preparing and failure lines and the three headings are English, like other gateway-authored lines; the model writes status and suggested actions in the user's language.
  • Carries two clarifications that missed docs: amend warm brief message UX #20778: role assistant is required by the ordinary message path, and the reader filters cover metadata-stripping recent projections and session transfer. The heading of 3.4 now reads "Preparation before the model" and undo describes the two-release rollback.

Backwards compatibility

Compatible: this changes design text only and no running code.

Removes nothing: no product code or accepted trigger is removed.

Tests

  • Documentation lint and PR description gates.
  • Text sweep: the only remaining "retract" is the sentence saying nothing retracts posted messages.

Manual verification

Reviewed sections 3.3, 3.4, 3.5, 3.7, user-visible outcomes, validation, rollout, undo, and the decision record together.

Screenshots / video

N/A — documentation-only design amendment with no rendered product change.

Related Issues

Part of #20156

Related implementation: #20422

Checklist

  • At most two commits, with one Conventional Commit
  • Existing tests pass and new tests are not needed for documentation-only changes
  • Self-review completed; code follows project style guidelines
  • Documentation updated
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

Posted preparing, result and failure messages stay as ordinary history; a stale result is dropped unposted. Removes the retraction and persist-before-surface clauses and records the English fixed lines.
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision f0db0877e2beeac765e122617d49face180e65e0 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision f0db0877e2beeac765e122617d49face180e65e0 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — 🟡 CONCERNS

Design-level review of f0db0877e2beeac765e122617d49face180e65e0 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

A stale attempt now leaves “Preparing your current-task summary. You can wait here.” in history for good, and no answer ever follows it.

Watch

  • Orphaned promise. The patch drops “The preparing message is not left behind when no current result or failure follows it” and adds “a stale attempt leaves only the preparing message.” Chain: the user sends, the task changes or the task completes after preparation starts → the result is discarded without being posted → the transcript keeps a permanent message telling the user to wait for a summary that never arrives. Reload shows it again. An ordinary third message (for example “Summary skipped — the task changed”), or wording that does not promise a follow-up, would keep the plain-history shape and stop the message from being false.
    Clears when: the RFC says what the user sees after a stale preparing message, either a closing ordinary message or preparing text that holds without a follow-up.
  • The accepted terms still contradict the amendment. The unchanged acceptance line still reads “stale/cancelled results suppressed with status cleared”. The new lifecycle table says “posted messages stay”. The amendment is credited to “the user's 2026-10-15 UX decision”, not to a superseding maintainer entry, so feat: add return-triggered warm task briefs #20422 is still being reviewed against two clauses that disagree.
    Clears when: the decision record links a maintainer-written supersession of the “status cleared” term, or the amendment explicitly names that term as replaced.

[DESIGN-REVIEWED] f0db087

Description read

[DESCRIPTION-READ] 7e0f41262758997b7f132f661ece257047f6c0908134225eca3b3ca2996fef58

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of f0db0877e2beeac765e122617d49face180e65e0 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f0db087

False positive or not applicable? A repository writer can comment:
/ai-review override gpt f0db0877e2beeac765e122617d49face180e65e0: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed f0db0877e2beeac765e122617d49face180e65e0 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] f0db087

Verdict parsed from the review's SHA-scoped output markers for commit f0db0877e2beeac765e122617d49face180e65e0.

False positive or not applicable? A repository writer can comment:
/ai-review override fable f0db0877e2beeac765e122617d49face180e65e0: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 15, 2026

@chenmingwei23 chenmingwei23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving: readiness: passed, all lanes green, no outstanding change requests.

@chenmingwei23
chenmingwei23 merged commit d3d933c into main Oct 16, 2026
148 of 149 checks passed
@chenmingwei23
chenmingwei23 deleted the docs/rfc-warm-brief-plain-messages branch October 16, 2026 01:37
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants