Repository navigation
feat: add return-triggered warm task briefs - #20422
Conversation
Design Review (Opus 5.5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS The crewmate never sees the catch-up it posts, so a reply to one of its suggestions ("do the second one") reaches a model with no record of them. Watch
[DESIGN-REVIEWED] 3d28ced Description read[DESCRIPTION-READ] 7caa5f8a068d28e19661eecf610c657867d2c55b1b2981cc0588d8cf55df6bf9 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The opener promises a catch-up but nothing shows it is coming, and a reply typed while waiting silently cancels it. Watch
Suggestions
[UX-REVIEWED] 3d28ced Description read[DESCRIPTION-READ] 921a7e6524f68dd3f492f59c9628d725a6fa1bbe2899758d78ac9eb9a7cf33e0 That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The diff overrides the accepted RFC's verbatim-quote and English-fixed-line rules, with a 7-language opener table and an amendment that exists only in this PR. Not justified as shipped
What this change shipsInventory (8 items) — 6 justifiedIntent: let a person returning after 30+ minutes recover the task without rereading the thread. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 3d28ced Description read[DESCRIPTION-READ] 7bfb07ddb944bd5646aeab8c8840fd361c370bba82d52b1d1cc18e8427b9ae99 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
e2935bd to
0250844
Compare
0250844 to
65fa29a
Compare
|
|
|
|
|
|
|
|
|
|
|
Sensitive change review
|
66de427 to
6f4fc09
Compare
Sensitive change review
|
6f4fc09 to
d3a5789
Compare
|
Disposition for head d3a5789 (rebased on main 0f98bd9): GPT BLOCK — unbounded waits in cancellation tests: fixed. The two flush-cancellation tests were removed with the retraction code they covered. The surviving test, Opus advisory — English fixed copy: accepted, not changed. The model now writes current status and suggested actions in the language the user writes in (prompt line added). The two fixed lines ("Preparing…", "I couldn't prepare…") and the three headings stay English, like other gateway-authored lines. Localizing them by Scope cut (First Principles item 9). Posted brief messages are ordinary history and stay. Removed: |
Sensitive change review
|
Sensitive change review
|
Sensitive change review
|
Sensitive change review
|
Replace immediate static warm resume cards with a return-triggered summary after an explicit 30-minute away episode. Preserve the cold welcome and gate one background model call behind owner presence, a durable fingerprint claim, and a stale-result check. The preparing, result and failure lines are ordinary crewmate messages and stay as ordinary history once posted. A stale result is dropped unposted. The model writes the status and suggested actions in the user's language.
Sensitive change review
|
|
Dispositions for head 3d28ced:
|
Problem / Motivation
Goal: Replace the immediate static warm resume with a grounded task brief shown only after a real return.
Opening an active crewmate thread currently shows fixed task status at once. It does not start with the request that caused the work, and it can race a newer answer.
Why it matters
People returning after a long break can recover the request, durable task truth, and next actions without rereading the thread. Unrelated opens and short absences spend nothing.
Not a goal
What changed (motivation → approach → change)
After at least 30 minutes away, a person returning to the same active crewmate thread gets a short catch-up from the crewmate in its own voice: what they asked for, where it stands, and one to three suggestions. This replaces fixed copy so they recover the task as it stands now, while ordinary opens and short absences stay quiet and free.
The trigger design is RFC #20157. Its plain-message amendment is RFC PR #20778 (merged). #20979 records that posted messages stay as plain history and must merge before this implementation. The client marks only an explicit
document.hiddenleave and reports the mounted crewmate thread on the later visible edge. The gateway keeps the away episode in memory on a suspend-counting wall clock, refuses a backward clock step, requires the same thread, then durably claims a task fingerprint before showing status or spending. Any later owner focus frame, including another connection, consumes the process-local away episode. That owner-only claim is an empty display-only row in the existing transcript, so reset and deletion remove it with the task.The gateway first posts a short fixed crewmate opener: “Welcome back, let me catch you up on where we are.” It is picked by the script of the user's request (English, Chinese, Japanese, Korean, Russian, Hindi, Bengali; Latin script gets English) and costs no model call. It then makes exactly one bounded, tool-free call through the existing governed background model path. The result is a second ordinary crewmate message in first-person prose: what was asked, where it stands, and one to three concrete suggestions. The prompt forbids headings, bold, lists and task-title dumps, and the gateway strips bold markers. There is no card, header, chip or Dismiss button; both rows draw in the normal assistant bubble with no special renderer. Generated messages are excluded from the task fingerprint, session summaries, consolidation prompts and model replay. Posted messages are ordinary history and stay; nothing retracts or rewrites them. User, assistant, surface, task, reset, close, and replacement changes cancel the attempt or drop its stale result unposted. Once model acquisition starts, cancellation lets the governed call finish safely, then discards stale output. Failure is a second short fixed crewmate line (“Sorry, I couldn't pull that together just now. Ask me where things stand.”) in the same language as the opener. The RFC gets a 2026-10-16 UX amendment line recording this shape.
The static
MateResumeCardand its warm-only copy were removed. The board read remains only to preserve the cold-welcome gate. User data stays inside the existing model and account path.Implementation spans
src/kiro_crew/autonudge_judge.py,src/kiro_crew/context.py,src/kiro_crew/decisions,src/kiro_crew/history_consolidation.py,src/kiro_crew/history_projection.py,src/kiro_crew/warm_task_brief_contract.py,src/kiro_crew/dashboard,src/kiro_crew/session_summary.py,src/kiro_crew/security_posture.py,website/src/app-sdk,website/src/hooks,website/src/lib, andwebsite/src/store. The security posture registry counts the final brief scrub as a transcript-and-browser egress boundary. Text and render coverage live inwebsite/src/i18nandwebsite/src/test. The owning contracts are updated underdocs/system-specs/modules, with the user path indexed indocs/feature-map; the earlier warm-card RFC is marked partially superseded while its cold-welcome decision stays current.Backwards compatibility
Breaking: opening an active crewmate thread no longer shows the immediate static warm card. RFC #20157 records the accepted replacement. Writer sweep on origin/main @ b413800: the only warm greeting producer was
useMateGreeting; the only component consumer wasMembersPage(nowMembersPageThread); the sharedcrewmateGreetinghost remains for the unchanged cold welcome.Undo: reverting the feature leaves completed rows as ordinary crewmate messages; empty claim rows draw nothing. Existing reset and delete paths remove both.
Reader:
website/src/pages/members/MembersPageThread.tsx:useMateGreeting-- crew page -- still reads the board only to decide whether the unchanged cold recap may run.Reader:
website/src/components/ChatPane.tsx:crewmateGreeting-- crew page -- still drawsMateWelcomeCardfor the unchanged cold path.Reader:
website/src/components/chat/crewmateBubbles.ts:isCrewmateChatRow-- crew page -- draws generated opener, result, and failure rows as ordinary crewmate messages; the fingerprint claim is anoticerow, which crewmate chat never draws.Reader:
src/kiro_crew/dashboard/ws.py:note_foreground-- slot retention -- consumes the focus frame's mounted member slot on the Crew page.Tests
Manual verification
The Electron source check confirms the dashboard keeps Chromium's default background throttling. Minimize and hide-to-tray smoke could not run on this headless Linux host; Windows and macOS desktop behavior remains release verification. Per RFC #20157, a platform that reports no
document.hiddenedge fails silent and adds no fallback trigger.Screenshots / video
Committed under
temp-screenshots/20422-warm-brief-plain/, captured from the real Members page capture entry with a stubbed API. Each frame asserts no "Where we left off" text, no Dismiss button and no bold section headings. The side panel's "dashboard could not be loaded" line is the capture stub, not this change.Ordinary open of an active thread: no card, no Dismiss:
While the one model call runs: the opener stands alone as an ordinary message. By design there is no spinner, typing bubble or status row; the opener itself says the crewmate is catching the user up, and the brief call is not a chat turn:
Return: opener then prose catch-up, light:
Return: opener then prose catch-up, dark:
Chinese request: Chinese opener and catch-up:
Model failure: opener then the fixed failure line:
Related Issues
Part of #20156
Implements the accepted RFC in #20157.
Related open PRs
ChatPane.tsx. Whichever PR merges second rebases.Checklist
Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.