Repository navigation
fix(dashboard): keep feature-preview switches on the gateway - #21569
mbriones98 wants to merge 2 commits into
Conversation
The Feature previews switches lived only in browser localStorage, so a new origin, the desktop app beside a browser tab, or cleared site data turned them back off. Each switch is now stored in the gateway config under dashboard.feature_previews.<name>, written through the existing owner-only config PATCH, with localStorage kept as a cache. A switch set only in this browser is carried up once with if_unset; a refused toggle says why next to the switches. Fixes #21396
…sist-21396 # Conflicts: # src/kiro_crew/config/loader.py # website/src/pages/settings/FeaturePreviewsSection.tsx
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that a non-owner dashboard session, which can no longer turn a preview on locally, is an accepted loss. [DESIGN-REVIEWED] fbf3982 Description read[DESCRIPTION-READ] e64a76641a2ad85ae12546577312114d732312390170fd15c2cd5ab925b6c34d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The PR reverses a recorded decision that preview switches belong to one device. The only evidence given is the symptom, not a case that the decision was wrong. Not justified as shipped
What this change shipsInventory (8 items) — 7 justifiedIntent: keep a Feature previews switch on once it is set, on every browser and in the desktop app that use the same gateway. FIX.
[FIRST-PRINCIPLES-REVIEWED] fbf3982 Description read[DESCRIPTION-READ] 5a9fcebaee1643a97ffcf02c144d444e9a44aec99ea9c4db2d151bd4ccfe1bbb That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The refusal notice appears only at the top of the section and never names the switch that went back, so users who scroll down may never see why their click undid itself. Watch
Suggestions
[UX-REVIEWED] fbf3982 Description read[DESCRIPTION-READ] efe342cbbe9fa87187db589b7b34808e121f88cd79a050a8c2bad99119266bf9 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings that block the merge. FINDING — website/src/hooks/usePreviewFlagServerSync.ts:181 — A refused toggle can stay ON while the notice says "The switch was put back". This happens in a non-owner session (PATCH gets 403 from [OPUS-REVIEWED] fbf3982 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — 🔴 changes requested (blocking)GPT 6.1 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- website/src/pages/settings/FeaturePreviewsSection.tsx:173 -- Record the error notice’s hand-off decision [BLOCK-MERGE] fbf3982 Adjudication (Opus 5.5) — is blocking on each finding proportionate?I'm keeping F1 blocking: the base-branch rule it cites is marked F1: I confirmed the condition in the code. At False positive or not applicable? A repository writer can comment: |
|
Superseded by #21602 |
Pull request was closed
Problem / Motivation
Goal: A Feature previews switch (such as Crewmates) stays on once you turn it on, in every browser and in the desktop app that talks to the same gateway.
The switches under Settings > Developer > Feature previews were kept only in browser localStorage (
mc-preview-*). A new origin or port, the desktop app next to a browser tab, or cleared site data each read the switch as off, so Crewmates and the other previews kept turning themselves off.Why it matters
Anyone trying a preview has to turn it on again on every surface and after every storage reset, and a preview that seems to switch itself off reads as broken.
Not a goal
DURABLE_PREF_KEYS//api/ui-prefsbackup, so there is one source of truth.What changed (motivation → approach → change)
Symptom: a switch turned on in one surface is off in another. Root cause: localStorage was the only copy.
Approach: the gateway config keeps each switch, and localStorage stays as a fast cache. I chose config over adding the keys to
DURABLE_PREF_KEYSbecause the uiPrefs backup restores only on a cold profile, so a warm desktop app and a warm browser tab would never pick up each other's change. The config route reaches every open dashboard through the configrefreshframe it already receives.sections_dashboard.py,loader.py,sections.py,handlers/core.py,change_card_catalog.py): one bool per switch underdashboard.feature_previews.<name>for the 6 live flags (webhooks,artifact_deploy,crew,remote_crew_chat,layout_harness,folder_conductor). The PATCH allowlist accepts only those names, the change card classifies them, andconfiguration.mdandconfig-baseline.jsonare updated. The retiredmc-preview-instance-sessionskey is not kept on the gateway. Its ON is carried up asremote_crew_chat.usePreviewFlagServerSync.ts, mounted inApp.tsxbeside the shell's existing reader of the same config query, so boot order is unchanged):if_unset, so it never replaces a stored value. Afterwards akc-feature-previews-syncedmarker makes a cache-only ON read as off, so a key the operator removed on the gateway stays off.en-XAis regenerated.Overlap: open PR #20420 also edits
DURABLE_PREF_KEYS. This PR does not touch that list, so the two do not conflict.Backwards compatibility
Compatible: the new config fields are optional with a
falsedefault, the PATCH allowlist only gains names, and an existing browser-only ON is carried up once instead of being dropped.The diff takes one thing away: localStorage is no longer the source of truth for a switch. After the first sync, a cache-only ON that the gateway does not hold reads as off, and a non-owner's toggle no longer overrides the gateway's stored value.
Reader: website/src/utils/previewFlags.ts:readPreviewFlag -- chat|crew page -- still reads the cache, which reconcile keeps equal to the gateway copy | previewFlagServerSync.test.tsx "lets the server copy win over a stale browser copy"
Reader: website/src/hooks/usePreviewFlag.ts:usePreviewFlag / useRemoteCrewChat -- chat|crew page -- re-renders on the same cache write event | previewFlagServerSync.test.tsx "turns Crewmates on from the server when this browser has no copy"
Reader: website/src/surfaces/registry.ts:surfacePreviewEnabled (nav rail, pagesProvider, appNavHidden, CommandBarOverlay) -- chat|crew page -- reads the cache via readPreviewFlag | previewSurfaces.test.tsx
Reader: website/src/pages/settings/FeaturePreviewsSection.tsx -- crew page -- toggles still write the cache first, then the gateway | previewSurfaces.test.tsx "says why a switch went back when the gateway refuses the write"
Reader: retired mc-preview-instance-sessions -- chat -- carried up as remote_crew_chat, then cleared | previewFlagServerSync.test.tsx "carries the retired Remote crew sessions switch up as Chat on a crew", "never lets the retired key turn Chat on a crew back on after it was turned off"
Tests
website/src/test/previewFlagServerSync.test.tsx(19 tests). The repro: Crewmates turns on from the server when localStorage is empty, and it fails with the sync disabled. The other tests cover:if_unsetcarry-up, not replacing a stored value, and not retrying a refused carry;PREVIEW_FLAGSequals every declared flag constant.website/src/test/previewSurfaces.test.tsx: the section renders the owner-only notice when the PATCH returns 403.test/test_feature_previews_config.py: the gateway flag list matches the dashboard flags, nothing is on by default, and the loader keeps only known names with bool values. It also checks that each switch is writable through the PATCH, that an unknown name or a non-bool writes nothing, thatif_unsetnever replaces a stored switch, and that a non-owner cannot write a switch.tsc(app) and eslint are clean.lint:i18n,i18n-checkandcheck-i18n-keyspass.origin/mainon this host (test_dashboard_gallery_dispatch_tree.py,test_home_pin_survives_monkeypatch_undo.py: the host resolves an enterprise profile and a liveKIROCREW_HOME), so they are unrelated.7a05257; both quoted that SHA). Neither found anything Critical or High. This revision fixes their Medium/advisory findings: write ordering, the carry-up undoing an operator reset, the retired key being carried up, the parity test gap, and silent refusals. The review briefs used the skill's fallback charters becauselocal_review.pyrefused to build them (__MERGE_BASE__unmapped).Manual verification
I took screenshots against the built SPA, with
/api/config/kirocrewreturningcrew: trueand the PATCH returning 403:Screenshots / video
Synced from the gateway (Crewmates on, empty browser storage):
A toggle refused with 403:
Related Issues
Fixes #21396
Related: #16237, #17424, #14232, #9876
Pattern harvest
Rule candidate: review-prompt
Pattern: a user-visible setting persisted only in browser localStorage, when it is meant to hold across surfaces of the same gateway; check whether it should live in gateway config with localStorage as a cache.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.