Repository navigation
test(history): list the members #21108 added in the frozen inventory - #21792
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 997556d Description read[DESCRIPTION-READ] fc989d9b5a4d3549d948efa4291b6c379f06c6f3285348c5bcc155b10181fe81 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: Backend Tests shard 1 is green again on main and on every PR rebased on it.
test/test_history_bindings.py::test_the_member_set_is_the_frozen_inventoryfails on main at9d088c85ad:Why it matters
Every open PR on current main shows a red Backend Tests shard 1 on Linux and Windows, so no PR can reach
readiness: passed.Not a goal
ConversationLogor the search code perf(search): single-flight cold searches, recency memos #21108 added.What changed (motivation → approach → change)
#21014 froze
ConversationLog's member list intest/test_history_bindings.py. #21108 then added three members to the class and did not list them, so the inventory test fails. This PR lists them in_MEMBERS:_dir_write_epochandwarm_searchas functions on the facade, with digests from the test's own_signature_digest, and_dir_write_epochsas data.Backwards compatibility
Compatible: test-only change; no product code changes.
Removes nothing: it only adds three inventory entries.
Tests
test/test_history_bindings.py: 212 passed locally, including the per-member kind, signature and owner check for the three new entries. Before this change the inventory test failed on cleanorigin/main9d088c85adwith the error above.Manual verification
N/A — unit coverage sufficient: the change is three entries in a test table.
Related Issues
Closes #21790
Pattern harvest
Not generalizable: the inventory test already catches this class; it fired as designed when two PRs merged close together.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)