Skip to content

test(history): list the members #21108 added in the frozen inventory - #21792

Merged
bolichen97 merged 1 commit into
mainfrom
fix/history-bindings-inventory-21108
Oct 18, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/history-bindings-inventory-21108

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Backend Tests shard 1 is green again on main and on every PR rebased on it.

test/test_history_bindings.py::test_the_member_set_is_the_frozen_inventory fails on main at 9d088c85ad:

AssertionError: assert ['_dir_write_epoch', '_dir_write_epochs', 'warm_search'] == []

Why it matters

Every open PR on current main shows a red Backend Tests shard 1 on Linux and Windows, so no PR can reach readiness: passed.

Not a goal

What changed (motivation → approach → change)

#21014 froze ConversationLog's member list in test/test_history_bindings.py. #21108 then added three members to the class and did not list them, so the inventory test fails. This PR lists them in _MEMBERS: _dir_write_epoch and warm_search as functions on the facade, with digests from the test's own _signature_digest, and _dir_write_epochs as data.

Backwards compatibility

Compatible: test-only change; no product code changes.

Removes nothing: it only adds three inventory entries.

Tests

test/test_history_bindings.py: 212 passed locally, including the per-member kind, signature and owner check for the three new entries. Before this change the inventory test failed on clean origin/main 9d088c85ad with the error above.

Manual verification

N/A — unit coverage sufficient: the change is three entries in a test table.

Related Issues

Closes #21790

Pattern harvest

Not generalizable: the inventory test already catches this class; it fired as designed when two PRs merged close together.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 997556d25592acd89b94610ac494cd81f43324b5 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 997556d25592acd89b94610ac494cd81f43324b5 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 997556d25592acd89b94610ac494cd81f43324b5 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 997556d

Description read

[DESCRIPTION-READ] fc989d9b5a4d3549d948efa4291b6c379f06c6f3285348c5bcc155b10181fe81

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 997556d25592acd89b94610ac494cd81f43324b5 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 997556d

Verdict parsed from the review's SHA-scoped output markers for commit 997556d25592acd89b94610ac494cd81f43324b5.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 997556d25592acd89b94610ac494cd81f43324b5: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 997556d25592acd89b94610ac494cd81f43324b5 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 997556d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 997556d25592acd89b94610ac494cd81f43324b5: <one-sentence reason>

@bolichen97
bolichen97 merged commit 943a4e5 into main Oct 18, 2026
100 of 101 checks passed
@bolichen97
bolichen97 deleted the fix/history-bindings-inventory-21108 branch October 18, 2026 07:26
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main red: history bindings inventory misses the members #21108 added

2 participants