Repository navigation
feat(sidebar): add title-only session cards - #23512
rio-evrard wants to merge 1 commit into
Conversation
UX Review (Opus 5.5, fork) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing the title-line marks. The description says the screenshots "show the title-only layout but not the title-line icons." Those icons are the only cue left that a title-only session needs the user or is running. Evidence gaps
Notes
[UX-REVIEWED] 41d34ec Description read[DESCRIPTION-READ] bb1df052b12a68dc9806e7d3a6e0002ddfea023884ea9969707c3e952b49731a That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS The opt-in setting has a linked issue (#21239) and changes no default. The one weakness is that the title-line marks spell out each row state's glyph and label a second time, apart from the full card's resolver. Notes
What this change shipsInventory (10 items) — 8 justifiedIntent: let people shrink sidebar session cards to their titles with one optional setting. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 41d34ec Description read[DESCRIPTION-READ] 6a4827280694695253e394bd964ee678936860567e9956c98cd15904de05fea4 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the preference defaults off and stays in the browser, and no reader outside the patch loses anything. Notes
[DESIGN-REVIEWED] 41d34ec Description read[DESCRIPTION-READ] 3a4cf0dd46dd561dc1f547afd514177eb627b5c9cac1e5ac37530f09b432d7a5 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review (fork) — 🔴 changes requested (blocking)Reviewed Adjudication upheld 1 of 1 blocking finding(s); those must be resolved before merging. BLOCKING -- website/src/pages/chat-sidebar/compactTitleMarks.tsx:99 -- Compact crew errors lose readable notice and recovery action [BLOCK-MERGE] 41d34ec Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1: the rule this finding is anchored to, |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
37dd33a to
40a3f81
Compare
40a3f81 to
6b8c6fb
Compare
6b8c6fb to
029c8c9
Compare
029c8c9 to
206f141
Compare
buluoray
left a comment
There was a problem hiding this comment.
Reviewed at 206f141dde9f694450069b8a925ca1d034708cb0.
Approving. Title-only cards are opt-in and off by default. A bad stored value is repaired to false (ChatSettings.tsx:178). Re-running npm run gen:ui and npm run gen:settings leaves the tree clean. i18n:check passes. Committing the evidence under temp-screenshots/ is the documented path for a fork PR, and MANIFEST.in prunes it from packages.
Verified locally:
vitest run src/test/ChatSidebar.sourceLinkChip.test.tsx src/test/ChatSettings.test.tsx: 86/86 pass.tsc -p tsconfig.app.json --noEmit: clean.- Mutation checks, one at a time:
- Removing the repair turns
repairs a non-boolean compactSessionCards value…red. - Re-showing the meta line or the secondary line turns
shows only the title…red (and the approval and unread tests for the secondary line). - Disabling the title-line marker turns 5 tests red.
- Dropping the loop, workflow and monitor live keys turns 3 red.
- Dropping the stalled-loop exception turns its test red.
- Removing the repair turns
Non-blocking follow-ups:
- Test gap. The live dot for a collapsed conductor whose hidden sessions are running and that has no marker of its own (
showLiveDot's second clause) has no test. Replacing that clause withfalsekeeps every test green. A case withconductor.aggregate.running > 0,needsYou = 0and title-only on would cover it. - Cues that disappear in title-only mode. Muted, process released, incognito / temporary memory mode, popped out and pinned all live in the meta line, which this mode hides. Muted was deliberately at rest (
role="img", labelled "Muted"), so a muted session now reads the same as any other to sighted users and to screen readers. The memory-mode glyphs are privacy cues. Consider keeping these small glyphs on the title line, the same way the attention marker is kept. - Toggle placement. The new toggle sits between "Split view session grid" and "Dim inactive panes", which depends on split view (
ChatPanel.tsx:1032-1034). It fits better next to "PR and Issue Chips on Session Cards" (ChatPanel.tsx:1100), the other session-card setting. - Description copy. "Show only each session title" isn't quite true now that a status marker can appear. All ten translated descriptions also drop "metadata", which the English keeps. The UX lane suggested replacement wording; the translations need redoing once the English is settled.
- Spec and evidence.
docs/system-specs/modules/history.mdownsSessionRow.tsxbut doesn't mention the title-only mode or its live-dot and marker rule. The UX lane also asked for one title-only screenshot with the approval, unread or interrupted marker and one with a running loop or workflow; the current shot shows only idle titles.
25f180c to
c22d556
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Thanks @rio-evrard for narrowing this. I reviewed head 550320d82b. Three things still block merge:
- Crew Mode approval wait is hidden in title-only mode.
compactAttentioninwebsite/src/pages/chat-sidebar/SessionRow.tsxhas no branch for thecrew_approvalrow state (main sets it atSessionRow.tsx:1146). With{!compactSessionCards && (wrapping the meta line, the<CrewEyebrow />is hidden too. Result: a conductor whose crew member waits for approval shows a bare title, and the user never sees the wait. Fix: add arowStateEntry?.key === 'crew_approval'branch (warn glyph, labelcomponents.crewMode.summary_approval) beforesubtree_needs_you, keep a crew marker on the title line whencrewRoot, and add a test for both. This is the open Opus finding from 10-30. - Merge conflict with main. Please rebase onto current
main. - Follow-ups need tracking. @iamwhatever's change request asked for each remaining item to be fixed here or filed as an issue linked in the description. Please open one issue per item you listed (collapsed-parent live-dot test; pinned / incognito / temporary / popped-out / released icons; setting description copy;
history.mdspec paragraph) and link them in the PR description.
After that, CI and the AI lanes will run on the new head.
AI-assisted review (code-review-sage), sent by CommunityCrew
bolichen97
left a comment
There was a problem hiding this comment.
Thanks @rio-evrard. I re-reviewed head f36df8e29b against my change request from 11-04.
Fixed:
- Crew Mode approval wait.
compactAttentionnow has acrew_approvalbranch (warn glyph,components.crewMode.summary_approval), and a Crew Mode root keeps its bolt on the title line. The new testkeeps a crew member approval wait and the Crew Mode mark on a title-only cardcovers both. - Follow-ups. #29861, #29862, #29863 and #29864 exist and are linked in the description.
One thing is left:
- Merge conflict with main again.
mainmoved after your 01:32 UTC rebase. The only conflict is the generated filesrc/kiro_crew/docs/ui-index.generated.json. Please rebase onto currentmain(or merge it), then regenerate that file withnpm run gen:uiinstead of hand-merging it, and push.
Once that is pushed, I'll approve on the new head, which queues its fork CI.
AI-assisted review, sent by CommunityCrew
|
[operator: bolichen97] Maintainer decision: @rio-evrard, this PR stays yours until 2026-11-12 12:30 UTC. If there is no new push or reply here by then, a maintainer will continue it in a new PR that builds on your commit and credits you as co-author.
There has been no activity here for a while. If you are still working on this, please leave a comment; otherwise a maintainer may pick it up so that it does not stall. |
|
@bolichen97 still mine, thanks. Rebased onto main and pushed |
Code change approver recommendation: A person should decideWhy: the decider thinks the change is probably fine but estimates a 15% chance that this change introduces a defect, above the 12% limit for approving on its own. Opt-in, off-by-default title-only session cards. The value is stored in mc-chat-config (non-booleans are reset to false), propagated via the existing mc-config-changed listener in useBoardColumns, and carried through RowShell to list and board rows. Every new SessionRow branch is gated on compactSessionCards, so full cards render as on main. The CrewRootSummaryLine extraction is a straight move with its needs-you count factored into a shared hook (same inputs), and the line keeps ROW_STATUS_LINE_CLS. The earlier blocking finding (marks inside [data-session-title], so a double-click started a rename and the scroll peek copied mark text) is fixed by CompactTitleRow placing marks beside the title, with a dblclick test. Owed, unread, muted, goal-loop/workflow/monitor-action, hidden-subtree, Crew Mode and code-channel states each get a labelled title-line mark, with focused tests. Failed CI checks are rate-limit or infrastructure failures, not code verdicts. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
- Blocking: title-only mode still hides two Crew Mode approval states.
Trigger: a remote crew worker reports group: "approval" and status: "needs_approval" without a local slot, or the root is running with crew_work.person > 0.
Outcome: the full card's CrewRootSummaryLine reports “1 needs you,” but compactAttention only checks local crewWaiting and the row resolver. The title-only card therefore shows no marker, or only a running dot. A required approval looks idle or still working, which breaks this PR's stated goal.
Please derive the title marker from the same needs-you aggregate used by CrewRootSummaryLine, and cover both remote-worker and root-ledger cases.
I reproduced this with Please return a valid tag list from this mock, then verify the test command exits 0. |
bolichen97
left a comment
There was a problem hiding this comment.
Requesting changes on 4c53c4f982, @rio-evrard. Thanks for the rebase. Both of Crew Captain's blockers are fixed on this head:
- Needs-you on title-only cards:
CompactCrewMarksandCrewRootSummaryLinenow read one count,useCrewRootNeedsYou. A remote worker in the approval group and a ledger item on a person both show thecrew_needs_youmarker, and the new tests cover both cases. - Vitest exit code: the
chatTagsandchatFoldersmocks now resolve to lists. Here, the sidebar, crew and ChatSettings suites pass with exit 0 (197 files, 2515 tests).tsc --noEmitand the line cap pass too, andSessionRow.tsxis at 1,985 lines.
I approved the 17 held fork runs on this head.
One blocker, from CI: Fast Gate's Source Gates job fails the feature-map gate (scripts/check_feature_map.py):
feature-map gate: this change adds or removes a dashboard feature but leaves docs/feature-map/README.md untouched.
added website/src/pages/chat-sidebar/CrewRootSummaryLine.tsx
added website/src/pages/chat-sidebar/compactTitleMarks.tsx
It reproduces here with FEATURE_MAP_BASE_REF=origin/main python3 scripts/check_feature_map.py. The fix is one row in docs/feature-map/README.md for Title-only session cards: what it does, the path (Settings → Chat → Sessions → Title-only session cards), and the frontend files (pages/chat-sidebar/SessionRow.tsx, pages/chat-sidebar/compactTitleMarks.tsx, pages/chat-sidebar/CrewRootSummaryLine.tsx, pages/settings/ChatPanel.tsx, pages/chat/ChatSettings.tsx). There is no backend handler. The fork AI lanes start only after Fast Gate passes, so they have not run on this head yet.
AI-assisted, sent by CommunityCrew
bolichen97
left a comment
There was a problem hiding this comment.
Requesting changes on 45d848f4dc, @rio-evrard. The feature-map row is in, and Fast Gate passes now. Opus 5.5, First Principles, Design, UX, Security Scope and Internal Content Scan pass on this head. I approved the 17 held fork runs on it.
Three things are left:
-
Merge conflict with main. GitHub reports the PR as conflicting. The only conflict is in
src/kiro_crew/docs/ui-index.generated.json, because main moved after your rebase. Rebase onto main and runnpm run gen:uiinwebsite/to regenerate the file; don't hand-merge it. -
GPT 6.1 blocker, upheld: a failed worker-list read is silent on a title-only card (
compactTitleMarks.tsx:69).CompactCrewMarkstakes onlylastWorkersandpausedfromuseCrewWorkerSummary. When the read fails (failed: true), the card shows stale counts or nothing. The full card'sErrorNoticelives inCrewRootSummaryLine, which is not mounted in title-only mode. That breaks the blockingerrors-use-error-noticerule. Readfailedand show the existing inline worker-listErrorNotice(with its hand-off), asCrewRootSummaryLinedoes. -
GPT 6.1 blocker, upheld: a running remote worker shows no activity (
compactTitleMarks.tsx:77). Theworkingprop comes fromcrewWorkinginSessionRow.tsx(line 399), which looks only at local slots. A root whose only running worker is remote (group: 'working'in the worker list) shows neither the live dot nor a running mark, while the hidden full card counts it as running. Take the running count from the merged list inside the component, asCrewRootSummaryLinedoes:crewRowCounts(summarizeCrewWorkers(lastWorkers)). Keep the current precedence (pause, then the needs-you mark, then a single dot).
Please add a test for each blocker: a failed crewWorkers read shows the notice on a title-only root, and a remote worker in the working group lights the root's dot. The frontend and backend test jobs were still running when I wrote this.
AI-assisted, sent by CommunityCrew
bolichen97
left a comment
There was a problem hiding this comment.
Requesting changes on 2cdd30095f, @rio-evrard. Against my last change request (5893572484):
- Failed worker-list read: fixed.
CompactCrewMarksreadsfailed, drops the stale needs-you count and shows the inline worker-listErrorNotice. Covered by "says a failed crew read on a title-only card, with no stale count". - Running remote worker: fixed. The dot also lights from the merged list's working count (
crewRowCounts(summarizeCrewWorkers(lastWorkers))). Covered by "lights the live dot on a title-only card while only a remote crew worker works". - Conflict with main: still open. Main moved again, and
src/kiro_crew/docs/ui-index.generated.jsonconflicts once more. Rebase and runnpm run gen:uiagain.
GPT 6.1, First Principles, Design, UX, Security Scope and Internal Content Scan pass on this head. I approved the 17 held fork runs on it.
New blocker, from Opus 5.5, which I checked on this head: the title-only marks render inside the [data-session-title] element (opened at SessionRow.tsx:1820). That covers CodeChannelRowMarks at line 1869 and CompactCrewMarks at line 1851, including its new ErrorNotice.
- The row's
onDoubleClick(line 1492) starts a rename when the target is inside[data-session-title].CodeChannelCrewTogglestops mousedown, pointerdown, click and auxclick, but not dblclick. So double-clicking the worker fold, the channel link or "Ask agent" toggles the fold twice and opens rename. - The scroll peek reads the title element's
textContent, so a clipped title would show the worker count, the channel state word or the error text glued to it. - Fix: put the compact marks in a sibling wrapper next to the title element (for example a flex row holding the marks and then the title div), so
[data-session-title]holds only the title text. A test that double-clicks a compact mark and checks that rename does not start would pin it.
The frontend, backend and E2E jobs were still running when I wrote this.
AI-assisted, sent by CommunityCrew
bolichen97
left a comment
There was a problem hiding this comment.
Requesting changes on a48f2c7194, @rio-evrard. Against my last change request (5896014424):
- Marks inside the title element: fixed.
CompactTitleRownow puts the marks in their own span next to[data-session-title], so double-clicking a mark no longer starts a rename and the scroll peek reads only the title. ui-index.generated.jsonconflict: fixed. The head merges cleanly into current main.
One blocker left, from GPT 6.1 and Opus 5.5 (both upheld), which I checked on this head: a failed crew read squeezes the title out of a title-only card.
CompactCrewMarksrenders the full inlineErrorNotice("Could not load the crew." plus "Ask the agent") whenfailedis true (compactTitleMarks.tsx:97).- It sits in the marks span, which is
inline-flex shrink-0(compactTitleMarks.tsx:110), so the span keeps the notice's full width. The notice's ownmin-w-0andtruncatecannot narrow it. - The title next to it is
flex-1 min-w-0, so at the 180px minimum sidebar width it gets little or no room, and the row'soverflow-hiddenclips the button. This lasts as long as the read keeps failing, on every Ultra Mode root row. - Fix: in the marks, show the failure as a fixed-size glyph (for example
TriangleAlertwithrole="img"and thecommandCenter.workers_errortext as its label and tooltip), and offer the hand-off somewhere off the title line. Please add a test that a failed read renders that glyph and keeps the title.
The other red checks on this head are not your code. PR Policy (it could not read the PR body), Dependency License Gate and Await Fast Gate hit the GitHub API rate limit, and Coverage Gate failed closed because the frontend tests were skipped after Await Fast Gate. They will run again on your next push.
AI-assisted, sent by CommunityCrew
bolichen97
left a comment
There was a problem hiding this comment.
Approving 41d34ec9ee, @rio-evrard. Against my last change request on a48f2c7194:
- Failed crew read squeezing the title: fixed.
CompactCrewMarksnow shows one fixed-sizeTriangleAlertglyph (session-compact-crew-error, labelled "Could not load the crew.") instead of the full inlineErrorNotice, so the marks span stays narrow and the title keeps its room. The test checks the label, that the glyph sits in the marks span, that the notice text is gone, and that[data-session-title]still reads "Crew root". - The rest of the diff since then is the rebase: the Ultra Mode → conductor mode renames, the
work.run.settledverdict forallDone, and the regeneratedui-index.generated.json.
I approved the 16 held fork runs on this head. Auto-merge is on. If E2E, Render Benchmark or i18n Render Gate go red with Playwright does not support chromium on ubuntu26.04-x64, that is the fork runner image, not this PR; it is tracked in #37647 and fixed by #37653.
AI-assisted, sent by Bolin Review bot
|
Two older change requests still hold this PR, and both look addressed on
AI-assisted, sent by Bolin Review bot |
|
@rio-evrard answering your question from Slack: I won't override GPT 6.1 here as it stands, but you don't need to bring the full inline GPT's point holds. On Please do both: keep the small warning icon on the title line, and make it a real button ( If you'd rather keep the plain icon, the alternative is to show the full card for that one row while its read has failed. That is also fine with me. AI-assisted, sent by Bolin Review bot |
Problem / Motivation
Goal: Let people reduce sidebar session cards to their titles with one optional setting.
The sidebar has separate controls for some card details, but no single title-only mode. People who organize many sessions by title still see repeated agent metadata, timestamps, activity previews, and linked-source chips.
Why it matters
A title-only option makes dense session lists faster to scan and keeps unrelated issue or pull-request references out of screenshots and screen shares.
Not a goal
What changed (motivation → approach → change)
A browser-local Title-only session cards switch now appears under Settings → Chat → Sessions, after Compact empty folders and Full titles on scroll, the other two settings that change how sidebar rows look. It defaults off, updates the mounted sidebar immediately, and persists with the existing chat display preferences.
When enabled, the shared session row keeps its title and hides the agent/timestamp metadata line, the secondary activity or message line, and linked source chips. A session that needs the user (an owed approval, an unanswered question, a waiting loop, an interrupted turn, a blocked or budget-stopped monitor, or an unread result) keeps one icon in front of its title, with the same glyph and label the full card uses, so it does not look idle. A goal loop, workflow run or monitor action lights the title-line live dot; a goal loop whose last turn was interrupted shows the danger loop icon instead. A collapsed conductor whose hidden sessions need the user shows the needs-you icon, and one whose hidden sessions are running shows the live dot. A Crew Mode root whose crew holds something for the user (a local or remote worker waiting on a tool approval, or a ledger item waiting on a person) shows the needs-you icon with the count and label of the full card's crew summary line, which it reads from the same hook, so the two cannot disagree. While a crew member works, local or remote (the worker list's working group, as the summary line counts it), the root lights the live dot. If the worker list cannot be read, the title line shows one fixed-size warning icon labelled with the summary line's error text, instead of stale counts. The full notice and its "Ask the agent" hand-off would push the title out of a narrow row, so they stay on the full card and in the Crew panel. Every Crew Mode root keeps its bolt on the title line, labelled with the mode's name, because the agent line that names the mode is hidden. A paused conductor mode crew keeps its Paused icon there, and a crew whose open work all waits in the workers' own loops keeps the running-crew icon. A Slack code channel conductor keeps its folded crew's state icon, its channel badge, its worker fold and its folded workers' most pressing want on the title line, since all of them sat on the hidden agent and status lines. A muted session keeps its labelled mute icon on the title line, because muting also suppresses chimes, toasts and unread markers. The other metadata-line markers (pinned, incognito or temporary memory, process released, location and connected-channel chips) are hidden with that line in title-only mode. The title-line marks live in
chat-sidebar/compactTitleMarks.tsxand render beside the title element, not inside it, so the row's double-click rename and the scroll peek read only the title text; and the crew summary line moves unchanged intochat-sidebar/CrewRootSummaryLine.tsxwith its needs-you count as a shared hook, which keepsSessionRow.tsxunder the 2,000-line cap. The same row component supplies list and board views, so both receive the same presentation without changing stored session data or provider refresh behavior.The generated documentation registry (
src/kiro_crew/docs/settings-registry.generated.json), command-palette registry (website/src/components/commandPalette/settingsRegistry.gen.ts), generated UI index, supported locale catalogs underwebsite/src/i18n, and focused tests describe and lock in the preference. This is broader than #21925, which hides only ordinary message previews while preserving the remaining card status and metadata.Backwards compatibility
Compatible: the new browser-local preference defaults to
false, so existing installations retain detailed session cards.Reader: website/src/pages/ChatSidebar.tsx:ChatSidebar -- chat -- reads the preference and passes it through the shared row shell.
Reader: website/src/pages/chat-sidebar/SessionRow.tsx:SessionRow -- chat -- hides only rendered card details when the preference is enabled; slot payloads and row actions are unchanged.
Reader: website/src/pages/settings/ChatPanel.tsx:ChatPanel -- settings -- writes the preference through the existing
mc-chat-configpath.Tests
ChatSettings.test.tsxcovers the detailed default, stored opt-in, and repair of invalid stored values.ChatSidebar.sourceLinkChip.test.tsxverifies that titles remain while the activity preview, timestamp, and source chips disappear; that a pending approval, an unread result and a muted session each keep a labelled title-line marker; that a workflow run and a goal loop light the live dot; that a stalled goal loop shows its interrupted marker and no live dot; that a collapsed conductor with a hidden session needing approval shows the needs-you icon, alongside the live dot when the conductor itself is working; that a Crew Mode root shows its crew's needs-you count for a local worker's approval, a remote worker's approval and a ledger item waiting on a person, and its Crew Mode mark; that a working crew member, local or remote only, lights the root's live dot; that a failed worker-list read shows the warning icon and keeps the title; that a paused conductor mode crew keeps its Paused mark; that a running crew keeps its running-crew marker; and that full cards get none of these extra cues. The mute and Crew Mode tests fail with theirSessionRow.tsxbranches removed.ChatSidebar.codeChannelCrew.test.tsxverifies that a title-only code channel conductor keeps its crew state, channel badge and worker fold on the title line. This test and the paused and running-crew tests fail with the fix removed.ChatSidebar.codeChannelCrew.test.tsxalso checks that double-clicking a title-only card's worker fold does not start a rename; that test fails with the fix removed.scripts/check_file_line_cap.pypasses.i18n:checkandgit diff --checkpassed; regenerating the settings registry and UI index produced no changes.Manual verification
Verified in an isolated local dashboard profile:
The screenshots use synthetic sessions and links. They show the title-only layout but not the title-line icons, which were added later and are covered by the tests above.
Screenshots / video
Related Issues
Part of #21239
Follow-ups left out of this PR: #29861 (collapsed-parent live-dot test), #29862 (pinned, incognito/temporary, popped-out and released icons), #29863 (setting description copy), #29864 (
history.mdspec paragraph).Related overlap: #21925 provides a narrower preview-only setting and intentionally keeps status indicators and other card details visible.
Checklist
Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of
CONTRIBUTING.md.