Repository navigation
feat(crew): remove the cold Recap greeting; the warm brief is the only return greeting - #23829
Conversation
Sensitive Change ReviewSensitive files changed:
|
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the owner asked for this removal, it reaches every layer, and no reader of the removed symbols, route or i18n keys is left in the tree. [DESIGN-REVIEWED] 76858cc Description read[DESCRIPTION-READ] 6d24560f3e820ed22e57529b6792ab06c09a34ea08c7f3ae2c9a0fa00d2397be That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ human override accepted@iamwhatever overrode this lane for |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: this PR only removes things, and both screenshots show the empty chat that is left (dark and light). Notes
[UX-REVIEWED] 76858cc Description read[DESCRIPTION-READ] 4a0eb5c60e600fd38c3ad8ab8a3d7f4879b023ee6c218305f8195ec68d38cf77 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
self-added: no
|
|
1700ec9 to
5bef70f
Compare
Sensitive change review
|
|
5bef70f to
45628b0
Compare
|
re-pinned after rebase -- needs a human to post as /ai-review override Rebased onto main 3d6764b to clear a merge conflict with #23566 (unread landing in ChatPane; its code is kept, only the greeting slot is removed). New head: |
Sensitive change review
|
|
|
re-pinned after rebase -- needs a human to post as /ai-review override Rebased onto main c4ce1ef to pick up #23867 (the Bundle Size Gate budget fix; a re-run reuses the old merge ref). No code change. New head: |
Sensitive change review
|
45628b0 to
7fc409d
Compare
|
Owner decision (iamwhatever): on 2026-10-24 I decided to remove the cold-start Recap card. The warm task brief is the only return greeting; the first-meeting welcome stays. I accept the product-shape concern First Principles raised. Posted by my Kiro Crew agent on my instruction of 2026-10-27. |
|
/ai-review override first-principles 7813363 owner-decision: owner removed the cold Recap card; the warm task brief is the only return greeting. Decision: #23829 (comment) |
Human judgment recorded@iamwhatever recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
…y return greeting
The owner decided the idle-chat Recap card has no value. Remove the card,
its hook, the ChatPane crewmateGreeting slot it alone used, the recap
client call, GET /api/members/{slug}/recap and member_recap.py, their
tests and the welcome_* i18n keys. An empty crewmate chat keeps its
existing hint; the warm task brief and the first welcome are unchanged.
7813363 to
76858cc
Compare
Sensitive change review
|
|
re-pinned after rebase -- needs a human to post as /ai-review override Rebased onto main 61c1fac, which has #24307 (the warm welcome as free-form text with an optional widget). Three conflicts, each one main's new lines next to a Recap line this PR removes: |
|
/ai-review override first-principles 76858cc owner-decision: owner removed the cold Recap card; the warm task brief is the only return greeting. Decision: #23829 (comment) |
Human judgment recorded@iamwhatever recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
buluoray
left a comment
There was a problem hiding this comment.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:
Approving at 76858ccce0.
- The take-away list is complete: a
Breaking:line forGET /api/members/{slug}/recapwith a writer sweep, plus sixReader:lines. No config key is removed. - The seven
welcome_*keys are gone from all 13 locales, and nothing at the head still references them or the removed code. - It reverses two earlier RFC decisions (
rfc-crewmate-greeting.md, andrfc-delayed-task-brief.mdwhich said the cold welcome stays). Both carry a dated amendment and the owner decision is recorded on this PR; nothing indocs/decisions/is reversed. - Intended gap, worth stating plainly: a user returning to a crewmate with no goal in flight now sees only the "Session ready" hint, since the warm brief needs an open task and 30+ minutes away.
- Mutations: 3/3 redden
test_allowlist_has_no_stale_entries,test_the_routes_and_the_package_reach_the_facade_objectsand the openThread empty-hint test. pytest 294 + vitest 283 pass; CI green.
Non-blocking follow-ups:
website/scripts/capture-first-mate-entrance.mjs:67still mocks/recap.rfc-crewmate-greeting-as-message.mdand lines 95-96 of the RFC README still describe the cold card.- The UX lane notes "Idle · 7h ago" next to "Session ready" reads as a contradiction.
Problem / Motivation
Goal: A crewmate chat no longer opens on the cold "Recap" card; the warm task brief is the only greeting a returning user sees.
Today an idle (6h+) crewmate chat with no open task shows a Recap card: paused goals plus three recent sessions. The product owner decided the card has no value and asked to remove it.
Why it matters
The Recap costs two reads on every long-idle open (
GET /api/crew-board, thenGET /api/members/{slug}/recap), one more surface to keep in sync with the warm brief, and copy in 13 locales, for a card the owner judged not useful.Not a goal
dashboard/warm_task_brief.py,components/chat/WarmBriefCard.tsx). Untouched.useFirstGreeting.ts,MateEntrance.tsx,POST /api/members/{slug}/greet). Untouched.What changed (motivation → approach → change)
Owner decision → delete every piece of the Recap and the slot that only it used → the empty crewmate chat falls back to its existing "Session ready" hint.
mateGreeting.ts(+ test),MateWelcomeCard.tsx,MateGreetingMessage.tsxanduseCrewmateGreetingShown.ts. ChatPane'screwmateGreetingprop is gone: the Recap was its only user (the warm brief is a transcript row, the first greeting a real turn).MembersPageThread.tsxno longer reads the board on open, no longer draws the "Couldn't read what X was working on" notice, andhideEmptyHintnow depends only on a failed thread or the entrance.api.memberRecapand theMemberRecaptype (website/src/api/client/agents.ts, re-export inwebsite/src/api/client.ts).member_recap.py,api_member_recapand theGET /api/members/{slug}/recaproute; dropped the name from the members facade, its frozen inventory, and the posture sink list.pages.membersPage.welcome_*keys from all 13 locales (website/src/i18n/locales/*.json: bn, de, en-XA, en, es, fr, hi, it, ja, ko, pt, ru, zh-CN).src/kiro_crew/docs/crew-members.md.rfc-crewmate-greeting.mdandrfc-delayed-task-brief.md; the feature-map row and the spec paragraph are updated.Decision record: the owner's ruling of 2026-10-24, recorded as an amendment in rfc-crewmate-greeting.md (accepted on main); a maintainer ruling may still be needed for the First Principles lane.
Backwards compatibility
Breaking:
GET /api/members/{slug}/recapis removed. Writer sweep on origin/main @ c4ce1ef:git grep -n -E "MemberRecap|member_recap|memberRecap|/recap\b|useMateGreeting|MateWelcomeCard|crewmateGreeting|kc-mate-welcomed"acrosssrc,test,website/src, app bundles and docs. Its only caller wasmateGreeting.ts, removed here.Reader: website/src/pages/members/mateGreeting.ts:useMateGreeting -- crew page -- removed with the card
Reader: website/src/pages/members/MembersPageThread.tsx:useMembersPageThreadView -- crew page -- no longer calls it; MembersPage.openThread.test.tsx "opening a long-idle mate with no goal in flight shows the empty-chat hint and reads no board"
Reader: website/src/components/ChatPane.tsx:crewmateGreeting -- crew page -- prop removed; no other host passed it (git grep finds none)
Reader: src/kiro_crew/dashboard/handlers/members.py:api_member_recap -- crew page -- facade name dropped; test_members_handler_facade.py, test_campaign_facades_base_public_names.py
Reader: src/kiro_crew/security_posture.py:member_recap.py -- release -- sink entry removed with the file; test_security_posture.py
Reader: localStorage kc-mate-welcomed- -- crew page -- no longer read or written; an old key is inert
Tests
MembersPage.openThread.test.tsx: the cold-welcome case is replaced by one that opens a 6h+ idle mate and checks the pane keeps its empty-chat hint and no board read happens; the mid-goal case now checks no board read on open; the board-failure notice case is removed with the notice.mateGreeting.test.ts,test/test_member_recap.pyand thecrewmateGreetingblock inChatPane.scrollChrome.test.tsx; dropped thememberRecapmock from 16 MembersPage test files.Proof: not provable -- frontend test (prove.py runs Python only)
Run locally: vitest on 26 files (656 passed: every touched test file plus
useFirstGreeting,MateEntrance,ChatPane.mateChat,warmTaskBrief); 7 i18n vitest files (167 passed) withI18N_BASE_REF=origin/main;npm run lint:i18n;npx tsc --noEmit; eslint on changed files;gen-ui-index --check; pytest ontest_members_handler_facade.py,test_campaign_facades_base_public_names.py,test_dashboard_agents_composition_contract.py,test_mate_welcome.py,test_members_parts_facade.py,test_security_posture*.py(390 passed).Manual verification
Real Members page (
capture/members-page.html, gateway-free, Playwright), Radar idle 7h, empty thread, no ledger, both themes: no/recaprequest, no/api/crew-boardread, no Recap card, the "Session ready" hint shows, no console or page errors.Checked nearby paths: first greeting and Mate entrance (
useFirstGreeting.test.tsx,MateEntrance.test.tsx,MembersPage.newCrewmate*.test.tsx: green, code untouched); empty-chat hint (test above + capture); warm brief (warmTaskBrief.test.tsxand the "return summary rows" case: green, code untouched); crew window and side chat render ChatPane withoutcrewmateGreeting(git grepfinds no other host;MembersPage.sideChat.test.tsxgreen).Screenshots / video
After, dark and light (the right panel's dashboard error is the gateway-free harness, unrelated):
Related Issues
Closes nothing: no issue tracks this; it is the product owner's direct decision.
Checklist
Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.