Skip to content

feat(crew): remove the cold Recap greeting; the warm brief is the only return greeting - #23829

Merged
iamwhatever merged 1 commit into
mainfrom
feat/remove-cold-recap
Oct 28, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
feat/remove-cold-recap

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A crewmate chat no longer opens on the cold "Recap" card; the warm task brief is the only greeting a returning user sees.

Today an idle (6h+) crewmate chat with no open task shows a Recap card: paused goals plus three recent sessions. The product owner decided the card has no value and asked to remove it.

Why it matters

The Recap costs two reads on every long-idle open (GET /api/crew-board, then GET /api/members/{slug}/recap), one more surface to keep in sync with the warm brief, and copy in 13 locales, for a card the owner judged not useful.

Not a goal

  • Changing the warm task brief (dashboard/warm_task_brief.py, components/chat/WarmBriefCard.tsx). Untouched.
  • Changing the first-time crewmate welcome or Mate's entrance (useFirstGreeting.ts, MateEntrance.tsx, POST /api/members/{slug}/greet). Untouched.
  • Replacing the Recap with anything new.

What changed (motivation → approach → change)

Owner decision → delete every piece of the Recap and the slot that only it used → the empty crewmate chat falls back to its existing "Session ready" hint.

  • Frontend: deleted mateGreeting.ts (+ test), MateWelcomeCard.tsx, MateGreetingMessage.tsx and useCrewmateGreetingShown.ts. ChatPane's crewmateGreeting prop is gone: the Recap was its only user (the warm brief is a transcript row, the first greeting a real turn). MembersPageThread.tsx no longer reads the board on open, no longer draws the "Couldn't read what X was working on" notice, and hideEmptyHint now depends only on a failed thread or the entrance.
  • Client: removed api.memberRecap and the MemberRecap type (website/src/api/client/agents.ts, re-export in website/src/api/client.ts).
  • Backend: removed member_recap.py, api_member_recap and the GET /api/members/{slug}/recap route; dropped the name from the members facade, its frozen inventory, and the posture sink list.
  • i18n: removed the 7 pages.membersPage.welcome_* keys from all 13 locales (website/src/i18n/locales/*.json: bn, de, en-XA, en, es, fr, hi, it, ja, ko, pt, ru, zh-CN).
  • User doc: dropped the welcome-card paragraph from src/kiro_crew/docs/crew-members.md.
  • Docs: dated amendment line in rfc-crewmate-greeting.md and rfc-delayed-task-brief.md; the feature-map row and the spec paragraph are updated.

Decision record: the owner's ruling of 2026-10-24, recorded as an amendment in rfc-crewmate-greeting.md (accepted on main); a maintainer ruling may still be needed for the First Principles lane.

Backwards compatibility

Breaking: GET /api/members/{slug}/recap is removed. Writer sweep on origin/main @ c4ce1ef: git grep -n -E "MemberRecap|member_recap|memberRecap|/recap\b|useMateGreeting|MateWelcomeCard|crewmateGreeting|kc-mate-welcomed" across src, test, website/src, app bundles and docs. Its only caller was mateGreeting.ts, removed here.

Reader: website/src/pages/members/mateGreeting.ts:useMateGreeting -- crew page -- removed with the card
Reader: website/src/pages/members/MembersPageThread.tsx:useMembersPageThreadView -- crew page -- no longer calls it; MembersPage.openThread.test.tsx "opening a long-idle mate with no goal in flight shows the empty-chat hint and reads no board"
Reader: website/src/components/ChatPane.tsx:crewmateGreeting -- crew page -- prop removed; no other host passed it (git grep finds none)
Reader: src/kiro_crew/dashboard/handlers/members.py:api_member_recap -- crew page -- facade name dropped; test_members_handler_facade.py, test_campaign_facades_base_public_names.py
Reader: src/kiro_crew/security_posture.py:member_recap.py -- release -- sink entry removed with the file; test_security_posture.py
Reader: localStorage kc-mate-welcomed- -- crew page -- no longer read or written; an old key is inert

Tests

  • MembersPage.openThread.test.tsx: the cold-welcome case is replaced by one that opens a 6h+ idle mate and checks the pane keeps its empty-chat hint and no board read happens; the mid-goal case now checks no board read on open; the board-failure notice case is removed with the notice.
  • Removed mateGreeting.test.ts, test/test_member_recap.py and the crewmateGreeting block in ChatPane.scrollChrome.test.tsx; dropped the memberRecap mock from 16 MembersPage test files.

Proof: not provable -- frontend test (prove.py runs Python only)

Run locally: vitest on 26 files (656 passed: every touched test file plus useFirstGreeting, MateEntrance, ChatPane.mateChat, warmTaskBrief); 7 i18n vitest files (167 passed) with I18N_BASE_REF=origin/main; npm run lint:i18n; npx tsc --noEmit; eslint on changed files; gen-ui-index --check; pytest on test_members_handler_facade.py, test_campaign_facades_base_public_names.py, test_dashboard_agents_composition_contract.py, test_mate_welcome.py, test_members_parts_facade.py, test_security_posture*.py (390 passed).

Manual verification

Real Members page (capture/members-page.html, gateway-free, Playwright), Radar idle 7h, empty thread, no ledger, both themes: no /recap request, no /api/crew-board read, no Recap card, the "Session ready" hint shows, no console or page errors.

Checked nearby paths: first greeting and Mate entrance (useFirstGreeting.test.tsx, MateEntrance.test.tsx, MembersPage.newCrewmate*.test.tsx: green, code untouched); empty-chat hint (test above + capture); warm brief (warmTaskBrief.test.tsx and the "return summary rows" case: green, code untouched); crew window and side chat render ChatPane without crewmateGreeting (git grep finds no other host; MembersPage.sideChat.test.tsx green).

Screenshots / video

After, dark and light (the right panel's dashboard error is the gateway-free harness, unrelated):

idle crewmate chat, no Recap, dark

idle crewmate chat, no Recap, light

Related Issues

Closes nothing: no issue tracks this; it is the product owner's direct decision.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 24, 2026 20:57
@iamwhatever
iamwhatever requested a review from buluoray October 24, 2026 20:57
@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/security_posture.py

  • @iamwhatever posted a complete reasoning template for 76858cc.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 24, 2026
@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 76858ccce0853ee6fa579b953dface2bd88d7a49 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the owner asked for this removal, it reaches every layer, and no reader of the removed symbols, route or i18n keys is left in the tree.

[DESIGN-REVIEWED] 76858cc

Description read

[DESCRIPTION-READ] 6d24560f3e820ed22e57529b6792ab06c09a34ea08c7f3ae2c9a0fa00d2397be

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@iamwhatever overrode this lane for 76858ccce0853ee6fa579b953dface2bd88d7a49 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 76858ccce0853ee6fa579b953dface2bd88d7a49 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: this PR only removes things, and both screenshots show the empty chat that is left (dark and light).

Notes

  • With the Recap gone, a long-idle mate now shows only "Session ready. Type a message to start." under "Idle · 7h ago". The blind reader saw these as contradicting each other: "One sounds brand new, the other says something happened 7 hours ago, and the chat is empty." A follow-up could reword the hint for a mate that has been active before (for example "Radar was last active 7h ago. Type a message to pick up.") or link the pill to the work log.

[UX-REVIEWED] 76858cc

Description read

[DESCRIPTION-READ] 4a0eb5c60e600fd38c3ad8ab8a3d7f4879b023ee6c218305f8195ec68d38cf77

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 76858ccce0853ee6fa579b953dface2bd88d7a49 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 76858cc

Verdict parsed from the review's SHA-scoped output markers for commit 76858ccce0853ee6fa579b953dface2bd88d7a49.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 76858ccce0853ee6fa579b953dface2bd88d7a49 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 76858ccce0853ee6fa579b953dface2bd88d7a49 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 76858cc

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 76858ccce0853ee6fa579b953dface2bd88d7a49 false-positive: <reason, 20 to 500 characters>

@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=f195b6ba5028 user doc still describes the removed welcome card

fixed in 5bef70f: dropped the welcome-card paragraph from src/kiro_crew/docs/crew-members.md.
Class sweep: git grep -n -i -E "welcome card|six hours|recap|left open|Hide recap" -- src/kiro_crew/docs website/docs README.md now finds no Recap description; the one "six hours" hit is the unrelated feature-tips cadence.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=5ed79d2d8d2e product-shape change without accepted RFC — removal of the cold Recap

needs-a-decision: the removal is the product owner's decision of 2026-10-24, recorded here as an amendment to the accepted rfc-crewmate-greeting.md; no separate RFC is on main.
Maintainer: please record it with /ai-review override first-principles <head-sha> product-shape: <decision> on the current head, or say if you want a standalone RFC merged first.

@iamwhatever
iamwhatever force-pushed the feat/remove-cold-recap branch from 1700ec9 to 5bef70f Compare October 24, 2026 21:10
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 5bef70f
  • What rule changed: one entry, member_recap.py, leaves the redaction-sink module list in src/kiro_crew/security_posture.py, because this PR deletes that module and the route it served.
  • Before -> after (what was allowed/blocked, now): before, member_recap.py was listed as a helper behind the members dashboard HTTP surface; after, the file and its route GET /api/members/{slug}/recap no longer exist, so nothing is listed for them. No other entry, rule or check changes.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): the posture test would flag a listed module that does not exist; no secret path opens, since the removed route was the only output of that module.
  • Evidence checked (which sandbox result proves it): test/test_security_posture.py and test/test_security_posture_facade.py pass locally (70 passed), including test_every_named_sink_module_actually_redacts.
  • No regression:
    • Tools still work (which tools/commands were run, result): targeted pytest (390 passed), vitest on 33 files, tsc, eslint, i18n lint: all green.
    • Backward compatible (old config / old data / old callers still work, how checked): the only caller of the removed route was the removed frontend hook; git grep for member_recap|memberRecap|/recap finds no other reader.
    • Existing tests (which suites passed on this head): the CI suites on this head; locally the files listed above.
  • How to undo: revert this PR's commit.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=5102a9e8889b product-shape change without accepted RFC: removing the cold welcome

needs-a-decision: the removal is the product owner's decision of 2026-10-24, recorded as an amendment to the accepted rfc-crewmate-greeting.md; no separate RFC is on main.
Maintainer: please record it with /ai-review override first-principles 5bef70fb7b3152260890a5de9565e86a1fc93c63 product-shape: <decision>, or say if a standalone RFC should merge first.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 24, 2026
@iamwhatever
iamwhatever force-pushed the feat/remove-cold-recap branch from 5bef70f to 45628b0 Compare October 25, 2026 00:12
@iamwhatever

Copy link
Copy Markdown
Contributor Author

re-pinned after rebase -- needs a human to post as /ai-review override

Rebased onto main 3d6764b to clear a merge conflict with #23566 (unread landing in ChatPane; its code is kept, only the greeting slot is removed). New head: 45628b0f8a49b7bb82cbdb6aad53e02793d5c813.

/ai-review override first-principles 45628b0f8a49b7bb82cbdb6aad53e02793d5c813 product-shape: the product owner decided on 2026-10-24 to remove the cold Recap; the warm task brief is the only return greeting.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 45628b0
  • What rule changed: one entry, member_recap.py, leaves the redaction-sink module list in src/kiro_crew/security_posture.py, because this PR deletes that module and the route it served.
  • Before -> after (what was allowed/blocked, now): before, member_recap.py was listed as a helper behind the members dashboard HTTP surface; after, the file and its route GET /api/members/{slug}/recap no longer exist, so nothing is listed for them. No other entry, rule or check changes.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): the posture test would flag a listed module that does not exist; no secret path opens, since the removed route was the only output of that module.
  • Evidence checked (which sandbox result proves it): test/test_security_posture.py and test/test_security_posture_facade.py pass locally (70 passed), including test_every_named_sink_module_actually_redacts.
  • No regression:
    • Tools still work (which tools/commands were run, result): targeted pytest (390 passed), vitest on 33 files, tsc, eslint, i18n lint: all green.
    • Backward compatible (old config / old data / old callers still work, how checked): the only caller of the removed route was the removed frontend hook; git grep for member_recap|memberRecap|/recap finds no other reader.
    • Existing tests (which suites passed on this head): the CI suites on this head; locally the files listed above.
  • How to undo: revert this PR's commit.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 25, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=ddebeb1c1fbd product-shape change without accepted RFC: removing the cold Recap

needs-a-decision: the removal is the product owner's decision of 2026-10-24, recorded as an amendment to the accepted rfc-crewmate-greeting.md; no separate RFC is on main.
Maintainer: please record it with /ai-review override first-principles 45628b0f8a49b7bb82cbdb6aad53e02793d5c813 product-shape: <decision>, or say if a standalone RFC should merge first.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 25, 2026
@iamwhatever

iamwhatever commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor Author

re-pinned after rebase -- needs a human to post as /ai-review override

Rebased onto main c4ce1ef to pick up #23867 (the Bundle Size Gate budget fix; a re-run reuses the old merge ref). No code change. New head: 7fc409dc4f864376542ad323e5e6e29e3638c732.

/ai-review override first-principles 7fc409dc4f864376542ad323e5e6e29e3638c732 product-shape: the product owner decided on 2026-10-24 to remove the cold Recap; the warm task brief is the only return greeting.

@iamwhatever

iamwhatever commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 7fc409d
  • What rule changed: one entry, member_recap.py, leaves the redaction-sink module list in src/kiro_crew/security_posture.py, because this PR deletes that module and the route it served.
  • Before -> after (what was allowed/blocked, now): before, member_recap.py was listed as a helper behind the members dashboard HTTP surface; after, the file and its route GET /api/members/{slug}/recap no longer exist, so nothing is listed for them. No other entry, rule or check changes.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): the posture test would flag a listed module that does not exist; no secret path opens, since the removed route was the only output of that module.
  • Evidence checked (which sandbox result proves it): test/test_security_posture.py and test/test_security_posture_facade.py pass locally (70 passed), including test_every_named_sink_module_actually_redacts.
  • No regression:
    • Tools still work (which tools/commands were run, result): targeted pytest (390 passed), vitest on the touched files, tsc, eslint, i18n lint: all green.
    • Backward compatible (old config / old data / old callers still work, how checked): the only caller of the removed route was the removed frontend hook; git grep for member_recap|memberRecap|/recap finds no other reader.
    • Existing tests (which suites passed on this head): the CI suites on this head; locally the files listed above.
  • How to undo: revert this PR's commit.

@iamwhatever
iamwhatever force-pushed the feat/remove-cold-recap branch from 45628b0 to 7fc409d Compare October 25, 2026 01:50
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 27, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Owner decision (iamwhatever): on 2026-10-24 I decided to remove the cold-start Recap card. The warm task brief is the only return greeting; the first-meeting welcome stays. I accept the product-shape concern First Principles raised. Posted by my Kiro Crew agent on my instruction of 2026-10-27.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 7813363 owner-decision: owner removed the cold Recap card; the warm task brief is the only return greeting. Decision: #23829 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@iamwhatever recorded a owner-decision release (class owner-decision) for the first-principles AI finding on 7813363e4a7eafbb30e91e834843aa809d0db8d4.

owner removed the cold Recap card; the warm task brief is the only return greeting. Decision: #23829 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention labels Oct 27, 2026
…y return greeting

The owner decided the idle-chat Recap card has no value. Remove the card,
its hook, the ChatPane crewmateGreeting slot it alone used, the recap
client call, GET /api/members/{slug}/recap and member_recap.py, their
tests and the welcome_* i18n keys. An empty crewmate chat keeps its
existing hint; the warm task brief and the first welcome are unchanged.
@iamwhatever
iamwhatever force-pushed the feat/remove-cold-recap branch from 7813363 to 76858cc Compare October 28, 2026 16:19
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 76858cc
  • What rule changed: one entry, member_recap.py, leaves the redaction-sink module list in src/kiro_crew/security_posture.py, because this PR deletes that module and the route it served.
  • Before -> after (what was allowed/blocked, now): before, member_recap.py was listed as a helper behind the members dashboard HTTP surface; after, the file and its route GET /api/members/{slug}/recap no longer exist, so nothing is listed for them. No other entry, rule or check changes.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): the posture test would flag a listed module that does not exist; no secret path opens, since the removed route was the only output of that module.
  • Evidence checked (which sandbox result proves it): test/test_security_posture.py passes locally on this head (56 passed).
  • No regression:
    • Tools still work (which tools/commands were run, result): on this head, test/test_members_handler_facade.py (11 passed), test/test_crew_log_fullscan_guard.py (13 passed, 3 xfailed), tsc -b (0 errors) and vitest on ApiClient.refactor.surface (182), ChatPane.scrollChrome (4), MembersPage.openThread (27), MembersPage (27) and MembersPage.sidePanel (37): all passed.
    • Backward compatible (old config / old data / old callers still work, how checked): the only caller of the removed route was the removed frontend hook; git grep for member_recap|memberRecap|crewmateGreeting|greetingShown finds no code reader after the rebase onto feat(dashboard): the warm welcome is free-form text with an optional widget #24307.
    • Existing tests (which suites passed on this head): the CI suites on this head; locally the files listed above.
  • How to undo: revert this PR's commit.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Oct 28, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

re-pinned after rebase -- needs a human to post as /ai-review override

Rebased onto main 61c1fac, which has #24307 (the warm welcome as free-form text with an optional widget). Three conflicts, each one main's new lines next to a Recap line this PR removes: website/src/components/ChatPane.tsx (kept useMarkTranscriptShown, dropped useCrewmateGreetingShown) and the MembersPage.test.tsx / MembersPage.sidePanel.test.tsx mocks (kept chatSlotEnvironment, dropped memberRecap). No warm-brief code changed. New head: 76858ccce0853ee6fa579b953dface2bd88d7a49. The override for 7813363 no longer counts.

/ai-review override first-principles 76858ccce0853ee6fa579b953dface2bd88d7a49 owner-decision: owner removed the cold Recap card; the warm task brief is the only return greeting. Decision: https://github.com/kirodotdev/KiroCrew/pull/23829#issuecomment-6452984131

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 28, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 76858cc owner-decision: owner removed the cold Recap card; the warm task brief is the only return greeting. Decision: #23829 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@iamwhatever recorded a owner-decision release (class owner-decision) for the first-principles AI finding on 76858ccce0853ee6fa579b953dface2bd88d7a49.

owner removed the cold Recap card; the warm task brief is the only return greeting. Decision: #23829 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 28, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

Approving at 76858ccce0.

  • The take-away list is complete: a Breaking: line for GET /api/members/{slug}/recap with a writer sweep, plus six Reader: lines. No config key is removed.
  • The seven welcome_* keys are gone from all 13 locales, and nothing at the head still references them or the removed code.
  • It reverses two earlier RFC decisions (rfc-crewmate-greeting.md, and rfc-delayed-task-brief.md which said the cold welcome stays). Both carry a dated amendment and the owner decision is recorded on this PR; nothing in docs/decisions/ is reversed.
  • Intended gap, worth stating plainly: a user returning to a crewmate with no goal in flight now sees only the "Session ready" hint, since the warm brief needs an open task and 30+ minutes away.
  • Mutations: 3/3 redden test_allowlist_has_no_stale_entries, test_the_routes_and_the_package_reach_the_facade_objects and the openThread empty-hint test. pytest 294 + vitest 283 pass; CI green.

Non-blocking follow-ups:

  1. website/scripts/capture-first-mate-entrance.mjs:67 still mocks /recap.
  2. rfc-crewmate-greeting-as-message.md and lines 95-96 of the RFC README still describe the cold card.
  3. The UX lane notes "Idle · 7h ago" next to "Session ready" reads as a contradiction.

@iamwhatever
iamwhatever merged commit b7dbc19 into main Oct 28, 2026
204 of 214 checks passed
@iamwhatever
iamwhatever deleted the feat/remove-cold-recap branch October 28, 2026 20:55
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants