Repository navigation
feat(dashboard): the warm welcome is free-form text with an optional widget - #24307
Conversation
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing the brief's widget. No screenshot shows the sandboxed widget this PR adds below the body, and the PR says that capture is "still to come". Evidence gaps
Notes
[UX-REVIEWED] 9c8fb40 Description read[DESCRIPTION-READ] f8b2e5cb5542544b5a977e3d55566240d8cd319a6f1f820556c684a68d9561ff That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the widget reuses the chat Notes
[DESIGN-REVIEWED] 9c8fb40 Description read[DESCRIPTION-READ] 18f957818d7f42960ca44ec7b5a6c6222b9be9f10fbbd16ac9e20971c830dc5f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ human override accepted@iamwhatever overrode this lane for |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
re-pinned for this head -- needs a human to post as /ai-review override First Principles blocks on product shape: the free-form body and HTML widget have no accepted RFC on the base. The owner chose this shape (option B) on 2026-10-26; the RFC amendment in this PR records it. Proposed override line: The lane's item 7 note (drop the older-field parse branches) is advisory: those branches keep a model that still returns the #23847 shape working, and removing them would rewrite many existing tests beyond this PR's budget. |
31ce78c to
028aad7
Compare
|
re-pinned for this head -- needs a human to post as /ai-review override New head after fixing the GPT redaction finding (the body and widget are now redacted as a whole before and after The older override line for |
|
/ai-review override first-principles 028aad7 product-shape: Owner chose option B on 2026-10-26: free-form plain-text body plus an optional widget drawn in the existing WidgetFrame sandbox with no new grants. Progress stays gateway-counted from the ledger; content stays plain text. The RFC amendment in this PR records the decision. |
|
AI-review override not recorded: |
028aad7 to
1bcf4b0
Compare
|
re-pinned for this head -- needs a human to post as /ai-review override Rebased onto main after #24512 (one RFC status-list conflict: kept both amendment lines). Code diff unchanged. Proposed override line for head The earlier override lines for |
1bcf4b0 to
6fa7a34
Compare
|
re-pinned for this head -- needs a human to post as /ai-review override New head after the UX fix: the widget prompt now forbids chips, pills and done/pending step marks, and asks for no own background or font. The First Principles product-shape block is unchanged. Proposed override line for head The earlier override lines for Inherited red, not from this diff: both backend shard 2 jobs fail |
6fa7a34 to
9c8fb40
Compare
|
/ai-review override first-principles 9c8fb40 product-shape: Owner chose option B on 2026-10-26: free-form plain-text body plus an optional widget drawn in the existing WidgetFrame sandbox with no new grants. Progress stays gateway-counted from the ledger; content stays plain text. The RFC amendment in this PR records the decision. |
|
AI-review override not recorded: |
|
re-pinned for this head -- needs a human to post as /ai-review override Rebased onto main after #24774 (no conflicts, code diff unchanged). First Principles blocks again on product shape. Proposed override line for head The earlier override lines for older heads no longer apply. |
|
Owner decision (iamwhatever): on 2026-10-26 I chose option B for the warm brief: free-form plain-text body plus an optional widget in the existing WidgetFrame sandbox, no new grants. Progress stays counted by the gateway from the ledger. I accept the product-shape concern First Principles raised. Posted by my Kiro Crew agent on my instruction of 2026-10-27. |
|
/ai-review override first-principles 9c8fb40 owner-decision: owner chose option B, free-form brief plus optional sandboxed widget, progress gateway-counted. Decision: #24307 (comment) |
Human judgment recorded@iamwhatever recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
Bring the delayed-task-brief RFC and its directory index into agreement with the document's amendments and with what shipped on main. The warm task brief shipped in #20422 and its amendments shipped in #21750, #22828, #22839, #23847, #24512 and #24307, but the RFC still read `accepted` ("nothing built yet") with implementation-prs [] and a 2026-10-14 audit stamp. The front matter now records status implemented, those seven PRs, and last-audited 2026-10-28 at 7cbf872; the section 1 status and "Audited on" lines match it; and the snapshot's third field is renamed "Suggested actions" to match the section 3.5 output it feeds. The README index row no longer describes the superseded preparing-status design or says implementation waits for the RFC. It reads implemented, names the shipped PRs, and summarises the shipped trigger, the free-form brief card and the leave-after-opener rule. The audit paragraph gains a dated re-audit sentence for the row. Closes #20887
Bring the delayed-task-brief RFC and its directory index into agreement with the document's amendments and with what shipped on main. The warm task brief shipped in #20422 and its amendments shipped in #21750, #22828, #22839, #23847, #24512 and #24307, but the RFC still read `accepted` ("nothing built yet") with implementation-prs [] and a 2026-10-14 audit stamp. The 2026-10-28 writer amendment (section 3.8, #25433) is design only: main has no wake turn and no `dashboard.warm_brief_wake` setting. So the front matter now records status partial, those seven PRs, and last-audited 2026-10-29 at 4d36177; the section 1 status line names what shipped and that section 3.8 is not built; the "Audited on" line matches; and the snapshot's third field is renamed "Suggested actions" to match the section 3.5 output it feeds. The README index row no longer describes the superseded preparing-status design or says implementation waits for the RFC. It reads partial, names the shipped PRs, summarises the shipped trigger, the free-form brief card and the leave-after-opener rule, and names the unbuilt writer amendment. The audit paragraph gains a dated re-audit sentence for the row. Closes #20887
…21712) Bring the delayed-task-brief RFC and its directory index into agreement with the document's amendments and with what shipped on main. The warm task brief shipped in #20422 and its amendments shipped in #21750, #22828, #22839, #23847, #24512, #24307, #25881 (Crew Mode scope), #26500 (fixed progress orb) and #26652 (first part of the 2026-10-31 redesign), yet the front matter and README row still read `accepted` ("nothing built yet") with implementation-prs [] and a 2026-10-14 audit stamp. Not built on main: the 2026-10-28 writer amendment (section 3.8; main has no wake turn and no `dashboard.warm_brief_wake` setting), the 2026-11-01 trigger amendment (#26938 is open), and the live checks, links and copied option buttons of section 3.9.3. So the front matter now records status partial, those ten PRs, and last-audited 2026-11-01 at fed53fc; the section 1 status line names what shipped and what is not built; the "Audited on" line matches; and the snapshot's third field is renamed "Suggested actions" to match the section 3.5 output it feeds. The README index row no longer describes the superseded preparing-status design or says implementation waits for the RFC. It reads partial, names the shipped PRs, summarises the shipped trigger, the one-message brief with its fixed card and quiet return, and names the unbuilt parts. The audit paragraph gains a dated re-audit sentence for the row. Closes #20887
Problem / Motivation
Goal: the warm welcome a crewmate posts when the owner comes back keeps the key facts but reads like a teammate catching them up, not a form.
After #23847 the brief is a fixed set of labelled sections (status, Needs you, Progress, You asked, Done, Next). The owner finds it stiff and formal.
Why it matters
The brief is the first thing the owner reads after time away. A form they skim past saves them nothing; a short, warm catch-up with a picture when one helps gets read.
Not a goal
<mcwidget>already has.content.What changed (motivation → approach → change)
body: short paragraphs or lines, emoji welcome, plain textwidget, drawn below the text in the same sandboxedWidgetFramea chat<mcwidget>usesThe status chip, the highlighted Needs you box and the progress bar stay. The widget prompt asks for theme variables, a fit at 320 px, animation only under
prefers-reduced-motion: no-preference, and no scripts, buttons, links or numbers the snapshot lacks. The widget is redacted and defanged like every other field, and dropped whole when over its cap. It goes only intometa.brief; the row's plain-textcontentnever holds it, so copy, export and search stay clean text.The decision is a dated 2026-10-26 amendment in
docs/request-for-change/rfc-delayed-task-brief.md; the session and history specs name the new fields.Security: the widget gets no new grants: it is the existing chat widget frame (
sandbox="allow-scripts", null origin, CSP, host link bridge). Its HTML is model output grounded in an untrusted snapshot, the same trust level as any chat widget. The owner chose this option.Backwards compatibility
Compatible: briefs stored in the #23847 shape and the older
asked/now/needs_you/nextshape still parse and draw. A model that still returns the older fields is read as before.Tests
test/test_warm_task_brief_shape.py: body keeps lines, folds blank runs, caps lines and length, and replaces the quoted-request fallback; widget unwrapped from an<mcwidget>tag, kept in meta only, dropped whole over the cap; body and widget join every redaction and control-marker case; a marker opener split across body lines is defanged; prompt carries the widget rules.website/src/test/warmTaskBrief.test.tsx: body drawn after progress with its lines, widget mounted inWidgetFrame; oversize or non-string body and widget dropped; search counts body text and not widget text.Proof: not provable -- other: a feature change, not a fix; the new tests pin new behaviour
Screenshots / video
Real Members page, gateway-free capture (dev build, API route-intercepted). Card fits the viewport and no page errors in every frame.
After, a free-form body (dark, 1280 px):
The earlier widget sample drew step chips, which the widget prompt now forbids (no chips, pills or done/pending marks, no own background or font), so it is removed here. A widget capture that follows the new rules is still to come: the build host is out of memory and the browser capture timed out.
Older brief still draws
Related Issues
Closes #24306
Checklist