Skip to content

feat(dashboard): the warm welcome is free-form text with an optional widget - #24307

Merged
chenmingwei23 merged 1 commit into
mainfrom
warm-brief-loosen
Oct 27, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
warm-brief-loosen

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: the warm welcome a crewmate posts when the owner comes back keeps the key facts but reads like a teammate catching them up, not a form.

After #23847 the brief is a fixed set of labelled sections (status, Needs you, Progress, You asked, Done, Next). The owner finds it stiff and formal.

Why it matters

The brief is the first thing the owner reads after time away. A form they skim past saves them nothing; a short, warm catch-up with a picture when one helps gets read.

Not a goal

  • Changing when the brief fires, the opener, the failure line, spend (one model call), redaction or staleness rules.
  • Letting the model report progress numbers: the count stays the gateway's, from the work ledger.
  • Giving the widget any grant beyond what a chat <mcwidget> already has.
  • Putting HTML into the row's plain-text content.

What changed (motivation → approach → change)

Part Before After
Prompt a manager's report with eight fixed fields names the facts the owner must come away with (what needs them and what it unblocks, the ask, distance to the goal, what is next) and lets the model pick tone and layout
Text one short line per labelled field a free-form body: short paragraphs or lines, emoji welcome, plain text
Picture none an optional widget, drawn below the text in the same sandboxed WidgetFrame a chat <mcwidget> uses
Progress gateway count unchanged: gateway count from the work ledger; the model is told never to repeat or draw it

The status chip, the highlighted Needs you box and the progress bar stay. The widget prompt asks for theme variables, a fit at 320 px, animation only under prefers-reduced-motion: no-preference, and no scripts, buttons, links or numbers the snapshot lacks. The widget is redacted and defanged like every other field, and dropped whole when over its cap. It goes only into meta.brief; the row's plain-text content never holds it, so copy, export and search stay clean text.

The decision is a dated 2026-10-26 amendment in docs/request-for-change/rfc-delayed-task-brief.md; the session and history specs name the new fields.

Security: the widget gets no new grants: it is the existing chat widget frame (sandbox="allow-scripts", null origin, CSP, host link bridge). Its HTML is model output grounded in an untrusted snapshot, the same trust level as any chat widget. The owner chose this option.

Backwards compatibility

Compatible: briefs stored in the #23847 shape and the older asked/now/needs_you/next shape still parse and draw. A model that still returns the older fields is read as before.

Tests

  • test/test_warm_task_brief_shape.py: body keeps lines, folds blank runs, caps lines and length, and replaces the quoted-request fallback; widget unwrapped from an <mcwidget> tag, kept in meta only, dropped whole over the cap; body and widget join every redaction and control-marker case; a marker opener split across body lines is defanged; prompt carries the widget rules.
  • website/src/test/warmTaskBrief.test.tsx: body drawn after progress with its lines, widget mounted in WidgetFrame; oversize or non-string body and widget dropped; search counts body text and not widget text.

Proof: not provable -- other: a feature change, not a fix; the new tests pin new behaviour

Screenshots / video

Real Members page, gateway-free capture (dev build, API route-intercepted). Card fits the viewport and no page errors in every frame.

After, a free-form body (dark, 1280 px):

chinese

The earlier widget sample drew step chips, which the widget prompt now forbids (no chips, pills or done/pending marks, no own background or font), so it is removed here. A widget capture that follows the new rules is still to come: the build host is out of memory and the browser capture timed out.

Older brief still draws

before dark 1280

before light 320

Related Issues

Closes #24306

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 26, 2026 05:55
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 26, 2026
@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 9c8fb407df32ef38c85773745ffcd4a81f25353d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing the brief's widget. No screenshot shows the sandboxed widget this PR adds below the body, and the PR says that capture is "still to come".

Evidence gaps

  • The warm-brief-widget block (<WidgetFrame html={brief.widget} …/> under the body) appears in none of shot-01 to shot-03. It needs a screenshot of a brief with a widget that follows the new rules, in dark and light themes and at narrow width, so a reviewer can judge its fit, its spacing against the body, and that it adds no second container.

Notes

  • Raw list markers in the body: whitespace-pre-line draws the model's - list markers as literal text. The blind reader saw "- 下一步:重跑分片" and said the "- " "looks like a list marker that didn't get formatted". Tell the model in the prompt not to use markdown list markers, or remove them before drawing.
  • Mixed languages: the card's labels are English ("Blocked", "Needs you", "1 of 3 done") but in shot-01 the body is in Chinese, and the blind reader said "sure it's mixed, no idea why". Make the body follow the UI language, or say in the PR why it shouldn't.
  • No way to act on "Needs you": all three shots ask the owner to "approve the push" but offer no control. The reader said "I don't know how I'm supposed to approve." That's outside this PR's goal, so it's a follow-up.

[UX-REVIEWED] 9c8fb40

Description read

[DESCRIPTION-READ] f8b2e5cb5542544b5a977e3d55566240d8cd319a6f1f820556c684a68d9561ff

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 9c8fb407df32ef38c85773745ffcd4a81f25353d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the widget reuses the chat <mcwidget> frame with no new grants, older briefs still parse and draw, and the gateway still owns the progress count.

Notes

  • No capture shows the widget yet; the description says so ("A widget capture that follows the new rules is still to come"). WidgetFrame has its own toolbar, including open-in-new-tab and a link bridge, so a capture should show whether those controls look right inside a card that promises "never a link or a button".
  • The rules against scripts and clickable elements live only in the prompt. WidgetFrame runs allow-scripts, and the snapshot it is built from is untrusted, so these rules are a request to the model and nothing enforces them. That is the same trust level as chat, but here the widget is drawn without the owner having asked for it.

[DESIGN-REVIEWED] 9c8fb40

Description read

[DESCRIPTION-READ] 18f957818d7f42960ca44ec7b5a6c6222b9be9f10fbbd16ac9e20971c830dc5f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@iamwhatever overrode this lane for 9c8fb407df32ef38c85773745ffcd4a81f25353d via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 9c8fb407df32ef38c85773745ffcd4a81f25353d — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 9c8fb40

Verdict parsed from the review's SHA-scoped output markers for commit 9c8fb407df32ef38c85773745ffcd4a81f25353d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 9c8fb407df32ef38c85773745ffcd4a81f25353d false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 9c8fb407df32ef38c85773745ffcd4a81f25353d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 9c8fb40

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 9c8fb407df32ef38c85773745ffcd4a81f25353d false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 26, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

re-pinned for this head -- needs a human to post as /ai-review override

First Principles blocks on product shape: the free-form body and HTML widget have no accepted RFC on the base. The owner chose this shape (option B) on 2026-10-26; the RFC amendment in this PR records it. Proposed override line:

/ai-review override first-principles 31ce78cffef75b46eadfb0cd90156353da572f70 product-shape: Owner chose option B on 2026-10-26: free-form plain-text body plus an optional widget drawn in the existing WidgetFrame sandbox with no new grants. Progress stays gateway-counted from the ledger; content stays plain text. The RFC amendment in this PR records the decision.

The lane's item 7 note (drop the older-field parse branches) is advisory: those branches keep a model that still returns the #23847 shape working, and removing them would rewrite many existing tests beyond this PR's budget.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

re-pinned for this head -- needs a human to post as /ai-review override

New head after fixing the GPT redaction finding (the body and widget are now redacted as a whole before and after ** is dropped, with a regression test). The First Principles product-shape block is unchanged. Proposed override line for head 028aad76e9ac8519347e6aed3678fa318d55a10e:

/ai-review override first-principles 028aad76e9ac8519347e6aed3678fa318d55a10e product-shape: Owner chose option B on 2026-10-26: free-form plain-text body plus an optional widget drawn in the existing WidgetFrame sandbox with no new grants. Progress stays gateway-counted from the ledger; content stays plain text. The RFC amendment in this PR records the decision.

The older override line for 31ce78cf no longer applies.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 26, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 028aad7 product-shape: Owner chose option B on 2026-10-26: free-form plain-text body plus an optional widget drawn in the existing WidgetFrame sandbox with no new grants. Progress stays gateway-counted from the ledger; content stays plain text. The RFC amendment in this PR records the decision.

@github-actions

Copy link
Copy Markdown
Contributor

AI-review override not recorded: product-shape is not a release class. Use /ai-review override <fable|gpt|design|ux|first-principles|scope|all> <current-sha> <class>[ #N]: <reason, 20 to 500 characters>, where <class> is one of false-positive, not-applicable, pre-existing, evidence-supplied, infra-failure, reissue, deferred, owner-decision. What each class needs: docs/ci/ci-and-reviews.md#risk-release-records.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 27, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

re-pinned for this head -- needs a human to post as /ai-review override

Rebased onto main after #24512 (one RFC status-list conflict: kept both amendment lines). Code diff unchanged. Proposed override line for head 1bcf4b06ba640645056bb9f222e8e2661b22321e:

/ai-review override first-principles 1bcf4b06ba640645056bb9f222e8e2661b22321e product-shape: Owner chose option B on 2026-10-26: free-form plain-text body plus an optional widget drawn in the existing WidgetFrame sandbox with no new grants. Progress stays gateway-counted from the ledger; content stays plain text. The RFC amendment in this PR records the decision.

The earlier override lines for 31ce78cf and 028aad76 no longer apply.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 27, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

re-pinned for this head -- needs a human to post as /ai-review override

New head after the UX fix: the widget prompt now forbids chips, pills and done/pending step marks, and asks for no own background or font. The First Principles product-shape block is unchanged. Proposed override line for head 6fa7a34f97e2211dfeae5e5b2d62754547efd07d:

/ai-review override first-principles 6fa7a34f97e2211dfeae5e5b2d62754547efd07d product-shape: Owner chose option B on 2026-10-26: free-form plain-text body plus an optional widget drawn in the existing WidgetFrame sandbox with no new grants. Progress stays gateway-counted from the ledger; content stays plain text. The RFC amendment in this PR records the decision.

The earlier override lines for 31ce78cf, 028aad76 and 1bcf4b06 no longer apply.

Inherited red, not from this diff: both backend shard 2 jobs fail test/test_crew_log_fullscan_guard.py::test_a_warm_session_read_that_earns_a_savepoint_reads_only_the_gap as XPASS(strict). It reproduces locally on this tree, which touches no crew-log code; #24276 on main made the guard pass and #24774 drops the strict xfail.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 27, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 27, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 9c8fb40 product-shape: Owner chose option B on 2026-10-26: free-form plain-text body plus an optional widget drawn in the existing WidgetFrame sandbox with no new grants. Progress stays gateway-counted from the ledger; content stays plain text. The RFC amendment in this PR records the decision.

@github-actions

Copy link
Copy Markdown
Contributor

AI-review override not recorded: product-shape is not a release class. Use /ai-review override <fable|gpt|design|ux|first-principles|scope|all> <current-sha> <class>[ #N]: <reason, 20 to 500 characters>, where <class> is one of false-positive, not-applicable, pre-existing, evidence-supplied, infra-failure, reissue, deferred, owner-decision. What each class needs: docs/ci/ci-and-reviews.md#risk-release-records.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

re-pinned for this head -- needs a human to post as /ai-review override

Rebased onto main after #24774 (no conflicts, code diff unchanged). First Principles blocks again on product shape. Proposed override line for head 9c8fb407df32ef38c85773745ffcd4a81f25353d:

/ai-review override first-principles 9c8fb407df32ef38c85773745ffcd4a81f25353d product-shape: Owner chose option B on 2026-10-26: free-form plain-text body plus an optional widget drawn in the existing WidgetFrame sandbox with no new grants. Progress stays gateway-counted from the ledger; content stays plain text. The RFC amendment in this PR records the decision.

The earlier override lines for older heads no longer apply.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 27, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Owner decision (iamwhatever): on 2026-10-26 I chose option B for the warm brief: free-form plain-text body plus an optional widget in the existing WidgetFrame sandbox, no new grants. Progress stays counted by the gateway from the ledger. I accept the product-shape concern First Principles raised. Posted by my Kiro Crew agent on my instruction of 2026-10-27.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 9c8fb40 owner-decision: owner chose option B, free-form brief plus optional sandboxed widget, progress gateway-counted. Decision: #24307 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@iamwhatever recorded a owner-decision release (class owner-decision) for the first-principles AI finding on 9c8fb407df32ef38c85773745ffcd4a81f25353d.

owner chose option B, free-form brief plus optional sandboxed widget, progress gateway-counted. Decision: #24307 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Oct 27, 2026
@chenmingwei23
chenmingwei23 merged commit 7756964 into main Oct 27, 2026
110 of 114 checks passed
@chenmingwei23
chenmingwei23 deleted the warm-brief-loosen branch October 27, 2026 23:09
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 27, 2026
iamwhatever pushed a commit that referenced this pull request Oct 28, 2026
Bring the delayed-task-brief RFC and its directory index into agreement
with the document's amendments and with what shipped on main.

The warm task brief shipped in #20422 and its amendments shipped in
#21750, #22828, #22839, #23847, #24512 and #24307, but the RFC still
read `accepted` ("nothing built yet") with implementation-prs [] and a
2026-10-14 audit stamp.

The front matter now records status implemented, those seven PRs, and
last-audited 2026-10-28 at 7cbf872; the section 1 status and
"Audited on" lines match it; and the snapshot's third field is renamed
"Suggested actions" to match the section 3.5 output it feeds.

The README index row no longer describes the superseded preparing-status
design or says implementation waits for the RFC. It reads implemented,
names the shipped PRs, and summarises the shipped trigger, the
free-form brief card and the leave-after-opener rule. The audit
paragraph gains a dated re-audit sentence for the row.

Closes #20887
iamwhatever pushed a commit that referenced this pull request Oct 29, 2026
Bring the delayed-task-brief RFC and its directory index into agreement
with the document's amendments and with what shipped on main.

The warm task brief shipped in #20422 and its amendments shipped in
#21750, #22828, #22839, #23847, #24512 and #24307, but the RFC still
read `accepted` ("nothing built yet") with implementation-prs [] and a
2026-10-14 audit stamp.

The 2026-10-28 writer amendment (section 3.8, #25433) is design only:
main has no wake turn and no `dashboard.warm_brief_wake` setting. So
the front matter now records status partial, those seven PRs, and
last-audited 2026-10-29 at 4d36177; the section 1 status line
names what shipped and that section 3.8 is not built; the "Audited on"
line matches; and the snapshot's third field is renamed "Suggested
actions" to match the section 3.5 output it feeds.

The README index row no longer describes the superseded preparing-status
design or says implementation waits for the RFC. It reads partial,
names the shipped PRs, summarises the shipped trigger, the free-form
brief card and the leave-after-opener rule, and names the unbuilt
writer amendment. The audit paragraph gains a dated re-audit sentence
for the row.

Closes #20887
iamwhatever pushed a commit that referenced this pull request Nov 2, 2026
…21712)

Bring the delayed-task-brief RFC and its directory index into agreement
with the document's amendments and with what shipped on main.

The warm task brief shipped in #20422 and its amendments shipped in
#21750, #22828, #22839, #23847, #24512, #24307, #25881 (Crew Mode
scope), #26500 (fixed progress orb) and #26652 (first part of the
2026-10-31 redesign), yet the front matter and README row still
read `accepted` ("nothing built yet") with implementation-prs [] and a
2026-10-14 audit stamp.

Not built on main: the 2026-10-28 writer amendment (section 3.8; main
has no wake turn and no `dashboard.warm_brief_wake` setting), the
2026-11-01 trigger amendment (#26938 is open), and the live checks,
links and copied option buttons of section 3.9.3. So the front matter
now records status partial, those ten PRs, and last-audited 2026-11-01
at fed53fc; the section 1 status line names what shipped and what
is not built; the "Audited on" line matches; and the snapshot's third
field is renamed "Suggested actions" to match the section 3.5 output it
feeds.

The README index row no longer describes the superseded preparing-status
design or says implementation waits for the RFC. It reads partial,
names the shipped PRs, summarises the shipped trigger, the one-message
brief with its fixed card and quiet return, and names the unbuilt
parts. The audit paragraph gains a dated re-audit sentence for the row.

Closes #20887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warm welcome brief reads stiff: let the model choose layout, with an optional widget

2 participants