Repository navigation
feat(settings): merge the Developer page into Settings > Developer - #24810
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the old Notes
[DESIGN-REVIEWED] b6caf23 Description read[DESCRIPTION-READ] 3aefc5608d38b044fc27d23a935fcd6d04546d048400ee205145ee26801ccc9a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The accepted RFC What this change shipsInventory (9 items) — 8 justifiedIntent: put every developer tool in one place, Settings > Developer, with no hidden switch in front of it. This is an ADDITION (a move plus removing the switch).
[FIRST-PRINCIPLES-REVIEWED] b6caf23 Description read[DESCRIPTION-READ] a2ca3b31ac5d8b35c338adc529bd5b0b0d575901c089af0b1724af96d6ceb713 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing a screenshot of the chat side panel's Evidence gaps
Notes
[UX-REVIEWED] b6caf23 Description read[DESCRIPTION-READ] 207868a60737cc0074938583e957f35c9c130ef797bffd0a5f4a9bd603031d91 That sha256 names everything this verdict read: the PR description, plus the 10 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
self-added: yes
|
|
dc6a984 to
55ffa4c
Compare
|
self-added: yes
|
|
UX lane note (PASS, "cannot evaluate" the side panel |
|
55ffa4c to
3b0e84e
Compare
3b0e84e to
bb4a075
Compare
|
self-added: yes
|
|
self-added: yes
|
|
|
|
bb4a075 to
d771d14
Compare
|
7801c02 to
8befe1b
Compare
|
Rebased onto main adb562f, which now carries the accepted RFC from #24818 (docs/request-for-change/rfc-developer-tools-in-settings.md). Conflicts resolved: docs/feature-map/README.md (kept main's new context_turn_detail / turn= text, reapplied this PR's Developer Mode removals) and ui-index.generated.json (regenerated). Also removed a stale mock of the deleted useDevMode hook from main's new sidePanelAllTabs.test.tsx. New head 8befe1b. Locally: tsc, i18n:check, check_feature_map pass; changed backend tests 554 passed; changed frontend tests 54 files / 1081 tests passed; settings + side-panel suites 143 files / 2205 tests passed. |
Settings > Developer becomes a SubNav: Feature Previews first, then the logs, system, telemetry, storage, MCP Management, memory, config, debug tools and archive pages. The Developer Mode toggle, the rail Developer row and its unseen dot are removed; the side-panel diagnostics views and the desktop DevTools menu item are always offered. /developer?tab= links redirect to /settings/developer/<page>.
8befe1b to
b6caf23
Compare
|
Rebased onto main to clear conflicts with #19661 (MCP sharing). Resolutions: the 13 locale catalogs keep this PR's removal of developerPage.tabs.mcpPool.description (main reworded it, but its only reader was the old Developer page tab list; en-XA regenerated with i18n:pseudo); settingsCoverage.test.ts keeps this PR's Settings > Developer wording and adds main's new McpManagementHero.tsx in the same wording. New head b6caf23. Locally: tsc, i18n:check, check_feature_map pass; changed backend tests 554 passed; changed frontend tests 55 files / 1102 tests passed; settings + side-panel + McpManagement suites 148 files / 2337 tests passed. |
Problem / Motivation
Goal: The developer tools live in one place, Settings > Developer, with no Developer Mode switch in front of them.
Today the tools are split. Settings > Developer holds a Developer Mode switch and the feature previews. Turning the switch on adds a separate Developer page to the left rail with Logs, System, Telemetry, Storage, MCP Management, Memory, Config, Debug tools and Archive. A reader must find the switch, then a second page. The same switch also hides the chat side panel's Logs, Context and Crew log views, and the desktop app's View > Toggle Developer Tools item.
Why it matters
A person debugging a problem has to know a hidden switch exists before they can see logs or system metrics. Docs, tips and the doctor's MCP hint each had to explain "turn on Developer Mode first". One home in Settings removes that step and the explanation.
Not a goal
KIROCREW_DEV_MODEsetting and per-app dev mode (/api/apps/{name}/dev). They are separate switches and stay as they are./logsor the other standalone pages.What changed (motivation → approach → change)
+Logs / Context / Crew log/developer?tab=<page>/settings/developer/<page>The approach reuses the Settings SubNav that Chat, Display and Notifications already use, so the page list, the phone drill-in and path deep links behave the same way.
DeveloperPanel.tsxrenders the pages;DeveloperPage.tsxis only the redirect. It keeps every other query param (plane,highlight), forwardsagent-backendto Agent Harness as before, and matches the route's own trailing-slash and case rules.Without the switch there is nothing for a gate to guard, so the
developer_modeguide gate, theshell.developerlocation, thepage.developerpalette entry,useDevMode/useDeveloperMode, and their catalog strings are removed. Search andfind_uinow point atsettings.tab.developerand itssettings.sub.developer.*pages.App.tsxdrops the phone rail row, anduiLocations/conditions.tswithuiLocations/areas/shell.tsdrop the gate and location. In-app links, curated tips (data/tips_curated.json), the doctor's MCP hint (doctor_checks/mcp.py), thefind_uiblocker wording (mcp_guide.py,dashboard/guide_runs.py), theutils/previewFlags.tscomments and agent docs use the new paths. Thei18n/locales/en.jsoncatalog and its translations lose the removed strings and the tab description no longer says "Developer mode". The generated settings registry, ui index and guide plans, the GUI user-test catalog, and the owning specs (learn-cron-dashboard.md,metrics.md,kas-auth.md, feature map) follow the new layout.Backwards compatibility
Compatible: every old
/developer?tab=<page>link lands on the same page under Settings, and/developer?tab=agent-backendstill reaches Agent Harness.Reader: website/src/hooks/useDevMode.ts:useDevMode -- chat -- removed with its only caller,
pages/chat/SidePanel.tsx, which no longer gates diagnosticsReader: website/src/shell/nav/developerMode.ts:useDeveloperMode -- chat -- removed with its only caller,
shell/appShell.tsx; the rail row it fed is goneReader: website/src/lib/uiPrefs.ts:DURABLE_PREF_KEYS
mc-dev-mode-- chat -- dropped from backup; the frozenPRE_ROSTER_KEYSlist keeps it by design, and a restored profile carrying it is ignored (App.mobileSingleTopbar.test.tsx,AppRootCoverage.test.tsx)Reader: website/src/guide/guidePredicates.ts:GUIDE_GATE_EVALUATORS
developer_mode-- chat -- no plan names the gate after regeneration; an unknown id readsunmet(liveRegistry.test.tsx)Reader: src/kiro_crew/ui_index.py:AREAS developer -- subagent -- anchors move to
page.logs,page.webhooks,page.projects;test_find_ui.py,test_find_ui_shell.pyReader: src/kiro_crew/docs/ui-index.generated.json
shell.developer/page.developer-- subagent -- regenerated; "developer page" terms resolve tosettings.tab.developer(test_find_ui_shell.py)Reader: website/src/components/commandPalette/providers/pagesData.ts:EXTRA_PAGES
developer-- chat -- removed; Settings search lists the tab and its pages (pagesProvider.test.ts)Reader: website/electron/app-menu.js
devtools-toggle-- app -- built visible; an older desktop shell still getssetDevMode(true)at boot (app-menu.test.js,AppRootCoverage.test.tsx)Tests
DeveloperPanel.test.tsx: the page list order, path navigation, and that no Developer Mode switch is drawn.previewSurfaces.test.tsx: the redirect for Feature Previews (rings the section), another page, kept params, trailing slash, mixed case and an unknown tab. Removing the route-matching guard fails the trailing-slash and mixed-case cases.DeveloperPanel.defaultCrewmateHighlight.test.tsxandDeveloperPanel.lazyGraph.test.tsx: the default-mate deep link and the lazy memory graph on their new pages.sidePanelAddMenu.test.tsx,ContextBreakdownPanel.test.tsx: diagnostics offered whatever Terminal does; group ids stay fixed.GuideLayer.uiShow.test.tsx,test_guide_select_gate.py,test_guide_ui_find.py,test_guide_ui_show.py) use the terminal and Mates preview gates in place of the removed one.settingsCoverage.test.ts,deadKeys.test.ts,uiPrefs*.test.ts, gui_user catalog tests,app-menu.test.js.Determinism: the 53 changed frontend test files passed 3 runs in a row (1067 tests each). Under
--sequence.shuffle,DeveloperPanel.lazyGraph.test.tsxreads its import count once at load, so it passes in any order (5 shuffled runs). Three files still go red in some shuffled orders: thecrew is preview-gated end to endblock ofpreviewSurfaces.test.tsx,sidePanelBrowserTabs.test.tsxandsidePanelPinsTab.test.tsx. The same reds reproduce under shuffle on unmodifiedorigin/main, and this PR touches none of those test bodies.Manual verification
Built
website/distand drove it with headless Chromium against stubbed/api/**(desktop 1400x900 light and dark, phone 390x844): the page list, Feature Previews, System, Config, the old/developer?tab=logslink, and the rail with an oldmc-dev-mode=1value all render as shown below.Screenshots / video
Feature Previews, light and dark. The rail has no Developer row:
The old link
/developer?tab=logslands on the Logs page:The chat side panel's
+menu (Logs, Context, Crew log now in its diagnostics group for everyone) is not shown: the stubbed-API harness cannot open a chat session, so/chatrenders its error card.sidePanelAddMenu.test.tsxrenders the real menu and asserts those three rows and the three-group, two-separator layout.System, Config, phone list, rail with the old key set
Related Issues
Closes #24797
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)