Repository navigation
chore(release): backport the 0.11.1 hotfix fixes to release/0.11.0 - #26487
Conversation
Sensitive Change ReviewSensitive files changed:
How to clear this check:
Only the author's comment counts this way. A reviewer can instead |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing a screenshot of the new settings-row error shown when Evidence gaps
Notes
[UX-REVIEWED] 0ff5fce Description read[DESCRIPTION-READ] 9a08b4d2e9d8adf250ceb30fc5c2a0a998fdab4204df32ccb178696ce75d81e0 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Every item is a cherry-pick of a fix already merged on Notes
What this change shipsInventory (10 items) — 9 justifiedIntent: ship 23 fixes already merged on
[FIRST-PRINCIPLES-REVIEWED] 0ff5fce Description read[DESCRIPTION-READ] bff1c1ca555f45198efddd3c7e19c2ca5a303989c2616614b19341f72073cdd7 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: these are cherry-picks of fixes already merged on main, and the hand-adapted conflicts only touch test pins, an import and doc rows. Notes
[DESIGN-REVIEWED] 0ff5fce Description read[DESCRIPTION-READ] 80d326116ba4d6551e66bfd12a0368f4b07b29e8bfa033c6d41c099434d6d1d9 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Security Scope Review -- ✅ PASSWhich legitimate operations does Verdict basis: adjudicated, zero confirmed regressions. Security scope review -- adjudicated candidates
No candidate flipped from allowed to refused. Scope-Verdict: PASS Reason: The only tightening in the shell composite is the new TIGHTENING: nested-shell payload extraction ( ADJUDICATED: 29 candidates, 0 confirmed newly-refused PLATFORM COVERAGE: posix — 24 rows. They cover:
windows — 5 rows: UNADJUDICATED:
[SCOPE-REVIEWED] 0ff5fce |
37649cc to
2049d09
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved on behalf of the watch holder (bolichen). Design and First Principles pass on this head, UX skipped or pass, no conflict, no open change request.
Backports these main PRs to release/0.11.0, in pick order. Each was a `git cherry-pick -x` of its squash commit on main: - fix(memory): read memory.db off the writer lock, split background pool (#24290) (cherry picked from commit fed830c) - fix(dashboard): bound the pre-prompt build's wait to enter the memory pool (#24414) (cherry picked from commit 520cf2c) - fix(memory): keep the shared -wal when another process closes the memory store (#25852) (cherry picked from commit dc63bb6) - fix: read the page-cache prefetch in a child to keep sqlite locks (#26302) (cherry picked from commit 81dde23) - perf(memory): score facts from a term index and prebuild after restart (#25328) (cherry picked from commit 6824348) - fix(desktop): retry a failed netstat before Windows recovery gives up (#25792) (cherry picked from commit 043dd9f) - fix(cli): say a gateway still serves the port when restart's replacement is refused (#25366) (cherry picked from commit 2e13127) - fix(cli): refuse to stop or restart a gateway the desktop app supervises (#25705) (cherry picked from commit bbf0910) - fix(hooks): approve kiro-cli read-only file searches after the deny tiers (#25150) (cherry picked from commit a0c0bd4) - fix(settings): refuse a config save that config.local.json overrides (#26216) (cherry picked from commit 7f8688e) - fix(workflows): write non-finite floats as null so runs open (#26085) (cherry picked from commit 3591282) - fix(approvals): give each background tool approval its own id (#25905) (cherry picked from commit 51ef3bb) - fix(chat): record file changes for kiro-cli v3 write tools (#25650) (cherry picked from commit 5369270) - fix(sandbox): stop blaming a host-wide OOM kill on a per-tree limit (#25647) (cherry picked from commit 791d2a2) - fix(acp): replay history when a KAS resume restores no turns (#25521) (cherry picked from commit 47c71cb) - fix(kas): auto-approve granted built-ins after Crew's own checks (#25339) (cherry picked from commit dba4de5) - fix(kas): mount web_search as the engine's remote_web_search (#26435) (cherry picked from commit 65c21b5) - fix(kas): answer a spec's shell.allowedCommands at the gate, after Crew's checks (#25539) (cherry picked from commit 39d07d9) - fix(kas): relay an MCP server's boolean env flags, never its secrets (#25331) (cherry picked from commit b734a68) - fix(security): read the -c script past options and redirections (#26087) (cherry picked from commit fea0920) - fix(kas): refuse a shell command a denyByDefault spec does not allow (#26501) (cherry picked from commit 9f0d02f) - fix(kas): name a deniedCommands deny aimed at a redirect as not carried (#26489) (cherry picked from commit 4951c0c) - fix(security): delete the curl-upload deny rule (#26469) (cherry picked from commit 70e206e) Conflicts resolved by hand: - #26302: test/spawn_audit_helpers.py adds only the page_cache.py entry (the embeddings_child.py entry names a module 0.11.0 lacks); test/test_page_cache_prefetch.py takes main's file. - #25328: test/test_dashboard_server_composition_contract.py lazy-import count 93 -> 96 (the three names it adds). - #25705: test/test_cli_restart_refused_message.py takes main's file. - #26085: dashboard/handlers/workflows.py adds import math, keeps the release typing import. - #25339: platform/governance.py keeps the release rule for a missing ceiling (main's enterprise-baseline clause is not on 0.11.0). - #26435: harness-parity.md H6 row edited in place on the release text. - #25539: its acp-client.md and agent-spec-fields.md lines are left out; the paragraphs they edit are not on 0.11.0 (security.md carries it). - #25331: the test and two doc mentions use hoist_managed_servers / resume=, the 0.11.0 names of main's renamed hoist_servers_for_session. - #26087: security package line budget 32,552 -> 32,714 (re-measured). - #26501: kas_permissions.py comment keeps 0.11.0's shapes (main's subagent rules are absent); its acp-client.md line is left out, and the agent-spec-fields.md toolsSettings row says denyByDefault is gate-enforced. - #26489: its agent-spec-fields.md sentence is added to the 0.11.0 row. - #26469: test_denied_commands_security.py keeps 0.11.0's comment; count 113 -> 112. Test fixes (host-dependent tests made hermetic; none loosens an assertion): - tmpdir_helpers.short_tmp_path: a tmp_path override for modules whose code judges a path by its components (a .kiro/crew data-home part); an agent session's TMPDIR under ~/.kiro/crew made every test path the data home. Used by the file-explorer, design-tweak (both), spawn-offload, launch-copy, home-pin, native-skill and auto-improvement-members tests; the sage ancestor-chain test creates its dir under /tmp for the same reason. - pi-gate tests and the remote-session Python 3.9 test take the first real binary on PATH (playwright_cli_installer_helpers._native_tool_on_path): a mise shim under a scratch HOME hangs or writes to stdout. - snapshot-merge ACL test names its own uid; nobody (65534) is the overflow uid inside a user namespace and cannot be named in an ACL. - installer-step and push_guard interrupt tests spawn with SIGINT at its default; a background pytest run starts with SIGINT ignored, which a shell trap and Python both keep. Left out: #23920 (already on release/0.11.0), #26144 (needs sandbox_launch_mark from #24709), #26088 (fences a main-only port), #25346 (11 of its tests fail on 0.11.0: the kiro-cli skill scope it compares against differs there), #26397 (needs #26152's new download route, not on 0.11.0), #26428 (not merged).
2049d09 to
0ff5fce
Compare
|
Two candidates for this backport, both merged on main:
Happy to prepare the cherry-pick if that helps. |
…/0.11.0 (#26594) Backports these main PRs to release/0.11.0 after #26487, in pick order. Each was a `git cherry-pick -x` of its squash commit on main: - fix(memory): keep the shared -wal on close when the driver has no setconfig (#26486) (cherry picked from commit ad856ad) - fix(crew): blink a working icon's eyes and seat it flush in the crew stack (#25381) (cherry picked from commit d180166) - fix(crew): counter-scale a working icon's frame in the face flight (#25020) (cherry picked from commit 94de6c6) - fix(terminal): keep a newly opened terminal above the iPhone keyboard (#25370) (cherry picked from commit 670ab7d) - fix(hooks): run agent spec hooks by kiro-cli's rules on KAS (#26428) (cherry picked from commit 314ea38) Conflict resolved by hand: - #26428: src/kiro_crew/hook_runtime/script_hooks.py keeps 0.11.0's extra_hooks_cwd branch (main passes **extra_run, which 0.11.0 lacks) and sets result.from_spec on both branches. Left out (see the PR body): #19629, #23916, #23911 already on release/0.11.0; #26001, #25419, #25142 need files only main has; #26084 and #25483 use props and APIs only main has; #24634, #24635 and #25364 conflict widely with code main changed after the cut; #26397 needs #26152's route; #26144 needs sandbox_launch_mark; #26456 not merged. Co-authored-by: w <w@k.local>
….0 (#26627) Backports these main fixes to release/0.11.0 after #26487 and #26594: - fix(kas): let a relative file:// prompt use .. like kiro-cli (#26382) (cherry picked from commit 36c95db) - part of #24709 (cherry picked from commit d86c94a, partial): the sandbox_launch_mark module, its note() call in cli.main before the KIROCREW_SANDBOX_ACTIVE pop, and its per-test reset fixture. Nothing else of #24709 (its enterprise policy-cache tier) is included; the module docstring and the cli.py comment name the 0.11.0 reader. - fix(cloud): treat every agent process as an agent in the human-action guard (#26144) (cherry picked from commit dd0dd62) Conflict resolved by hand: - #26382: keeps 0.11.0's acp-client.md (the paragraph it edits is not on 0.11.0); agent-spec-fields.md takes its path-fence bullets and keeps 0.11.0's blank-prompt fallback bullet. Test-only fixes: - test_cloud_aws pins sandbox_launch_mark.SANDBOX_MARKER to sandbox_tiers._IN_SANDBOX_MARKER (the #24709 test that pinned it on main is not on 0.11.0). - test_prompt_override_encoding pins browser_cli.install.available() off: the context build probed the host's PATH for playwright-cli and counted its refusal warning as a second override warning. Left out: #26471 is a feature built on KAS code only main has. Co-authored-by: w <w@k.local>
…NGELOG) (#26648) Declare release/0.11.0 as the 0.11.1 hotfix line in the dual-valid RC spelling the version numbering policy requires: all three version files move from 0.11.0 to 0.11.1-rc.1. Add the ## [0.11.1] - 2026-10-31 section, written from the three hotfix backports already on the branch (#26487, #26594, #26627). Every earlier section is unchanged. Co-authored-by: w <w@k.local>
Problem / Motivation
Goal: Ship the P0 and must-have fixes already merged on
mainto the 0.11.0 release line, so the 0.11.1 hot patch can be cut from it.These main PRs merged after
release/0.11.0was cut, so no 0.11.0 build has them. Users on 0.11.0 still hit a split or corruptmemory.db, astopthe desktop app undoes, stuck approvals, blank KAS resumes and the other bugs below.Why it matters
The release line is what users install. Each fix here is already reviewed and merged on
main; without this PR it reaches users only with 0.12.0.Not a goal
What changed (motivation → approach → change)
One commit: each main PR below was
git cherry-pick -x'd in this order, then squashed (PR Hygiene allows two commits). The commit message lists every pick and its source sha.memory.dboff the writer lock (executors.py,vector_memory.py,vector_memory_lifecycle.py,history_consolidation_pass.py,slack/gateway_runtime/memory_lifecycle.py).dashboard/chat_turn/prompt_assembly.py).-walon close (sqlite_wal.py,diagnose_probes.py, one.github/black-baseline.txtrow).page_cache.py).vector_memory_runtime/term_index.py,memory_startup_prebuild.py).website/electron).restart/stopand a desktop-supervised gateway (cli_server.py,cli_server_restart.py,cli_server_stop.py,apps/builtins/dev_fleet).hook_runtime/gate_tiers.py,hooks.py).config.local.jsonoverrides (dashboard/handlers,website/src/pages/settings,website/src/test/ChatPanel.defaultModel.test.tsx).workflows/store.py).slack/gateway_runtime/turn_approvals.py).dashboard/chat_turn/file_changes.py).sandbox_slice.py).acp/runtime_session_load.py,providers/acp_runtime_start.py).acp/kas_permissions.py,platform/governance.py).web_searchasremote_web_search(platform/tool_names.py).shell.allowedCommandsat the gate (platform/allowed_commands.py).acp/kas_agents.py,security_posture.py).-cscript past options (security/shell_normalizer.py).denyByDefaultspec does not allow (hook_runtime/tool_identity.py).deniedCommandsdeny aimed at a redirect as not carried.Adapted by hand (also in the commit message): #26302 and #25328 and #25705 test pins; #26085 one import; #25339 keeps 0.11.0's missing-ceiling rule (main's enterprise clause is absent here); #26435 edits the H6 row on the release text; #25539 drops two doc lines whose paragraphs 0.11.0 lacks; #25331's test uses 0.11.0's
hoist_managed_servers(resume=); #26087's security line budget is re-measured at 32,714. #26501 keeps 0.11.0's rule shapes in a comment and its doc line moves into thetoolsSettingsrow; #26489's sentence joins that row.Left out:
release/0.11.0(via the chore(release): backport crew-log and kas relay fixes to 0.11.0 #25663 stack).kiro_crew.sandbox_launch_markfrom fix(enterprise): let sandboxed MCP servers read the governance cache #24709; alone,kiro_crew.cloud.awsfails to import.Docs move with their picks (
docs/system-specs,docs/architecture,src/kiro_crew/docs,src/kiro_crew/builtin_skills). The test-only fixes are under Tests.Backwards compatibility
Compatible: each change is its main PR's own, already reviewed for compatibility there; the hand-resolved conflicts only adapt test pins to the release branch.
Removes nothing: no change here takes anything away beyond what the main PRs did, and each was reviewed on
main.Tests
Test fixes
Test fixes (test files only; no assertion is loosened). Each test failed on this host, and also on a clean
release/0.11.0and onmain:TMPDIRunder~/.kiro/crew(an agent session's scratch dir) made the code under test treat every test path as the data home.test/tmpdir_helpers.pygainsshort_tmp_path, used as atmp_pathoverride in the file-explorer, design-tweak, spawn-offload, launch-copy, home-pin and native-skill tests, and for one auto-improvement-members test; the sage ancestor-chain test (src/kiro_crew/apps/builtins/code_review_sage/tests/test_store_ancestor_chain.py) makes its dir under/tmp.node) or writes to stdout (python3.9): the pi-gate and remote-session tests take the first real binary on PATH, as the installer tests already do.nobodycannot be named inside a user namespace.npm ciinwebsite/electronin my worktree, not a test defect; CI installs it. With it, 2874 pass.The picked tests are the main PRs' own. Run on this tree:
mypy src/kiro_crew/, semgrep (repo rules, diff-scoped), flake-pattern ratchet, file line cap, comment history,check_black_formatting.py,docs-lint.shand harness parity: all pass.npm --prefix website run test:electron(withwebsite/electrondeps installed as CI does): 2874 tests, 0 failed.test_vector_memory_lock_discipline.py,test_spawn_audit.py,test_hooks_composition_contract.py: 2712 passed.test_security*,test_denied*,test_exfil*,test_blocked*: 7256 passed.Determinism: the tests are the main PRs' own, unchanged; their repeat and shuffled-order runs are recorded on each main PR.
Manual verification
N/A - every change was verified on its own main PR; this PR moves them to the release branch.
Screenshots / video
Why no screenshot: every frontend change here (#25792, #26216) is a byte-identical cherry-pick of a main PR that carries its own evidence.
Related Issues
Part of #25846
Backport of #24290, #24414, #25852, #26302, #25328, #25792, #25366, #25705, #25150, #26216, #26085, #25905, #25650, #25647, #25521, #25339, #26435, #25539, #25331, #26087, #26501, #26489, #26469. Replaces #26474 and #26465.
Sibling sweep
Siblings: none -- a backport of main fixes; each sibling sweep is on its main PR
Pattern harvest
Not generalizable: backport of main fixes; each harvest is recorded on its main PR.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.