Repository navigation
docs(rfc): crewmate pin that cannot run a full crewmate runs on KAS with an error; model follows harness - #30116
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a docs-only change that writes down decisions the owner made, the H17 rule is updated in Notes
[DESIGN-REVIEWED] 7bbe807 Description read[DESCRIPTION-READ] 587de6e8bead3a57739bf1ff26acddb8f3205dfbc685b2bec394866699747631 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
Thanks for this PR. The only real reds on this head are Backend Tests (3.12, 7) and (Windows) (7), which come from a Slack code-channel test regression on main, not from your change. That is now fixed on main. Could you update the branch onto the latest main? We will review it again once CI is green. |
60958d0 to
1f62274
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Comment on 1f62274. This is an RFC, so the sign-off is a maintainer decision; here is a short brief plus one point to fix first.
Design brief
What it does: a crewmate follows the harness the user picks in settings. A harness that cannot run a full crewmate (no crewmate chat or no worker kit) falls back to KAS. That fallback is keyed on a new explicit set, ACP_BACKENDS_CREWMATE_PIN_TO_KAS.
Pros: one rule for which harness a crewmate runs on. An unsupported harness falls back to a working one instead of a half-working crewmate.
Cons: the fallback is only as good as the set. A harness missing from it runs silently on the pinned harness.
Long-term tech debt: low, provided the set is checked against the selectable list in both directions.
One point before sign-off
The Opus lane is right, and I checked it on main. ACP_BACKEND_COPILOT is in BASELINE_SELECTABLE_BACKENDS (agent_sdk/backends.py), but it is in none of ACP_BACKENDS_MEMBER_CAPABILITIES, ACP_BACKENDS_MEMBER_DISPATCH or ACP_BACKENDS_MATE_WORKER_KIT (agent_sdk/backends_members.py). By the RFC's own definition at rfc-crewmate-harness-follows-settings.md:212 it cannot run a full crewmate, yet the 5.8 set lists only goose, opencode, strands, pi and deepseek. Please add copilot to the set (and the matching harness-parity.md and AUTOSDE.yaml text), or record why it is left out. Please also make the planned set test check the other direction: every selectable harness outside the crewmate sets must be in ACP_BACKENDS_CREWMATE_PIN_TO_KAS.
|
Maintainer direction on this RFC: signed, with two conditions before merge.
Once both are in, this is good to merge from the design side. |
…ith an error; model follows harness Amends rfc-crewmate-harness-follows-settings with the owner's 2026-11-05 decisions O6-O8 and updates H17 in harness-parity.md and AUTOSDE.yaml to match: an unstartable pin still refuses; a startable pin to goose, opencode, strands, pi or deepseek runs on KAS with an error log and bell. Status field unchanged. Refs #21910
1f62274 to
7bbe807
Compare
|
Both sign-off conditions are met at 7bbe807:
Thanks. The only red entries on this head are cancelled older duplicate runs. |
Problem / Motivation
Goal: Record the owner's 2026-11-05 changes to the crewmate-harness RFC, so the implementation PRs trace to the rules the owner now wants.
The draft RFC
docs/request-for-change/rfc-crewmate-harness-follows-settings.md(#29442) says a crewmate pinned to a harness this gateway cannot start refuses (H17), and it says nothing about which model a crewmate uses when it lands on a different harness. On 2026-11-05 the owner changed both rules.Why it matters
Today a hand-edited pin to an unrunnable harness stops that crewmate entirely, and a crewmate that moves to another harness can start with a model that harness cannot serve. The implementation PRs need the new rules written down before the First Principles and Design lanes can check code against them.
Not a goal
statusfield; acceptance is the owner's call.What changed (motivation → approach → change)
Owner decisions → write them into the RFC as O6 to O8, and update the H17 rule text in the same docs PR (the #25798 precedent: rule changes go in docs PRs, not code PRs) → three files.
ACP_BACKENDS_CREWMATE_PIN_TO_KAS) runs on KAS, with an error in the editor, the log and the dashboard bell. That KAS still crosses the selection gate. copilot is in the set because it meets the definition (selectable, in none of the crewmate sets). Codex is not: on main it has the worker kit, so a Codex pin runs on Codex.docs/system-specs/modules/harness-parity.mdand the H17 Allowed entry of ruleharness-parityinAUTOSDE.yamlnow say the same, with what reviewers still flag.The
Not a goalbullet that excluded the H17 edit was replaced, because the owner then asked for the H17 change in this PR.The RFC cites symbols, not line numbers; each new symbol was checked at main.
Security checklist (
AUTOSDE.yamledit)harness-parity. Noblocking:flag, file pattern or other rule changes.Backwards compatibility
Compatible: documentation and review-rule text only; no code, config or schema changes.
Tests
Proof: not provable -- docs or config only
python3 scripts/docs_lint.pyreports "All documentation checks passed";AUTOSDE.yamlparses;test/test_harness_parity.pyand the GPT/Opus review-workflow tests pass except two that fail the same way on main in this environment.Manual verification
Both local reviewers ran on the CI review contracts before the push. GPT: no findings. Opus: no Critical/High; one Medium (the rule text required the error to name KAS, while 5.8 lands on the Kiro CLI floor when policy denies
kas) and two Low (pi/deepseek pin vs inherit reasoning; a stale "covers deepseek and pi" line), all fixed. CI Opus then found copilot missing from the set (verified:ACP_BACKEND_COPILOTis inBASELINE_SELECTABLE_BACKENDSand in none ofACP_BACKENDS_MEMBER_CAPABILITIES,ACP_BACKENDS_MEMBER_DISPATCH,ACP_BACKENDS_MATE_WORKER_KIT); fixed, with a two-way set test named in Phase 6.Related Issues
Refs #21910
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.