Skip to content

test: ask the platform ignore hook without the ci shard targets list - #32209

Merged
buluoray merged 1 commit into
mainfrom
crew/slack/fix-collect-ignore-targets
Nov 7, 2026
Merged

buluoray merged 1 commit into
mainfrom
crew/slack/fix-collect-ignore-targets

Conversation

@buluoray

@buluoray buluoray commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A PR that changes only test files no longer fails Backend Tests on test_platform_collect_ignore.py when its shard draws that file.

test/test_platform_collect_ignore.py::test_the_windows_list_ignores_exactly_the_listed_test_files fails on every leaf-test run that puts it in a shard's corpus gates (#32199). Those gates run with --file-shard-targets= (#31516), and the ci_file_shards plugin then skips every unlisted path, by design. The test asks the whole hook chain whether test/fixtures/<listed name> is ignored, so the shard plugin's answer stands in for the Windows list's and the assertion fails.

Closes #32199

Why it matters

#32183 (main's line-budget fix) is red on Backend Tests (3.12, 7) for this alone, and any other test-only PR whose shard draws this file is too.

Not a goal

What changed (motivation → approach → change)

The test's windows_list fixture sets the registered ci-file-shards plugin's targets list to None for the test, when the plugin is loaded. The test still asks the real hook chain, now without the CI targets list answering for it. Test-only.

Backwards compatibility

Compatible: test-only; no runtime or CI code changes.

Removes nothing: every assertion stays; only the CI targets list stops answering for them.

Tests

  • Under the targets list, the way CI's leaf gates run it (-p scripts.ci_file_shards --file-shards 1 --file-shard 1 --file-shard-targets=<file listing this test>): 1 failed on origin/main 0795ebc479, 3 passed with this change, 5 runs in a row. With --file-shards 8 --file-shard 7 -n 4: 3 passed, twice.
  • Without the plugin: test/test_platform_collect_ignore.py and test/test_ci_file_shards.py pass (29 tests).

Proof: not provable -- test-only change

Manual verification

N/A — unit coverage sufficient: the change is a fixture line in one test.

Related Issues

Follow-up to #31516. Unblocks #32183.

Sibling sweep

Swept: git grep -n "pytest_ignore_collect(" -- test/
Siblings: none -- test_platform_collect_ignore.py is the only test that asks the live session's hook chain about paths outside its own file

Pattern harvest

Not generalizable: one test asked the live session's hook chain, which CI's file-shard plugin also answers when a targets list is set.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 7, 2026 08:18
@buluoray
buluoray requested a review from tim-finnigan November 7, 2026 08:18
@buluoray
buluoray enabled auto-merge (squash) November 7, 2026 08:18
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 188cc77c7a956e1b00ed71ea9b1f619822dc4842 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 188cc77c7a956e1b00ed71ea9b1f619822dc4842 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 188cc77c7a956e1b00ed71ea9b1f619822dc4842 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a test-only fixture change. It turns off the shard plugin's keep filter for the duration of this test, and the plugin's name and attribute match scripts/ci_file_shards.py.

[DESIGN-REVIEWED] 188cc77

Description read

[DESCRIPTION-READ] 5d97b0845922f56147144d08f19c23e838fa930e217e6d7bdc62bf050c15c925

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 188cc77c7a956e1b00ed71ea9b1f619822dc4842 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 188cc77

Verdict parsed from the review's SHA-scoped output markers for commit 188cc77c7a956e1b00ed71ea9b1f619822dc4842.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 188cc77c7a956e1b00ed71ea9b1f619822dc4842 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 188cc77c7a956e1b00ed71ea9b1f619822dc4842 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 188cc77

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 188cc77c7a956e1b00ed71ea9b1f619822dc4842 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 7, 2026
@bolichen97

Copy link
Copy Markdown
Contributor

[operator: bolichen97] Heads-up: #32183 and #32209 each stay red on the other's main bug, so neither can go green alone.

Suggest folding one change into the other PR so a single PR carries both fixes and can pass CI. Happy to help if useful.

Under --file-shard-targets the ci_file_shards plugin skips every unlisted path by design, so the hook chain answered for the Windows list and the nested-path assertion failed on every leaf-test run. The fixture lifts that list for these questions only. Closes #32199.
@buluoray
buluoray force-pushed the crew/slack/fix-collect-ignore-targets branch from edb0249 to 188cc77 Compare November 7, 2026 11:24
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 7, 2026
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 7, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (1 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only change: the platform ignore-hook test lifts the CI file-shard target list for its own questions.

@buluoray
buluoray merged commit e7a3ca1 into main Nov 7, 2026
97 of 98 checks passed
@buluoray
buluoray deleted the crew/slack/fix-collect-ignore-targets branch November 7, 2026 13:07

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving head 188cc77. The gate showed 96 checks passed. Sensitive Change Review failed on the GitHub API rate limit, and its rerun passed.

This is a test-only change in test/test_platform_collect_ignore.py. Under CI's --file-shard-targets, the ci-file-shards plugin skips every unlisted path, which would answer the platform-ignore question for these tests. The fixture now sets that plugin's keep to None through monkeypatch, only when the plugin is loaded, so it is restored after each test. No product code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_the_windows_list_ignores_exactly_the_listed_test_files fails every leaf-test run under --file-shard-targets (#31516)

3 participants