Repository navigation
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. This is a single test-only constant that sets the budget to the size already measured on main. It changes no runtime behaviour and takes nothing away. Notes
[DESIGN-REVIEWED] ad73108 Description read[DESCRIPTION-READ] 9d7ae6ecd1f0e27944e91b6e853ffaf01857f322c0ee7aeb7f2ea5ecd42a0e78 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
fca3ea5 to
ad73108
Compare
|
Rebased onto main @ |
|
[operator: bolichen97] Heads-up: #32183 and #32209 each stay red on the other's main bug, so neither can go green alone.
Suggest folding one change into the other PR so a single PR carries both fixes and can pass CI. Happy to help if useful. |
|
Superseded by #32252, which landed the same +10 raise (34,845 -> 34,855) plus its own +39 on main. Main's package total (34,894) now equals its budget, so this PR has nothing left to do. |
Pull request was closed
Problem / Motivation
Goal: Main's backend test shards pass again: the security package line budget matches the package's measured size on main.
test/test_security_gate_liveness.py::test_the_package_stays_within_its_line_budgetfails on main since #30976 (package grew to 34855 lines, budget 34,845). #30976 counted its 55 lines against 12 lines of headroom, but #31445 merged first and used 10 of them, so main landed 10 lines over.Why it matters
Every open PR that includes #30976 shows a red backend shard it did not cause, and readiness stays red for all of them.
Not a goal
What changed (motivation → approach → change)
_PACKAGE_LINE_BUDGETgoes from 34,845 to 34,855, with a note in the test's existing style saying why. Test-only.Backwards compatibility
Compatible: test-only; no runtime code changes.
Removes nothing: the budget only grows by the 10 lines already on main.
Tests
test/test_security_gate_liveness.py: 10 passed on fresh origin/mainb65af1a666plus this change (one process, no xdist); the budget test fails there without it (package grew to 34855 lines).Proof: not provable -- test-only change
Manual verification
N/A — unit coverage sufficient: the change is one constant in a test.
Related Issues
Follow-up to #30976 and #31445.
Sibling sweep
Swept: git grep -n "_LINE_BUDGET = " -- test/test_security_gate_liveness.py
Siblings: none -- the package budget is the only total-size budget in that test
Pattern harvest
Not generalizable: two security PRs counted against the same headroom and merged in either order; the same budget raced before (#31469).
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)