Skip to content

test: raise the security package line budget to its size on main - #32183

Closed
buluoray wants to merge 1 commit into
mainfrom
crew/slack/fix-security-line-budget-3
Closed

buluoray wants to merge 1 commit into
mainfrom
crew/slack/fix-security-line-budget-3

Conversation

@buluoray

@buluoray buluoray commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Main's backend test shards pass again: the security package line budget matches the package's measured size on main.

test/test_security_gate_liveness.py::test_the_package_stays_within_its_line_budget fails on main since #30976 (package grew to 34855 lines, budget 34,845). #30976 counted its 55 lines against 12 lines of headroom, but #31445 merged first and used 10 of them, so main landed 10 lines over.

Why it matters

Every open PR that includes #30976 shows a red backend shard it did not cause, and readiness stays red for all of them.

Not a goal

  • Shrinking the security package.
  • Changing any security code or check.

What changed (motivation → approach → change)

_PACKAGE_LINE_BUDGET goes from 34,845 to 34,855, with a note in the test's existing style saying why. Test-only.

Backwards compatibility

Compatible: test-only; no runtime code changes.

Removes nothing: the budget only grows by the 10 lines already on main.

Tests

  • test/test_security_gate_liveness.py: 10 passed on fresh origin/main b65af1a666 plus this change (one process, no xdist); the budget test fails there without it (package grew to 34855 lines).

Proof: not provable -- test-only change

Manual verification

N/A — unit coverage sufficient: the change is one constant in a test.

Related Issues

Follow-up to #30976 and #31445.

Sibling sweep

Swept: git grep -n "_LINE_BUDGET = " -- test/test_security_gate_liveness.py
Siblings: none -- the package budget is the only total-size budget in that test

Pattern harvest

Not generalizable: two security PRs counted against the same headroom and merged in either order; the same budget raced before (#31469).

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 7, 2026 07:22
@buluoray
buluoray requested a review from tim-finnigan November 7, 2026 07:22
@buluoray
buluoray enabled auto-merge (squash) November 7, 2026 07:22
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision ad7310808d8ac2a737a7ea772cefc7712cc11a99 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision ad7310808d8ac2a737a7ea772cefc7712cc11a99 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of ad7310808d8ac2a737a7ea772cefc7712cc11a99 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check. This is a single test-only constant that sets the budget to the size already measured on main. It changes no runtime behaviour and takes nothing away.

Notes

[DESIGN-REVIEWED] ad73108

Description read

[DESCRIPTION-READ] 9d7ae6ecd1f0e27944e91b6e853ffaf01857f322c0ee7aeb7f2ea5ecd42a0e78

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed ad7310808d8ac2a737a7ea772cefc7712cc11a99 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ad73108

Verdict parsed from the review's SHA-scoped output markers for commit ad7310808d8ac2a737a7ea772cefc7712cc11a99.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ad7310808d8ac2a737a7ea772cefc7712cc11a99 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of ad7310808d8ac2a737a7ea772cefc7712cc11a99 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ad73108

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ad7310808d8ac2a737a7ea772cefc7712cc11a99 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 7, 2026
#31445 merged first and used the headroom #30976 was counted against, so main landed 10 lines over the budget (34,855 vs 34,845). Test-only; nothing is relaxed.
@bolichen97
bolichen97 force-pushed the crew/slack/fix-security-line-budget-3 branch from fca3ea5 to ad73108 Compare November 7, 2026 10:03
@bolichen97

Copy link
Copy Markdown
Contributor

Rebased onto main @ e30915e712 (no change to the diff) to clear the red on the old head: test_platform_collect_ignore.py::test_the_windows_list_ignores_exactly_the_listed_test_files passes on current main, while the budget test still fails there at 34855 <= 34845, which this PR fixes. Main's security package is still 34,855 lines, so the new budget stays exact.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 7, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 7, 2026
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 7, 2026
@bolichen97

Copy link
Copy Markdown
Contributor

[operator: bolichen97] Heads-up: #32183 and #32209 each stay red on the other's main bug, so neither can go green alone.

Suggest folding one change into the other PR so a single PR carries both fixes and can pass CI. Happy to help if useful.

@buluoray

buluoray commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #32252, which landed the same +10 raise (34,845 -> 34,855) plus its own +39 on main. Main's package total (34,894) now equals its budget, so this PR has nothing left to do.

@buluoray buluoray closed this Nov 7, 2026
auto-merge was automatically disabled November 7, 2026 11:21

Pull request was closed

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants