Repository navigation
fix(ui): show a failed issue refresh and app release lookup in an error notice - #33029
Conversation
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing a screenshot of either new failure state. The PR attaches no image, so the blind read was not performed. Evidence gaps
Notes
[UX-REVIEWED] 334026a Description read[DESCRIPTION-READ] 979a718937fc98f86567bf776452a603b4d9abeede7ec56c496e01ec1cd0184e That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. Both silent failures now reach the shared Notes
[DESIGN-REVIEWED] 334026a Description read[DESCRIPTION-READ] f6ff5e4060af3cadfb083c084b1c9b4ccfb375ee47479528dd8aff246391bb12 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Both silent failures now reach the shared Not checked: the patch's ~100 other files (credential masks, notification bridge, Slack and so on), which I read as base drift outside this PR. What this change shipsInventory (8 items) — 8 justifiedIntent: when an Issue Radar refresh or a former built-in app's release lookup fails, the user is told instead of nothing happening. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 334026a Description read[DESCRIPTION-READ] 0b7f65a5f02f05f02a547add466a970627f78f275eb46f482ea7062a8ca1c7b2 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
…or notice Issue Radar's Refresh ran through a mutation whose error nothing read, so a failed refresh just stopped the spinner and left stale rows as if it had worked. Its failure now reaches issuesError, which IssueList already shows in an ErrorNotice, the way pullsError reports a failed PR refresh. BuiltinAppRoute's release lookup kept only the query's data, so a lookup that kept failing showed nothing while the compiled page rendered against a backend that may not be there. Once its retries are spent the error shows in an ErrorNotice above the page; the page itself still renders. Refs #30664, #31481
37174c5 to
dd946b2
Compare
|
span=b59654cd7d51
|
|
span=b59654cd7d51
|
|
span=8fc9be39b244
|
The legacy-route test pinned no alert after a failed release lookup, which was the silent behaviour this PR replaces with an ErrorNotice.
bolichen97
left a comment
There was a problem hiding this comment.
Approving on 334026a. UI-only change, all checks green.
issuesErrornow also surfacesrefreshMutation.error, and it resets when the shown list changes, so a stale refresh failure doesn't stick to a new list.- The ErrorNotice in IssueList and PrList moves outside the card region, so it no longer renders inside a card.
- BuiltinAppRoute shows an ErrorNotice when the release lookup fails instead of rendering silently.
No regex, no new restrictions.
…or notice (#33029) * fix(ui): show a failed issue refresh and app release lookup in an error notice Issue Radar's Refresh ran through a mutation whose error nothing read, so a failed refresh just stopped the spinner and left stale rows as if it had worked. Its failure now reaches issuesError, which IssueList already shows in an ErrorNotice, the way pullsError reports a failed PR refresh. BuiltinAppRoute's release lookup kept only the query's data, so a lookup that kept failing showed nothing while the compiled page rendered against a backend that may not be there. Once its retries are spent the error shows in an ErrorNotice above the page; the page itself still renders. Refs #30664, #31481 * test(ui): expect the release lookup notice after a failed lookup The legacy-route test pinned no alert after a failed release lookup, which was the silent behaviour this PR replaces with an ErrorNotice. Release resolution: docs/system-specs/modules/app-kit-platform.md keeps release's surrounding text; only the failed-lookup sentence changes. Release resolution: BuiltinAppRoute.tsx adds the ErrorNotice import, which main got from #30667 (not on release; too wide to pick for one import). (cherry picked from commit e43f72c)
…or notice (#33029) * fix(ui): show a failed issue refresh and app release lookup in an error notice Issue Radar's Refresh ran through a mutation whose error nothing read, so a failed refresh just stopped the spinner and left stale rows as if it had worked. Its failure now reaches issuesError, which IssueList already shows in an ErrorNotice, the way pullsError reports a failed PR refresh. BuiltinAppRoute's release lookup kept only the query's data, so a lookup that kept failing showed nothing while the compiled page rendered against a backend that may not be there. Once its retries are spent the error shows in an ErrorNotice above the page; the page itself still renders. Refs #30664, #31481 * test(ui): expect the release lookup notice after a failed lookup The legacy-route test pinned no alert after a failed release lookup, which was the silent behaviour this PR replaces with an ErrorNotice. Release resolution: docs/system-specs/modules/app-kit-platform.md keeps release's surrounding text; only the failed-lookup sentence changes. Release resolution: BuiltinAppRoute.tsx adds the ErrorNotice import, which main got from #30667 (not on release; too wide to pick for one import). (cherry picked from commit e43f72c)
Problem / Motivation
Goal: A failed Issue Radar refresh and a failed app release lookup tell the user, instead of failing silently.
Two places swallow an error, which the blocking
errors-use-error-noticereview rule forbids. Both were found by review of 0.12.1 backport batches, and both are onmain:IssueList.tsx)BuiltinAppRoute.tsx)Why it matters
Both fixes this blocks, #31481 (Issue Radar refresh) and #30664 (the release lookup), were dropped from 0.12.1 batches for this reason. They can go back into 0.12.1 once this lands.
Not a goal
What changed (motivation → approach → change)
issuesErrornow falls back to that mutation's error, the waypullsErrorreports a failed PR refresh. Both refresh mutations drop their error when the shown list changes (repo, or state filter), so a new list never shows the old list's failure. The list'sErrorNoticeinIssueListandPrListsits above the card region, where the absolute card scrollers can no longer cover it over cached rows.useReleasedWithNoRecordnow returns the query's error with its answer. When the lookup still fails after its retries, the route shows that error in anErrorNotice(agent hand-off) above the compiled page. The page itself still renders, as before.app-kit-platform.md) says the failed lookup now shows a notice.Backwards compatibility
Compatible: nothing changes on success; a failure now shows the shared
ErrorNoticewhere it showed nothing.Removes nothing: no setting, route, key or caller is removed.
Tests
IssueRadarContextCoverage.test.tsx› "reports a failed refresh as the issues error, so the list notice shows it": a refresh that rejects setsissuesErrorand keeps the cached rows.IssueRadarContextCoverage.test.tsx› "drops a failed refresh's error once another list is shown": switching the state filter clears it.IssueList.refreshButton.test.tsx› "shows a refresh failure outside the card region, so cached cards cannot cover it".BuiltinAppRoute.adopted.test.tsx› "keeps the compiled page and shows an error notice when the release lookup fails": a 503 lookup shows its message while the compiled page still renders.BuiltinAppRoute.adopted.test.tsxpasses.tsc, eslint on the touched files,lint:i18nandi18n-checkpass.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
N/A — unit coverage sufficient: both paths are failure branches driven by mocked API rejections, which is how they are reached in the tests above.
Screenshots / video
Why no screenshot: the only rendered change is the existing shared
ErrorNoticeappearing on a failure path, moved one level up in the same column, with no new string or style.Related Issues
Refs #30664, #31481
Sibling sweep
Swept:
git grep -n "useMutation" -- website/src/apps/issue-radar/context.tsxfor refresh mutations whose error is never readSibling: website/src/apps/issue-radar/context.tsx -- changed here
Sibling: website/src/apps/BuiltinAppRoute.tsx -- changed here
Sibling: website/src/apps/issue-radar/components/PrList.tsx -- changed here
context.tsxhas two mutations:refreshPullsMutationalready reports throughpullsError, andrefreshMutationis the one fixed here.Pattern harvest
Rule candidate: review-prompt
Pattern: a
useQueryoruseMutationwhoseerroris never destructured or read is a silent failure.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.