Skip to content

fix(ui): show a failed issue refresh and app release lookup in an error notice - #33029

Merged
bolichen97 merged 2 commits into
mainfrom
crew/slack/error-notice-fixes
Nov 8, 2026
Merged

bolichen97 merged 2 commits into
mainfrom
crew/slack/error-notice-fixes

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A failed Issue Radar refresh and a failed app release lookup tell the user, instead of failing silently.

Two places swallow an error, which the blocking errors-use-error-notice review rule forbids. Both were found by review of 0.12.1 backport batches, and both are on main:

Where What a user sees today
Issue Radar's Refresh button (IssueList.tsx) A failed refresh just stops the spinner. The stale list stays, as if the refresh had worked.
A former built-in app's route (BuiltinAppRoute.tsx) When the check "was this app uninstalled?" keeps failing, nothing is shown, and the compiled page renders against a backend that may not be there.

Why it matters

Both fixes this blocks, #31481 (Issue Radar refresh) and #30664 (the release lookup), were dropped from 0.12.1 batches for this reason. They can go back into 0.12.1 once this lands.

Not a goal

  • Changing what either refresh or lookup does on success.
  • Retrying differently: the release lookup keeps its shared retry ladder and is asked again on the next mount.
  • Any other silent error path in these apps.

What changed (motivation → approach → change)

  • Issue Radar: the manual refresh runs through a mutation whose error nothing read. issuesError now falls back to that mutation's error, the way pullsError reports a failed PR refresh. Both refresh mutations drop their error when the shown list changes (repo, or state filter), so a new list never shows the old list's failure. The list's ErrorNotice in IssueList and PrList sits above the card region, where the absolute card scrollers can no longer cover it over cached rows.
  • Former built-in route: useReleasedWithNoRecord now returns the query's error with its answer. When the lookup still fails after its retries, the route shows that error in an ErrorNotice (agent hand-off) above the compiled page. The page itself still renders, as before.
  • The App Kit spec (app-kit-platform.md) says the failed lookup now shows a notice.

Backwards compatibility

Compatible: nothing changes on success; a failure now shows the shared ErrorNotice where it showed nothing.

Removes nothing: no setting, route, key or caller is removed.

Tests

  • IssueRadarContextCoverage.test.tsx › "reports a failed refresh as the issues error, so the list notice shows it": a refresh that rejects sets issuesError and keeps the cached rows.
  • IssueRadarContextCoverage.test.tsx › "drops a failed refresh's error once another list is shown": switching the state filter clears it.
  • IssueList.refreshButton.test.tsx › "shows a refresh failure outside the card region, so cached cards cannot cover it".
  • BuiltinAppRoute.adopted.test.tsx › "keeps the compiled page and shows an error notice when the release lookup fails": a 503 lookup shows its message while the compiled page still renders.
  • Reverting each source change turns its test red (checked one at a time). All 92 Issue Radar test files give 1,660 passed, and BuiltinAppRoute.adopted.test.tsx passes. tsc, eslint on the touched files, lint:i18n and i18n-check pass.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

N/A — unit coverage sufficient: both paths are failure branches driven by mocked API rejections, which is how they are reached in the tests above.

Screenshots / video

Why no screenshot: the only rendered change is the existing shared ErrorNotice appearing on a failure path, moved one level up in the same column, with no new string or style.

Related Issues

Refs #30664, #31481

Sibling sweep

Swept: git grep -n "useMutation" -- website/src/apps/issue-radar/context.tsx for refresh mutations whose error is never read
Sibling: website/src/apps/issue-radar/context.tsx -- changed here
Sibling: website/src/apps/BuiltinAppRoute.tsx -- changed here
Sibling: website/src/apps/issue-radar/components/PrList.tsx -- changed here

context.tsx has two mutations: refreshPullsMutation already reports through pullsError, and refreshMutation is the one fixed here.

Pattern harvest

Rule candidate: review-prompt
Pattern: a useQuery or useMutation whose error is never destructured or read is a silent failure.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 08:20
@buluoray
buluoray requested a review from tim-finnigan November 8, 2026 08:20
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 334026ad9c9ba58466b8fd08eeaf71121fc2f21c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing a screenshot of either new failure state. The PR attaches no image, so the blind read was not performed.

Evidence gaps

  • Former built-in app route, release lookup failed: a new ErrorNotice with an agent hand-off now appears above the compiled page (BuiltinAppRoute.tsx, releasedLookupError != null && <ErrorNotice … askAgent className="m-4" />). To close: a screenshot of the route after a lookup failure such as a 503, with the page rendered under the notice.
  • Issue Radar list after a failed Refresh, with cached rows still shown: the ErrorNotice moved out of the card region in IssueList.tsx and PrList.tsx (className="mx-4 my-2 flex-shrink-0"). To close: a screenshot of both lists with the notice above the cached cards. That screenshot is also the only proof of the PR's own claim that the cards can no longer cover the notice.

Notes

  • On the built-in route, the notice prints only the raw error text (releasedLookupError.message, e.g. "gateway unreachable") and never says what failed. Put an i18n lead line in front of it, such as "Couldn't check whether this app is still installed; this page may not work," followed by the error detail.

[UX-REVIEWED] 334026a

Description read

[DESCRIPTION-READ] 979a718937fc98f86567bf776452a603b4d9abeede7ec56c496e01ec1cd0184e

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 334026ad9c9ba58466b8fd08eeaf71121fc2f21c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. Both silent failures now reach the shared ErrorNotice, and the spec changes in the same commit.

Notes

  • adoptionApiRows.test.tsx changes its check from queryByRole('alert')).toBeNull() to expecting an alert. The description never mentions this flipped check, and the old JSDoc line "no failure is reported from here" was a deliberate statement. Name the reversal and the errors-use-error-notice rule behind it in the description, so a reader sees it was chosen and not missed.

[DESIGN-REVIEWED] 334026a

Description read

[DESCRIPTION-READ] f6ff5e4060af3cadfb083c084b1c9b4ccfb375ee47479528dd8aff246391bb12

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 334026ad9c9ba58466b8fd08eeaf71121fc2f21c — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Both silent failures now reach the shared ErrorNotice, which the errors-use-error-notice rule in website/AUTOSDE.yaml requires. That rule is also why the deleted "no alert" pin can go.

Not checked: the patch's ~100 other files (credential masks, notification bridge, Slack and so on), which I read as base drift outside this PR.

What this change ships

Inventory (8 items) — 8 justified

Intent: when an Issue Radar refresh or a former built-in app's release lookup fails, the user is told instead of nothing happening. This is a FIX.

  1. A failed Issue Radar refresh now shows its error above the cached issue list. — justified
  2. A refresh error is cleared when the repo or state filter changes, so a new list never shows the old list's failure. — justified
  3. A PR refresh error is cleared the same way when the scope or PR filter changes. — justified
  4. The issue list's error notice moved above the card area, out of reach of the cached-card scrollers. — justified
  5. The PR list's error notice moved above its card area. — justified
  6. A former built-in app's route shows an error notice (with agent hand-off) once the release lookup has failed every retry, and still renders the compiled page. — justified
  7. The legacy-route test that pinned "no alert after a failed lookup", and the source comment "no failure is reported from here", are reversed. The described change and the documented rule both cover this. — justified
  8. The App Kit spec now says the failed lookup shows a notice. — justified

[FIRST-PRINCIPLES-REVIEWED] 334026a

Description read

[DESCRIPTION-READ] 0b7f65a5f02f05f02a547add466a970627f78f275eb46f482ea7062a8ca1c7b2

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 334026ad9c9ba58466b8fd08eeaf71121fc2f21c — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 334026a

Verdict parsed from the review's SHA-scoped output markers for commit 334026ad9c9ba58466b8fd08eeaf71121fc2f21c.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 334026ad9c9ba58466b8fd08eeaf71121fc2f21c false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 334026ad9c9ba58466b8fd08eeaf71121fc2f21c and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 334026a

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 334026ad9c9ba58466b8fd08eeaf71121fc2f21c false-positive: <reason, 20 to 500 characters>

…or notice

Issue Radar's Refresh ran through a mutation whose error nothing read, so a
failed refresh just stopped the spinner and left stale rows as if it had
worked. Its failure now reaches issuesError, which IssueList already shows
in an ErrorNotice, the way pullsError reports a failed PR refresh.

BuiltinAppRoute's release lookup kept only the query's data, so a lookup
that kept failing showed nothing while the compiled page rendered against a
backend that may not be there. Once its retries are spent the error shows
in an ErrorNotice above the page; the page itself still renders.

Refs #30664, #31481
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 8, 2026
@buluoray
buluoray force-pushed the crew/slack/error-notice-fixes branch from 37174c5 to dd946b2 Compare November 8, 2026 08:53
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 8, 2026
@buluoray

buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

span=b59654cd7d51

  • Cached issue cards obscure the refresh failure notice

fixed in dd946b2: the list ErrorNotice in IssueList.tsx (and the same pattern in PrList.tsx) now renders above the relative card region as a flex-shrink-0 sibling, so neither absolute scroller can cover it.
Test: IssueList.refreshButton.test.tsx "shows a refresh failure outside the card region, so cached cards cannot cover it" fails with the old layout.

@buluoray

buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

span=b59654cd7d51

  • A repository switch retains the previous repository's refresh error

fixed in dd946b2: context.tsx resets refreshMutation when scopeKey or stateFilter changes (and refreshPullsMutation on scopeKey or prFetchState), so a new list never reports the old list's refresh failure.
Test: IssueRadarContextCoverage.test.tsx "drops a failed refresh's error once another list is shown" fails without the reset.

@buluoray

buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

span=8fc9be39b244

  • A failed refresh keeps its error after a repo or state-filter switch

fixed in dd946b2: context.tsx resets refreshMutation when scopeKey or stateFilter changes (and refreshPullsMutation on scopeKey or prFetchState), so the stale error no longer reaches issuesError or pullsError.
Test: IssueRadarContextCoverage.test.tsx "drops a failed refresh's error once another list is shown" fails without the reset.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 8, 2026
The legacy-route test pinned no alert after a failed release lookup,
which was the silent behaviour this PR replaces with an ErrorNotice.
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 8, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on 334026a. UI-only change, all checks green.

  • issuesError now also surfaces refreshMutation.error, and it resets when the shown list changes, so a stale refresh failure doesn't stick to a new list.
  • The ErrorNotice in IssueList and PrList moves outside the card region, so it no longer renders inside a card.
  • BuiltinAppRoute shows an ErrorNotice when the release lookup fails instead of rendering silently.

No regex, no new restrictions.

@bolichen97
bolichen97 merged commit e43f72c into main Nov 8, 2026
115 of 119 checks passed
@bolichen97
bolichen97 deleted the crew/slack/error-notice-fixes branch November 8, 2026 13:14
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 8, 2026
buluoray added a commit that referenced this pull request Nov 8, 2026
…or notice (#33029)

* fix(ui): show a failed issue refresh and app release lookup in an error notice

Issue Radar's Refresh ran through a mutation whose error nothing read, so a
failed refresh just stopped the spinner and left stale rows as if it had
worked. Its failure now reaches issuesError, which IssueList already shows
in an ErrorNotice, the way pullsError reports a failed PR refresh.

BuiltinAppRoute's release lookup kept only the query's data, so a lookup
that kept failing showed nothing while the compiled page rendered against a
backend that may not be there. Once its retries are spent the error shows
in an ErrorNotice above the page; the page itself still renders.

Refs #30664, #31481

* test(ui): expect the release lookup notice after a failed lookup

The legacy-route test pinned no alert after a failed release lookup,
which was the silent behaviour this PR replaces with an ErrorNotice.

Release resolution: docs/system-specs/modules/app-kit-platform.md keeps
release's surrounding text; only the failed-lookup sentence changes.
Release resolution: BuiltinAppRoute.tsx adds the ErrorNotice import, which
main got from #30667 (not on release; too wide to pick for one import).
(cherry picked from commit e43f72c)
buluoray added a commit that referenced this pull request Nov 8, 2026
…or notice (#33029)

* fix(ui): show a failed issue refresh and app release lookup in an error notice

Issue Radar's Refresh ran through a mutation whose error nothing read, so a
failed refresh just stopped the spinner and left stale rows as if it had
worked. Its failure now reaches issuesError, which IssueList already shows
in an ErrorNotice, the way pullsError reports a failed PR refresh.

BuiltinAppRoute's release lookup kept only the query's data, so a lookup
that kept failing showed nothing while the compiled page rendered against a
backend that may not be there. Once its retries are spent the error shows
in an ErrorNotice above the page; the page itself still renders.

Refs #30664, #31481

* test(ui): expect the release lookup notice after a failed lookup

The legacy-route test pinned no alert after a failed release lookup,
which was the silent behaviour this PR replaces with an ErrorNotice.

Release resolution: docs/system-specs/modules/app-kit-platform.md keeps
release's surrounding text; only the failed-lookup sentence changes.
Release resolution: BuiltinAppRoute.tsx adds the ErrorNotice import, which
main got from #30667 (not on release; too wide to pick for one import).
(cherry picked from commit e43f72c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants