Repository navigation
feat(dashboard): show the whole text on the conductor mode board - #37209
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this changes how one panel displays text and stores nothing. Before and after screenshots of this revision exist, and the three removed catalog keys have no remaining readers. Notes
[DESIGN-REVIEWED] b7b0216 Description read[DESCRIPTION-READ] 4544468376afc79bef7ec99abd3c334985885311f5f5238e21ac741a557b07f9 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Every item follows from the cut text and frozen Overview reported in #37207. The new What this change shipsInventory (9 items) — 8 justifiedIntent: let a person read a long conductor mode run at a glance, with every text whole and the latest re-plan visible. This is an ADDITION, plus fixes to cut text.
[FIRST-PRINCIPLES-REVIEWED] b7b0216 Description read[DESCRIPTION-READ] 634f3ea97b06017e960a749dd4195f9b917b3404866690ae9786f08fc7c3f910 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the after-shots at 360, 560 and 900 px show every changed element, and the blind reader read the board correctly. Notes
[UX-REVIEWED] b7b0216 Description read[DESCRIPTION-READ] 108f05c8699a83a590020bf0c0aa79897420ab0622ac8d7d23c4f90017d301ee That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
606bbaf to
58e13e3
Compare
261c176 to
a5ecb46
Compare
c7f504a to
8f762c0
Compare
8f762c0 to
21db3f0
Compare
a5ecb46 to
47d3e1f
Compare
21db3f0 to
79d7983
Compare
Code change approver recommendation: A person should decideWhy: the decider estimates a 12% chance that this change introduces a defect, within the 12% limit for approving on its own, but it changes 463 lines, more than the 400 it may approve on its own. The change is display-only: the conductor mode Board's Status view now wraps its text instead of cutting it. The goal and "Done when" show whole, with a regex fix so "0.63 s" no longer ends the sentence. A new "Latest change" line is read from the goal's existing Changed: part, whose format matches what the conductor's prompt defines. Running rows show the time since their last report instead of "now". The done fold reads only "N done", and the Recap counts running milestones using the existing plural key. The three removed catalog keys have no remaining readers. Every locale was updated and the spec got its row. Each behaviour has a test that would fail without the change, and the new render test freezes Date only. No state, trust-boundary or lifecycle issue was found. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
79d7983 to
05efacc
Compare
05efacc to
73d8c8e
Compare
73d8c8e to
e463330
Compare
On a long run the Status view cut almost every line: the goal, its Done when, each milestone's title and latest report, the done fold and the Recap all ended in an ellipsis, and every running milestone said "now". The Overview also hid the goal's Changed line, the one part a re-plan rewrites, so a conductor that re-planned still looked frozen. Every Status text now wraps. The Overview shows the whole goal sentence, the goal's own Done when (no longer cut at a dot inside a number) and the goal's latest Changed entry with how long ago it was, or nothing when the goal has no Changed entry. A milestone shows the time since its last report, the done fold reads only its count, and the Recap counts running milestones instead of naming them.
e463330 to
b7b0216
Compare
buluoray
left a comment
There was a problem hiding this comment.
Approve on b7b0216. This PR makes the conductor mode Board's Status view show every text whole. The goal, its Done when sentence, each milestone's title and report, and the Recap now wrap instead of being cut, and long words such as a commit hash wrap too. The Overview gains a Latest change line read from the goal's own Changed part, with its age when the entry has a date. A running milestone shows the time since its last report instead of "now", the done fold reads only its count, and the Recap counts running milestones instead of naming them. All 78 tests in the three touched test files pass, and each of eight separate reverts of the change turned at least one of them red. A component render at 320 and 360 px in English, German and Russian showed no cut text and nothing wider than the panel. The two new strings are in every catalog, with translator context, and the three removed keys have no reader left. Non-blocking follow-ups: the Changed parser assumes entries are appended newest last, as its own comment says, and a Done when written as a bulleted list keeps a trailing dash. Decisive lines: website/src/pages/chat/command-center/ConductorModeCrewPanel.tsx:234-244 (goalSentence, goalDoneWhen), :252-272 (latestChange), :362 (WRAP), :415-418 (right column), :796-805 (Overview), :851 (done fold), :865 (Recap), :97-98 (milestoneSentence)
Problem / Motivation
Goal: On a long conductor mode run, the Board's Status view shows every text whole and its Overview shows when the plan last changed.
On a run with 94 milestones and long titles, the Status view cut almost every line: the goal, its "Done when", each milestone's title and latest report, the done fold and the Recap all ended in "…". Every running milestone said "now", so seven rows looked the same. The Overview drew only the goal's first sentence and its "Done when", so a conductor that re-planned (it rewrites the goal's Plan and Changed lines) still looked frozen.
Why it matters
The Board is where a person checks a long run at a glance. With the text cut, they cannot tell what each milestone is, what it last reported or how old that report is, and an Overview that never moves reads as a stuck run.
Not a goal
What changed (motivation → approach → change)
Wrapping beats a tap-to-expand control here: it hides nothing and adds no control. The age comes from the goal text the conductor already writes, so no field or prompt changes.
Plan:startsChanged:entry, with its age when it has a date ("Latest change, 2d ago: ..."); nothing when the goal has no entryThe
crew-mode.mdspec gets a row for these rules, and the catalogs in every locale (website/src/i18n/locales/, withen.context.json) gain the two "Latest change" strings and drop the three the view no longer reads.website/capture/conductor-mode-board-long.htmlis a capture page with the real panel over fixture reads (94 milestones, long titles, all made up), andscripts/capture-conductor-mode-board-long.mjsscreenshots it at 360, 560 and 900 px and lists every cut element (--strictfails on any).Backwards compatibility
Compatible: a display-only change in one panel; the board read, the ledger and every stored value are unchanged.
Removes nothing: the catalog keys removed (
conductor_mode_ms_now,conductor_mode_recap_run_one,conductor_mode_recap_run_many) had no reader left in the code after this change, whichdeadKeys.test.tsandnpm run i18n:checkconfirm.Tests
ConductorModeCrewPanel.readable.test.tsx(new): the whole goal and Done when show, the latest change shows "2d ago" with its stamp intitle, aChanged:part written one entry per line shows its newest entry, no change line without aChanged:entry, notruncateorline-clampand no "…" in the Status view, a running milestone shows "29m" and not "now", the done fold reads only its count, and the Recap counts running milestones. One frozen clock (vi.useFakeTimers({ toFake: ['Date'] })). Each fails on the parent commit's panel and passes here.ConductorModeCrewPanel.test.ts:goalSentencekeeps a long goal whole,goalDoneWhendoes not stop inside "0.63",latestChangepicks the last dated entry, a bare time gives no age, and noChanged:gives nothing; the milestone sentence counts running ones.CrewWorkerList.test.tsx: the quiet reason wraps; the done fold reads "N done" folded and open.Determinism: the three changed test files ran 5 times with
--sequence.shuffle(seeds 4001 to 4005), 78 of 78 passing each time.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Measured in Chromium at side-panel widths 360, 560 and 900 px on the capture page: 19, 16 and 12 cut elements before; 0, 0 and 0 after (
--strictpasses). Each screenshot was checked by eye for clipping.Screenshots / video
After, 560 px:
Before, 560 px:
360 and 900 px, before and after
Related Issues
Closes #37207
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement