Skip to content

feat(dashboard): show the whole text on the conductor mode board - #37209

Merged
bolichen97 merged 1 commit into
mainfrom
feat/board-readability
Nov 15, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
feat/board-readability

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On a long conductor mode run, the Board's Status view shows every text whole and its Overview shows when the plan last changed.

On a run with 94 milestones and long titles, the Status view cut almost every line: the goal, its "Done when", each milestone's title and latest report, the done fold and the Recap all ended in "…". Every running milestone said "now", so seven rows looked the same. The Overview drew only the goal's first sentence and its "Done when", so a conductor that re-planned (it rewrites the goal's Plan and Changed lines) still looked frozen.

Why it matters

The Board is where a person checks a long run at a glance. With the text cut, they cannot tell what each milestone is, what it last reported or how old that report is, and an Overview that never moves reads as a stuck run.

Not a goal

  • No change to the conductor's prompts, skills or tools, and nothing new stored on the ledger.
  • No new control: no "Show more", no reordering or cap of the milestone list.
  • The Needs your input cards and the Workers view are unchanged.

What changed (motivation → approach → change)

Wrapping beats a tap-to-expand control here: it hides nothing and adds no control. The age comes from the goal text the conductor already writes, so no field or prompt changes.

Part of the Status view Before After
Goal first sentence, cut at about 90 characters, one line whole first sentence, wraps
Done when one line, ended at the first "." (so "0.63 s" cut it) whole sentence, ends at a sentence end or where Plan: starts
Latest change not shown the goal's last Changed: entry, with its age when it has a date ("Latest change, 2d ago: ..."); nothing when the goal has no entry
Milestone title and report one line each, cut wrap, a SHA included
Right column of a running milestone "now" time since its last report ("29m")
Done fold "87 done · " plus every done title, cut "87 done"
Recap named every running milestone, two lines, cut "87 of 94 done; 7 running."

The crew-mode.md spec gets a row for these rules, and the catalogs in every locale (website/src/i18n/locales/, with en.context.json) gain the two "Latest change" strings and drop the three the view no longer reads. website/capture/conductor-mode-board-long.html is a capture page with the real panel over fixture reads (94 milestones, long titles, all made up), and scripts/capture-conductor-mode-board-long.mjs screenshots it at 360, 560 and 900 px and lists every cut element (--strict fails on any).

Backwards compatibility

Compatible: a display-only change in one panel; the board read, the ledger and every stored value are unchanged.
Removes nothing: the catalog keys removed (conductor_mode_ms_now, conductor_mode_recap_run_one, conductor_mode_recap_run_many) had no reader left in the code after this change, which deadKeys.test.ts and npm run i18n:check confirm.

Tests

  • ConductorModeCrewPanel.readable.test.tsx (new): the whole goal and Done when show, the latest change shows "2d ago" with its stamp in title, a Changed: part written one entry per line shows its newest entry, no change line without a Changed: entry, no truncate or line-clamp and no "…" in the Status view, a running milestone shows "29m" and not "now", the done fold reads only its count, and the Recap counts running milestones. One frozen clock (vi.useFakeTimers({ toFake: ['Date'] })). Each fails on the parent commit's panel and passes here.
  • ConductorModeCrewPanel.test.ts: goalSentence keeps a long goal whole, goalDoneWhen does not stop inside "0.63", latestChange picks the last dated entry, a bare time gives no age, and no Changed: gives nothing; the milestone sentence counts running ones.
  • CrewWorkerList.test.tsx: the quiet reason wraps; the done fold reads "N done" folded and open.

Determinism: the three changed test files ran 5 times with --sequence.shuffle (seeds 4001 to 4005), 78 of 78 passing each time.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Measured in Chromium at side-panel widths 360, 560 and 900 px on the capture page: 19, 16 and 12 cut elements before; 0, 0 and 0 after (--strict passes). Each screenshot was checked by eye for clipping.

Screenshots / video

After, 560 px:

after 560

Before, 560 px:

before 560

360 and 900 px, before and after

after 360
before 360
after 900
before 900

Related Issues

Closes #37207

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 14, 2026 12:06
@bolichen97
bolichen97 requested review from buluoray and removed request for a team November 14, 2026 12:06
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of b7b0216f27be0e310dc7c9b23d9a9e9b1e726afe — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this changes how one panel displays text and stores nothing. Before and after screenshots of this revision exist, and the three removed catalog keys have no remaining readers.

Notes

  • latestChange reads the age from free-text Changed: stamps, and it rests on the conductor skill appending entries newest-last (the code comment admits this shortcut). If that skill stops appending in order, the "Latest change" line quietly shows the wrong entry. Pin that ordering in the conductor skill's own test, not only in a comment in the panel.

[DESIGN-REVIEWED] b7b0216

Description read

[DESCRIPTION-READ] 4544468376afc79bef7ec99abd3c334985885311f5f5238e21ac741a557b07f9

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of b7b0216f27be0e310dc7c9b23d9a9e9b1e726afe — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Every item follows from the cut text and frozen Overview reported in #37207. The new Changed: parser reads a line the conductor prompt already writes (agent_parts/spec_prompts.py:145).

What this change ships

Inventory (9 items) — 8 justified

Intent: let a person read a long conductor mode run at a glance, with every text whole and the latest re-plan visible. This is an ADDITION, plus fixes to cut text.

  1. The goal, Done when, scope, milestone titles, reports and Recap wrap instead of being cut — justified
  2. Done when no longer stops inside a number such as "0.63 s" — justified
  3. The Overview gains a "Latest change, 2d ago: …" line taken from the goal's Changed: part — justified
  4. A running milestone's right column shows the time since its last report instead of "now" — justified
  5. The done fold reads only "N done" and no longer lists the done titles — justified
  6. The Recap counts running milestones and no longer names them (reuses the existing conductor_mode_row_count_running key) — justified
  7. The hover tooltips on the goal, Done when and Recap are gone — undeclared
  8. Two "Latest change" strings added and three dead keys removed in every locale — justified
  9. A capture page and screenshot script for a 94-milestone run, matching the existing convention under website/capture/ (679 files) — justified

[FIRST-PRINCIPLES-REVIEWED] b7b0216

Description read

[DESCRIPTION-READ] 634f3ea97b06017e960a749dd4195f9b917b3404866690ae9786f08fc7c3f910

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of b7b0216f27be0e310dc7c9b23d9a9e9b1e726afe — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the after-shots at 360, 560 and 900 px show every changed element, and the blind reader read the board correctly.

Notes

  • The blind reader could not tell what the bare purple age means: "either how long each step has been running or how long since its last update". The PR says it is the time since the last report, so render it as "29m ago" (the sibling "moving · 2m ago" already does this) or attach the report time as the title.
  • The undated "Latest change: {{what}}" variant (conductor_mode_changed) appears in no screenshot. A capture of a goal with a bare-time Changed: entry would show it.
  • At 360 px the full SHA in the milestone report breaks mid-hash ("…c37b29 / eb"), and the reader called it "ugly and means nothing to me". Shorten it to the 12-character form the same line already uses for main d15505809e1d.

[UX-REVIEWED] b7b0216

Description read

[DESCRIPTION-READ] 108f05c8699a83a590020bf0c0aa79897420ab0622ac8d7d23c4f90017d301ee

That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed b7b0216f27be0e310dc7c9b23d9a9e9b1e726afe — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] b7b0216

Verdict parsed from the review's SHA-scoped output markers for commit b7b0216f27be0e310dc7c9b23d9a9e9b1e726afe.

False positive or not applicable? A repository writer can comment:
/ai-review override fable b7b0216f27be0e310dc7c9b23d9a9e9b1e726afe false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of b7b0216f27be0e310dc7c9b23d9a9e9b1e726afe and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] b7b0216

False positive or not applicable? A repository writer can comment:
/ai-review override gpt b7b0216f27be0e310dc7c9b23d9a9e9b1e726afe false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added the readiness: passed Eligible automated validation passed for the current revision label Nov 14, 2026
@bolichen97
bolichen97 force-pushed the feat/conductor-mode-run-done-state branch from 606bbaf to 58e13e3 Compare November 14, 2026 12:40
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 14, 2026
@bolichen97
bolichen97 force-pushed the feat/conductor-mode-run-done-state branch 2 times, most recently from 261c176 to a5ecb46 Compare November 14, 2026 14:35
@bolichen97
bolichen97 force-pushed the feat/board-readability branch from c7f504a to 8f762c0 Compare November 14, 2026 14:35
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 14, 2026
@bolichen97
bolichen97 force-pushed the feat/board-readability branch from 8f762c0 to 21db3f0 Compare November 14, 2026 14:57
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 14, 2026
@bolichen97
bolichen97 force-pushed the feat/conductor-mode-run-done-state branch from a5ecb46 to 47d3e1f Compare November 14, 2026 18:56
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 14, 2026
@bolichen97
bolichen97 force-pushed the feat/board-readability branch from 21db3f0 to 79d7983 Compare November 14, 2026 19:13
@bolichen97 bolichen97 removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 14, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running labels Nov 14, 2026
Base automatically changed from feat/conductor-mode-run-done-state to main November 14, 2026 21:23
@KiroCrewCaptain

KiroCrewCaptain commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider estimates a 12% chance that this change introduces a defect, within the 12% limit for approving on its own, but it changes 463 lines, more than the 400 it may approve on its own.

The change is display-only: the conductor mode Board's Status view now wraps its text instead of cutting it. The goal and "Done when" show whole, with a regex fix so "0.63 s" no longer ends the sentence. A new "Latest change" line is read from the goal's existing Changed: part, whose format matches what the conductor's prompt defines. Running rows show the time since their last report instead of "now". The done fold reads only "N done", and the Recap counts running milestones using the existing plural key. The three removed catalog keys have no remaining readers. Every locale was updated and the spec got its row. Each behaviour has a test that would fail without the change, and the new render test freezes Date only. No state, trust-boundary or lifecycle issue was found.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit e463330516 · 463 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@bolichen97
bolichen97 enabled auto-merge (squash) November 14, 2026 21:50
@bolichen97
bolichen97 force-pushed the feat/board-readability branch from 79d7983 to 05efacc Compare November 14, 2026 22:31
@bolichen97 bolichen97 removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 14, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 14, 2026
@bolichen97
bolichen97 force-pushed the feat/board-readability branch from 05efacc to 73d8c8e Compare November 14, 2026 23:10
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 14, 2026
@bolichen97
bolichen97 force-pushed the feat/board-readability branch from 73d8c8e to e463330 Compare November 15, 2026 00:03
@bolichen97

Copy link
Copy Markdown
Contributor Author

The red Backend Tests shards on e463330 (3.12 shards 1, 2 and 8) are the eight row-scrub tests that are red on main at af94fac too (CI run 43654430807, same node ids). Tracked in #37421; the fix is #37423. This PR touches no backend code and waits for that fix.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 15, 2026
On a long run the Status view cut almost every line: the goal, its Done
when, each milestone's title and latest report, the done fold and the
Recap all ended in an ellipsis, and every running milestone said "now".
The Overview also hid the goal's Changed line, the one part a re-plan
rewrites, so a conductor that re-planned still looked frozen.

Every Status text now wraps. The Overview shows the whole goal sentence,
the goal's own Done when (no longer cut at a dot inside a number) and
the goal's latest Changed entry with how long ago it was, or nothing
when the goal has no Changed entry. A milestone shows the time since its
last report, the done fold reads only its count, and the Recap counts
running milestones instead of naming them.
@bolichen97
bolichen97 force-pushed the feat/board-readability branch from e463330 to b7b0216 Compare November 15, 2026 01:14
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 15, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 15, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on b7b0216. This PR makes the conductor mode Board's Status view show every text whole. The goal, its Done when sentence, each milestone's title and report, and the Recap now wrap instead of being cut, and long words such as a commit hash wrap too. The Overview gains a Latest change line read from the goal's own Changed part, with its age when the entry has a date. A running milestone shows the time since its last report instead of "now", the done fold reads only its count, and the Recap counts running milestones instead of naming them. All 78 tests in the three touched test files pass, and each of eight separate reverts of the change turned at least one of them red. A component render at 320 and 360 px in English, German and Russian showed no cut text and nothing wider than the panel. The two new strings are in every catalog, with translator context, and the three removed keys have no reader left. Non-blocking follow-ups: the Changed parser assumes entries are appended newest last, as its own comment says, and a Done when written as a bulleted list keeps a trailing dash. Decisive lines: website/src/pages/chat/command-center/ConductorModeCrewPanel.tsx:234-244 (goalSentence, goalDoneWhen), :252-272 (latestChange), :362 (WRAP), :415-418 (right column), :796-805 (Overview), :851 (done fold), :865 (Recap), :97-98 (milestoneSentence)

@bolichen97
bolichen97 disabled auto-merge November 15, 2026 06:01
@bolichen97
bolichen97 merged commit 45c0cdd into main Nov 15, 2026
151 of 156 checks passed
@bolichen97
bolichen97 deleted the feat/board-readability branch November 15, 2026 06:02
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conductor mode Board cuts its text and its Overview looks frozen

3 participants