Skip to content

feat(settings): move Kiro sign-in to its own Kiro account tab - #38304

Merged
iamwhatever merged 1 commit into
mainfrom
feat/kiro-account-settings
Nov 18, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
feat/kiro-account-settings

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Kiro sign-in gets its own Settings tab, "Kiro account", reachable on every harness, and every sign-in link leads there.

The Kiro sign-in card sat inside the Kiro Agent row of Settings > Agent Harness, and its shortcuts showed only while Kiro Agent ran something. The sign-in is used by more than that harness (Team Crews, Shared Crews, the credits pill), so a person on Claude Code or another harness had no plain place to sign in.

Why it matters

Anyone not on Kiro Agent could not find where to sign in to Kiro, and the Team Crews / Shared Crews refusals told them to sign in without saying where.

Not a goal

  • Remote crew launch sign-in text (LaunchCrew identity strings).
  • Showing a credit balance for Crew's own sign-in on a harness other than Kiro Agent.
  • Any change to how sign-in, sign-out or token renewal work.

What changed (motivation → approach → change)

  • New Settings tab "Kiro account", right after Overview. It holds the existing sign-in card as a full card (its folded in-row form had no caller left and is removed), and shows whenever the build offers Kiro sign-in, whatever harness is picked.
  • Agent Harness: the Kiro Agent row now shows one line, "Signed in as …", "Not signed in" or "Using your Kiro CLI sign-in" (KAS running on a kiro-cli login), with a "Go to Kiro account" link instead of the card. Its "Recommended" tag and sentence are main's (fix(ui): say why Kiro Agent is the default on the agent card #38655), unchanged here. Kiro CLI gets a description: "Uses the kiro-cli installed on this machine, with kiro-cli's own sign-in."
  • Every sign-in link goes to the new tab: the chat error row, the sign-in notice, the account popup, Settings search and old bookmarks. Old Agent Harness links are forwarded.
  • Shown on any harness: off Kiro Agent, the expired sign-in notice shows only when a sign-in was saved, so nobody who never signed in is nagged. On a harness with no balance, the top bar shows a quiet "Sign in to Kiro" button when none is saved. The Shared Crews card's signed-out refusals link to the tab, and the Crew switcher's signed-out Team Crews "Sign in to Kiro" item (added on main by fix: make Team Crew screens work for teammates over the relay #38437) now opens the Kiro account tab, bringing the local Crew forward first.
  • Copy: sign-in remedies now say "Settings → Kiro account". The chat still recognises rows saved with the old wording. The card's intro no longer says only Kiro Agent uses the sign-in.

Where:

  • Top bar and phone drawers: website/src/shell/topbar/kiroUsageReadout.tsx, website/src/shell/topbar/shellHeader.tsx, website/src/shell/appShell.tsx, website/src/shell/nav/navRail.tsx, website/src/App.tsx.
  • Team Crews / Shared Crews refusals: website/src/components/SharedCrewsCards.tsx, website/src/components/TeamCrewsGroup.tsx; screenshot harnesses website/scripts/capture-shared-crews-card.mjs (two signed-out frames) and website/scripts/capture-kiro-sign-in-phone-drawer.mjs (new).
  • The KAS engine bundle switch's description now names Settings → Kiro account (pages.developer.kasBundleCard.toggle_description, all catalogs).
  • Backend remedy text: src/kiro_crew/agent_sdk/host_auth.py, src/kiro_crew/acp/model_registry_errors.py, and a comment in src/kiro_crew/dashboard/chat_utils_injected_rows.py; the capture fixture website/capture/kas-signed-out-card.tsx uses the new sentence.
  • Docs naming the old place: docs/architecture/mcp.md, docs/feature-map/README.md, docs/guides/install.md, docs/system-specs/modules/agent-host-contract.md, docs/system-specs/modules/kas-auth.md, src/kiro_crew/docs/coming-from-kiro-cli.md.
  • Regenerated by their scripts: src/kiro_crew/docs/settings-registry.generated.json, src/kiro_crew/docs/ui-index.generated.json, website/src/i18n/locales/en-XA.json.
  • Strings: website/src/i18n/locales/en.json and en.manual.json; the 11 translated catalogs (zh-CN, hi, es, fr, bn, pt, ru, de, ja, ko, it .json under website/src/i18n/locales/) get the same keys, checked with i18n-translate.mjs verify.

Backwards compatibility

Compatible: old /settings/agent?highlight=key:kiro-sign-in, ?highlight=agent.kiro-sign-in, ?tab=agent&highlight=… and /developer?tab=agent-backend&highlight=… links forward to the new tab, and stored chat rows naming the old path still resolve to the translated notice.

Reader: website/src/components/commandPalette/settingsManual.ts:agent.kiro-sign-in -- app -- renamed to kiro-account.kiro-sign-in; the old id is a legacy highlight alias (useSettingHighlight.ts LEGACY_ID_EXACT) and SettingsPage forwards it (SettingsPage.agentHarness.test.tsx).
Reader: website/src/pages/developer/KiroSignInCard.tsx:KiroSignInCard compact/openRequest props -- app -- removed; their only caller was the Kiro Agent row, which now renders KiroAccountStatusLine; the tab renders the full card (KiroSignInCard.test.tsx).
Reader: website/src/pages/developer/AgentBackendTab.tsx:SignInDeepLink -- app -- removed; the card no longer lives in that row, and SettingsPage forwards the highlight to the new tab (SettingsPage.agentHarness.test.tsx).

Known behaviour

  • On the Kiro CLI harness nothing changes in the top bar: the kiro-cli balance pill stays, with no extra "Sign in to Kiro" hint, because that harness runs on kiro-cli's own sign-in.
  • Off Kiro Agent, someone who never signed in sees the sign-in notice only if the sign-in status cannot be read (an error, not a nag).

Tests

  • SettingsPage.agentHarness.test.tsx: the chat link, old Developer-page links and old Agent Harness links (path and ?tab= forms) land on the Kiro account tab and ring the card.
  • SettingsPage.agentHarnessSignIn.test.tsx: the real card renders on the new tab on a non-KAS harness, is absent on a build without KAS, Settings search lands on it, and the Kiro Agent row keeps only the line and link.
  • KiroAccountStatusLine.test.tsx: Not signed in / Using your Kiro CLI sign-in (sources say kiro-cli is active) / Signed in as / provider-only off KAS (never the kiro-cli account).
  • KiroSignInNotice.test.tsx: off KAS a stored lapsed sign-in shows with account wording; no stored sign-in shows nothing; a failed read shows the error notice.
  • kiroUsageReadout.signInPrompt.test.tsx: the "Sign in to Kiro" segment shows on Claude with no sign-in, not when signed in, not on a build without KAS, not on a Kiro harness.
  • SharedCrewsCards.test.tsx: signed-out list and row refusals link to the tab; other refusals do not.
  • TeamCrewsGroup.test.tsx: the switcher's signed-out "Sign in to Kiro" item opens the tab and clears a covering remote or relay pane; other refusals show no sign-in item.
  • AgentBackendTab*.test.tsx, settingsSearchGovernance.test.ts, gatewayNotice.test.tsx (new sentence recognised), backend test_agent_sdk_host_auth.py, test_cli_chat.py, test_acp_refactor_error_surface.py, test_find_ui_browse.py updated for the new wording.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Built the dashboard and captured it in a browser against stubbed APIs (Claude as the harness, no Kiro sign-in): the Kiro account tab, the Kiro Agent and Kiro CLI rows, and the top-bar segment with and without a sign-in. Locally: tsc, eslint, the i18n/key/DNT/theme checks, gen:settings --check, gen:ui --check, 162 related vitest files and the related backend tests pass. test_find_ui_auto.py::...continue with github... fails locally on a clean origin/main worktree too.

Screenshots / video

Kiro account tab, Claude harness, signed out:

01-kiro-account-tab-claude-signed-out

Agent Harness, Kiro Agent row (main's Recommended tag, then the status line and link):

02-agent-harness-kiro-agent-row

More

Kiro CLI row description:

03-agent-harness-kiro-cli-row

Top bar on Claude, not signed in to Kiro:

04-capsule-sign-in-to-kiro-claude

Top bar on Claude, signed in (no segment):

05-capsule-claude-signed-in-no-segment

Kiro account tab, light theme:

06-kiro-account-tab-light

Kiro Agent row, signed in (status line):

07-kas-row-signed-in-as

Claude harness with a stored, expired Kiro sign-in (notice names the account features):

08-notice-claude-stored-sign-in-expired

Settings → Remote Crew, Shared Crews card, signed out of Kiro: the list refusal and a refused Open each carry "Go to Kiro account":

09-shared-crews-signed-out-list

10-shared-crew-open-signed-out

Phone width, Claude harness, no Kiro sign-in: the open nav drawer shows "Sign in to Kiro", which opens Settings → Kiro account (website/scripts/capture-kiro-sign-in-phone-drawer.mjs checks both):

11-phone-drawer-sign-in-to-kiro

Crew switcher, signed out of Kiro: the Team Crews group shows the refusal and the "Sign in to Kiro" menu item, which opens Settings → Kiro account:

12-team-crews-signed-out

Related Issues

Closes #38299

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners November 17, 2026 07:34
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 09892b4b973feb89c5eaf2c4b21d59dd6938a834 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

No design-level concerns: the sign-in now has a home that isn't tied to any harness, every old link is forwarded, and the screenshots cover the new tab and the top-bar segment.

Notes

  • The doc comment at website/src/components/KasLoginGate.tsx:849 still says the embedded sign-in sits on "Settings → Agent Harness … under the harness switch". The new placement makes that untrue, so it should say Kiro account.

[DESIGN-REVIEWED] 09892b4

Description read

[DESCRIPTION-READ] 95f5e6f6b4ca938de479894f8179d5a6a76a96b7163fbf0279f2c51623768c56

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 09892b4b973feb89c5eaf2c4b21d59dd6938a834 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

The tab move has a named harm: Team and Shared Crews use the sign-in on every harness. Two new nag surfaces go past the Goal and are notes; neither meets a BLOCK trigger.

Notes

  • Item 1 — unjustified move: the only harm given is the description's "Anyone not on Kiro Agent could not find where to sign in". No linked issue or report backs it. The base card already rendered whenever kas was on offer, and Team Crews' refusal already ran navigate(KIRO_SIGN_IN_PATH).
  • Item 5 — oversized: the Goal is a tab plus existing links leading there. A new "Sign in to Kiro" segment shown by default on non-Kiro harnesses (kiroSignInPrompt = pillHidden && signInOffered && …) is a new surface. Subtraction: delete kiroSignInSegment and its kas-login query from kiroUsageReadout.tsx. Clears when: the mechanism is removed, or a human amends the Goal.
  • Item 6 — oversized: showing the lapsed notice off KAS (LAPSED_DETAIL.*.account, useKiroSignInOfferedQuery in KiroSignInNotice.tsx) is outside the Goal. Subtraction: drop the account variants and keep the kasInUse gate. Clears when: the mechanism is removed, or a human amends the Goal.

What this change ships

Inventory (9 items) — 5 justified

Intent: let someone on any harness find where to sign in to Kiro. This is an ADDITION (a move plus new surfaces).

  1. The sign-in card moved from the Kiro Agent row in Agent Harness to a new "Kiro account" tab after Overview — unjustified move
  2. The Kiro Agent row shows a one-line status and a "Go to Kiro account" link — justified
  3. Old Agent Harness and Developer links, and the legacy search id, forward to the new tab — justified
  4. Chat, notice, popup, search and the switcher's sign-in links go to the new tab and bring the local Crew forward — justified
  5. A new top-bar "Sign in to Kiro" button on non-Kiro harnesses when not signed in — oversized
  6. The expired sign-in notice now shows off Kiro Agent when a sign-in was saved — oversized
  7. Shared Crews' signed-out refusals link to the tab — justified
  8. Remedy text says "Settings → Kiro account" in the backend, catalogs and docs; old chat rows are still recognised — justified
  9. The Kiro CLI row gains a description line — rides along

[FIRST-PRINCIPLES-REVIEWED] 09892b4

Description read

[DESCRIPTION-READ] 52c068da0be0ea2ac61e2c47b975d1f387f00e9026392cbfe9dd2270a621e366

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 09892b4b973feb89c5eaf2c4b21d59dd6938a834 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the blind reader correctly identified the new Kiro account tab, the "Go to Kiro account →" links and the top-bar "Sign in to Kiro" button, and said it would use each of them.

Notes

  • kiro_cli_description "Uses the kiro-cli installed on this machine, with kiro-cli's own sign-in." The reader said "I don't know what … kiro-cli mean[s]". Use the product name instead: "Uses Kiro CLI installed on this machine, with its own sign-in."
  • The same sign-in goes by three entry points with two icons: KeyRound in the top bar and phone drawer, and the arrow-into-door icon on the switcher item this PR re-points (shot-12). The reader asked whether these are "all the same thing". Use KeyRound on the switcher's "Sign in to Kiro" item too.
  • In shot-10, the Shared Crews row's refusal says "Sign in to Kiro to see your Team Crews." just above the new "Go to Kiro account →" link. The reader called this self-contradictory: an online team is listed, and the card is titled "Shared Crews". When this row is signed out, the refusal should name Shared Crews.

[UX-REVIEWED] 09892b4

Description read

[DESCRIPTION-READ] c33b5b13a44c5769f064865e7444e47d02e0f639f02c01d385d90d5bdda51eb7

That sha256 names everything this verdict read: the PR description, plus the 15 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 09892b4b973feb89c5eaf2c4b21d59dd6938a834 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 09892b4

Verdict parsed from the review's SHA-scoped output markers for commit 09892b4b973feb89c5eaf2c4b21d59dd6938a834.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 09892b4b973feb89c5eaf2c4b21d59dd6938a834 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 09892b4b973feb89c5eaf2c4b21d59dd6938a834 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 09892b4

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 09892b4b973feb89c5eaf2c4b21d59dd6938a834 false-positive: <reason, 20 to 500 characters>

@iamwhatever
iamwhatever force-pushed the feat/kiro-account-settings branch from 9693a68 to 92ff2ab Compare November 17, 2026 08:34
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Pushed 92ff2ab (base unchanged, 48d0a93). Changes since 9693a68:

  • GPT blocker on docs/feature-map/README.md: the notice condition now matches the code (shows when the build offers Kiro sign-in; on a non-Kiro-Agent harness only when a stored Crew sign-in has lapsed).
  • File line cap: src/kiro_crew/acp/transport_errors.py is back to 2,000 lines (two comment-only lines reverted to main).
  • Settings coverage gate: website/scripts/settingsExtract.ts now maps KiroSignInCard.tsx to the kiro-account tab, so the kiro-account.kiro-sign-in search entry stays anchored.
  • Review minors: kiroSignInState.ts comment, kas-signed-out-card.tsx capture sentence, removed the unused compact / openRequest / onOpenRequestHandled props from KiroSignInCard, and the kas-auth.md entry-point paragraph.

Backend Python lanes were green on 9693a68.

@iamwhatever
iamwhatever force-pushed the feat/kiro-account-settings branch from 92ff2ab to 1b776c0 Compare November 17, 2026 09:29
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in files this PR also touches, from base 48d0a93 to 204f8ea (head 92ff2ab -> 1b776c0, no conflicts, no code change).

Overlapping files from main:

  • docs/guides/telemetry-otlp-export.md, docs/system-specs/modules/{config,dashboard-token-auth,metrics,subagent,session-control}.md
  • src/kiro_crew/agent_sdk/mcp_problems.py, src/kiro_crew/apps/manager_lookup.py, src/kiro_crew/cli_config.py, src/kiro_crew/acp/skill_projection.py, src/kiro_crew/dashboard/handlers/work_ledger.py, src/kiro_crew/dashboard/handlers/work_ledger_conductor.py
  • test/integration/conftest.py, test/test_dashboard_handlers_core_coverage_security_endpoints.py, test/test_unattended_mcp_wait.py, test/test_native_skill_projection_proved_current.py, test/test_remote_dispatch_conductor_retire.py, test/test_work_ledger_tools.py

Re-run locally on the new base: the PR's backend tests plus the overlapping tests (462 passed), and gen-settings-registry --check / gen-ui-index --check are up to date.

@iamwhatever
iamwhatever force-pushed the feat/kiro-account-settings branch from 1b776c0 to e4e69aa Compare November 17, 2026 10:25
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in files this PR also touches, from base 204f8ea to 8cc64c0 (head 1b776c0 -> e4e69aa, no conflicts). This push also carries the fix for the GPT draft-guard finding (see the disposition comment).

Overlapping files from main:

  • docs/system-specs/modules/{app-kit-platform,security,agent-host-contract,md-notebook}.md
  • src/kiro_crew/dashboard/handlers/updates.py, src/kiro_crew/dashboard/{sse_event_scope,ws,ws_event_scope}.py, src/kiro_crew/llm_helpers.py, src/kiro_crew/llm_helpers_parts/tool_approval.py, src/kiro_crew/agent_sdk/backends_turns.py
  • test/test_chat_slots_app_token_view.py, test/test_dashboard_updates_coverage_streams.py, test/test_slot_patch_frames.py, test/test_sse_stream_app_scope.py, test/test_ws_event_scoping_audit.py, test/test_ws_event_scoping_live.py, test/test_ws_offload.py, test/test_acp_backend_kas.py

Re-run locally on the new base: the PR's backend tests plus the overlapping tests, docs lint, and gen-settings-registry --check / gen-ui-index --check all pass. Frontend: the touched component tests, tsc and eslint pass.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Account link bypasses the unsaved-draft guard span=08653623129b

fixed in e4e69aa: KiroAccountStatusLine now renders SettingsLink (which asks the leave guard through useGuardedLeave) instead of a plain Link. The same plain-Link pattern in SharedCrewsCards.tsx (the signed-out "Go to Kiro account" link) is fixed the same way. Both use a shared KIRO_SIGN_IN_TARGET from kiroSignInLink.ts. New KiroAccountStatusLine.test.tsx checks that a click asks the guard, stays put when the guard keeps the draft, and navigates to the Kiro account tab when it allows.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 17, 2026
@iamwhatever
iamwhatever force-pushed the feat/kiro-account-settings branch from e4e69aa to 556d75e Compare November 17, 2026 11:30
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in files this PR also touches, from base 8cc64c0 to 8beb3f2 (head e4e69aa -> 556d75e).

Two conflicts, both resolved without changing this PR's behaviour:

  • website/src/pages/SettingsPage.tsx: feat(settings): hide the Settings -> Advanced page #38312 removed the Advanced tab (AdvancedPanel, SlidersHorizontal). Kept that removal and this PR's UserRound icon / Kiro account tab.
  • src/kiro_crew/docs/ui-index.generated.json: regenerated with gen-ui-index.mjs (and gen-settings-registry.mjs), not hand-merged; both --check pass.

Other overlapping files from main (auto-merged): docs/feature-map/README.md (same file), docs/architecture/harness-requirements.md, several docs/system-specs/modules/*.md, src/kiro_crew/agent_sdk/unresolved_tool_answers.py, and the test files main changed.

Re-run locally on the new base: tsc, eslint, i18n checks, 582 touched frontend tests (45 files), the PR's backend tests plus every test file main changed (2125 passed), and docs lint all pass.

The PR body now also carries the "Known behaviour" section and re-shot screenshots (01-08) from this revision.

@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 17, 2026
@iamwhatever
iamwhatever force-pushed the feat/kiro-account-settings branch from 556d75e to 8db3df1 Compare November 17, 2026 12:27
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Feature map still puts the Kiro sign-in on the KAS harness row span=4464213526e3

fixed in 8db3df1: the KAS engine bundle row now says it is signed in on Settings → Kiro account. The Kiro sign-in row adds pages/SettingsPage.tsx (mounts the card on the kiro-account tab), pages/developer/useKiroSignInOffered.ts (the offered gate), pages/developer/KiroAccountStatusLine.tsx and shell/topbar/kiroUsageReadout.tsx to its frontend owners, and lists the top-bar "Sign in to Kiro" capsule segment and the phone nav row as entry points. The two notes are fixed in the same commit: capture-orchestrator-memory.mjs now waits on kiro-account-status-line, and kas-auth.md states the notice and failed-read conditions as kasInUse or the build offering Kiro sign-in. Same base as before (8beb3f2), no rebase.

@iamwhatever
iamwhatever force-pushed the feat/kiro-account-settings branch from 8db3df1 to 1fb1801 Compare November 17, 2026 12:53
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in files this PR also touches, from base 8beb3f2 to 0cc0336 (head 8db3df1 -> 1fb1801). GitHub reported the PR as conflicting, so this re-sync was needed to merge.

Two conflicts, both resolved keeping main's change and this PR's:

  • website/src/components/SharedCrewsCards.tsx: main now marks a Crew as seen after it opens (recordRelayCrewsSeen, with a seen_not_saved notice). This PR stores the refusal code so a SIGNED_OUT refusal can show the "Go to Kiro account" SettingsLink. A row's notice is now { text, code? }: refusals keep both, the seen-save failure carries text only.
  • docs/feature-map/README.md: took main's Relay viewer routes row and this PR's Kiro sign-in row (each side changed only its own row).

Generated files re-run with their scripts (gen-settings-registry, gen-ui-index, both --check clean).

Re-run locally on the new base: tsc, eslint, i18n checks, docs lint, 583 touched frontend tests (45 files), and the PR's backend tests plus the 42 test files main changed (2120 passed).

The earlier dispositions (gpt span 08653623129b on 1b776c0, opus span 4464213526e3 on 556d75e) are scoped to the heads they judged; no override is posted on this PR.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 17, 2026
@iamwhatever
iamwhatever force-pushed the feat/kiro-account-settings branch from 1fb1801 to 7b508da Compare November 17, 2026 13:53
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Schema failures silently disable sign-in monitoring span=1a5648bad833

fixed in 7b508da: useKiroSignInOffered.ts adds useKiroSignInOfferedQuery(), which returns the schema read's error alongside the answer (through the existing useConfigSchemaQuery). KiroSignInNotice uses it: off KAS, once the config read has landed, a schema read that failed with no answer renders the notice's existing ErrorNotice ("Could not read the dashboard settings", hand-off, dismiss), under the same offline/token guards as the config-read failure. On KAS the status read runs anyway and this branch stays out. No new strings. Two tests in KiroSignInNotice.test.tsx cover both cases; kas-auth.md states the new branch.

@iamwhatever
iamwhatever force-pushed the feat/kiro-account-settings branch from 7b508da to 812f11f Compare November 17, 2026 14:53
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 17, 2026
@iamwhatever
iamwhatever force-pushed the feat/kiro-account-settings branch from b0aa06c to 90ae787 Compare November 17, 2026 19:16
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in files this PR also touches, from base 0cc0336 to e72cf2e (head b0aa06c -> 90ae787). GitHub reported the PR as conflicting.

The conflict was #38655, which changed the same Kiro Agent row this PR changed. Resolution: main's version wins for that row.

  • Kiro Agent keeps main's "Recommended" tag and "Recommended. New installs start on this agent." sentence, in all 13 catalogs, AgentBackendTab.tsx and both AgentBackendTab*.test.tsx.
  • This PR's Default tag next to the name and its new Kiro Agent description are dropped (the tag prop on AgentPickerRow.tsx is reverted to main, and the kas_description key is removed from every catalog).
  • Kept from this PR: the Kiro Agent row's sign-in status line with "Go to Kiro account", and the Kiro CLI description.

Also in this push: the fix for the Opus finding on b0aa06c (see the disposition), and website/scripts/capture-team-crews-signed-out.mjs, the harness behind screenshot 12. Screenshots 02 and 03 are re-shot from this revision.

Generated files re-run with their scripts (en-XA, both settings registries, ui-index). Local on the new base: tsc, eslint, i18n checks (keys, strings, catalog), docs lint, 1013 touched frontend tests (53 files), and the PR's backend tests plus the 165 test files main changed (11820 passed; the 4 failures in test_mcp_listing_import_budget.py fail the same way on a clean main checkout here, an environment import of aiohttp).

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • KAS row says "Not signed in" while KAS runs on the kiro-cli login span=309bb3520f9e

fixed in 90ae787: KiroAccountStatusLine now reads the same sources query the card uses (useKiroSignInSources). When Crew holds no sign-in and sourcesNotice() returns 'using_kiro_cli', the line shows "Using your Kiro CLI sign-in" (using_kiro_cli_title) instead of "Not signed in". New case in src/test/KiroAccountStatusLine.test.tsx covers it and checks "Not signed in" is absent.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 17, 2026
@iamwhatever
iamwhatever force-pushed the feat/kiro-account-settings branch from 90ae787 to 2912204 Compare November 17, 2026 20:20
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Preserve failures when reading sign-in sources span=08653623129b

fixed in 2912204: KiroAccountStatusLine now renders the card's own errors for the sources read: the "could not read sources" ErrorNotice when the query fails, and SignInStoreUnreadableErrors when either store answers stored: null. In both cases the line no longer says "Not signed in" (whether a sign-in is stored is unknown). Two new cases in src/test/KiroAccountStatusLine.test.tsx cover an unreadable kiro-cli store and a failed sources read, each asserting the error notice and the absence of "Not signed in". Same base (e72cf2e), no rebase.

@iamwhatever
iamwhatever force-pushed the feat/kiro-account-settings branch from 2912204 to fadee8b Compare November 17, 2026 21:29
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Sources-read error lacks the required hand-off decision span=08653623129b

fixed in fadee8b: the hand-off stays off, and a No hand-off comment now sits directly above the sources-read ErrorNotice in KiroAccountStatusLine.tsx, naming the reason: the row is on the Agent Harness tab beside the unsaved Subagent Settings draft, which the hand-off's navigation would discard. The store-unreadable notices come from the card's SignInStoreUnreadableErrors, which carries its own decision. Same base, no rebase.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • New ErrorNotice in KiroAccountStatusLine makes no hand-off decision span=309bb3520f9e

fixed in fadee8b: added a No hand-off comment directly above the sources-read ErrorNotice, naming the unsaved Subagent Settings draft on the Agent Harness tab that the hand-off's navigation would discard, so withholding askAgent is a recorded choice. Same base, no rebase.

@iamwhatever
iamwhatever force-pushed the feat/kiro-account-settings branch from fadee8b to c851055 Compare November 17, 2026 22:37
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Reveal the local Crew before opening sign-in settings span=39487d6b17d0

fixed in c851055: new website/src/pages/developer/useOpenKiroSignIn.ts brings the local Crew forward with setActiveId(null) when a pane is active (the same step crewDeepLink.ts takes before its refusal), then asks the leave guard and navigates to KIRO_SIGN_IN_PATH. All three named sites use it: the Team Crews "Go to Kiro account" item (TeamCrewsGroup.tsx), the top-bar "Sign in to Kiro" segment (kiroUsageReadout.tsx) and the account popup's link (KiroAccountModal.tsx, closing the popup once the leave is allowed). TeamCrewsGroup.test.tsx now starts with a remote pane active and asserts activeId is cleared along with the route change. Same base, no rebase.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in files this PR also touches, from base e72cf2e to bf8094b (head c851055 -> 2890617, no conflicts).

Why now: the fix for the GPT finding on c851055 uses localCovered() and relayActive from website/src/store/instancesSlice.ts, which landed on main after the old base, so the fix could not be written on it.

Overlapping files from main (auto-merged): website/src/App.tsx, website/src/components/SharedCrewsCards.tsx, website/src/components/TeamCrewsGroup.tsx (+ test), website/src/components/commandPalette/settingsSearchCore.ts, the locale catalogs, docs/feature-map/README.md, docs/architecture/mcp.md, test/test_find_ui_browse.py, and the generated settingsRegistry.gen.ts / settings-registry.generated.json / ui-index.generated.json (both generator --checks pass on the new base).

Re-run locally on the new base: tsc, eslint, i18n checks (catalog and keys), docs lint, 1562 frontend tests across every file touching the changed surfaces (97 files), and the PR's backend tests plus the 116 test files main changed (8730 passed).

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Clear relay-active panes before opening sign-in settings span=9c3f6e631edc

fixed in 2890617: useOpenKiroSignIn now checks the existing localCovered predicate (both activeId and relayActive) before setActiveId(null), the same guard crewDeepLink.ts and appShell.tsx use, so a relay pane is cleared too. All three sites (account popup, Team Crews item, top-bar segment) go through the hook. TeamCrewsGroup.test.tsx runs the case over both a remote Crew pane and a relay pane and asserts activeId and relayActive are both cleared. This needed the rebase onto bf8094b, where localCovered lives.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 17, 2026
@iamwhatever
iamwhatever force-pushed the feat/kiro-account-settings branch from 2890617 to fcc54d2 Compare November 17, 2026 23:23
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in files this PR also touches, from base bf8094b to a907d1f (head 2890617 -> fcc54d2). GitHub reported the PR as conflicting.

Three conflicts, each resolved keeping both sides:

  • website/src/hooks/useSettingHighlight.ts: main added the agent.orchestrator-memory -> agent.kiro-memory legacy alias next to this PR's agent.kiro-sign-in -> kiro-account.kiro-sign-in; both aliases kept.
  • docs/feature-map/README.md: main renamed the "Orchestrator memory" row to "Kiro Memory"; took main's row and this PR's Kiro sign-in row (main did not change the sign-in row).
  • src/kiro_crew/docs/ui-index.generated.json: regenerated with gen-ui-index.mjs (and gen-settings-registry.mjs), not hand-merged; both --checks pass.

Re-run locally on the new base: tsc, i18n checks (catalog and keys), docs lint, 2063 frontend tests across every file touching the changed surfaces (114 files), and the PR's backend tests plus the test files main changed (535 passed).

@iamwhatever
iamwhatever force-pushed the feat/kiro-account-settings branch from fcc54d2 to 09892b4 Compare November 17, 2026 23:38
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in files this PR also touches, from base a907d1f to a1ac53e (head fcc54d2 -> 09892b4). GitHub reported the PR as conflicting.

The conflict was website/src/components/TeamCrewsGroup.tsx: #38437 added its own "Sign in to Kiro" item under the signed-out Team Crews refusal, the same spot as this PR's "Go to Kiro account" item. Resolution, one item instead of two:

  • Kept main's item (label, LogIn icon, relay-crews-list-sign-in test id, aria-describedby).
  • Routed it through this PR's useOpenKiroSignIn (closes the menu, brings the local Crew forward when a remote or relay pane covers it, asks the leave guard, opens Settings → Kiro account) instead of a bare navigate.
  • Dropped this PR's separate "Go to Kiro account" item; its two tests now drive main's item. Screenshot 12 and website/scripts/capture-team-crews-signed-out.mjs are updated to match, and the description now says so.

Re-run locally on the new base: tsc, eslint, generator --checks, and 2065 frontend tests across every file touching the changed surfaces (114 files, including all 77 in TeamCrewsGroup.test.tsx).

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 17, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

@KiroCrewCaptain all checks and AI lanes are green on 09892b4 (GPT and Opus with no blocking findings; Design, First Principles and UX PASS). Everything from your 16:28 review is in: screenshots 09-12 cover the Shared Crews signed-out refusals, the phone drawer's "Sign in to Kiro" and the Team Crews switcher item, and the Team Crews signed-out item opens the Kiro account tab (bringing the local Crew forward first). Could you take another look?

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 18, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review covered head 09892b4. Old links all land on the new tab: the Agent Harness highlight link in both path and ?tab= form, the old search id, and the Developer page link. Stored chat rows still match through the widened regex in gatewayNotice.ts. All 12 catalogs carry the new remedy path. Every new navigation asks the leave guard. Earlier change request: (1) the screenshots are fixed, with 09 to 12 now in the body and the UX review passing on this head; (2) the Team Crews switcher link is fixed in TeamCrewsGroup.tsx, with a test; (3) toggle_description is fixed and now names Settings > Kiro account; (4) the feature-map row is fixed and no longer describes the removed fold or deep link.
Done well: three separate hand-offs are merged into one useOpenKiroSignIn hook, and the old compact fold and SignInDeepLink are deleted, not kept beside the new tab.
Security: the change matches the auth-surface path list only because it moves the sign-in card. The sign-in, renewal and sign-out flows and the owner gate are unchanged. No token or secret handling changes, and nothing renders raw HTML.
The design is signed off under the standing maintainer sign-off for changes by team members.
Optional:

  • KiroAccountModal.signOutLink.test.tsx never mocks useKiroSignInOffered, so its "hides the link" case passes even though the link now shows. The new "Kiro account in Settings" branch has no test.
  • In kiroUsageReadout.signInPrompt.test.tsx, the "stays away once signed in" case can pass before the status loads. Wait for the kas-login query to succeed before you assert.
  • KasLoginGate.tsx:849 still says Settings > Agent Harness. The feature-map Kiro sign-in row should also list shell/nav/navRail.tsx and App.tsx for the phone drawer rows.

@iamwhatever
iamwhatever merged commit 820d411 into main Nov 18, 2026
98 of 101 checks passed
@iamwhatever
iamwhatever deleted the feat/kiro-account-settings branch November 18, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kiro sign-in is buried in the Kiro Agent harness row

2 participants