Repository navigation
feat(settings): move Kiro sign-in to its own Kiro account tab - #38304
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS No design-level concerns: the sign-in now has a home that isn't tied to any harness, every old link is forwarded, and the screenshots cover the new tab and the top-bar segment. Notes
[DESIGN-REVIEWED] 09892b4 Description read[DESCRIPTION-READ] 95f5e6f6b4ca938de479894f8179d5a6a76a96b7163fbf0279f2c51623768c56 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS The tab move has a named harm: Team and Shared Crews use the sign-in on every harness. Two new nag surfaces go past the Goal and are notes; neither meets a BLOCK trigger. Notes
What this change shipsInventory (9 items) — 5 justifiedIntent: let someone on any harness find where to sign in to Kiro. This is an ADDITION (a move plus new surfaces).
[FIRST-PRINCIPLES-REVIEWED] 09892b4 Description read[DESCRIPTION-READ] 52c068da0be0ea2ac61e2c47b975d1f387f00e9026392cbfe9dd2270a621e366 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the blind reader correctly identified the new Kiro account tab, the "Go to Kiro account →" links and the top-bar "Sign in to Kiro" button, and said it would use each of them. Notes
[UX-REVIEWED] 09892b4 Description read[DESCRIPTION-READ] c33b5b13a44c5769f064865e7444e47d02e0f639f02c01d385d90d5bdda51eb7 That sha256 names everything this verdict read: the PR description, plus the 15 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
9693a68 to
92ff2ab
Compare
|
Pushed 92ff2ab (base unchanged, 48d0a93). Changes since 9693a68:
Backend Python lanes were green on 9693a68. |
92ff2ab to
1b776c0
Compare
|
Rebased: main moved in files this PR also touches, from base 48d0a93 to 204f8ea (head 92ff2ab -> 1b776c0, no conflicts, no code change). Overlapping files from main:
Re-run locally on the new base: the PR's backend tests plus the overlapping tests (462 passed), and |
1b776c0 to
e4e69aa
Compare
|
Rebased: main moved in files this PR also touches, from base 204f8ea to 8cc64c0 (head 1b776c0 -> e4e69aa, no conflicts). This push also carries the fix for the GPT draft-guard finding (see the disposition comment). Overlapping files from main:
Re-run locally on the new base: the PR's backend tests plus the overlapping tests, docs lint, and |
|
e4e69aa to
556d75e
Compare
|
Rebased: main moved in files this PR also touches, from base 8cc64c0 to 8beb3f2 (head e4e69aa -> 556d75e). Two conflicts, both resolved without changing this PR's behaviour:
Other overlapping files from main (auto-merged): Re-run locally on the new base: tsc, eslint, i18n checks, 582 touched frontend tests (45 files), the PR's backend tests plus every test file main changed (2125 passed), and docs lint all pass. The PR body now also carries the "Known behaviour" section and re-shot screenshots (01-08) from this revision. |
556d75e to
8db3df1
Compare
|
8db3df1 to
1fb1801
Compare
|
Rebased: main moved in files this PR also touches, from base 8beb3f2 to 0cc0336 (head 8db3df1 -> 1fb1801). GitHub reported the PR as conflicting, so this re-sync was needed to merge. Two conflicts, both resolved keeping main's change and this PR's:
Generated files re-run with their scripts ( Re-run locally on the new base: tsc, eslint, i18n checks, docs lint, 583 touched frontend tests (45 files), and the PR's backend tests plus the 42 test files main changed (2120 passed). The earlier dispositions (gpt span 08653623129b on 1b776c0, opus span 4464213526e3 on 556d75e) are scoped to the heads they judged; no override is posted on this PR. |
1fb1801 to
7b508da
Compare
|
7b508da to
812f11f
Compare
b0aa06c to
90ae787
Compare
|
Rebased: main moved in files this PR also touches, from base 0cc0336 to e72cf2e (head b0aa06c -> 90ae787). GitHub reported the PR as conflicting. The conflict was #38655, which changed the same Kiro Agent row this PR changed. Resolution: main's version wins for that row.
Also in this push: the fix for the Opus finding on b0aa06c (see the disposition), and Generated files re-run with their scripts (en-XA, both settings registries, ui-index). Local on the new base: tsc, eslint, i18n checks (keys, strings, catalog), docs lint, 1013 touched frontend tests (53 files), and the PR's backend tests plus the 165 test files main changed (11820 passed; the 4 failures in |
|
90ae787 to
2912204
Compare
|
2912204 to
fadee8b
Compare
|
|
fadee8b to
c851055
Compare
|
c851055 to
2890617
Compare
|
Rebased: main moved in files this PR also touches, from base e72cf2e to bf8094b (head c851055 -> 2890617, no conflicts). Why now: the fix for the GPT finding on c851055 uses Overlapping files from main (auto-merged): Re-run locally on the new base: tsc, eslint, i18n checks (catalog and keys), docs lint, 1562 frontend tests across every file touching the changed surfaces (97 files), and the PR's backend tests plus the 116 test files main changed (8730 passed). |
|
2890617 to
fcc54d2
Compare
|
Rebased: main moved in files this PR also touches, from base bf8094b to a907d1f (head 2890617 -> fcc54d2). GitHub reported the PR as conflicting. Three conflicts, each resolved keeping both sides:
Re-run locally on the new base: tsc, i18n checks (catalog and keys), docs lint, 2063 frontend tests across every file touching the changed surfaces (114 files), and the PR's backend tests plus the test files main changed (535 passed). |
fcc54d2 to
09892b4
Compare
|
Rebased: main moved in files this PR also touches, from base a907d1f to a1ac53e (head fcc54d2 -> 09892b4). GitHub reported the PR as conflicting. The conflict was
Re-run locally on the new base: tsc, eslint, generator |
|
@KiroCrewCaptain all checks and AI lanes are green on 09892b4 (GPT and Opus with no blocking findings; Design, First Principles and UX PASS). Everything from your 16:28 review is in: screenshots 09-12 cover the Shared Crews signed-out refusals, the phone drawer's "Sign in to Kiro" and the Team Crews switcher item, and the Team Crews signed-out item opens the Kiro account tab (bringing the local Crew forward first). Could you take another look? |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
This review covered head 09892b4. Old links all land on the new tab: the Agent Harness highlight link in both path and ?tab= form, the old search id, and the Developer page link. Stored chat rows still match through the widened regex in gatewayNotice.ts. All 12 catalogs carry the new remedy path. Every new navigation asks the leave guard. Earlier change request: (1) the screenshots are fixed, with 09 to 12 now in the body and the UX review passing on this head; (2) the Team Crews switcher link is fixed in TeamCrewsGroup.tsx, with a test; (3) toggle_description is fixed and now names Settings > Kiro account; (4) the feature-map row is fixed and no longer describes the removed fold or deep link.
Done well: three separate hand-offs are merged into one useOpenKiroSignIn hook, and the old compact fold and SignInDeepLink are deleted, not kept beside the new tab.
Security: the change matches the auth-surface path list only because it moves the sign-in card. The sign-in, renewal and sign-out flows and the owner gate are unchanged. No token or secret handling changes, and nothing renders raw HTML.
The design is signed off under the standing maintainer sign-off for changes by team members.
Optional:
KiroAccountModal.signOutLink.test.tsxnever mocksuseKiroSignInOffered, so its "hides the link" case passes even though the link now shows. The new "Kiro account in Settings" branch has no test.- In
kiroUsageReadout.signInPrompt.test.tsx, the "stays away once signed in" case can pass before the status loads. Wait for thekas-loginquery to succeed before you assert. KasLoginGate.tsx:849still says Settings > Agent Harness. The feature-map Kiro sign-in row should also listshell/nav/navRail.tsxandApp.tsxfor the phone drawer rows.
Problem / Motivation
Goal: Kiro sign-in gets its own Settings tab, "Kiro account", reachable on every harness, and every sign-in link leads there.
The Kiro sign-in card sat inside the Kiro Agent row of Settings > Agent Harness, and its shortcuts showed only while Kiro Agent ran something. The sign-in is used by more than that harness (Team Crews, Shared Crews, the credits pill), so a person on Claude Code or another harness had no plain place to sign in.
Why it matters
Anyone not on Kiro Agent could not find where to sign in to Kiro, and the Team Crews / Shared Crews refusals told them to sign in without saying where.
Not a goal
What changed (motivation → approach → change)
Where:
website/src/shell/topbar/kiroUsageReadout.tsx,website/src/shell/topbar/shellHeader.tsx,website/src/shell/appShell.tsx,website/src/shell/nav/navRail.tsx,website/src/App.tsx.website/src/components/SharedCrewsCards.tsx,website/src/components/TeamCrewsGroup.tsx; screenshot harnesseswebsite/scripts/capture-shared-crews-card.mjs(two signed-out frames) andwebsite/scripts/capture-kiro-sign-in-phone-drawer.mjs(new).pages.developer.kasBundleCard.toggle_description, all catalogs).src/kiro_crew/agent_sdk/host_auth.py,src/kiro_crew/acp/model_registry_errors.py, and a comment insrc/kiro_crew/dashboard/chat_utils_injected_rows.py; the capture fixturewebsite/capture/kas-signed-out-card.tsxuses the new sentence.docs/architecture/mcp.md,docs/feature-map/README.md,docs/guides/install.md,docs/system-specs/modules/agent-host-contract.md,docs/system-specs/modules/kas-auth.md,src/kiro_crew/docs/coming-from-kiro-cli.md.src/kiro_crew/docs/settings-registry.generated.json,src/kiro_crew/docs/ui-index.generated.json,website/src/i18n/locales/en-XA.json.website/src/i18n/locales/en.jsonanden.manual.json; the 11 translated catalogs (zh-CN,hi,es,fr,bn,pt,ru,de,ja,ko,it.jsonunderwebsite/src/i18n/locales/) get the same keys, checked withi18n-translate.mjs verify.Backwards compatibility
Compatible: old
/settings/agent?highlight=key:kiro-sign-in,?highlight=agent.kiro-sign-in,?tab=agent&highlight=…and/developer?tab=agent-backend&highlight=…links forward to the new tab, and stored chat rows naming the old path still resolve to the translated notice.Reader: website/src/components/commandPalette/settingsManual.ts:agent.kiro-sign-in -- app -- renamed to kiro-account.kiro-sign-in; the old id is a legacy highlight alias (useSettingHighlight.ts LEGACY_ID_EXACT) and SettingsPage forwards it (SettingsPage.agentHarness.test.tsx).
Reader: website/src/pages/developer/KiroSignInCard.tsx:KiroSignInCard compact/openRequest props -- app -- removed; their only caller was the Kiro Agent row, which now renders KiroAccountStatusLine; the tab renders the full card (KiroSignInCard.test.tsx).
Reader: website/src/pages/developer/AgentBackendTab.tsx:SignInDeepLink -- app -- removed; the card no longer lives in that row, and SettingsPage forwards the highlight to the new tab (SettingsPage.agentHarness.test.tsx).
Known behaviour
Tests
SettingsPage.agentHarness.test.tsx: the chat link, old Developer-page links and old Agent Harness links (path and?tab=forms) land on the Kiro account tab and ring the card.SettingsPage.agentHarnessSignIn.test.tsx: the real card renders on the new tab on a non-KAS harness, is absent on a build without KAS, Settings search lands on it, and the Kiro Agent row keeps only the line and link.KiroAccountStatusLine.test.tsx: Not signed in / Using your Kiro CLI sign-in (sources say kiro-cli is active) / Signed in as / provider-only off KAS (never the kiro-cli account).KiroSignInNotice.test.tsx: off KAS a stored lapsed sign-in shows with account wording; no stored sign-in shows nothing; a failed read shows the error notice.kiroUsageReadout.signInPrompt.test.tsx: the "Sign in to Kiro" segment shows on Claude with no sign-in, not when signed in, not on a build without KAS, not on a Kiro harness.SharedCrewsCards.test.tsx: signed-out list and row refusals link to the tab; other refusals do not.TeamCrewsGroup.test.tsx: the switcher's signed-out "Sign in to Kiro" item opens the tab and clears a covering remote or relay pane; other refusals show no sign-in item.AgentBackendTab*.test.tsx,settingsSearchGovernance.test.ts,gatewayNotice.test.tsx(new sentence recognised), backendtest_agent_sdk_host_auth.py,test_cli_chat.py,test_acp_refactor_error_surface.py,test_find_ui_browse.pyupdated for the new wording.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Built the dashboard and captured it in a browser against stubbed APIs (Claude as the harness, no Kiro sign-in): the Kiro account tab, the Kiro Agent and Kiro CLI rows, and the top-bar segment with and without a sign-in. Locally:
tsc, eslint, the i18n/key/DNT/theme checks,gen:settings --check,gen:ui --check, 162 related vitest files and the related backend tests pass.test_find_ui_auto.py::...continue with github...fails locally on a cleanorigin/mainworktree too.Screenshots / video
Kiro account tab, Claude harness, signed out:
Agent Harness, Kiro Agent row (main's Recommended tag, then the status line and link):
More
Kiro CLI row description:
Top bar on Claude, not signed in to Kiro:
Top bar on Claude, signed in (no segment):
Kiro account tab, light theme:
Kiro Agent row, signed in (status line):
Claude harness with a stored, expired Kiro sign-in (notice names the account features):
Settings → Remote Crew, Shared Crews card, signed out of Kiro: the list refusal and a refused Open each carry "Go to Kiro account":
Phone width, Claude harness, no Kiro sign-in: the open nav drawer shows "Sign in to Kiro", which opens Settings → Kiro account (
website/scripts/capture-kiro-sign-in-phone-drawer.mjschecks both):Crew switcher, signed out of Kiro: the Team Crews group shows the refusal and the "Sign in to Kiro" menu item, which opens Settings → Kiro account:
Related Issues
Closes #38299
Checklist