Repository navigation
feat(shared-crew): fix the teammate experience for a shared Crew - #38803
Conversation
UX Review (Opus 5.5) — ✅ human override accepted@bolichen97 overrode this lane for |
Design Review (Opus 5.5) — ✅ human override accepted@bolichen97 overrode this lane for |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: each item traces to a Bug Bash row or a linked issue. The creator-filter replacement leaves the old server-filtered list path with no caller. Notes
What this change shipsInventory (10 items) — 8 justifiedIntent: let a teammate on a Shared Crew tell whose message is whose, filter by creator, see who they are, avoid the owner's sandbox runbook, and sign in on a fresh Linux install. FIX, with an #38790 layout ADDITION bundled in.
The change has more than 10 items; these are the 10 most visible. [FIRST-PRINCIPLES-REVIEWED] 6fd3b2e Description read[DESCRIPTION-READ] 2aafc53e3021c0ac6b41e29d4929f8eb08206566b06e82fa8867b954154d889e That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
b9da410 to
25ef673
Compare
25ef673 to
d134a64
Compare
d134a64 to
137db76
Compare
|
Bolin asked for #38790's scope (the Remote Crew page, the People page and the header switcher layout) to be built into this PR, on top of #38437's People and RemoteCrew code. The Goal line, "Not a goal" and "Related Issues" (now |
137db76 to
b290b50
Compare
|
/ai-review override ux 2c7ff44 owner-decision: the diff is over the lane's 1 MB cap because Bolin asked for #38790 to land in this PR (#38803 (comment)), so the lane cannot run; real-machine before/after proof is in the PR and after-shots. Failed run: https://github.com/kirodotdev/KiroCrew/actions/runs/44340285983 |
Human judgment recorded@bolichen97 recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
Human judgment recorded@bolichen97 recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
A teammate on a Shared Crew saw the host owner's runbook when the host
could not start chats, controls that only refused them, no name for whom
to ask, People that said "Tailscale: Not set up" on a Crew shared over
Kiro, and a Team Crew that opened in a separate window and could land on
the relay's bare 403 page.
- Desktop: a Team Crew opens in the main window as a pane with a top-bar
chip and the Cmd/Ctrl+digit chord; older desktops keep the window path.
A main-frame 401/403 mints once more, then shows a notice instead of
the bare page, and the owner turning off access has its own notice.
- Host cannot start chats: the error row gets the typed code
host_sandbox_unavailable; a non-owner audience gets one plain line and
Copy details, never host paths or config keys, and no Resume that
replays the same refusal.
- Owner-only areas (secrets, phone, sign-in links, webhooks, remote
Crews, channel connection writes, cron secret grants, invites, the
preview switch, admission keys, redaction, reveal) show one lock that
names the person at the host machine, driven by /api/auth/me teammate
and an owner_only 403, pinned to the backend table by a test.
- Sidebar identity row ("<name> via Kiro Login") and a read-only Shared
state under the one showsTeamAttribution rule; People grouped by path
from each row's provenance, with an owner row for a teammate.
- Copy: name the Crew's computer instead of "your device" in Security and
About, plain Computer Use and Voice host copy, a retired stale
session-not-found banner, and a full-path tooltip in Task Runner.
2c7ff44 to
6fd3b2e
Compare
|
|
|
/ai-review override design 6fd3b2e owner-decision: the diff is over the lane's 1 MB cap because Bolin asked for #38790 to land in this PR (#38803 (comment)), so the lane cannot run; real-machine before/after proof is in the PR and after-shots. Failed run: https://github.com/kirodotdev/KiroCrew/actions/runs/44348315452 |
|
/ai-review override ux 6fd3b2e owner-decision: the diff is over the lane's 1 MB cap because Bolin asked for #38790 to land in this PR (#38803 (comment)), so the lane cannot run; real-machine before/after proof is in the PR and after-shots. Failed run: https://github.com/kirodotdev/KiroCrew/actions/runs/44348315085 |
Human judgment recorded@bolichen97 recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
Human judgment recorded@bolichen97 recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
I reviewed head 6fd3b2e against the earlier approved head, focusing on the two rebases, the legacy refusal redaction and the sign-in refresh fix. Both sides of every conflict survive: the refused-credential wording and the 'Error:' lead from main, the plugin-missing steps now living in the setup cards, and the new sign-in props on the error card. A refusal row stored by an older build is now recognized by either raiser's fixed wording wherever it sits in the row, including the background-start stop notice. A teammate gets the plain line on history reads, socket frames, chat events, the status stream and JSON bodies, while the owner reads the row unchanged. Search and the session-list preview never quote such a row, and cancelling the in-flight queries keeps a stale poll from overwriting the fresh sign-in reading. The related backend tests pass, removing either fix makes the new tests fail, and I found no blocking defect.
Problem / Motivation
Goal: A teammate on a Shared Crew can tell their own messages from other people's, filter sessions by who started them in the existing Sort & filter menu, sees who they are signed in as, never sees the host owner's sandbox runbook, and can sign in to Kiro on a fresh Linux install without getting stuck; and the Remote Crew page, the People page and the header switcher follow the layout in #38790.
Replaces #38314, reopened under the author's own account. Scope follows the Crew for Teams re:Invent Bug Bash doc and the rulings since: the in-window pane moved to #38293, owner-only locks / host wording / the first People page moved to #38437. #38790's Remote Crew, People and switcher layout is built here on top of #38437's code.
The Linux E2E run (an Amazon Linux host, two teammates on separate desktop apps over the Kiro relay, one fresh-HOME install) showed:
~/.kiro/crew/config.jsonkeys) and Resume buttons that replay it.Why it matters
This is the re:Invent demo path: every teammate who opens a Shared Crew hits these screens in the first minute, and each one reads as broken or as someone else's machine.
Not a goal
/api/chat/slots(Bug Bash 16, adlio): the evidence points at the relay service.TypingLockBanner, Take over andcomposer_locked.teammate_accessare unchanged.What changed (motivation → approach → change)
A teammate sees whose message is whose, filters by who started a session, sees who they are, never reads the host's sandbox runbook, and gets through a fresh sign-in; the Remote Crew page, People and the switcher follow #38790.
queue_popand a steer's row,steer_pushand requeue carry the author, so steered and queued rows are named live and on reload.UserMessage.tsx,ChatMessageList.tsx,chat_turn/queue_drain.py,chat_delivery.py,chat_send.py,websocket/chatStream.tsrows.ts,creatorFilterMenu.tsx,creators.ts,switchSlotCallsiteClassification.test.tsviewer_viaandowner_label; the sidebar shows " via Kiro Login" and a Shared count. The owner is named by oneowner.owner_name()(Kiro e-mail, else Tailscale name, else host name). "Shared Crew(s)" in all 12 locales.SidebarIdentityRow.tsx,shared_crew/owner.py,sharedCrewMode.ts,hooks/sharedCrew/,i18n/locales,en.context.jsonhost_sandbox_unavailableon every row path. A non-owner reads one plain line with Copy details on the WebSocket, SSE and every buffered HTTP body (gzipped and JSON lines included); the owner keeps the diagnostic. A row an older build stored untyped (a no-backend refusal, a launcher failure behind its lead, a background-start stop notice of either) is matched by its raiser's fixed wording. Session search and the session-list preview never quote such a row; exports carry no error rows.host_sandbox_refusal.py,redaction_audience.py,eager_spawn.py,turn_failures.py,acp_vocab.py,history_search.py,history_projection_reads.py,chatErrorRecovery.ts,HostSandboxUnavailableCard.tsxSignInRequiredErroris taggedauth_required, so the card offers Sign in. A sign-in refreshes the top bar's reading and the Shared Crews list at once; a usage or status read still in flight is cancelled first, so it cannot put the previous account's answer back. AGetUsageLimitsAUTH_REJECTEDis a failed balance read, notsignin_required. The device-code screen has labelled Copy link and Copy code. The switcher's Kiro-account group has Connect, which opens the Crew in its own window and never connects on its own.transport_errors.py,useKasLogin.ts,KasLoginGate.tsxRemoteCrewPanel*.tsx,SettingsPage.tsx,launch_job.pyGET /api/shared-crew/modereturnssources(Tailscale, AWS SSM, organization, Kiro Login) with state and people count. One card per source with its own invite button; a source not set up is a dashed card with its setup link; organization is read-only. One People list follows, a source chip per row, a distinct-people count, Remove only where it works. A teammate's invite buttons stay locked.crew_mode.sources_view,PeopleSources.tsx,PeopleCrew.tsx,sharedCrewUi.tsTeamCrewsGroup.tsxSpecs:
shared-crew.md,instances.md,cloud.md,history.md,kas-auth.md,acp-client.md,learn-cron-dashboard.md, feature map. Every locale and the generateden-XAcarry the new strings (settingsGluedFragments.test.tspins the joined ones).Backwards compatibility
Compatible: every new response and frame field (
viewer_via,owner_label,sourceson the mode body,authoronqueue_pop/steer_push) is additive and optional on the client; no route accepts or refuses anything it did not before.Reader: website/src/pages/chat-sidebar/CreatorFilter.tsx:CreatorFilteredSessions -- crew page -- removed with the bar; the sidebar's own lanes now filter by creator (
ChatSidebar.creatorFilter.test.tsx)Reader: src/kiro_crew/shared_crew/routes_identity.py:GET /api/shared-crew/sessions -- crew page -- the route stays; the sidebar no longer calls it (
api.sharedCrewSessionskept,ApiClient.refactor.surface.test.ts)Tests
test_shared_crew_steer_author.py: a teammate's steer row,steer_pushand requeue carry the author; an author-less steer keeps its old shape.test_shared_crew_queue_pop_author.py: a teammate's queued send drains with aqueue_popnaming them.test_host_sandbox_refusal.py: typed row; owner vs teammate on WS, SSE, JSON, gzipped and JSON-lines bodies.test_shared_crew_owner.py,test_shared_crew_mode_viewer_fields.py: theowner_nameorder and the viewer fields.test_usage_crew_vault.py,test_acp_refactor_error_surface.py: L1/L2.test_host_sandbox_refusal.pyalso: a stored untyped setgroups row on JSON, JSON lines and the socket; each untyped legacy shape (bare no-backend row,Error:-led launcher failure, background-start stop notice of either) read by a teammate as the plain line with nonotice_args, and by the owner as stored; no search excerpt or session-list preview of a refusal row. The four teammate shapes fail on the unfixed module (12 of 20 new cases red, every owner case green).test_shared_crew_mode_sources.py:sourceslists every path at once with its state and people count.RemoteCrewPanel.layout.test.tsx(sections, Add Crew modal, Setting up row, one main action per state, chevron details),PeoplePanel.test.tsx(source cards, per-source invite, teammate lock, chips, distinct count, Remove placement),TeamCrewsGroup.test.tsx(heading, Private/Shared icons, arrow kept, no pin),MessageByline.runs.test.tsx(sides per viewer, a teammate's steer named),ChatMessageList.userSide.test.tsx,UseWebSocketCoverage.test.tsx(steer echo author),CreatorFilter.test.tsx,rows.test.ts,ChatSidebar.creatorFilter.test.tsx,TeamCrewsGroup.test.tsx,SidebarIdentityRow.test.tsx,ErrorCard.hostSandbox.test.tsx,KasLoginGate.test.tsx,KiroSignInCard.test.tsx(a usage poll or status refetch in flight when the sign-in lands does not overwrite the new answer; both red without the cancel, green with it, 5 shuffled seeds).Proof: not provable -- frontend test
Manual verification
Every kept item was reproduced on real boxes (AL2023 host at origin/main, teammate viewers A and B over the Kiro relay), then rerun with the host and viewer A on this branch, plus a fresh-HOME sign-in on viewer C and the owner's own view in a browser on the host. All FIXED: #38703, rows 10/15/20, items 4 and 6, L1-L5, and Connect. #38790 items 1-8: see the shots below. Row 20's literal "first message" case did not reproduce on main (B's first message was named); the nameless rows were the steered and queued ones, now named. Viewer B's own Local app stayed on Nightly; everything B used here is served by the host build.
Screenshots / video
Teammate view, Linux desktop app (e-mails blurred). BEFORE on main: a teammate's message and steer on the right, no name on the steer, the separate "All sessions" bar.
AFTER: the teammate's messages on the left with their name, steer included; the viewer's own on the right.
Related Issues
Closes #38703
Closes #38458
Closes #38790
Replaces #38314. Related: #38293 (pane, merged), #38437 (owner locks, host wording, People), #38304 (Kiro account tab), #37523 (added-to-a-Shared-Crew notice).
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.