Repository navigation
test: 0.13 backport, give the policy-readiness test handle its runtime (#38941) - #39417
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. This is a test-only backport: it gives the fixture handle the runtime that the product code now reads. [DESIGN-REVIEWED] 0dccecb Description read[DESCRIPTION-READ] 8f4685d399f13a219707cd03b94aea59ed34776046dc640ba41a4f91537a8cc3 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: the v0.13.0 release-candidate test job passes on release/0.13.0.
The
v0.13.0-rc.6Release run failsTest Release Candidate SHA (2)with two failures intest/test_kas_policy_hidden_readiness.py:AttributeError: 'AcpSessionHandle' object has no attribute '_runtime'. The KAS 0.66.117 bump (#39376) made_wait_managed_mcpcallsettle_kas_model_select, which readshandle._runtime. The test's bare handle has no runtime. Main fixed the same test in #38941.Why it matters
The stable gate needs a green release-candidate run.
Not a goal
No product code change.
What changed (motivation → approach → change)
git cherry-pick -xof #38941 (5ca143070d), test only.git range-diffshows it is identical to main apart from thecherry picked fromline.Backwards compatibility
Compatible: test only.
Removes nothing: test only.
Tests
On this branch, the 13 test files that call
_wait_managed_mcporsettle_kas_model_select: 1,437 passed. The two failing tests fail onaa0c14cf63locally and pass here. flake8: exit 0.Proof: not provable -- other: a test-only backport of a main fix
Manual verification
N/A: test only.
Related Issues
Release fix for 0.13.0; no tracking issue.
Sibling sweep
Siblings: none -- every test that reaches
settle_kas_model_selectpasses on this branchPattern harvest
Not generalizable: a backport
Checklist