Skip to content

test: 0.13 backport, give the policy-readiness test handle its runtime (#38941) - #39417

Merged
bolichen97 merged 1 commit into
release/0.13.0from
fix/backport-0.13-policy-readiness-test
Nov 19, 2026
Merged

bolichen97 merged 1 commit into
release/0.13.0from
fix/backport-0.13-policy-readiness-test

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: the v0.13.0 release-candidate test job passes on release/0.13.0.

The v0.13.0-rc.6 Release run fails Test Release Candidate SHA (2) with two failures in test/test_kas_policy_hidden_readiness.py: AttributeError: 'AcpSessionHandle' object has no attribute '_runtime'. The KAS 0.66.117 bump (#39376) made _wait_managed_mcp call settle_kas_model_select, which reads handle._runtime. The test's bare handle has no runtime. Main fixed the same test in #38941.

Why it matters

The stable gate needs a green release-candidate run.

Not a goal

No product code change.

What changed (motivation → approach → change)

git cherry-pick -x of #38941 (5ca143070d), test only. git range-diff shows it is identical to main apart from the cherry picked from line.

Backwards compatibility

Compatible: test only.

Removes nothing: test only.

Tests

On this branch, the 13 test files that call _wait_managed_mcp or settle_kas_model_select: 1,437 passed. The two failing tests fail on aa0c14cf63 locally and pass here. flake8: exit 0.

Proof: not provable -- other: a test-only backport of a main fix

Manual verification

N/A: test only.

Related Issues

Release fix for 0.13.0; no tracking issue.

Sibling sweep

Siblings: none -- every test that reaches settle_kas_model_select passes on this branch

Pattern harvest

Not generalizable: a backport

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 19, 2026 06:05
@bolichen97
bolichen97 requested review from dodgeblaster and removed request for a team November 19, 2026 06:05
@bolichen97
bolichen97 merged commit b8a44bd into release/0.13.0 Nov 19, 2026
26 checks passed
@bolichen97
bolichen97 deleted the fix/backport-0.13-policy-readiness-test branch November 19, 2026 06:05
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 0dccecb5e4b2d5f958062c3891cb02e75b9a755b ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 0dccecb5e4b2d5f958062c3891cb02e75b9a755b touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 0dccecb5e4b2d5f958062c3891cb02e75b9a755b — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check. This is a test-only backport: it gives the fixture handle the runtime that the product code now reads.

[DESIGN-REVIEWED] 0dccecb

Description read

[DESCRIPTION-READ] 8f4685d399f13a219707cd03b94aea59ed34776046dc640ba41a4f91537a8cc3

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 0dccecb5e4b2d5f958062c3891cb02e75b9a755b — this comment is updated in place on each push.

Review details

Test-only change; no candidates.

No findings.

[OPUS-REVIEWED] 0dccecb

Verdict parsed from the review's SHA-scoped output markers for commit 0dccecb5e4b2d5f958062c3891cb02e75b9a755b.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 0dccecb5e4b2d5f958062c3891cb02e75b9a755b false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 0dccecb5e4b2d5f958062c3891cb02e75b9a755b and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 0dccecb

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 0dccecb5e4b2d5f958062c3891cb02e75b9a755b false-positive: <reason, 20 to 500 characters>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants